clang-tools 24.0.0git
CodeCompleteTests.cpp
Go to the documentation of this file.
1//===-- CodeCompleteTests.cpp -----------------------------------*- C++ -*-===//
2//
3// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6//
7//===----------------------------------------------------------------------===//
8
9#include "ASTSignals.h"
10#include "Annotations.h"
11#include "ClangdServer.h"
12#include "CodeComplete.h"
13#include "Compiler.h"
14#include "Config.h"
15#include "Feature.h"
16#include "Matchers.h"
17#include "Protocol.h"
18#include "Quality.h"
19#include "SourceCode.h"
20#include "SyncAPI.h"
21#include "TestFS.h"
22#include "TestIndex.h"
23#include "TestTU.h"
24#include "index/Index.h"
25#include "index/MemIndex.h"
26#include "index/SymbolOrigin.h"
27#include "support/Threading.h"
28#include "clang/Sema/CodeCompleteConsumer.h"
29#include "clang/Tooling/CompilationDatabase.h"
30#include "llvm/ADT/StringRef.h"
31#include "llvm/Support/Error.h"
32#include "llvm/Support/Path.h"
33#include "llvm/Testing/Annotations/Annotations.h"
34#include "llvm/Testing/Support/Error.h"
35#include "llvm/Testing/Support/SupportHelpers.h"
36#include "gmock/gmock.h"
37#include "gtest/gtest.h"
38#include <condition_variable>
39#include <functional>
40#include <mutex>
41#include <vector>
42
43namespace clang {
44namespace clangd {
45
46namespace {
47using ::llvm::Failed;
48using ::testing::AllOf;
49using ::testing::Contains;
50using ::testing::ElementsAre;
51using ::testing::Field;
52using ::testing::HasSubstr;
53using ::testing::IsEmpty;
54using ::testing::Not;
55using ::testing::UnorderedElementsAre;
56using ContextKind = CodeCompletionContext::Kind;
57
58// GMock helpers for matching completion items.
59MATCHER_P(named, Name, "") { return arg.Name == Name; }
60MATCHER_P(mainFileRefs, Refs, "") { return arg.MainFileRefs == Refs; }
61MATCHER_P(scopeRefs, Refs, "") { return arg.ScopeRefsInFile == Refs; }
62MATCHER_P(nameStartsWith, Prefix, "") {
63 return llvm::StringRef(arg.Name).starts_with(Prefix);
64}
65MATCHER_P(filterText, F, "") { return arg.FilterText == F; }
66MATCHER_P(scope, S, "") { return arg.Scope == S; }
67MATCHER_P(qualifier, Q, "") { return arg.RequiredQualifier == Q; }
68MATCHER_P(labeled, Label, "") {
69 return arg.RequiredQualifier + arg.Name + arg.Signature == Label;
70}
71MATCHER_P(sigHelpLabeled, Label, "") { return arg.label == Label; }
72MATCHER_P(kind, K, "") { return arg.Kind == K; }
73MATCHER_P(doc, D, "") {
74 return arg.Documentation && arg.Documentation->asPlainText() == D;
75}
76MATCHER_P(returnType, D, "") { return arg.ReturnType == D; }
77MATCHER_P(hasInclude, IncludeHeader, "") {
78 return !arg.Includes.empty() && arg.Includes[0].Header == IncludeHeader;
79}
80MATCHER_P(insertInclude, IncludeHeader, "") {
81 return !arg.Includes.empty() && arg.Includes[0].Header == IncludeHeader &&
82 bool(arg.Includes[0].Insertion);
83}
84MATCHER_P(insertIncludeText, InsertedText, "") {
85 return !arg.Includes.empty() && arg.Includes[0].Insertion &&
86 arg.Includes[0].Insertion->newText == InsertedText;
87}
88MATCHER(insertInclude, "") {
89 return !arg.Includes.empty() && bool(arg.Includes[0].Insertion);
90}
91MATCHER_P(snippetSuffix, Text, "") { return arg.SnippetSuffix == Text; }
92MATCHER_P(origin, OriginSet, "") { return arg.Origin == OriginSet; }
93MATCHER_P(signature, S, "") { return arg.Signature == S; }
94MATCHER_P(replacesRange, Range, "") {
95 return arg.CompletionInsertRange == Range;
96}
97
98// Shorthand for Contains(named(Name)).
99Matcher<const std::vector<CodeCompletion> &> has(std::string Name) {
100 return Contains(named(std::move(Name)));
101}
102Matcher<const std::vector<CodeCompletion> &> has(std::string Name,
104 return Contains(AllOf(named(std::move(Name)), kind(K)));
105}
106MATCHER(isDocumented, "") { return arg.Documentation.has_value(); }
107MATCHER(deprecated, "") { return arg.Deprecated; }
108
109std::unique_ptr<SymbolIndex> memIndex(std::vector<Symbol> Symbols) {
111 for (const auto &Sym : Symbols)
112 Slab.insert(Sym);
113 return MemIndex::build(std::move(Slab).build(), RefSlab(), RelationSlab());
114}
115
116// Runs code completion.
117// If IndexSymbols is non-empty, an index will be built and passed to opts.
118CodeCompleteResult completions(const TestTU &TU, Position Point,
119 std::vector<Symbol> IndexSymbols = {},
120 clangd::CodeCompleteOptions Opts = {}) {
121 std::unique_ptr<SymbolIndex> OverrideIndex;
122 if (!IndexSymbols.empty()) {
123 assert(!Opts.Index && "both Index and IndexSymbols given!");
124 OverrideIndex = memIndex(std::move(IndexSymbols));
125 Opts.Index = OverrideIndex.get();
126 }
127
128 MockFS FS;
129 auto Inputs = TU.inputs(FS);
130 IgnoreDiagnostics Diags;
131 auto CI = buildCompilerInvocation(Inputs, Diags);
132 if (!CI) {
133 ADD_FAILURE() << "Couldn't build CompilerInvocation";
134 return {};
135 }
136 auto Preamble = buildPreamble(testPath(TU.Filename), *CI, Inputs,
137 /*InMemory=*/true, /*Callback=*/nullptr);
138 return codeComplete(testPath(TU.Filename), Point, Preamble.get(), Inputs,
139 Opts);
140}
141
142// Runs code completion.
143CodeCompleteResult completions(llvm::StringRef Text,
144 std::vector<Symbol> IndexSymbols = {},
145 clangd::CodeCompleteOptions Opts = {},
146 PathRef FilePath = "foo.cpp") {
147 Annotations Test(Text);
148 auto TU = TestTU::withCode(Test.code());
149 // To make sure our tests for completiopns inside templates work on Windows.
150 TU.Filename = FilePath.str();
151 return completions(TU, Test.point(), std::move(IndexSymbols),
152 std::move(Opts));
153}
154
155// Runs code completion without the clang parser.
156CodeCompleteResult completionsNoCompile(llvm::StringRef Text,
157 std::vector<Symbol> IndexSymbols = {},
158 clangd::CodeCompleteOptions Opts = {},
159 PathRef FilePath = "foo.cpp") {
160 std::unique_ptr<SymbolIndex> OverrideIndex;
161 if (!IndexSymbols.empty()) {
162 assert(!Opts.Index && "both Index and IndexSymbols given!");
163 OverrideIndex = memIndex(std::move(IndexSymbols));
164 Opts.Index = OverrideIndex.get();
165 }
166
167 MockFS FS;
168 Annotations Test(Text);
169 ParseInputs ParseInput{tooling::CompileCommand(), &FS, Test.code().str()};
170 return codeComplete(FilePath, Test.point(), /*Preamble=*/nullptr, ParseInput,
171 Opts);
172}
173
174Symbol withReferences(int N, Symbol S) {
175 S.References = N;
176 return S;
177}
178
179#if CLANGD_DECISION_FOREST
180TEST(DecisionForestRankingModel, NameMatchSanityTest) {
181 clangd::CodeCompleteOptions Opts;
182 Opts.RankingModel = CodeCompleteOptions::DecisionForest;
183 auto Results = completions(
184 R"cpp(
185struct MemberAccess {
186 int ABG();
187 int AlphaBetaGamma();
188};
189int func() { MemberAccess().ABG^ }
190)cpp",
191 /*IndexSymbols=*/{}, Opts);
192 EXPECT_THAT(Results.Completions,
193 ElementsAre(named("ABG"), named("AlphaBetaGamma")));
194}
195
196TEST(DecisionForestRankingModel, ReferencesAffectRanking) {
197 clangd::CodeCompleteOptions Opts;
198 Opts.RankingModel = CodeCompleteOptions::DecisionForest;
199 constexpr int NumReferences = 100000;
200 EXPECT_THAT(
201 completions("int main() { clang^ }",
202 {ns("clangA"), withReferences(NumReferences, func("clangD"))},
203 Opts)
204 .Completions,
205 ElementsAre(named("clangD"), named("clangA")));
206 EXPECT_THAT(
207 completions("int main() { clang^ }",
208 {withReferences(NumReferences, ns("clangA")), func("clangD")},
209 Opts)
210 .Completions,
211 ElementsAre(named("clangA"), named("clangD")));
212}
213#endif // CLANGD_DECISION_FOREST
214
215TEST(DecisionForestRankingModel, DecisionForestScorerCallbackTest) {
216 clangd::CodeCompleteOptions Opts;
217 constexpr float MagicNumber = 1234.5678f;
218 Opts.RankingModel = CodeCompleteOptions::DecisionForest;
219 Opts.DecisionForestScorer = [&](const SymbolQualitySignals &,
220 const SymbolRelevanceSignals &, float Base) {
222 Scores.Total = MagicNumber;
223 Scores.ExcludingName = MagicNumber;
224 return Scores;
225 };
226 llvm::StringRef Code = "int func() { int xyz; xy^ }";
227 auto Results = completions(Code,
228 /*IndexSymbols=*/{}, Opts);
229 ASSERT_EQ(Results.Completions.size(), 1u);
230 EXPECT_EQ(Results.Completions[0].Score.Total, MagicNumber);
231 EXPECT_EQ(Results.Completions[0].Score.ExcludingName, MagicNumber);
232
233 // Do not use DecisionForestScorer for heuristics model.
234 Opts.RankingModel = CodeCompleteOptions::Heuristics;
235 Results = completions(Code,
236 /*IndexSymbols=*/{}, Opts);
237 ASSERT_EQ(Results.Completions.size(), 1u);
238 EXPECT_NE(Results.Completions[0].Score.Total, MagicNumber);
239 EXPECT_NE(Results.Completions[0].Score.ExcludingName, MagicNumber);
240}
241
242TEST(CompletionTest, Limit) {
243 clangd::CodeCompleteOptions Opts;
244 Opts.Limit = 2;
245 auto Results = completions(R"cpp(
246struct ClassWithMembers {
247 int AAA();
248 int BBB();
249 int CCC();
250};
251
252int main() { ClassWithMembers().^ }
253 )cpp",
254 /*IndexSymbols=*/{}, Opts);
255
256 EXPECT_TRUE(Results.HasMore);
257 EXPECT_THAT(Results.Completions, ElementsAre(named("AAA"), named("BBB")));
258}
259
260TEST(CompletionTest, Filter) {
261 std::string Body = R"cpp(
262 #define MotorCar
263 int Car;
264 struct S {
265 int FooBar;
266 int FooBaz;
267 int Qux;
268 };
269 )cpp";
270
271 // Only items matching the fuzzy query are returned.
272 EXPECT_THAT(completions(Body + "int main() { S().Foba^ }").Completions,
273 AllOf(has("FooBar"), has("FooBaz"), Not(has("Qux"))));
274
275 // Macros require prefix match, either from index or AST.
276 Symbol Sym = var("MotorCarIndex");
277 Sym.SymInfo.Kind = index::SymbolKind::Macro;
278 EXPECT_THAT(
279 completions(Body + "int main() { C^ }", {Sym}).Completions,
280 AllOf(has("Car"), Not(has("MotorCar")), Not(has("MotorCarIndex"))));
281 EXPECT_THAT(completions(Body + "int main() { M^ }", {Sym}).Completions,
282 AllOf(has("MotorCar"), has("MotorCarIndex")));
283}
284
285void testAfterDotCompletion(clangd::CodeCompleteOptions Opts) {
286 auto Results = completions(
287 R"cpp(
288 int global_var;
289
290 int global_func();
291
292 // Make sure this is not in preamble.
293 #define MACRO X
294
295 struct GlobalClass {};
296
297 struct ClassWithMembers {
298 /// doc for method.
299 int method();
300
301 int field;
302 private:
303 int private_field;
304 };
305
306 int test() {
307 struct LocalClass {};
308
309 /// doc for local_var.
310 int local_var;
311
312 ClassWithMembers().^
313 }
314 )cpp",
315 {cls("IndexClass"), var("index_var"), func("index_func")}, Opts);
316
317 EXPECT_TRUE(Results.RanParser);
318 // Class members. The only items that must be present in after-dot
319 // completion.
320 EXPECT_THAT(Results.Completions,
321 AllOf(has("method"), has("field"), Not(has("ClassWithMembers")),
322 Not(has("operator=")), Not(has("~ClassWithMembers"))));
323 EXPECT_IFF(Opts.IncludeIneligibleResults, Results.Completions,
324 has("private_field"));
325 // Global items.
326 EXPECT_THAT(
327 Results.Completions,
328 Not(AnyOf(has("global_var"), has("index_var"), has("global_func"),
329 has("global_func()"), has("index_func"), has("GlobalClass"),
330 has("IndexClass"), has("MACRO"), has("LocalClass"))));
331 // There should be no code patterns (aka snippets) in after-dot
332 // completion. At least there aren't any we're aware of.
333 EXPECT_THAT(Results.Completions,
334 Not(Contains(kind(CompletionItemKind::Snippet))));
335 // Check documentation.
336 EXPECT_THAT(Results.Completions, Contains(isDocumented()));
337}
338
339void testGlobalScopeCompletion(clangd::CodeCompleteOptions Opts) {
340 auto Results = completions(
341 R"cpp(
342 int global_var;
343 int global_func();
344
345 // Make sure this is not in preamble.
346 #define MACRO X
347
348 struct GlobalClass {};
349
350 struct ClassWithMembers {
351 /// doc for method.
352 int method();
353 };
354
355 int test() {
356 struct LocalClass {};
357
358 /// doc for local_var.
359 int local_var;
360
361 ^
362 }
363 )cpp",
364 {cls("IndexClass"), var("index_var"), func("index_func")}, Opts);
365
366 EXPECT_TRUE(Results.RanParser);
367 // Class members. Should never be present in global completions.
368 EXPECT_THAT(Results.Completions,
369 Not(AnyOf(has("method"), has("method()"), has("field"))));
370 // Global items.
371 EXPECT_THAT(Results.Completions,
372 AllOf(has("global_var"), has("index_var"), has("global_func"),
373 has("index_func" /* our fake symbol doesn't include () */),
374 has("GlobalClass"), has("IndexClass")));
375 // A macro.
376 EXPECT_THAT(Results.Completions, has("MACRO"));
377 // Local items. Must be present always.
378 EXPECT_THAT(Results.Completions,
379 AllOf(has("local_var"), has("LocalClass"),
380 Contains(kind(CompletionItemKind::Snippet))));
381 // Check documentation.
382 EXPECT_THAT(Results.Completions, Contains(isDocumented()));
383}
384
385TEST(CompletionTest, CompletionOptions) {
386 auto Test = [&](const clangd::CodeCompleteOptions &Opts) {
387 testAfterDotCompletion(Opts);
388 testGlobalScopeCompletion(Opts);
389 };
390 // We used to test every combination of options, but that got too slow (2^N).
391 auto Flags = {
392 &clangd::CodeCompleteOptions::IncludeIneligibleResults,
393 };
394 // Test default options.
395 Test({});
396 // Test with one flag flipped.
397 for (auto &F : Flags) {
398 clangd::CodeCompleteOptions O;
399 O.*F ^= true;
400 Test(O);
401 }
402}
403
404TEST(CompletionTest, Accessible) {
405 auto Internal = completions(R"cpp(
406 class Foo {
407 public: void pub();
408 protected: void prot();
409 private: void priv();
410 };
411 void Foo::pub() { this->^ }
412 )cpp");
413 EXPECT_THAT(Internal.Completions,
414 AllOf(has("priv"), has("prot"), has("pub")));
415
416 auto External = completions(R"cpp(
417 class Foo {
418 public: void pub();
419 protected: void prot();
420 private: void priv();
421 };
422 void test() {
423 Foo F;
424 F.^
425 }
426 )cpp");
427 EXPECT_THAT(External.Completions,
428 AllOf(has("pub"), Not(has("prot")), Not(has("priv"))));
429
430 auto Results = completions(R"cpp(
431 struct Foo {
432 public: void pub();
433 protected: void prot();
434 private: void priv();
435 };
436 struct Bar : public Foo {
437 private: using Foo::pub;
438 };
439 void test() {
440 Bar B;
441 B.^
442 }
443 )cpp");
444 EXPECT_THAT(Results.Completions,
445 AllOf(Not(has("priv")), Not(has("prot")), Not(has("pub"))));
446}
447
448TEST(CompletionTest, Qualifiers) {
449 auto Results = completions(R"cpp(
450 class Foo {
451 public: int foo() const;
452 int bar() const;
453 };
454 class Bar : public Foo {
455 int foo() const;
456 };
457 void test() { Bar().^ }
458 )cpp");
459 EXPECT_THAT(Results.Completions,
460 Contains(AllOf(qualifier(""), named("bar"))));
461 // Hidden members are not shown.
462 EXPECT_THAT(Results.Completions,
463 Not(Contains(AllOf(qualifier("Foo::"), named("foo")))));
464 // Private members are not shown.
465 EXPECT_THAT(Results.Completions,
466 Not(Contains(AllOf(qualifier(""), named("foo")))));
467}
468
469// https://github.com/clangd/clangd/issues/1451
470TEST(CompletionTest, QualificationWithInlineNamespace) {
471 auto Results = completions(R"cpp(
472 namespace a { inline namespace b {} }
473 using namespace a::b;
474 void f() { Foo^ }
475 )cpp",
476 {cls("a::Foo")});
477 EXPECT_THAT(Results.Completions,
478 UnorderedElementsAre(AllOf(qualifier("a::"), named("Foo"))));
479}
480
481TEST(CompletionTest, InjectedTypename) {
482 // These are suppressed when accessed as a member...
483 EXPECT_THAT(completions("struct X{}; void foo(){ X().^ }").Completions,
484 Not(has("X")));
485 EXPECT_THAT(completions("struct X{ void foo(){ this->^ } };").Completions,
486 Not(has("X")));
487 // ...but accessible in other, more useful cases.
488 EXPECT_THAT(completions("struct X{ void foo(){ ^ } };").Completions,
489 has("X"));
490 EXPECT_THAT(
491 completions("struct Y{}; struct X:Y{ void foo(){ ^ } };").Completions,
492 has("Y"));
493 EXPECT_THAT(
494 completions(
495 "template<class> struct Y{}; struct X:Y<int>{ void foo(){ ^ } };")
496 .Completions,
497 has("Y"));
498 // This case is marginal (`using X::X` is useful), we allow it for now.
499 EXPECT_THAT(completions("struct X{}; void foo(){ X::^ }").Completions,
500 has("X"));
501}
502
503TEST(CompletionTest, SkipInjectedWhenUnqualified) {
504 EXPECT_THAT(completions("struct X { void f() { X^ }};").Completions,
505 ElementsAre(named("X"), named("~X")));
506}
507
508TEST(CompletionTest, Snippets) {
509 clangd::CodeCompleteOptions Opts;
510 auto Results = completions(
511 R"cpp(
512 struct fake {
513 int a;
514 int f(int i, const float f) const;
515 };
516 int main() {
517 fake f;
518 f.^
519 }
520 )cpp",
521 /*IndexSymbols=*/{}, Opts);
522 EXPECT_THAT(
523 Results.Completions,
524 HasSubsequence(named("a"),
525 snippetSuffix("(${1:int i}, ${2:const float f})")));
526}
527
528TEST(CompletionTest, HeuristicsForMemberFunctionCompletion) {
529 clangd::CodeCompleteOptions Opts;
530 Opts.EnableSnippets = true;
531
532 Annotations Code(R"cpp(
533 struct Foo {
534 static int staticMethod(int name);
535 int method(int name) const;
536 template <typename T, typename U, typename V = int>
537 T generic(U nameU, V nameV);
538 template <typename T, int U>
539 static T staticGeneric();
540 Foo() {
541 this->$canBeCallNoStatic^
542 $canBeCall^
543 Foo::$canBeCall^
544 }
545 };
546
547 int Foo::$isDefinition^ {
548 }
549 ;
550
551 int i = Foo::$canBeCallStaticOnly^
552 ;
553
554 struct Derived : Foo {
555 using Foo::method;
556 using Foo::generic;
557 Derived() {
558 Foo::$canBeCall^
559 }
560 };
561
562 struct OtherClass {
563 OtherClass() {
564 Foo f;
565 Derived d;
566 f.$canBeCallNoStatic^
567 ; // Prevent parsing as 'f.f'
568 f.Foo::$canBeCall^
569 ;
570 &Foo::$canNotBeCall^
571 ;
572 d.Foo::$canBeCall^
573 ;
574 d.Derived::$canBeCall^
575 }
576 };
577
578 int main() {
579 Foo f;
580 Derived d;
581 f.$canBeCall^
582 ; // Prevent parsing as 'f.f'
583 f.Foo::$canBeCall^
584 ;
585 &Foo::$canNotBeCall^
586 ;
587 d.Foo::$canBeCall^
588 ;
589 d.Derived::$canBeCall^
590 }
591 )cpp");
592 auto TU = TestTU::withCode(Code.code());
593
594 for (const auto &P : Code.points("canNotBeCall")) {
595 auto Results = completions(TU, P, /*IndexSymbols*/ {}, Opts);
596 EXPECT_THAT(Results.Completions,
597 Contains(AllOf(named("method"), signature("(int name) const"),
598 snippetSuffix(""))));
599 // We don't have any arguments to deduce against if this isn't a call.
600 EXPECT_THAT(
601 Results.Completions,
602 Contains(AllOf(named("generic"),
603 signature("<typename T, typename U>(U nameU, V nameV)"),
604 snippetSuffix("<${1:typename T}, ${2:typename U}>"))));
605 EXPECT_THAT(Results.Completions,
606 Contains(AllOf(named("staticMethod"), signature("(int name)"),
607 snippetSuffix(""))));
608 EXPECT_THAT(Results.Completions,
609 Contains(AllOf(
610 named("staticGeneric"), signature("<typename T, int U>()"),
611 snippetSuffix("<${1:typename T}, ${2:int U}>"))));
612 }
613
614 for (const auto &P : Code.points("canBeCall")) {
615 auto Results = completions(TU, P, /*IndexSymbols*/ {}, Opts);
616 EXPECT_THAT(Results.Completions,
617 Contains(AllOf(named("method"), signature("(int name) const"),
618 snippetSuffix("(${1:int name})"))));
619 EXPECT_THAT(
620 Results.Completions,
621 Contains(AllOf(
622 named("generic"), signature("<typename T>(U nameU, V nameV)"),
623 snippetSuffix("<${1:typename T}>(${2:U nameU}, ${3:V nameV})"))));
624 EXPECT_THAT(Results.Completions,
625 Contains(AllOf(named("staticMethod"), signature("(int name)"),
626 snippetSuffix("(${1:int name})"))));
627 EXPECT_THAT(Results.Completions,
628 Contains(AllOf(
629 named("staticGeneric"), signature("<typename T, int U>()"),
630 snippetSuffix("<${1:typename T}, ${2:int U}>()"))));
631 }
632
633 for (const auto &P : Code.points("canBeCallNoStatic")) {
634 auto Results = completions(TU, P, /*IndexSymbols*/ {}, Opts);
635 EXPECT_THAT(Results.Completions,
636 Contains(AllOf(named("method"), signature("(int name) const"),
637 snippetSuffix("(${1:int name})"))));
638 EXPECT_THAT(
639 Results.Completions,
640 Contains(AllOf(
641 named("generic"), signature("<typename T>(U nameU, V nameV)"),
642 snippetSuffix("<${1:typename T}>(${2:U nameU}, ${3:V nameV})"))));
643 }
644
645 for (const auto &P : Code.points("canBeCallStaticOnly")) {
646 auto Results = completions(TU, P, /*IndexSymbols*/ {}, Opts);
647 EXPECT_THAT(Results.Completions,
648 Contains(AllOf(named("method"), signature("(int name) const"),
649 snippetSuffix(""))));
650 EXPECT_THAT(
651 Results.Completions,
652 Contains(AllOf(named("generic"),
653 signature("<typename T, typename U>(U nameU, V nameV)"),
654 snippetSuffix("<${1:typename T}, ${2:typename U}>"))));
655 EXPECT_THAT(Results.Completions,
656 Contains(AllOf(named("staticMethod"), signature("(int name)"),
657 snippetSuffix("(${1:int name})"))));
658 EXPECT_THAT(Results.Completions,
659 Contains(AllOf(
660 named("staticGeneric"), signature("<typename T, int U>()"),
661 snippetSuffix("<${1:typename T}, ${2:int U}>()"))));
662 }
663
664 for (const auto &P : Code.points("isDefinition")) {
665 auto Results = completions(TU, P, /*IndexSymbols*/ {}, Opts);
666
667 EXPECT_THAT(Results.Completions,
668 Contains(AllOf(named("method"), signature("(int name) const"),
669 snippetSuffix("(int name) const"))));
670 EXPECT_THAT(
671 Results.Completions,
672 Contains(AllOf(named("generic"),
673 signature("<typename T, typename U>(U nameU, V nameV)"),
674 snippetSuffix("(U nameU, V nameV)"))));
675 EXPECT_THAT(Results.Completions,
676 Contains(AllOf(named("staticMethod"), signature("(int name)"),
677 snippetSuffix("(int name)"))));
678 EXPECT_THAT(Results.Completions,
679 Contains(AllOf(named("staticGeneric"),
680 signature("<typename T, int U>()"),
681 snippetSuffix("()"))));
682 }
683}
684
685TEST(CompletionTest, PrivateMemberDefinition) {
686 clangd::CodeCompleteOptions Opts;
687 Opts.EnableSnippets = true;
688 auto Results = completions(
689 R"cpp(
690 class Foo {
691 int func(int a, int b);
692 };
693 int Foo::func^
694 )cpp",
695 /*IndexSymbols=*/{}, Opts);
696 EXPECT_THAT(Results.Completions,
697 Contains(AllOf(named("func"), signature("(int a, int b)"),
698 snippetSuffix("(int a, int b)"))));
699}
700
701TEST(CompletionTest, DeclParamName) {
702 // This is 1/3 regression tests to make sure signatures
703 // 1) have consistent variable names between header and source file
704 // 2) find variable names in other declarations
705 // See SignatureHelpTest.DeclParamName and IndexActionTest.DeclParamName for
706 // the other tests.
707 clangd::CodeCompleteOptions Opts;
708 Opts.EnableSnippets = true;
709 auto FuncFromSource = completions(R"cpp(
710 void sun(int);
711 void sun(int night);
712 void sun(int day);
713 void sun(int);
714 void position() {
715 sun^;
716 }
717 )cpp",
718 {}, Opts);
719 EXPECT_THAT(FuncFromSource.Completions, Contains(signature("(int day)")));
720}
721
722TEST(CompletionTest, DefaultArgsWithValues) {
723 clangd::CodeCompleteOptions Opts;
724 Opts.EnableSnippets = true;
725 auto Results = completions(
726 R"cpp(
727 struct Arg {
728 Arg(int a, int b);
729 };
730 struct Foo {
731 void foo(int x = 42, int y = 0, Arg arg = Arg(42, 0));
732 };
733 void Foo::foo^
734 )cpp",
735 /*IndexSymbols=*/{}, Opts);
736 EXPECT_THAT(Results.Completions,
737 Contains(AllOf(
738 named("foo"),
739 signature("(int x = 42, int y = 0, Arg arg = Arg(42, 0))"),
740 snippetSuffix("(int x, int y, Arg arg)"))));
741}
742
743TEST(CompletionTest, NoSnippetsInUsings) {
744 clangd::CodeCompleteOptions Opts;
745 Opts.EnableSnippets = true;
746 auto Results = completions(
747 R"cpp(
748 namespace ns {
749 int func(int a, int b);
750 }
751
752 using ns::^;
753 )cpp",
754 /*IndexSymbols=*/{}, Opts);
755 EXPECT_THAT(Results.Completions,
756 ElementsAre(AllOf(named("func"), labeled("func(int a, int b)"),
757 snippetSuffix(""))));
758
759 // Check index completions too.
760 auto Func = func("ns::func");
761 Func.CompletionSnippetSuffix = "(${1:int a}, ${2: int b})";
762 Func.Signature = "(int a, int b)";
763 Func.ReturnType = "void";
764
765 Results = completions(R"cpp(
766 namespace ns {}
767 using ns::^;
768 )cpp",
769 /*IndexSymbols=*/{Func}, Opts);
770 EXPECT_THAT(Results.Completions,
771 ElementsAre(AllOf(named("func"), labeled("func(int a, int b)"),
772 snippetSuffix(""))));
773
774 // Check all-scopes completions too.
775 Opts.AllScopes = true;
776 Results = completions(R"cpp(
777 using ^;
778 )cpp",
779 /*IndexSymbols=*/{Func}, Opts);
780 EXPECT_THAT(Results.Completions,
781 Contains(AllOf(named("func"), labeled("ns::func(int a, int b)"),
782 snippetSuffix(""))));
783}
784
785TEST(CompletionTest, Kinds) {
786 auto Results = completions(
787 R"cpp(
788 int variable;
789 struct Struct {};
790 int function();
791 // make sure MACRO is not included in preamble.
792 #define MACRO 10
793 int X = ^
794 )cpp",
795 {func("indexFunction"), var("indexVariable"), cls("indexClass"),
796 macro("indexObjMacro"), macro("indexFuncMacro", "(x, y)")});
797 EXPECT_THAT(Results.Completions,
798 AllOf(has("function", CompletionItemKind::Function),
799 has("variable", CompletionItemKind::Variable),
800 has("int", CompletionItemKind::Keyword),
801 has("Struct", CompletionItemKind::Struct),
802 has("MACRO", CompletionItemKind::Constant),
803 has("indexFunction", CompletionItemKind::Function),
804 has("indexVariable", CompletionItemKind::Variable),
805 has("indexClass", CompletionItemKind::Class),
806 has("indexObjMacro", CompletionItemKind::Constant),
807 has("indexFuncMacro", CompletionItemKind::Function)));
808
809 Results = completions("nam^");
810 EXPECT_THAT(Results.Completions,
811 has("namespace", CompletionItemKind::Snippet));
812
813 // Members of anonymous unions are of kind 'field'.
814 Results = completions(
815 R"cpp(
816 struct X{
817 union {
818 void *a;
819 };
820 };
821 auto u = X().^
822 )cpp");
823 EXPECT_THAT(
824 Results.Completions,
825 UnorderedElementsAre(AllOf(named("a"), kind(CompletionItemKind::Field))));
826
827 // Completion kinds for templates should not be unknown.
828 Results = completions(
829 R"cpp(
830 template <class T> struct complete_class {};
831 template <class T> void complete_function();
832 template <class T> using complete_type_alias = int;
833 template <class T> int complete_variable = 10;
834
835 struct X {
836 template <class T> static int complete_static_member = 10;
837
838 static auto x = complete_^
839 }
840 )cpp");
841 EXPECT_THAT(
842 Results.Completions,
843 UnorderedElementsAre(
844 AllOf(named("complete_class"), kind(CompletionItemKind::Class)),
845 AllOf(named("complete_function"), kind(CompletionItemKind::Function)),
846 AllOf(named("complete_type_alias"),
848 AllOf(named("complete_variable"), kind(CompletionItemKind::Variable)),
849 AllOf(named("complete_static_member"),
851
852 Results = completions(
853 R"cpp(
854 enum Color {
855 Red
856 };
857 Color u = ^
858 )cpp");
859 EXPECT_THAT(
860 Results.Completions,
861 Contains(AllOf(named("Red"), kind(CompletionItemKind::EnumMember))));
862}
863
864TEST(CompletionTest, NoDuplicates) {
865 auto Results = completions(
866 R"cpp(
867 class Adapter {
868 };
869
870 void f() {
871 Adapter^
872 }
873 )cpp",
874 {cls("Adapter")});
875
876 // Make sure there are no duplicate entries of 'Adapter'.
877 EXPECT_THAT(Results.Completions, ElementsAre(named("Adapter")));
878}
879
880TEST(CompletionTest, ScopedNoIndex) {
881 auto Results = completions(
882 R"cpp(
883 namespace fake { int BigBang, Babble, Box; };
884 int main() { fake::ba^ }
885 ")cpp");
886 // Babble is a better match than BigBang. Box doesn't match at all.
887 EXPECT_THAT(Results.Completions,
888 ElementsAre(named("Babble"), named("BigBang")));
889}
890
891TEST(CompletionTest, Scoped) {
892 auto Results = completions(
893 R"cpp(
894 namespace fake { int Babble, Box; };
895 int main() { fake::ba^ }
896 ")cpp",
897 {var("fake::BigBang")});
898 EXPECT_THAT(Results.Completions,
899 ElementsAre(named("Babble"), named("BigBang")));
900}
901
902TEST(CompletionTest, ScopedWithFilter) {
903 auto Results = completions(
904 R"cpp(
905 void f() { ns::x^ }
906 )cpp",
907 {cls("ns::XYZ"), func("ns::foo")});
908 EXPECT_THAT(Results.Completions, UnorderedElementsAre(named("XYZ")));
909}
910
911TEST(CompletionTest, ReferencesAffectRanking) {
912 EXPECT_THAT(completions("int main() { abs^ }", {func("absA"), func("absB")})
913 .Completions,
914 HasSubsequence(named("absA"), named("absB")));
915 EXPECT_THAT(completions("int main() { abs^ }",
916 {func("absA"), withReferences(1000, func("absB"))})
917 .Completions,
918 HasSubsequence(named("absB"), named("absA")));
919}
920
921TEST(CompletionTest, ContextWords) {
922 auto Results = completions(R"cpp(
923 enum class Color { RED, YELLOW, BLUE };
924
925 // (blank lines so the definition above isn't "context")
926
927 // "It was a yellow car," he said. "Big yellow car, new."
928 auto Finish = Color::^
929 )cpp");
930 // Yellow would normally sort last (alphabetic).
931 // But the recent mention should bump it up.
932 ASSERT_THAT(Results.Completions,
933 HasSubsequence(named("YELLOW"), named("BLUE")));
934}
935
936TEST(CompletionTest, GlobalQualified) {
937 auto Results = completions(
938 R"cpp(
939 void f() { ::^ }
940 )cpp",
941 {cls("XYZ")});
942 EXPECT_THAT(Results.Completions,
943 AllOf(has("XYZ", CompletionItemKind::Class),
945}
946
947TEST(CompletionTest, FullyQualified) {
948 auto Results = completions(
949 R"cpp(
950 namespace ns { void bar(); }
951 void f() { ::ns::^ }
952 )cpp",
953 {cls("ns::XYZ")});
954 EXPECT_THAT(Results.Completions,
955 AllOf(has("XYZ", CompletionItemKind::Class),
956 has("bar", CompletionItemKind::Function)));
957}
958
959TEST(CompletionTest, SemaIndexMerge) {
960 auto Results = completions(
961 R"cpp(
962 namespace ns { int local; void both(); }
963 void f() { ::ns::^ }
964 )cpp",
965 {func("ns::both"), cls("ns::Index")});
966 // We get results from both index and sema, with no duplicates.
967 EXPECT_THAT(Results.Completions,
968 UnorderedElementsAre(
969 AllOf(named("local"), origin(SymbolOrigin::AST)),
970 AllOf(named("Index"), origin(SymbolOrigin::Static)),
971 AllOf(named("both"),
973}
974
975TEST(CompletionTest, SemaIndexMergeWithLimit) {
976 clangd::CodeCompleteOptions Opts;
977 Opts.Limit = 1;
978 auto Results = completions(
979 R"cpp(
980 namespace ns { int local; void both(); }
981 void f() { ::ns::^ }
982 )cpp",
983 {func("ns::both"), cls("ns::Index")}, Opts);
984 EXPECT_EQ(Results.Completions.size(), Opts.Limit);
985 EXPECT_TRUE(Results.HasMore);
986}
987
988TEST(CompletionTest, IncludeInsertionPreprocessorIntegrationTests) {
989 TestTU TU;
990 TU.ExtraArgs.push_back("-I" + testPath("sub"));
991 TU.AdditionalFiles["sub/bar.h"] = "";
992 auto BarURI = URI::create(testPath("sub/bar.h")).toString();
993
994 Symbol Sym = cls("ns::X");
995 Sym.CanonicalDeclaration.FileURI = BarURI.c_str();
996 Sym.IncludeHeaders.emplace_back(BarURI, 1, Symbol::Include);
997 // Shorten include path based on search directory and insert.
998 Annotations Test("int main() { ns::^ }");
999 TU.Code = Test.code().str();
1000 auto Results = completions(TU, Test.point(), {Sym});
1001 EXPECT_THAT(Results.Completions,
1002 ElementsAre(AllOf(named("X"), insertInclude("\"bar.h\""))));
1003 // Can be disabled via option.
1004 CodeCompleteOptions NoInsertion;
1005 NoInsertion.InsertIncludes = Config::HeaderInsertionPolicy::NeverInsert;
1006 Results = completions(TU, Test.point(), {Sym}, NoInsertion);
1007 EXPECT_THAT(Results.Completions,
1008 ElementsAre(AllOf(named("X"), Not(insertInclude()))));
1009 // Duplicate based on inclusions in preamble.
1010 Test = Annotations(R"cpp(
1011 #include "sub/bar.h" // not shortest, so should only match resolved.
1012 int main() { ns::^ }
1013 )cpp");
1014 TU.Code = Test.code().str();
1015 Results = completions(TU, Test.point(), {Sym});
1016 EXPECT_THAT(Results.Completions, ElementsAre(AllOf(named("X"), labeled("X"),
1017 Not(insertInclude()))));
1018}
1019
1020TEST(CompletionTest, NoIncludeInsertionWhenDeclFoundInFile) {
1021 Symbol SymX = cls("ns::X");
1022 Symbol SymY = cls("ns::Y");
1023 std::string BarHeader = testPath("bar.h");
1024 auto BarURI = URI::create(BarHeader).toString();
1025 SymX.CanonicalDeclaration.FileURI = BarURI.c_str();
1026 SymY.CanonicalDeclaration.FileURI = BarURI.c_str();
1027 SymX.IncludeHeaders.emplace_back("<bar>", 1, Symbol::Include);
1028 SymY.IncludeHeaders.emplace_back("<bar>", 1, Symbol::Include);
1029 // Shorten include path based on search directory and insert.
1030 auto Results = completions(R"cpp(
1031 namespace ns {
1032 class X;
1033 class Y {};
1034 }
1035 int main() { ns::^ }
1036 )cpp",
1037 {SymX, SymY});
1038 EXPECT_THAT(Results.Completions,
1039 ElementsAre(AllOf(named("X"), Not(insertInclude())),
1040 AllOf(named("Y"), Not(insertInclude()))));
1041}
1042
1043TEST(CompletionTest, IncludeInsertionRespectsQuotedAngledConfig) {
1044 TestTU TU;
1045 TU.ExtraArgs.push_back("-I" + testPath("sub"));
1046 TU.AdditionalFiles["sub/bar.h"] = "";
1047 auto BarURI = URI::create(testPath("sub/bar.h")).toString();
1048
1049 Symbol Sym = cls("ns::X");
1050 Sym.CanonicalDeclaration.FileURI = BarURI.c_str();
1051 Sym.IncludeHeaders.emplace_back(BarURI, 1, Symbol::Include);
1052 Annotations Test("int main() { ns::^ }");
1053 TU.Code = Test.code().str();
1054 auto Results = completions(TU, Test.point(), {Sym});
1055 // Default for a local path is quoted include
1056 EXPECT_THAT(Results.Completions,
1057 ElementsAre(AllOf(named("X"), insertInclude("\"bar.h\""))));
1058 {
1059 Config C;
1060 C.Style.AngledHeaders.push_back(
1061 [](auto header) { return header.contains("bar.h"); });
1062 WithContextValue WithCfg(Config::Key, std::move(C));
1063 Results = completions(TU, Test.point(), {Sym});
1064 EXPECT_THAT(Results.Completions,
1065 ElementsAre(AllOf(named("X"), insertInclude("<bar.h>"))));
1066 }
1067 {
1068 Config C;
1069 C.Style.QuotedHeaders.push_back(
1070 [](auto header) { return header.contains("bar.h"); });
1071 WithContextValue WithCfg(Config::Key, std::move(C));
1072 Results = completions(TU, Test.point(), {Sym});
1073 EXPECT_THAT(Results.Completions,
1074 ElementsAre(AllOf(named("X"), insertInclude("\"bar.h\""))));
1075 }
1076}
1077
1078TEST(CompletionTest, IndexSuppressesPreambleCompletions) {
1079 Annotations Test(R"cpp(
1080 #include "bar.h"
1081 namespace ns { int local; }
1082 void f() { ns::^; }
1083 void f2() { ns::preamble().$2^; }
1084 )cpp");
1085 auto TU = TestTU::withCode(Test.code());
1086 TU.AdditionalFiles["bar.h"] =
1087 R"cpp(namespace ns { struct preamble { int member; }; })cpp";
1088
1089 clangd::CodeCompleteOptions Opts = {};
1090 auto I = memIndex({var("ns::index")});
1091 Opts.Index = I.get();
1092 auto WithIndex = completions(TU, Test.point(), {}, Opts);
1093 EXPECT_THAT(WithIndex.Completions,
1094 UnorderedElementsAre(named("local"), named("index")));
1095 auto ClassFromPreamble = completions(TU, Test.point("2"), {}, Opts);
1096 EXPECT_THAT(ClassFromPreamble.Completions, Contains(named("member")));
1097
1098 Opts.Index = nullptr;
1099 auto WithoutIndex = completions(TU, Test.point(), {}, Opts);
1100 EXPECT_THAT(WithoutIndex.Completions,
1101 UnorderedElementsAre(named("local"), named("preamble")));
1102}
1103
1104// This verifies that we get normal preprocessor completions in the preamble.
1105// This is a regression test for an old bug: if we override the preamble and
1106// try to complete inside it, clang kicks our completion point just outside the
1107// preamble, resulting in always getting top-level completions.
1108TEST(CompletionTest, CompletionInPreamble) {
1109 auto Results = completions(R"cpp(
1110 #ifnd^ef FOO_H_
1111 #define BAR_H_
1112 #include <bar.h>
1113 int foo() {}
1114 #endif
1115 )cpp")
1116 .Completions;
1117 EXPECT_THAT(Results, ElementsAre(named("ifndef")));
1118}
1119
1120TEST(CompletionTest, CompletionRecoveryASTType) {
1121 auto Results = completions(R"cpp(
1122 struct S { int member; };
1123 S overloaded(int);
1124 void foo() {
1125 // No overload matches, but we have recovery-expr with the correct type.
1126 overloaded().^
1127 })cpp")
1128 .Completions;
1129 EXPECT_THAT(Results, ElementsAre(named("member")));
1130}
1131
1132TEST(CompletionTest, DynamicIndexIncludeInsertion) {
1133 MockFS FS;
1136 Opts.BuildDynamicSymbolIndex = true;
1137 ClangdServer Server(CDB, FS, Opts);
1138
1139 FS.Files[testPath("foo_header.h")] = R"cpp(
1140 #pragma once
1141 struct Foo {
1142 // Member doc
1143 int foo();
1144 };
1145 )cpp";
1146 const std::string FileContent(R"cpp(
1147 #include "foo_header.h"
1148 int Foo::foo() {
1149 return 42;
1150 }
1151 )cpp");
1152 Server.addDocument(testPath("foo_impl.cpp"), FileContent);
1153 // Wait for the dynamic index being built.
1154 ASSERT_TRUE(Server.blockUntilIdleForTest());
1155
1156 auto File = testPath("foo.cpp");
1157 Annotations Test("Foo^ foo;");
1158 runAddDocument(Server, File, Test.code());
1159 auto CompletionList =
1160 llvm::cantFail(runCodeComplete(Server, File, Test.point(), {}));
1161
1162 EXPECT_THAT(CompletionList.Completions,
1163 ElementsAre(AllOf(named("Foo"), hasInclude("\"foo_header.h\""),
1164 insertInclude())));
1165}
1166
1167TEST(CompletionTest, DynamicIndexMultiFile) {
1168 MockFS FS;
1170 auto Opts = ClangdServer::optsForTest();
1171 Opts.BuildDynamicSymbolIndex = true;
1172 ClangdServer Server(CDB, FS, Opts);
1173
1174 FS.Files[testPath("foo.h")] = R"cpp(
1175 namespace ns { class XYZ {}; void foo(int x) {} }
1176 )cpp";
1177 runAddDocument(Server, testPath("foo.cpp"), R"cpp(
1178 #include "foo.h"
1179 )cpp");
1180
1181 auto File = testPath("bar.cpp");
1182 Annotations Test(R"cpp(
1183 namespace ns {
1184 class XXX {};
1185 /// Doooc
1186 void fooooo() {}
1187 }
1188 void f() { ns::^ }
1189 )cpp");
1190 runAddDocument(Server, File, Test.code());
1191
1192 auto Results = cantFail(runCodeComplete(Server, File, Test.point(), {}));
1193 // "XYZ" and "foo" are not included in the file being completed but are still
1194 // visible through the index.
1195 EXPECT_THAT(Results.Completions, has("XYZ", CompletionItemKind::Class));
1196 EXPECT_THAT(Results.Completions, has("foo", CompletionItemKind::Function));
1197 EXPECT_THAT(Results.Completions, has("XXX", CompletionItemKind::Class));
1198 EXPECT_THAT(Results.Completions,
1199 Contains((named("fooooo"), kind(CompletionItemKind::Function),
1200 doc("Doooc"), returnType("void"))));
1201}
1202
1203TEST(CompletionTest, Documentation) {
1204 auto Results = completions(
1205 R"cpp(
1206 // Non-doxygen comment.
1207 __attribute__((annotate("custom_annotation"))) int foo();
1208 /// Doxygen comment.
1209 /// \param int a
1210 int bar(int a);
1211 /* Multi-line
1212 block comment
1213 */
1214 int baz();
1215
1216 int x = ^
1217 )cpp");
1218 EXPECT_THAT(
1219 Results.Completions,
1220 Contains(
1221 AllOf(named("foo"),
1222 doc("Annotation: custom_annotation\n\nNon-doxygen comment."))));
1223 EXPECT_THAT(
1224 Results.Completions,
1225 Contains(AllOf(named("bar"), doc("Doxygen comment.\n\\param int a"))));
1226 EXPECT_THAT(Results.Completions,
1227 Contains(AllOf(named("baz"), doc("Multi-line block comment"))));
1228}
1229
1230TEST(CompletionTest, CommentsFromSystemHeaders) {
1231 MockFS FS;
1233
1234 auto Opts = ClangdServer::optsForTest();
1235 Opts.BuildDynamicSymbolIndex = true;
1236
1237 ClangdServer Server(CDB, FS, Opts);
1238
1239 FS.Files[testPath("foo.h")] = R"cpp(
1240 #pragma GCC system_header
1241
1242 // This comment should be retained!
1243 int foo();
1244 )cpp";
1245
1246 auto File = testPath("foo.cpp");
1247 Annotations Test(R"cpp(
1248#include "foo.h"
1249int x = foo^
1250 )cpp");
1251 runAddDocument(Server, File, Test.code());
1252 auto CompletionList =
1253 llvm::cantFail(runCodeComplete(Server, File, Test.point(), {}));
1254
1255 EXPECT_THAT(
1256 CompletionList.Completions,
1257 Contains(AllOf(named("foo"), doc("This comment should be retained!"))));
1258}
1259
1260TEST(CompletionTest, CommentsOnMembersFromHeader) {
1261 MockFS FS;
1263
1264 auto Opts = ClangdServer::optsForTest();
1265 Opts.BuildDynamicSymbolIndex = true;
1266
1267 ClangdServer Server(CDB, FS, Opts);
1268
1269 FS.Files[testPath("foo.h")] = R"cpp(
1270 struct alpha {
1271 /// This is a member field.
1272 int gamma;
1273
1274 /// This is a member function.
1275 int delta();
1276 };
1277
1278 template <typename T>
1279 struct beta {
1280 /// This is a member field inside a template.
1281 int omega;
1282
1283 /// This is a member function inside a template.
1284 int epsilon();
1285 };
1286 )cpp";
1287
1288 auto File = testPath("foo.cpp");
1289 Annotations Test(R"cpp(
1290#include "foo.h"
1291alpha a;
1292beta<int> b;
1293int x = a.$p1^;
1294int y = b.$p2^;
1295 )cpp");
1296 runAddDocument(Server, File, Test.code());
1297 auto CompletionList =
1298 llvm::cantFail(runCodeComplete(Server, File, Test.point("p1"), {}));
1299
1300 EXPECT_THAT(CompletionList.Completions,
1301 Contains(AllOf(named("gamma"), doc("This is a member field."))));
1302 EXPECT_THAT(
1303 CompletionList.Completions,
1304 Contains(AllOf(named("delta"), doc("This is a member function."))));
1305
1307 llvm::cantFail(runCodeComplete(Server, File, Test.point("p2"), {}));
1308
1309 EXPECT_THAT(CompletionList.Completions,
1310 Contains(AllOf(named("omega")
1311 /* FIXME: Doc retrieval does not work yet*/)));
1312 EXPECT_THAT(
1313 CompletionList.Completions,
1314 Contains(AllOf(named("epsilon"),
1315 doc("This is a member function inside a template."))));
1316}
1317
1318TEST(CompletionTest, CommentsOnMembersFromHeaderOverloadBundling) {
1319 using testing::AnyOf;
1320 MockFS FS;
1322
1323 auto Opts = ClangdServer::optsForTest();
1324 Opts.BuildDynamicSymbolIndex = true;
1325
1326 ClangdServer Server(CDB, FS, Opts);
1327
1328 FS.Files[testPath("foo.h")] = R"cpp(
1329 struct alpha {
1330 /// bool overload.
1331 int delta(bool b);
1332
1333 /// int overload.
1334 int delta(int i);
1335
1336 void epsilon(long l);
1337
1338 /// This one has a comment.
1339 void epsilon(int i);
1340 };
1341 )cpp";
1342
1343 auto File = testPath("foo.cpp");
1344 Annotations Test(R"cpp(
1345#include "foo.h"
1346alpha a;
1347int x = a.^
1348 )cpp");
1349 runAddDocument(Server, File, Test.code());
1350 clangd::CodeCompleteOptions CCOpts;
1351 CCOpts.BundleOverloads = true;
1352 auto CompletionList =
1353 llvm::cantFail(runCodeComplete(Server, File, Test.point(), CCOpts));
1354
1355 EXPECT_THAT(
1356 CompletionList.Completions,
1357 Contains(AllOf(named("epsilon"), doc("This one has a comment."))));
1358 EXPECT_THAT(CompletionList.Completions,
1359 Contains(AllOf(named("delta"), AnyOf(doc("bool overload."),
1360 doc("int overload.")))));
1361}
1362
1363TEST(CompletionTest, GlobalCompletionFiltering) {
1364
1365 Symbol Class = cls("XYZ");
1366 Class.Flags = static_cast<Symbol::SymbolFlag>(
1368 Symbol Func = func("XYZ::foooo");
1369 Func.Flags = static_cast<Symbol::SymbolFlag>(
1370 Func.Flags & ~(Symbol::IndexedForCodeCompletion));
1371
1372 auto Results = completions(R"(// void f() {
1373 XYZ::foooo^
1374 })",
1375 {Class, Func});
1376 EXPECT_THAT(Results.Completions, IsEmpty());
1377}
1378
1379TEST(CodeCompleteTest, DisableTypoCorrection) {
1380 auto Results = completions(R"cpp(
1381 namespace clang { int v; }
1382 void f() { clangd::^
1383 )cpp");
1384 EXPECT_TRUE(Results.Completions.empty());
1385}
1386
1387TEST(CodeCompleteTest, NoColonColonAtTheEnd) {
1388 auto Results = completions(R"cpp(
1389 namespace clang { }
1390 void f() {
1391 clan^
1392 }
1393 )cpp");
1394
1395 EXPECT_THAT(Results.Completions, Contains(labeled("clang")));
1396 EXPECT_THAT(Results.Completions, Not(Contains(labeled("clang::"))));
1397}
1398
1399TEST(CompletionTests, EmptySnippetDoesNotCrash) {
1400 // See https://github.com/clangd/clangd/issues/1216
1401 auto Results = completions(R"cpp(
1402 int main() {
1403 auto w = [&](auto &&f) { return f(f); };
1404 auto f = w([&](auto &&f) {
1405 return [&](auto &&n) {
1406 if (n == 0) {
1407 return 1;
1408 }
1409 return n * ^(f)(n - 1);
1410 };
1411 })(10);
1412 }
1413 )cpp");
1414}
1415
1416TEST(CompletionTest, Issue1427Crash) {
1417 // Need to provide main file signals to ensure that the branch in
1418 // SymbolRelevanceSignals::computeASTSignals() that tries to
1419 // compute a symbol ID is taken.
1420 ASTSignals MainFileSignals;
1422 Opts.MainFileSignals = &MainFileSignals;
1423 completions(R"cpp(
1424 auto f = []() {
1425 1.0_^
1426 };
1427 )cpp",
1428 {}, Opts);
1429}
1430
1431TEST(CompletionTest, BacktrackCrashes) {
1432 // Sema calls code completion callbacks twice in these cases.
1433 auto Results = completions(R"cpp(
1434 namespace ns {
1435 struct FooBarBaz {};
1436 } // namespace ns
1437
1438 int foo(ns::FooBar^
1439 )cpp");
1440
1441 EXPECT_THAT(Results.Completions, ElementsAre(labeled("FooBarBaz")));
1442
1443 // Check we don't crash in that case too.
1444 completions(R"cpp(
1445 struct FooBarBaz {};
1446 void test() {
1447 if (FooBarBaz * x^) {}
1448 }
1449)cpp");
1450}
1451
1452TEST(CompletionTest, CompleteInMacroWithStringification) {
1453 auto Results = completions(R"cpp(
1454void f(const char *, int x);
1455#define F(x) f(#x, x)
1456
1457namespace ns {
1458int X;
1459int Y;
1460} // namespace ns
1461
1462int f(int input_num) {
1463 F(ns::^)
1464}
1465)cpp");
1466
1467 EXPECT_THAT(Results.Completions,
1468 UnorderedElementsAre(named("X"), named("Y")));
1469}
1470
1471TEST(CompletionTest, CompleteInMacroAndNamespaceWithStringification) {
1472 auto Results = completions(R"cpp(
1473void f(const char *, int x);
1474#define F(x) f(#x, x)
1475
1476namespace ns {
1477int X;
1478
1479int f(int input_num) {
1480 F(^)
1481}
1482} // namespace ns
1483)cpp");
1484
1485 EXPECT_THAT(Results.Completions, Contains(named("X")));
1486}
1487
1488TEST(CompletionTest, IgnoreCompleteInExcludedPPBranchWithRecoveryContext) {
1489 auto Results = completions(R"cpp(
1490 int bar(int param_in_bar) {
1491 }
1492
1493 int foo(int param_in_foo) {
1494#if 0
1495 // In recovery mode, "param_in_foo" will also be suggested among many other
1496 // unrelated symbols; however, this is really a special case where this works.
1497 // If the #if block is outside of the function, "param_in_foo" is still
1498 // suggested, but "bar" and "foo" are missing. So the recovery mode doesn't
1499 // really provide useful results in excluded branches.
1500 par^
1501#endif
1502 }
1503)cpp");
1504
1505 EXPECT_TRUE(Results.Completions.empty());
1506}
1507
1508TEST(CompletionTest, DefaultArgs) {
1509 clangd::CodeCompleteOptions Opts;
1510 std::string Context = R"cpp(
1511 int X(int A = 0);
1512 int Y(int A, int B = 0);
1513 int Z(int A, int B = 0, int C = 0, int D = 0);
1514 )cpp";
1515 EXPECT_THAT(completions(Context + "int y = X^", {}, Opts).Completions,
1516 UnorderedElementsAre(labeled("X(int A = 0)")));
1517 EXPECT_THAT(completions(Context + "int y = Y^", {}, Opts).Completions,
1518 UnorderedElementsAre(AllOf(labeled("Y(int A, int B = 0)"),
1519 snippetSuffix("(${1:int A})"))));
1520 EXPECT_THAT(completions(Context + "int y = Z^", {}, Opts).Completions,
1521 UnorderedElementsAre(
1522 AllOf(labeled("Z(int A, int B = 0, int C = 0, int D = 0)"),
1523 snippetSuffix("(${1:int A})"))));
1524}
1525
1526TEST(CompletionTest, NoCrashWithTemplateParamsAndPreferredTypes) {
1527 auto Completions = completions(R"cpp(
1528template <template <class> class TT> int foo() {
1529 int a = ^
1530}
1531)cpp")
1532 .Completions;
1533 EXPECT_THAT(Completions, Contains(named("TT")));
1534}
1535
1536TEST(CompletionTest, NestedTemplateHeuristics) {
1537 auto Completions = completions(R"cpp(
1538struct Plain { int xxx; };
1539template <typename T> class Templ { Plain ppp; };
1540template <typename T> void foo(Templ<T> &t) {
1541 // Formally ppp has DependentTy, because Templ may be specialized.
1542 // However we sholud be able to see into it using the primary template.
1543 t.ppp.^
1544}
1545)cpp")
1546 .Completions;
1547 EXPECT_THAT(Completions, Contains(named("xxx")));
1548}
1549
1550TEST(CompletionTest, RecordCCResultCallback) {
1551 std::vector<CodeCompletion> RecordedCompletions;
1553 Opts.RecordCCResult = [&RecordedCompletions](const CodeCompletion &CC,
1554 const SymbolQualitySignals &,
1555 const SymbolRelevanceSignals &,
1556 float Score) {
1557 RecordedCompletions.push_back(CC);
1558 };
1559
1560 completions("int xy1, xy2; int a = xy^", /*IndexSymbols=*/{}, Opts);
1561 EXPECT_THAT(RecordedCompletions,
1562 UnorderedElementsAre(named("xy1"), named("xy2")));
1563}
1564
1565TEST(CompletionTest, ASTSignals) {
1566 struct Completion {
1567 std::string Name;
1568 unsigned MainFileRefs;
1569 unsigned ScopeRefsInFile;
1570 };
1572 std::vector<Completion> RecordedCompletions;
1573 Opts.RecordCCResult = [&RecordedCompletions](const CodeCompletion &CC,
1574 const SymbolQualitySignals &,
1575 const SymbolRelevanceSignals &R,
1576 float Score) {
1577 RecordedCompletions.push_back({CC.Name, R.MainFileRefs, R.ScopeRefsInFile});
1578 };
1579 ASTSignals MainFileSignals;
1580 MainFileSignals.ReferencedSymbols[var("xy1").ID] = 3;
1581 MainFileSignals.ReferencedSymbols[var("xy2").ID] = 1;
1582 MainFileSignals.ReferencedSymbols[var("xyindex").ID] = 10;
1583 MainFileSignals.RelatedNamespaces["tar::"] = 5;
1584 MainFileSignals.RelatedNamespaces["bar::"] = 3;
1585 Opts.MainFileSignals = &MainFileSignals;
1586 Opts.AllScopes = true;
1587 completions(
1588 R"cpp(
1589 int xy1;
1590 int xy2;
1591 namespace bar {
1592 int xybar = 1;
1593 int a = xy^
1594 }
1595 )cpp",
1596 /*IndexSymbols=*/{var("xyindex"), var("tar::xytar"), var("bar::xybar")},
1597 Opts);
1598 EXPECT_THAT(RecordedCompletions,
1599 UnorderedElementsAre(
1600 AllOf(named("xy1"), mainFileRefs(3u), scopeRefs(0u)),
1601 AllOf(named("xy2"), mainFileRefs(1u), scopeRefs(0u)),
1602 AllOf(named("xyindex"), mainFileRefs(10u), scopeRefs(0u)),
1603 AllOf(named("xytar"), mainFileRefs(0u), scopeRefs(5u)),
1604 AllOf(/*both from sema and index*/ named("xybar"),
1605 mainFileRefs(0u), scopeRefs(3u))));
1606}
1607
1609signatures(llvm::StringRef Text, Position Point,
1610 std::vector<Symbol> IndexSymbols = {},
1611 MarkupKind DocumentationFormat = MarkupKind::PlainText) {
1612 std::unique_ptr<SymbolIndex> Index;
1613 if (!IndexSymbols.empty())
1614 Index = memIndex(IndexSymbols);
1615
1616 auto TU = TestTU::withCode(Text);
1617 MockFS FS;
1618 auto Inputs = TU.inputs(FS);
1619 Inputs.Index = Index.get();
1620 IgnoreDiagnostics Diags;
1621 auto CI = buildCompilerInvocation(Inputs, Diags);
1622 if (!CI) {
1623 ADD_FAILURE() << "Couldn't build CompilerInvocation";
1624 return {};
1625 }
1626 auto Preamble = buildPreamble(testPath(TU.Filename), *CI, Inputs,
1627 /*InMemory=*/true, /*Callback=*/nullptr);
1628 if (!Preamble) {
1629 ADD_FAILURE() << "Couldn't build Preamble";
1630 return {};
1631 }
1632 return signatureHelp(testPath(TU.Filename), Point, *Preamble, Inputs,
1633 DocumentationFormat);
1634}
1635
1637signatures(llvm::StringRef Text, std::vector<Symbol> IndexSymbols = {},
1638 MarkupKind DocumentationFormat = MarkupKind::PlainText) {
1639 Annotations Test(Text);
1640 return signatures(Test.code(), Test.point(), std::move(IndexSymbols),
1641 DocumentationFormat);
1642}
1643
1644struct ExpectedParameter {
1645 std::string Text;
1646 std::pair<unsigned, unsigned> Offsets;
1647};
1648llvm::raw_ostream &operator<<(llvm::raw_ostream &OS,
1649 const ExpectedParameter &P) {
1650 return OS << P.Text;
1651}
1652MATCHER_P(paramsAre, P, "") {
1653 if (P.size() != arg.parameters.size())
1654 return false;
1655 for (unsigned I = 0; I < P.size(); ++I) {
1656 if (P[I].Text != arg.parameters[I].labelString ||
1657 P[I].Offsets != arg.parameters[I].labelOffsets)
1658 return false;
1659 }
1660 return true;
1661}
1662MATCHER_P(sigDoc, doc, "") { return arg.documentation.value == doc; }
1663
1664/// \p AnnotatedLabel is a signature label with ranges marking parameters, e.g.
1665/// foo([[int p1]], [[double p2]]) -> void
1666Matcher<SignatureInformation> sig(llvm::StringRef AnnotatedLabel) {
1667 llvm::Annotations A(AnnotatedLabel);
1668 std::string Label = std::string(A.code());
1669 std::vector<ExpectedParameter> Parameters;
1670 for (auto Range : A.ranges()) {
1671 Parameters.emplace_back();
1672
1673 ExpectedParameter &P = Parameters.back();
1674 P.Text = Label.substr(Range.Begin, Range.End - Range.Begin);
1675 P.Offsets.first = lspLength(llvm::StringRef(Label).substr(0, Range.Begin));
1676 P.Offsets.second = lspLength(llvm::StringRef(Label).substr(1, Range.End));
1677 }
1678 return AllOf(sigHelpLabeled(Label), paramsAre(Parameters));
1679}
1680
1681TEST(SignatureHelpTest, Overloads) {
1682 auto Results = signatures(R"cpp(
1683 void foo(int x, int y);
1684 void foo(int x, float y);
1685 void foo(float x, int y);
1686 void foo(float x, float y);
1687 void bar(int x, int y = 0);
1688 int main() { foo(^); }
1689 )cpp");
1690 EXPECT_THAT(Results.signatures,
1691 UnorderedElementsAre(sig("foo([[float x]], [[float y]]) -> void"),
1692 sig("foo([[float x]], [[int y]]) -> void"),
1693 sig("foo([[int x]], [[float y]]) -> void"),
1694 sig("foo([[int x]], [[int y]]) -> void")));
1695 // We always prefer the first signature.
1696 EXPECT_EQ(0, Results.activeSignature);
1697 EXPECT_EQ(0, Results.activeParameter);
1698}
1699
1700TEST(SignatureHelpTest, DeclParamName) {
1701 // This is 2/3 regression tests to make sure signatures
1702 // 1) have consistent variable names between header and source file
1703 // 2) find variable names in other declarations
1704 // See CompletionTest.DeclParamName and IndexActionTest.DeclParamName for the
1705 // other tests.
1706 auto FuncFromSource = signatures(R"cpp(
1707 void sun(int);
1708 void sun(int night);
1709 void sun(int day);
1710 void sun(int);
1711 void position() {
1712 sun(^);
1713 }
1714 )cpp");
1715 EXPECT_THAT(FuncFromSource.signatures,
1716 UnorderedElementsAre(sig("sun([[int day]]) -> void")));
1717}
1718
1719TEST(SignatureHelpTest, FunctionPointers) {
1720 llvm::StringLiteral Tests[] = {
1721 // Variable of function pointer type
1722 R"cpp(
1723 void (*foo)(int x, int y);
1724 int main() { foo(^); }
1725 )cpp",
1726 // Wrapped in an AttributedType
1727 R"cpp(
1728 void (__stdcall *foo)(int x, int y);
1729 int main() { foo(^); }
1730 )cpp",
1731 // Another syntax for an AttributedType
1732 R"cpp(
1733 void (__attribute__(stdcall) *foo)(int x, int y);
1734 int main() { foo(^); },
1735 )cpp",
1736 // Wrapped in a typedef
1737 R"cpp(
1738 typedef void (*fn)(int x, int y);
1739 fn foo;
1740 int main() { foo(^); }
1741 )cpp",
1742 // Wrapped in both a typedef and an AttributedTyped
1743 R"cpp(
1744 typedef void (__stdcall *fn)(int x, int y);
1745 fn foo;
1746 int main() { foo(^); }
1747 )cpp",
1748 // Field of function pointer type
1749 R"cpp(
1750 struct S {
1751 void (*foo)(int x, int y);
1752 };
1753 S s;
1754 int main() { s.foo(^); }
1755 )cpp",
1756 // Field of function pointer typedef type
1757 R"cpp(
1758 typedef void (*fn)(int x, int y);
1759 struct S {
1760 fn foo;
1761 };
1762 S s;
1763 int main() { s.foo(^); }
1764 )cpp"};
1765 for (auto Test : Tests)
1766 EXPECT_THAT(signatures(Test).signatures,
1767 UnorderedElementsAre(sig("([[int x]], [[int y]]) -> void")));
1768}
1769
1770TEST(SignatureHelpTest, Constructors) {
1771 std::string Top = R"cpp(
1772 struct S {
1773 S(int);
1774 S(const S &) = delete;
1775 };
1776 )cpp";
1777
1778 auto CheckParenInit = [&](std::string Init) {
1779 EXPECT_THAT(signatures(Top + Init).signatures,
1780 UnorderedElementsAre(sig("S([[int]])")))
1781 << Init;
1782 };
1783 CheckParenInit("S s(^);");
1784 CheckParenInit("auto s = S(^);");
1785 CheckParenInit("auto s = new S(^);");
1786
1787 auto CheckBracedInit = [&](std::string Init) {
1788 EXPECT_THAT(signatures(Top + Init).signatures,
1789 UnorderedElementsAre(sig("S{[[int]]}")))
1790 << Init;
1791 };
1792 CheckBracedInit("S s{^};");
1793 CheckBracedInit("S s = {^};");
1794 CheckBracedInit("auto s = S{^};");
1795 // FIXME: doesn't work: no ExpectedType set in ParseCXXNewExpression.
1796 // CheckBracedInit("auto s = new S{^};");
1797 CheckBracedInit("int x(S); int i = x({^});");
1798}
1799
1800TEST(SignatureHelpTest, Aggregates) {
1801 std::string Top = R"cpp(
1802 struct S {
1803 int a, b, c, d;
1804 };
1805 )cpp";
1806 auto AggregateSig = sig("S{[[int a]], [[int b]], [[int c]], [[int d]]}");
1807 EXPECT_THAT(signatures(Top + "S s{^}").signatures,
1808 UnorderedElementsAre(AggregateSig, sig("S{}"),
1809 sig("S{[[const S &]]}"),
1810 sig("S{[[S &&]]}")));
1811 EXPECT_THAT(signatures(Top + "S s{1,^}").signatures,
1812 ElementsAre(AggregateSig));
1813 EXPECT_EQ(signatures(Top + "S s{1,^}").activeParameter, 1);
1814 EXPECT_THAT(signatures(Top + "S s{.c=3,^}").signatures,
1815 ElementsAre(AggregateSig));
1816 EXPECT_EQ(signatures(Top + "S s{.c=3,^}").activeParameter, 3);
1817}
1818
1819TEST(SignatureHelpTest, OverloadInitListRegression) {
1820 auto Results = signatures(R"cpp(
1821 struct A {int x;};
1822 struct B {B(A);};
1823 void f();
1824 int main() {
1825 B b({1});
1826 f(^);
1827 }
1828 )cpp");
1829 EXPECT_THAT(Results.signatures, UnorderedElementsAre(sig("f() -> void")));
1830}
1831
1832TEST(SignatureHelpTest, DefaultArgs) {
1833 auto Results = signatures(R"cpp(
1834 void bar(int x, int y = 0);
1835 void bar(float x = 0, int y = 42);
1836 int main() { bar(^
1837 )cpp");
1838 EXPECT_THAT(Results.signatures,
1839 UnorderedElementsAre(
1840 sig("bar([[int x]], [[int y = 0]]) -> void"),
1841 sig("bar([[float x = 0]], [[int y = 42]]) -> void")));
1842 EXPECT_EQ(0, Results.activeSignature);
1843 EXPECT_EQ(0, Results.activeParameter);
1844}
1845
1846TEST(SignatureHelpTest, ActiveArg) {
1847 auto Results = signatures(R"cpp(
1848 int baz(int a, int b, int c);
1849 int main() { baz(baz(1,2,3), ^); }
1850 )cpp");
1851 EXPECT_THAT(Results.signatures,
1852 ElementsAre(sig("baz([[int a]], [[int b]], [[int c]]) -> int")));
1853 EXPECT_EQ(0, Results.activeSignature);
1854 EXPECT_EQ(1, Results.activeParameter);
1855}
1856
1857TEST(SignatureHelpTest, OpeningParen) {
1858 llvm::StringLiteral Tests[] = {
1859 // Recursive function call.
1860 R"cpp(
1861 int foo(int a, int b, int c);
1862 int main() {
1863 foo(foo $p^( foo(10, 10, 10), ^ )));
1864 })cpp",
1865 // Functional type cast.
1866 R"cpp(
1867 struct Foo {
1868 Foo(int a, int b, int c);
1869 };
1870 int main() {
1871 Foo $p^( 10, ^ );
1872 })cpp",
1873 // New expression.
1874 R"cpp(
1875 struct Foo {
1876 Foo(int a, int b, int c);
1877 };
1878 int main() {
1879 new Foo $p^( 10, ^ );
1880 })cpp",
1881 // Macro expansion.
1882 R"cpp(
1883 int foo(int a, int b, int c);
1884 #define FOO foo(
1885
1886 int main() {
1887 // Macro expansions.
1888 $p^FOO 10, ^ );
1889 })cpp",
1890 // Macro arguments.
1891 R"cpp(
1892 int foo(int a, int b, int c);
1893 int main() {
1894 #define ID(X) X
1895 // FIXME: figure out why ID(foo (foo(10), )) doesn't work when preserving
1896 // the recovery expression.
1897 ID(foo $p^( 10, ^ ))
1898 })cpp",
1899 // Dependent args.
1900 R"cpp(
1901 int foo(int a, int b);
1902 template <typename T> void bar(T t) {
1903 foo$p^(t, ^t);
1904 })cpp",
1905 // Dependent args on templated func.
1906 R"cpp(
1907 template <typename T>
1908 int foo(T, T);
1909 template <typename T> void bar(T t) {
1910 foo$p^(t, ^t);
1911 })cpp",
1912 // Dependent args on member.
1913 R"cpp(
1914 struct Foo { int foo(int, int); };
1915 template <typename T> void bar(T t) {
1916 Foo f;
1917 f.foo$p^(t, ^t);
1918 })cpp",
1919 // Dependent args on templated member.
1920 R"cpp(
1921 struct Foo { template <typename T> int foo(T, T); };
1922 template <typename T> void bar(T t) {
1923 Foo f;
1924 f.foo$p^(t, ^t);
1925 })cpp",
1926 };
1927
1928 for (auto Test : Tests) {
1929 Annotations Code(Test);
1930 EXPECT_EQ(signatures(Code.code(), Code.point()).argListStart,
1931 Code.point("p"))
1932 << "Test source:" << Test;
1933 }
1934}
1935
1936TEST(SignatureHelpTest, StalePreamble) {
1937 TestTU TU;
1938 TU.Code = "";
1939 IgnoreDiagnostics Diags;
1940 MockFS FS;
1941 auto Inputs = TU.inputs(FS);
1942 auto CI = buildCompilerInvocation(Inputs, Diags);
1943 ASSERT_TRUE(CI);
1944 auto EmptyPreamble = buildPreamble(testPath(TU.Filename), *CI, Inputs,
1945 /*InMemory=*/true, /*Callback=*/nullptr);
1946 ASSERT_TRUE(EmptyPreamble);
1947
1948 TU.AdditionalFiles["a.h"] = "int foo(int x);";
1949 const Annotations Test(R"cpp(
1950 #include "a.h"
1951 void bar() { foo(^2); })cpp");
1952 TU.Code = Test.code().str();
1953 auto Results =
1954 signatureHelp(testPath(TU.Filename), Test.point(), *EmptyPreamble,
1955 TU.inputs(FS), MarkupKind::PlainText);
1956 EXPECT_THAT(Results.signatures, ElementsAre(sig("foo([[int x]]) -> int")));
1957 EXPECT_EQ(0, Results.activeSignature);
1958 EXPECT_EQ(0, Results.activeParameter);
1959}
1960
1961TEST(SignatureHelpTest, EOFInSkippedFunctionBody) {
1962 Annotations Test(R"cpp(
1963#ifdef IS_HEADER
1964void frameSizeBlocksWarning() {
1965 auto fn = []() {
1966 };
1967 fn();
1968}
1969#else
1970#define IS_HEADER
1971#include __FILE__
1972#^endif
1973)cpp");
1974 auto Results = signatures(Test.code(), Test.point());
1975 EXPECT_THAT(Results.signatures, IsEmpty());
1976}
1977
1978class IndexRequestCollector : public SymbolIndex {
1979public:
1980 IndexRequestCollector(std::vector<Symbol> Syms = {}) : Symbols(Syms) {}
1981
1982 bool
1983 fuzzyFind(const FuzzyFindRequest &Req,
1984 llvm::function_ref<void(const Symbol &)> Callback) const override {
1985 std::unique_lock<std::mutex> Lock(Mut);
1986 Requests.push_back(Req);
1987 ReceivedRequestCV.notify_one();
1988 for (const auto &Sym : Symbols)
1989 Callback(Sym);
1990 return true;
1991 }
1992
1993 void lookup(const LookupRequest &,
1994 llvm::function_ref<void(const Symbol &)>) const override {}
1995
1996 bool refs(const RefsRequest &,
1997 llvm::function_ref<void(const Ref &)>) const override {
1998 return false;
1999 }
2000
2001 bool containedRefs(
2002 const ContainedRefsRequest &,
2003 llvm::function_ref<void(const ContainedRefsResult &)>) const override {
2004 return false;
2005 }
2006
2007 void relations(const RelationsRequest &,
2008 llvm::function_ref<void(const SymbolID &, const Symbol &)>)
2009 const override {}
2010
2011 void
2012 reverseRelations(const RelationsRequest &,
2013 llvm::function_ref<void(const SymbolID &, const Symbol &)>)
2014 const override {}
2015
2016 llvm::unique_function<IndexContents(llvm::StringRef) const>
2017 indexedFiles() const override {
2018 return [](llvm::StringRef) { return IndexContents::None; };
2019 }
2020
2021 // This is incorrect, but IndexRequestCollector is not an actual index and it
2022 // isn't used in production code.
2023 size_t estimateMemoryUsage() const override { return 0; }
2024
2025 const std::vector<FuzzyFindRequest> consumeRequests(size_t Num) const {
2026 std::unique_lock<std::mutex> Lock(Mut);
2027 EXPECT_TRUE(wait(Lock, ReceivedRequestCV, timeoutSeconds(30),
2028 [this, Num] { return Requests.size() == Num; }));
2029 auto Reqs = std::move(Requests);
2030 Requests = {};
2031 return Reqs;
2032 }
2033
2034private:
2035 std::vector<Symbol> Symbols;
2036 // We need a mutex to handle async fuzzy find requests.
2037 mutable std::condition_variable ReceivedRequestCV;
2038 mutable std::mutex Mut;
2039 mutable std::vector<FuzzyFindRequest> Requests;
2040};
2041
2042// Clients have to consume exactly Num requests.
2043std::vector<FuzzyFindRequest> captureIndexRequests(llvm::StringRef Code,
2044 size_t Num = 1) {
2045 clangd::CodeCompleteOptions Opts;
2046 IndexRequestCollector Requests;
2047 Opts.Index = &Requests;
2048 completions(Code, {}, Opts);
2049 const auto Reqs = Requests.consumeRequests(Num);
2050 EXPECT_EQ(Reqs.size(), Num);
2051 return Reqs;
2052}
2053
2054TEST(CompletionTest, UnqualifiedIdQuery) {
2055 auto Requests = captureIndexRequests(R"cpp(
2056 namespace std {}
2057 using namespace std;
2058 namespace ns {
2059 void f() {
2060 vec^
2061 }
2062 }
2063 )cpp");
2064
2065 EXPECT_THAT(Requests,
2066 ElementsAre(Field(&FuzzyFindRequest::Scopes,
2067 UnorderedElementsAre("", "ns::", "std::"))));
2068}
2069
2070TEST(CompletionTest, EnclosingScopeComesFirst) {
2071 auto Requests = captureIndexRequests(R"cpp(
2072 namespace std {}
2073 using namespace std;
2074 namespace nx {
2075 namespace ns {
2076 namespace {
2077 void f() {
2078 vec^
2079 }
2080 }
2081 }
2082 }
2083 )cpp");
2084
2085 EXPECT_THAT(Requests,
2086 ElementsAre(Field(
2088 UnorderedElementsAre("", "std::", "nx::ns::", "nx::"))));
2089 EXPECT_EQ(Requests[0].Scopes[0], "nx::ns::");
2090}
2091
2092TEST(CompletionTest, ResolvedQualifiedIdQuery) {
2093 auto Requests = captureIndexRequests(R"cpp(
2094 namespace ns1 {}
2095 namespace ns2 {} // ignore
2096 namespace ns3 { namespace nns3 {} }
2097 namespace foo {
2098 using namespace ns1;
2099 using namespace ns3::nns3;
2100 }
2101 namespace ns {
2102 void f() {
2103 foo::^
2104 }
2105 }
2106 )cpp");
2107
2108 EXPECT_THAT(Requests,
2109 ElementsAre(Field(
2111 UnorderedElementsAre("foo::", "ns1::", "ns3::nns3::"))));
2112}
2113
2114TEST(CompletionTest, UnresolvedQualifierIdQuery) {
2115 auto Requests = captureIndexRequests(R"cpp(
2116 namespace a {}
2117 using namespace a;
2118 namespace ns {
2119 void f() {
2120 bar::^
2121 }
2122 } // namespace ns
2123 )cpp");
2124
2125 EXPECT_THAT(Requests,
2126 ElementsAre(Field(
2128 UnorderedElementsAre("a::bar::", "ns::bar::", "bar::"))));
2129}
2130
2131TEST(CompletionTest, UnresolvedNestedQualifierIdQuery) {
2132 auto Requests = captureIndexRequests(R"cpp(
2133 namespace a {}
2134 using namespace a;
2135 namespace ns {
2136 void f() {
2137 ::a::bar::^
2138 }
2139 } // namespace ns
2140 )cpp");
2141
2142 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes,
2143 UnorderedElementsAre("a::bar::"))));
2144}
2145
2146TEST(CompletionTest, EmptyQualifiedQuery) {
2147 auto Requests = captureIndexRequests(R"cpp(
2148 namespace ns {
2149 void f() {
2150 ^
2151 }
2152 } // namespace ns
2153 )cpp");
2154
2155 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes,
2156 UnorderedElementsAre("", "ns::"))));
2157}
2158
2159TEST(CompletionTest, GlobalQualifiedQuery) {
2160 auto Requests = captureIndexRequests(R"cpp(
2161 namespace ns {
2162 void f() {
2163 ::^
2164 }
2165 } // namespace ns
2166 )cpp");
2167
2168 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes,
2169 UnorderedElementsAre(""))));
2170}
2171
2172TEST(CompletionTest, NoDuplicatedQueryScopes) {
2173 auto Requests = captureIndexRequests(R"cpp(
2174 namespace {}
2175
2176 namespace na {
2177 namespace {}
2178 namespace nb {
2179 ^
2180 } // namespace nb
2181 } // namespace na
2182 )cpp");
2183
2184 EXPECT_THAT(Requests,
2185 ElementsAre(Field(&FuzzyFindRequest::Scopes,
2186 UnorderedElementsAre("na::", "na::nb::", ""))));
2187}
2188
2189TEST(CompletionTest, NoIndexCompletionsInsideClasses) {
2190 auto Completions = completions(
2191 R"cpp(
2192 struct Foo {
2193 int SomeNameOfField;
2194 typedef int SomeNameOfTypedefField;
2195 };
2196
2197 Foo::^)cpp",
2198 {func("::SomeNameInTheIndex"), func("::Foo::SomeNameInTheIndex")});
2199
2200 EXPECT_THAT(Completions.Completions,
2201 AllOf(Contains(labeled("SomeNameOfField")),
2202 Contains(labeled("SomeNameOfTypedefField")),
2203 Not(Contains(labeled("SomeNameInTheIndex")))));
2204}
2205
2206TEST(CompletionTest, NoIndexCompletionsInsideDependentCode) {
2207 {
2208 auto Completions = completions(
2209 R"cpp(
2210 template <class T>
2211 void foo() {
2212 T::^
2213 }
2214 )cpp",
2215 {func("::SomeNameInTheIndex")});
2216
2217 EXPECT_THAT(Completions.Completions,
2218 Not(Contains(labeled("SomeNameInTheIndex"))));
2219 }
2220
2221 {
2222 auto Completions = completions(
2223 R"cpp(
2224 template <class T>
2225 void foo() {
2226 T::template Y<int>::^
2227 }
2228 )cpp",
2229 {func("::SomeNameInTheIndex")});
2230
2231 EXPECT_THAT(Completions.Completions,
2232 Not(Contains(labeled("SomeNameInTheIndex"))));
2233 }
2234
2235 {
2236 auto Completions = completions(
2237 R"cpp(
2238 template <class T>
2239 void foo() {
2240 T::foo::^
2241 }
2242 )cpp",
2243 {func("::SomeNameInTheIndex")});
2244
2245 EXPECT_THAT(Completions.Completions,
2246 Not(Contains(labeled("SomeNameInTheIndex"))));
2247 }
2248}
2249
2250TEST(CompletionTest, OverloadBundling) {
2251 clangd::CodeCompleteOptions Opts;
2252 Opts.BundleOverloads = true;
2253
2254 std::string Context = R"cpp(
2255 struct X {
2256 // Overload with int
2257 int a(int) __attribute__((deprecated("", "")));
2258 // Overload with bool
2259 int a(bool);
2260 int b(float);
2261
2262 X(int);
2263 X(float);
2264 };
2265 int GFuncC(int);
2266 int GFuncD(int);
2267 )cpp";
2268
2269 // Member completions are bundled.
2270 EXPECT_THAT(completions(Context + "int y = X().^", {}, Opts).Completions,
2271 UnorderedElementsAre(labeled("a(…)"), labeled("b(float)")));
2272
2273 // Constructor completions are bundled.
2274 EXPECT_THAT(completions(Context + "X z = X^", {}, Opts).Completions,
2275 UnorderedElementsAre(labeled("X"), labeled("X(…)")));
2276
2277 // Non-member completions are bundled, including index+sema.
2278 Symbol NoArgsGFunc = func("GFuncC");
2279 EXPECT_THAT(
2280 completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).Completions,
2281 UnorderedElementsAre(labeled("GFuncC(…)"), labeled("GFuncD(int)")));
2282
2283 // Differences in header-to-insert suppress bundling.
2284 std::string DeclFile = URI::create(testPath("foo")).toString();
2285 NoArgsGFunc.CanonicalDeclaration.FileURI = DeclFile.c_str();
2286 NoArgsGFunc.IncludeHeaders.emplace_back("<foo>", 1, Symbol::Include);
2287 EXPECT_THAT(
2288 completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).Completions,
2289 UnorderedElementsAre(AllOf(named("GFuncC"), insertInclude("<foo>")),
2290 labeled("GFuncC(int)"), labeled("GFuncD(int)")));
2291
2292 // Examine a bundled completion in detail.
2293 auto A =
2294 completions(Context + "int y = X().a^", {}, Opts).Completions.front();
2295 EXPECT_EQ(A.Name, "a");
2296 EXPECT_EQ(A.Signature, "(…)");
2297 EXPECT_EQ(A.BundleSize, 2u);
2298 EXPECT_EQ(A.Kind, CompletionItemKind::Method);
2299 EXPECT_EQ(A.ReturnType, "int"); // All overloads return int.
2300 // For now we just return one of the doc strings arbitrarily.
2301 ASSERT_TRUE(A.Documentation);
2302 ASSERT_FALSE(A.Deprecated); // Not all overloads deprecated.
2303 EXPECT_THAT(
2304 A.Documentation->asPlainText(),
2305 AnyOf(HasSubstr("Overload with int"), HasSubstr("Overload with bool")));
2306 EXPECT_EQ(A.SnippetSuffix, "($0)");
2307}
2308
2309TEST(CompletionTest, OverloadBundlingSameFileDifferentURI) {
2310 clangd::CodeCompleteOptions Opts;
2311 Opts.BundleOverloads = true;
2312
2313 Symbol SymX = sym("ns::X", index::SymbolKind::Function, "@F@\\0#");
2314 Symbol SymY = sym("ns::X", index::SymbolKind::Function, "@F@\\0#I#");
2315 std::string BarHeader = testPath("bar.h");
2316 auto BarURI = URI::create(BarHeader).toString();
2317 SymX.CanonicalDeclaration.FileURI = BarURI.c_str();
2318 SymY.CanonicalDeclaration.FileURI = BarURI.c_str();
2319 // The include header is different, but really it's the same file.
2320 SymX.IncludeHeaders.emplace_back("\"bar.h\"", 1, Symbol::Include);
2321 SymY.IncludeHeaders.emplace_back(BarURI.c_str(), 1, Symbol::Include);
2322
2323 auto Results = completions("void f() { ::ns::^ }", {SymX, SymY}, Opts);
2324 // Expect both results are bundled, despite the different-but-same
2325 // IncludeHeader.
2326 ASSERT_EQ(1u, Results.Completions.size());
2327 const auto &R = Results.Completions.front();
2328 EXPECT_EQ("X", R.Name);
2329 EXPECT_EQ(2u, R.BundleSize);
2330}
2331
2332TEST(CompletionTest, DocumentationFromChangedFileCrash) {
2333 MockFS FS;
2334 auto FooH = testPath("foo.h");
2335 auto FooCpp = testPath("foo.cpp");
2336 FS.Files[FooH] = R"cpp(
2337 // this is my documentation comment.
2338 int func();
2339 )cpp";
2340 FS.Files[FooCpp] = "";
2341
2343 ClangdServer Server(CDB, FS, ClangdServer::optsForTest());
2344
2345 Annotations Source(R"cpp(
2346 #include "foo.h"
2347 int func() {
2348 // This makes sure we have func from header in the AST.
2349 }
2350 int a = fun^
2351 )cpp");
2352 Server.addDocument(FooCpp, Source.code(), "null", WantDiagnostics::Yes);
2353 // We need to wait for preamble to build.
2354 ASSERT_TRUE(Server.blockUntilIdleForTest());
2355
2356 // Change the header file. Completion will reuse the old preamble!
2357 FS.Files[FooH] = R"cpp(
2358 int func();
2359 )cpp";
2360
2361 clangd::CodeCompleteOptions Opts;
2362 CodeCompleteResult Completions =
2363 cantFail(runCodeComplete(Server, FooCpp, Source.point(), Opts));
2364 // We shouldn't crash. Unfortunately, current workaround is to not produce
2365 // comments for symbols from headers.
2366 EXPECT_THAT(Completions.Completions,
2367 Contains(AllOf(Not(isDocumented()), named("func"))));
2368}
2369
2370TEST(CompletionTest, NonDocComments) {
2371 const char *Text = R"cpp(
2372 // We ignore namespace comments, for rationale see CodeCompletionStrings.h.
2373 namespace comments_ns {
2374 }
2375
2376 // ------------------
2377 int comments_foo();
2378
2379 // A comment and a decl are separated by newlines.
2380 // Therefore, the comment shouldn't show up as doc comment.
2381
2382 int comments_bar();
2383
2384 // this comment should be in the results.
2385 int comments_baz();
2386
2387
2388 template <class T>
2389 struct Struct {
2390 int comments_qux();
2391 int comments_quux();
2392 };
2393
2394
2395 // This comment should not be there.
2396
2397 template <class T>
2398 int Struct<T>::comments_qux() {
2399 }
2400
2401 // This comment **should** be in results.
2402 template <class T>
2403 int Struct<T>::comments_quux() {
2404 int a = comments^;
2405 }
2406 )cpp";
2407
2408 // We should not get any of those comments in completion.
2409 EXPECT_THAT(
2410 completions(Text).Completions,
2411 UnorderedElementsAre(AllOf(Not(isDocumented()), named("comments_foo")),
2412 AllOf(isDocumented(), named("comments_baz")),
2413 AllOf(isDocumented(), named("comments_quux")),
2414 AllOf(Not(isDocumented()), named("comments_ns")),
2415 // FIXME(ibiryukov): the following items should have
2416 // empty documentation, since they are separated from
2417 // a comment with an empty line. Unfortunately, I
2418 // couldn't make Sema tests pass if we ignore those.
2419 AllOf(isDocumented(), named("comments_bar")),
2420 AllOf(isDocumented(), named("comments_qux"))));
2421}
2422
2423TEST(CompletionTest, CompleteOnInvalidLine) {
2424 auto FooCpp = testPath("foo.cpp");
2425
2427 MockFS FS;
2428 FS.Files[FooCpp] = "// empty file";
2429
2430 ClangdServer Server(CDB, FS, ClangdServer::optsForTest());
2431 // Run completion outside the file range.
2432 Position Pos;
2433 Pos.line = 100;
2434 Pos.character = 0;
2435 EXPECT_THAT_EXPECTED(
2436 runCodeComplete(Server, FooCpp, Pos, clangd::CodeCompleteOptions()),
2437 Failed());
2438}
2439
2440TEST(CompletionTest, QualifiedNames) {
2441 auto Results = completions(
2442 R"cpp(
2443 namespace ns { int local; void both(); }
2444 void f() { ::ns::^ }
2445 )cpp",
2446 {func("ns::both"), cls("ns::Index")});
2447 // We get results from both index and sema, with no duplicates.
2448 EXPECT_THAT(
2449 Results.Completions,
2450 UnorderedElementsAre(scope("ns::"), scope("ns::"), scope("ns::")));
2451}
2452
2453TEST(CompletionTest, Render) {
2454 CodeCompletion C;
2455 C.Name = "x";
2456 C.FilterText = "x";
2457 C.Signature = "(bool) const";
2458 C.SnippetSuffix = "(${0:bool})";
2459 C.ReturnType = "int";
2460 C.RequiredQualifier = "Foo::";
2461 C.Scope = "ns::Foo::";
2462 C.Documentation.emplace();
2463 C.Documentation->addParagraph().appendText("This is ").appendCode("x()");
2464 C.Includes.emplace_back();
2465 auto &Include = C.Includes.back();
2466 Include.Header = "\"foo.h\"";
2468 C.Score.Total = 1.0;
2469 C.Score.ExcludingName = .5;
2471
2473 Opts.IncludeIndicator.Insert = "^";
2474 Opts.IncludeIndicator.NoInsert = "";
2475 Opts.EnableSnippets = false;
2476
2477 auto R = C.render(Opts);
2478 EXPECT_EQ(R.label, "Foo::x");
2479 EXPECT_EQ(R.labelDetails->detail, "(bool) const");
2480 EXPECT_EQ(R.insertText, "Foo::x");
2481 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::PlainText);
2482 EXPECT_EQ(R.filterText, "x");
2483 EXPECT_EQ(R.detail, "int");
2484 EXPECT_EQ(R.documentation->value, "From \"foo.h\"\n\nThis is x()");
2485 EXPECT_THAT(R.additionalTextEdits, IsEmpty());
2486 EXPECT_EQ(R.sortText, sortText(1.0, "x"));
2487 EXPECT_FALSE(R.deprecated);
2488 EXPECT_EQ(R.score, .5f);
2489
2490 C.FilterText = "xtra";
2491 R = C.render(Opts);
2492 EXPECT_EQ(R.filterText, "xtra");
2493 EXPECT_EQ(R.sortText, sortText(1.0, "xtra"));
2494
2495 Opts.EnableSnippets = true;
2496 R = C.render(Opts);
2497 EXPECT_EQ(R.insertText, "Foo::x(${0:bool})");
2498 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::Snippet);
2499
2500 C.SnippetSuffix = "";
2501 R = C.render(Opts);
2502 EXPECT_EQ(R.insertText, "Foo::x");
2503 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::PlainText);
2504
2505 Include.Insertion.emplace();
2506 R = C.render(Opts);
2507 EXPECT_EQ(R.label, "^Foo::x");
2508 EXPECT_EQ(R.labelDetails->detail, "(bool) const");
2509 EXPECT_THAT(R.additionalTextEdits, Not(IsEmpty()));
2510
2511 Opts.ShowOrigins = true;
2512 R = C.render(Opts);
2513 EXPECT_EQ(R.label, "^[AS]Foo::x");
2514 EXPECT_EQ(R.labelDetails->detail, "(bool) const");
2515
2516 C.BundleSize = 2;
2517 R = C.render(Opts);
2518 EXPECT_EQ(R.detail, "[2 overloads]");
2519 EXPECT_EQ(R.documentation->value, "From \"foo.h\"\n\nThis is x()");
2520
2521 C.Deprecated = true;
2522 R = C.render(Opts);
2523 EXPECT_TRUE(R.deprecated);
2524
2525 Opts.DocumentationFormat = MarkupKind::Markdown;
2526 R = C.render(Opts);
2527 EXPECT_EQ(R.documentation->value, "From `\"foo.h\"`\n\nThis is `x()`");
2528}
2529
2530TEST(CompletionTest, IgnoreRecoveryResults) {
2531 auto Results = completions(
2532 R"cpp(
2533 namespace ns { int NotRecovered() { return 0; } }
2534 void f() {
2535 // Sema enters recovery mode first and then normal mode.
2536 if (auto x = ns::NotRecover^)
2537 }
2538 )cpp");
2539 EXPECT_THAT(Results.Completions, UnorderedElementsAre(named("NotRecovered")));
2540}
2541
2542TEST(CompletionTest, ScopeOfClassFieldInConstructorInitializer) {
2543 auto Results = completions(
2544 R"cpp(
2545 namespace ns {
2546 class X { public: X(); int x_; };
2547 X::X() : x_^(0) {}
2548 }
2549 )cpp");
2550 EXPECT_THAT(Results.Completions,
2551 UnorderedElementsAre(AllOf(scope("ns::X::"), named("x_"))));
2552}
2553
2554// Like other class members, constructor init lists have to parse what's below,
2555// after the completion point.
2556// But recovering from an incomplete constructor init list is particularly
2557// tricky because the bulk of the list is not surrounded by brackets.
2558TEST(CompletionTest, ConstructorInitListIncomplete) {
2559 auto Results = completions(
2560 R"cpp(
2561 namespace ns {
2562 struct X {
2563 X() : x^
2564 int xyz_;
2565 };
2566 }
2567 )cpp");
2568 EXPECT_THAT(Results.Completions, ElementsAre(named("xyz_")));
2569
2570 Results = completions(
2571 R"cpp(
2572 int foo();
2573
2574 namespace ns {
2575 struct X {
2576 X() : xyz_(fo^
2577 int xyz_;
2578 };
2579 }
2580 )cpp");
2581 EXPECT_THAT(Results.Completions, ElementsAre(named("foo")));
2582}
2583
2584TEST(CompletionTest, CodeCompletionContext) {
2585 auto Results = completions(
2586 R"cpp(
2587 namespace ns {
2588 class X { public: X(); int x_; };
2589 void f() {
2590 X x;
2591 x.^;
2592 }
2593 }
2594 )cpp");
2595
2596 EXPECT_THAT(Results.Context, CodeCompletionContext::CCC_DotMemberAccess);
2597}
2598
2599TEST(CompletionTest, OffsetOfDesignator) {
2600 auto Results = completions(R"cpp(
2601 struct S { int field; int other; void fieldFn(); };
2602 int x = __builtin_offsetof(S, fiel^d);
2603 )cpp");
2604 EXPECT_THAT(
2605 Results.Completions,
2606 ElementsAre(AllOf(named("field"), kind(CompletionItemKind::Field))));
2607 EXPECT_THAT(Results.Context, CodeCompletionContext::CCC_DotMemberAccess);
2608
2609 Results = completions(R"cpp(
2610 struct Inner { int field; void fieldFn(); };
2611 struct Outer { Inner inner; };
2612 int x = __builtin_offsetof(Outer, inner.fiel^d);
2613 )cpp");
2614 EXPECT_THAT(
2615 Results.Completions,
2616 ElementsAre(AllOf(named("field"), kind(CompletionItemKind::Field))));
2617
2618 Results = completions(R"cpp(
2619 struct Inner { int field; void fieldFn(); };
2620 struct Outer { Inner inner[2]; };
2621 int i;
2622 int x = __builtin_offsetof(Outer, inner[i].fiel^d);
2623 )cpp");
2624 EXPECT_THAT(
2625 Results.Completions,
2626 ElementsAre(AllOf(named("field"), kind(CompletionItemKind::Field))));
2627
2628 Results = completions(R"cpp(
2629 struct Base { int field; void fieldFn(); };
2630 struct Derived : Base {};
2631 int x = __builtin_offsetof(Derived, fiel^d);
2632 )cpp");
2633 EXPECT_THAT(
2634 Results.Completions,
2635 ElementsAre(AllOf(named("field"), kind(CompletionItemKind::Field))));
2636}
2637
2638TEST(CompletionTest, FixItForArrowToDot) {
2639 MockFS FS;
2641
2643 Opts.IncludeFixIts = true;
2644 const char *Code =
2645 R"cpp(
2646 class Auxilary {
2647 public:
2648 void AuxFunction();
2649 };
2650 class ClassWithPtr {
2651 public:
2652 void MemberFunction();
2653 Auxilary* operator->() const;
2654 Auxilary* Aux;
2655 };
2656 void f() {
2657 ClassWithPtr x;
2658 x[[->]]^;
2659 }
2660 )cpp";
2661 auto Results = completions(Code, {}, Opts);
2662 EXPECT_EQ(Results.Completions.size(), 3u);
2663
2664 TextEdit ReplacementEdit;
2665 ReplacementEdit.range = Annotations(Code).range();
2666 ReplacementEdit.newText = ".";
2667 for (const auto &C : Results.Completions) {
2668 EXPECT_TRUE(C.FixIts.size() == 1u || C.Name == "AuxFunction");
2669 if (!C.FixIts.empty()) {
2670 EXPECT_THAT(C.FixIts, ElementsAre(ReplacementEdit));
2671 }
2672 }
2673}
2674
2675TEST(CompletionTest, FixItForDotToArrow) {
2677 Opts.IncludeFixIts = true;
2678 const char *Code =
2679 R"cpp(
2680 class Auxilary {
2681 public:
2682 void AuxFunction();
2683 };
2684 class ClassWithPtr {
2685 public:
2686 void MemberFunction();
2687 Auxilary* operator->() const;
2688 Auxilary* Aux;
2689 };
2690 void f() {
2691 ClassWithPtr x;
2692 x[[.]]^;
2693 }
2694 )cpp";
2695 auto Results = completions(Code, {}, Opts);
2696 EXPECT_EQ(Results.Completions.size(), 3u);
2697
2698 TextEdit ReplacementEdit;
2699 ReplacementEdit.range = Annotations(Code).range();
2700 ReplacementEdit.newText = "->";
2701 for (const auto &C : Results.Completions) {
2702 EXPECT_TRUE(C.FixIts.empty() || C.Name == "AuxFunction");
2703 if (!C.FixIts.empty()) {
2704 EXPECT_THAT(C.FixIts, ElementsAre(ReplacementEdit));
2705 }
2706 }
2707}
2708
2709TEST(CompletionTest, RenderWithFixItMerged) {
2710 TextEdit FixIt;
2711 FixIt.range.end.character = 5;
2712 FixIt.newText = "->";
2713
2714 CodeCompletion C;
2715 C.Name = "x";
2716 C.RequiredQualifier = "Foo::";
2717 C.FixIts = {FixIt};
2718 C.CompletionInsertRange.start.character = 5;
2719
2721 Opts.IncludeFixIts = true;
2722
2723 auto R = C.render(Opts);
2724 EXPECT_TRUE(R.textEdit);
2725 EXPECT_EQ(std::get<TextEdit>(*R.textEdit).newText, "->Foo::x");
2726 EXPECT_TRUE(R.additionalTextEdits.empty());
2727}
2728
2729TEST(CompletionTest, RenderWithFixItNonMerged) {
2730 TextEdit FixIt;
2731 FixIt.range.end.character = 4;
2732 FixIt.newText = "->";
2733
2734 CodeCompletion C;
2735 C.Name = "x";
2736 C.RequiredQualifier = "Foo::";
2737 C.FixIts = {FixIt};
2738 C.CompletionInsertRange.start.character = 5;
2739
2741 Opts.IncludeFixIts = true;
2742
2743 auto R = C.render(Opts);
2744 EXPECT_TRUE(R.textEdit);
2745 EXPECT_EQ(std::get<TextEdit>(*R.textEdit).newText, "Foo::x");
2746 EXPECT_THAT(R.additionalTextEdits, UnorderedElementsAre(FixIt));
2747}
2748
2749TEST(CompletionTest, CompletionInsertRange) {
2750 MockFS FS;
2752 TestTU TU;
2753 TU.AdditionalFiles["foo/abc/foo.h"] = "";
2754
2755 constexpr const char *TestCodes[] = {
2756 R"cpp(
2757 class Auxilary {
2758 public:
2759 void AuxFunction();
2760 };
2761 void f() {
2762 Auxilary x;
2763 x.[[Aux]]^;
2764 }
2765 )cpp",
2766 R"cpp(
2767 class Auxilary {
2768 public:
2769 void AuxFunction();
2770 };
2771 void f() {
2772 Auxilary x;
2773 x.[[]]^;
2774 }
2775 )cpp",
2776 R"cpp(
2777 #include "foo/[[a^/]]foo.h"
2778 )cpp",
2779 R"cpp(
2780 #include "foo/abc/[[fo^o.h"]]
2781 )cpp",
2782 };
2783 for (const auto &Text : TestCodes) {
2784 Annotations TestCode(Text);
2785 TU.Code = TestCode.code().str();
2786 auto Results = completions(TU, TestCode.point());
2787 if (Results.Completions.size() != 1) {
2788 ADD_FAILURE() << "Results.Completions.size() != 1" << Text;
2789 continue;
2790 }
2791 EXPECT_THAT(Results.Completions.front().CompletionInsertRange,
2792 TestCode.range());
2793 }
2794}
2795
2796TEST(SignatureHelpTest, OverloadsOrdering) {
2797 const auto Results = signatures(R"cpp(
2798 void foo(int x);
2799 void foo(int x, float y);
2800 void foo(float x, int y);
2801 void foo(float x, float y);
2802 void foo(int x, int y = 0);
2803 int main() { foo(^); }
2804 )cpp");
2805 EXPECT_THAT(Results.signatures,
2806 ElementsAre(sig("foo([[int x]]) -> void"),
2807 sig("foo([[int x]], [[int y = 0]]) -> void"),
2808 sig("foo([[float x]], [[int y]]) -> void"),
2809 sig("foo([[int x]], [[float y]]) -> void"),
2810 sig("foo([[float x]], [[float y]]) -> void")));
2811 // We always prefer the first signature.
2812 EXPECT_EQ(0, Results.activeSignature);
2813 EXPECT_EQ(0, Results.activeParameter);
2814}
2815
2816TEST(SignatureHelpTest, InstantiatedSignatures) {
2817 StringRef Sig0 = R"cpp(
2818 template <class T>
2819 void foo(T, T, T);
2820
2821 int main() {
2822 foo<int>(^);
2823 }
2824 )cpp";
2825
2826 EXPECT_THAT(signatures(Sig0).signatures,
2827 ElementsAre(sig("foo([[T]], [[T]], [[T]]) -> void")));
2828
2829 StringRef Sig1 = R"cpp(
2830 template <class T>
2831 void foo(T, T, T);
2832
2833 int main() {
2834 foo(10, ^);
2835 })cpp";
2836
2837 EXPECT_THAT(signatures(Sig1).signatures,
2838 ElementsAre(sig("foo([[T]], [[T]], [[T]]) -> void")));
2839
2840 StringRef Sig2 = R"cpp(
2841 template <class ...T>
2842 void foo(T...);
2843
2844 int main() {
2845 foo<int>(^);
2846 }
2847 )cpp";
2848
2849 EXPECT_THAT(signatures(Sig2).signatures,
2850 ElementsAre(sig("foo([[T...]]) -> void")));
2851
2852 // It is debatable whether we should substitute the outer template parameter
2853 // ('T') in that case. Currently we don't substitute it in signature help, but
2854 // do substitute in code complete.
2855 // FIXME: make code complete and signature help consistent, figure out which
2856 // way is better.
2857 StringRef Sig3 = R"cpp(
2858 template <class T>
2859 struct X {
2860 template <class U>
2861 void foo(T, U);
2862 };
2863
2864 int main() {
2865 X<int>().foo<double>(^)
2866 }
2867 )cpp";
2868
2869 EXPECT_THAT(signatures(Sig3).signatures,
2870 ElementsAre(sig("foo([[T]], [[U]]) -> void")));
2871}
2872
2873TEST(SignatureHelpTest, IndexDocumentation) {
2874 Symbol Foo0 = sym("foo", index::SymbolKind::Function, "@F@\\0#");
2875 Foo0.Documentation = "doc from the index";
2876 Symbol Foo1 = sym("foo", index::SymbolKind::Function, "@F@\\0#I#");
2877 Foo1.Documentation = "doc from the index";
2878 Symbol Foo2 = sym("foo", index::SymbolKind::Function, "@F@\\0#I#I#");
2879
2880 StringRef Sig0 = R"cpp(
2881 int foo();
2882 int foo(double);
2883
2884 void test() {
2885 foo(^);
2886 }
2887 )cpp";
2888
2889 EXPECT_THAT(
2890 signatures(Sig0, {Foo0}).signatures,
2891 ElementsAre(AllOf(sig("foo() -> int"), sigDoc("doc from the index")),
2892 AllOf(sig("foo([[double]]) -> int"), sigDoc(""))));
2893
2894 StringRef Sig1 = R"cpp(
2895 int foo();
2896 // Overriden doc from sema
2897 int foo(int);
2898 // doc from sema
2899 int foo(int, int);
2900
2901 void test() {
2902 foo(^);
2903 }
2904 )cpp";
2905
2906 EXPECT_THAT(
2907 signatures(Sig1, {Foo0, Foo1, Foo2}).signatures,
2908 ElementsAre(
2909 AllOf(sig("foo() -> int"), sigDoc("doc from the index")),
2910 AllOf(sig("foo([[int]]) -> int"), sigDoc("Overriden doc from sema")),
2911 AllOf(sig("foo([[int]], [[int]]) -> int"), sigDoc("doc from sema"))));
2912}
2913
2914TEST(SignatureHelpTest, DynamicIndexDocumentation) {
2915 MockFS FS;
2918 Opts.BuildDynamicSymbolIndex = true;
2919 ClangdServer Server(CDB, FS, Opts);
2920
2921 FS.Files[testPath("foo.h")] = R"cpp(
2922 struct Foo {
2923 // Member doc
2924 int foo();
2925 };
2926 )cpp";
2927 Annotations FileContent(R"cpp(
2928 #include "foo.h"
2929 void test() {
2930 Foo f;
2931 f.foo(^);
2932 }
2933 )cpp");
2934 auto File = testPath("test.cpp");
2935 Server.addDocument(File, FileContent.code());
2936 // Wait for the dynamic index being built.
2937 ASSERT_TRUE(Server.blockUntilIdleForTest());
2938 EXPECT_THAT(llvm::cantFail(runSignatureHelp(Server, File, FileContent.point(),
2940 .signatures,
2941 ElementsAre(AllOf(sig("foo() -> int"), sigDoc("Member doc"))));
2942}
2943
2944TEST(CompletionTest, ArgumentListsPolicy) {
2946 Opts.EnableSnippets = true;
2947 Opts.ArgumentLists = Config::ArgumentListsPolicy::Delimiters;
2948
2949 {
2950 auto Results = completions(
2951 R"cpp(
2952 void xfoo();
2953 void xfoo(int x, int y);
2954 void f() { xfo^ })cpp",
2955 {}, Opts);
2956 EXPECT_THAT(
2957 Results.Completions,
2958 UnorderedElementsAre(AllOf(named("xfoo"), snippetSuffix("()")),
2959 AllOf(named("xfoo"), snippetSuffix("($0)"))));
2960 }
2961 {
2962 auto Results = completions(
2963 R"cpp(
2964 void xbar();
2965 void f() { xba^ })cpp",
2966 {}, Opts);
2967 EXPECT_THAT(Results.Completions, UnorderedElementsAre(AllOf(
2968 named("xbar"), snippetSuffix("()"))));
2969 }
2970 {
2971 Opts.BundleOverloads = true;
2972 auto Results = completions(
2973 R"cpp(
2974 void xfoo();
2975 void xfoo(int x, int y);
2976 void f() { xfo^ })cpp",
2977 {}, Opts);
2978 EXPECT_THAT(
2979 Results.Completions,
2980 UnorderedElementsAre(AllOf(named("xfoo"), snippetSuffix("($0)"))));
2981 }
2982 {
2983 auto Results = completions(
2984 R"cpp(
2985 template <class T, class U>
2986 void xfoo(int a, U b);
2987 void f() { xfo^ })cpp",
2988 {}, Opts);
2989 EXPECT_THAT(
2990 Results.Completions,
2991 UnorderedElementsAre(AllOf(named("xfoo"), snippetSuffix("<$1>($0)"))));
2992 }
2993 {
2994 auto Results = completions(
2995 R"cpp(
2996 template <class T>
2997 class foo_class{};
2998 template <class T>
2999 using foo_alias = T**;
3000 template <class T>
3001 T foo_var = T{};
3002 void f() { foo_^ })cpp",
3003 {}, Opts);
3004 EXPECT_THAT(
3005 Results.Completions,
3006 UnorderedElementsAre(AllOf(named("foo_class"), snippetSuffix("<$0>")),
3007 AllOf(named("foo_alias"), snippetSuffix("<$0>")),
3008 AllOf(named("foo_var"), snippetSuffix("<$0>"))));
3009 }
3010 {
3011 auto Results = completions(
3012 R"cpp(
3013 #define FOO(x, y) x##f
3014 FO^ )cpp",
3015 {}, Opts);
3016 EXPECT_THAT(Results.Completions, UnorderedElementsAre(AllOf(
3017 named("FOO"), snippetSuffix("($0)"))));
3018 }
3019 {
3020 auto Results = completions(
3021 R"cpp(
3022 void function() {
3023 auto Lambda = [](int a, const double &b) {return 1.f;};
3024 Lam^
3025 })cpp",
3026 {}, Opts);
3027 EXPECT_THAT(
3028 Results.Completions,
3029 UnorderedElementsAre(AllOf(named("Lambda"), snippetSuffix("($0)"))));
3030 }
3031 {
3032 Opts.ArgumentLists = Config::ArgumentListsPolicy::None;
3033 auto Results = completions(
3034 R"cpp(
3035 void xfoo(int x, int y);
3036 void f() { xfo^ })cpp",
3037 {}, Opts);
3038 EXPECT_THAT(Results.Completions,
3039 UnorderedElementsAre(AllOf(named("xfoo"), snippetSuffix(""))));
3040 }
3041 {
3042 Opts.ArgumentLists = Config::ArgumentListsPolicy::OpenDelimiter;
3043 auto Results = completions(
3044 R"cpp(
3045 void xfoo(int x, int y);
3046 void f() { xfo^ })cpp",
3047 {}, Opts);
3048 EXPECT_THAT(Results.Completions,
3049 UnorderedElementsAre(AllOf(named("xfoo"), snippetSuffix("("))));
3050 }
3051}
3052
3053TEST(CompletionTest, SuggestOverrides) {
3054 constexpr const char *const Text(R"cpp(
3055 class A {
3056 public:
3057 virtual void vfunc(bool param);
3058 virtual void vfunc(bool param, int p);
3059 void func(bool param);
3060 };
3061 class B : public A {
3062 virtual void ttt(bool param) const;
3063 void vfunc(bool param, int p) override;
3064 };
3065 class C : public B {
3066 public:
3067 void vfunc(bool param) override;
3068 ^
3069 };
3070 )cpp");
3071 const auto Results = completions(Text);
3072 EXPECT_THAT(
3073 Results.Completions,
3074 AllOf(Contains(AllOf(labeled("void vfunc(bool param, int p) override"),
3075 nameStartsWith("vfunc"))),
3076 Contains(AllOf(labeled("void ttt(bool param) const override"),
3077 nameStartsWith("ttt"))),
3078 Not(Contains(labeled("void vfunc(bool param) override")))));
3079}
3080
3081TEST(CompletionTest, OverridesNonIdentName) {
3082 // Check the completions call does not crash.
3083 completions(R"cpp(
3084 struct Base {
3085 virtual ~Base() = 0;
3086 virtual operator int() = 0;
3087 virtual Base& operator+(Base&) = 0;
3088 };
3089
3090 struct Derived : Base {
3091 ^
3092 };
3093 )cpp");
3094}
3095
3096TEST(CompletionTest, NoCrashOnMissingNewLineAtEOF) {
3097 auto FooCpp = testPath("foo.cpp");
3098
3100 MockFS FS;
3101 Annotations F("#pragma ^ // no new line");
3102 FS.Files[FooCpp] = F.code().str();
3103 ClangdServer Server(CDB, FS, ClangdServer::optsForTest());
3104 runAddDocument(Server, FooCpp, F.code());
3105 // Run completion outside the file range.
3106 EXPECT_THAT(cantFail(runCodeComplete(Server, FooCpp, F.point(),
3107 clangd::CodeCompleteOptions()))
3108 .Completions,
3109 IsEmpty());
3110 EXPECT_THAT(cantFail(runSignatureHelp(Server, FooCpp, F.point(),
3112 .signatures,
3113 IsEmpty());
3114}
3115
3116TEST(GuessCompletionPrefix, Filters) {
3117 for (llvm::StringRef Case : {
3118 "[[scope::]][[ident]]^",
3119 "[[]][[]]^",
3120 "\n[[]][[]]^",
3121 "[[]][[ab]]^",
3122 "x.[[]][[ab]]^",
3123 "x.[[]][[]]^",
3124 "[[x::]][[ab]]^",
3125 "[[x::]][[]]^",
3126 "[[::x::]][[ab]]^",
3127 "some text [[scope::more::]][[identif]]^ier",
3128 "some text [[scope::]][[mor]]^e::identifier",
3129 "weird case foo::[[::bar::]][[baz]]^",
3130 "/* [[]][[]]^ */",
3131 }) {
3132 Annotations F(Case);
3133 auto Offset = cantFail(positionToOffset(F.code(), F.point()));
3134 auto ToStringRef = [&](Range R) {
3135 return F.code().slice(cantFail(positionToOffset(F.code(), R.start)),
3136 cantFail(positionToOffset(F.code(), R.end)));
3137 };
3138 auto WantQualifier = ToStringRef(F.ranges()[0]),
3139 WantName = ToStringRef(F.ranges()[1]);
3140
3141 auto Prefix = guessCompletionPrefix(F.code(), Offset);
3142 // Even when components are empty, check their offsets are correct.
3143 EXPECT_EQ(WantQualifier, Prefix.Qualifier) << Case;
3144 EXPECT_EQ(WantQualifier.begin(), Prefix.Qualifier.begin()) << Case;
3145 EXPECT_EQ(WantName, Prefix.Name) << Case;
3146 EXPECT_EQ(WantName.begin(), Prefix.Name.begin()) << Case;
3147 }
3148}
3149
3150TEST(CompletionTest, EnableSpeculativeIndexRequest) {
3151 MockFS FS;
3153 ClangdServer Server(CDB, FS, ClangdServer::optsForTest());
3154
3155 auto File = testPath("foo.cpp");
3156 Annotations Test(R"cpp(
3157 namespace ns1 { int abc; }
3158 namespace ns2 { int abc; }
3159 void f() { ns1::ab$1^; ns1::ab$2^; }
3160 void f2() { ns2::ab$3^; }
3161 )cpp");
3162 runAddDocument(Server, File, Test.code());
3163 clangd::CodeCompleteOptions Opts = {};
3164
3165 IndexRequestCollector Requests;
3166 Opts.Index = &Requests;
3167
3168 auto CompleteAtPoint = [&](StringRef P) {
3169 auto CCR = cantFail(runCodeComplete(Server, File, Test.point(P), Opts));
3170 EXPECT_TRUE(CCR.HasMore);
3171 };
3172
3173 CompleteAtPoint("1");
3174 auto Reqs1 = Requests.consumeRequests(1);
3175 ASSERT_EQ(Reqs1.size(), 1u);
3176 EXPECT_THAT(Reqs1[0].Scopes, UnorderedElementsAre("ns1::"));
3177
3178 CompleteAtPoint("2");
3179 auto Reqs2 = Requests.consumeRequests(1);
3180 // Speculation succeeded. Used speculative index result.
3181 ASSERT_EQ(Reqs2.size(), 1u);
3182 EXPECT_EQ(Reqs2[0], Reqs1[0]);
3183
3184 CompleteAtPoint("3");
3185 // Speculation failed. Sent speculative index request and the new index
3186 // request after sema.
3187 auto Reqs3 = Requests.consumeRequests(2);
3188 ASSERT_EQ(Reqs3.size(), 2u);
3189}
3190
3191TEST(CompletionTest, InsertTheMostPopularHeader) {
3192 std::string DeclFile = URI::create(testPath("foo")).toString();
3193 Symbol Sym = func("Func");
3194 Sym.CanonicalDeclaration.FileURI = DeclFile.c_str();
3195 Sym.IncludeHeaders.emplace_back("\"foo.h\"", 2, Symbol::Include);
3196 Sym.IncludeHeaders.emplace_back("\"bar.h\"", 1000, Symbol::Include);
3197
3198 auto Results = completions("Fun^", {Sym}).Completions;
3199 assert(!Results.empty());
3200 EXPECT_THAT(Results[0], AllOf(named("Func"), insertInclude("\"bar.h\"")));
3201 EXPECT_EQ(Results[0].Includes.size(), 2u);
3202}
3203
3204TEST(CompletionTest, InsertIncludeOrImport) {
3205 std::string DeclFile = URI::create(testPath("foo")).toString();
3206 Symbol Sym = func("Func");
3207 Sym.CanonicalDeclaration.FileURI = DeclFile.c_str();
3208 Sym.IncludeHeaders.emplace_back("\"bar.h\"", 1000,
3211 // Should only take effect in import contexts.
3212 Opts.ImportInsertions = true;
3213 auto Results = completions("Fun^", {Sym}, Opts).Completions;
3214 assert(!Results.empty());
3215 EXPECT_THAT(Results[0],
3216 AllOf(named("Func"), insertIncludeText("#include \"bar.h\"\n")));
3217
3218 ASTSignals Signals;
3220 Opts.MainFileSignals = &Signals;
3221 Results = completions("Fun^", {Sym}, Opts, "Foo.m").Completions;
3222 assert(!Results.empty());
3223 EXPECT_THAT(Results[0],
3224 AllOf(named("Func"), insertIncludeText("#import \"bar.h\"\n")));
3225
3226 Sym.IncludeHeaders[0].SupportedDirectives = Symbol::Import;
3227 Results = completions("Fun^", {Sym}).Completions;
3228 assert(!Results.empty());
3229 EXPECT_THAT(Results[0], AllOf(named("Func"), Not(insertInclude())));
3230}
3231
3232TEST(CompletionTest, NoInsertIncludeIfOnePresent) {
3233 Annotations Test(R"cpp(
3234 #include "foo.h"
3235 Fun^
3236 )cpp");
3237 auto TU = TestTU::withCode(Test.code());
3238 TU.AdditionalFiles["foo.h"] = "";
3239
3240 std::string DeclFile = URI::create(testPath("foo")).toString();
3241 Symbol Sym = func("Func");
3242 Sym.CanonicalDeclaration.FileURI = DeclFile.c_str();
3243 Sym.IncludeHeaders.emplace_back("\"foo.h\"", 2, Symbol::Include);
3244 Sym.IncludeHeaders.emplace_back("\"bar.h\"", 1000, Symbol::Include);
3245
3246 EXPECT_THAT(completions(TU, Test.point(), {Sym}).Completions,
3247 UnorderedElementsAre(AllOf(named("Func"), hasInclude("\"foo.h\""),
3248 Not(insertInclude()))));
3249}
3250
3251TEST(CompletionTest, MergeMacrosFromIndexAndSema) {
3252 Symbol Sym;
3253 Sym.Name = "Clangd_Macro_Test";
3254 Sym.ID = SymbolID("c:foo.cpp@8@macro@Clangd_Macro_Test");
3255 Sym.SymInfo.Kind = index::SymbolKind::Macro;
3257 EXPECT_THAT(completions("#define Clangd_Macro_Test\nClangd_Macro_T^", {Sym})
3258 .Completions,
3259 UnorderedElementsAre(named("Clangd_Macro_Test")));
3260}
3261
3262TEST(CompletionTest, MacroFromPreamble) {
3263 Annotations Test(R"cpp(#define CLANGD_PREAMBLE_MAIN x
3264
3265 int x = 0;
3266 #define CLANGD_MAIN x
3267 void f() { CLANGD_^ }
3268 )cpp");
3269 auto TU = TestTU::withCode(Test.code());
3270 TU.HeaderCode = "#define CLANGD_PREAMBLE_HEADER x";
3271 auto Results = completions(TU, Test.point(), {func("CLANGD_INDEX")});
3272 // We should get results from the main file, including the preamble section.
3273 // However no results from included files (the index should cover them).
3274 EXPECT_THAT(Results.Completions,
3275 UnorderedElementsAre(named("CLANGD_PREAMBLE_MAIN"),
3276 named("CLANGD_MAIN"),
3277 named("CLANGD_INDEX")));
3278}
3279
3280TEST(CompletionTest, DeprecatedResults) {
3281 std::string Body = R"cpp(
3282 void TestClangd();
3283 void TestClangc() __attribute__((deprecated("", "")));
3284 )cpp";
3285
3286 EXPECT_THAT(
3287 completions(Body + "int main() { TestClang^ }").Completions,
3288 UnorderedElementsAre(AllOf(named("TestClangd"), Not(deprecated())),
3289 AllOf(named("TestClangc"), deprecated())));
3290}
3291
3292TEST(SignatureHelpTest, PartialSpec) {
3293 const auto Results = signatures(R"cpp(
3294 template <typename T> struct Foo {};
3295 template <typename T> struct Foo<T*> { Foo(T); };
3296 Foo<int*> F(^);)cpp");
3297 EXPECT_THAT(Results.signatures, Contains(sig("Foo([[T]])")));
3298 EXPECT_EQ(0, Results.activeParameter);
3299}
3300
3301TEST(SignatureHelpTest, InsideArgument) {
3302 {
3303 const auto Results = signatures(R"cpp(
3304 void foo(int x);
3305 void foo(int x, int y);
3306 int main() { foo(1+^); }
3307 )cpp");
3308 EXPECT_THAT(Results.signatures,
3309 ElementsAre(sig("foo([[int x]]) -> void"),
3310 sig("foo([[int x]], [[int y]]) -> void")));
3311 EXPECT_EQ(0, Results.activeParameter);
3312 }
3313 {
3314 const auto Results = signatures(R"cpp(
3315 void foo(int x);
3316 void foo(int x, int y);
3317 int main() { foo(1^); }
3318 )cpp");
3319 EXPECT_THAT(Results.signatures,
3320 ElementsAre(sig("foo([[int x]]) -> void"),
3321 sig("foo([[int x]], [[int y]]) -> void")));
3322 EXPECT_EQ(0, Results.activeParameter);
3323 }
3324 {
3325 const auto Results = signatures(R"cpp(
3326 void foo(int x);
3327 void foo(int x, int y);
3328 int main() { foo(1^0); }
3329 )cpp");
3330 EXPECT_THAT(Results.signatures,
3331 ElementsAre(sig("foo([[int x]]) -> void"),
3332 sig("foo([[int x]], [[int y]]) -> void")));
3333 EXPECT_EQ(0, Results.activeParameter);
3334 }
3335 {
3336 const auto Results = signatures(R"cpp(
3337 void foo(int x);
3338 void foo(int x, int y);
3339 int bar(int x, int y);
3340 int main() { bar(foo(2, 3^)); }
3341 )cpp");
3342 EXPECT_THAT(Results.signatures,
3343 ElementsAre(sig("foo([[int x]], [[int y]]) -> void")));
3344 EXPECT_EQ(1, Results.activeParameter);
3345 }
3346}
3347
3348TEST(SignatureHelpTest, ConstructorInitializeFields) {
3349 {
3350 const auto Results = signatures(R"cpp(
3351 struct A { A(int); };
3352 struct B {
3353 B() : a_elem(^) {}
3354 A a_elem;
3355 };
3356 )cpp");
3357 EXPECT_THAT(Results.signatures,
3358 UnorderedElementsAre(sig("A([[int]])"), sig("A([[A &&]])"),
3359 sig("A([[const A &]])")));
3360 }
3361 {
3362 const auto Results = signatures(R"cpp(
3363 struct A { A(int); };
3364 struct B {
3365 B() : a_elem(^
3366 A a_elem;
3367 };
3368 )cpp");
3369 // FIXME: currently the parser skips over the decl of a_elem as part of the
3370 // (broken) init list, so we don't get signatures for the first member.
3371 EXPECT_THAT(Results.signatures, IsEmpty());
3372 }
3373 {
3374 const auto Results = signatures(R"cpp(
3375 struct A { A(int); };
3376 struct B {
3377 B() : a_elem(^
3378 int dummy_elem;
3379 A a_elem;
3380 };
3381 )cpp");
3382 EXPECT_THAT(Results.signatures,
3383 UnorderedElementsAre(sig("A([[int]])"), sig("A([[A &&]])"),
3384 sig("A([[const A &]])")));
3385 }
3386 {
3387 const auto Results = signatures(R"cpp(
3388 struct A {
3389 A(int);
3390 };
3391 struct C {
3392 C(int);
3393 C(A);
3394 };
3395 struct B {
3396 B() : c_elem(A(1^)) {}
3397 C c_elem;
3398 };
3399 )cpp");
3400 EXPECT_THAT(Results.signatures,
3401 UnorderedElementsAre(sig("A([[int]])"), sig("A([[A &&]])"),
3402 sig("A([[const A &]])")));
3403 }
3404}
3405
3406TEST(SignatureHelpTest, Variadic) {
3407 const std::string Header = R"cpp(
3408 void fun(int x, ...) {}
3409 void test() {)cpp";
3410 const std::string ExpectedSig = "fun([[int x]], [[...]]) -> void";
3411
3412 {
3413 const auto Result = signatures(Header + "fun(^);}");
3414 EXPECT_EQ(0, Result.activeParameter);
3415 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3416 }
3417 {
3418 const auto Result = signatures(Header + "fun(1, ^);}");
3419 EXPECT_EQ(1, Result.activeParameter);
3420 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3421 }
3422 {
3423 const auto Result = signatures(Header + "fun(1, 2, ^);}");
3424 EXPECT_EQ(1, Result.activeParameter);
3425 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3426 }
3427}
3428
3429TEST(SignatureHelpTest, VariadicTemplate) {
3430 const std::string Header = R"cpp(
3431 template<typename T, typename ...Args>
3432 void fun(T t, Args ...args) {}
3433 void test() {)cpp";
3434 const std::string ExpectedSig = "fun([[T t]], [[Args args...]]) -> void";
3435
3436 {
3437 const auto Result = signatures(Header + "fun(^);}");
3438 EXPECT_EQ(0, Result.activeParameter);
3439 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3440 }
3441 {
3442 const auto Result = signatures(Header + "fun(1, ^);}");
3443 EXPECT_EQ(1, Result.activeParameter);
3444 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3445 }
3446 {
3447 const auto Result = signatures(Header + "fun(1, 2, ^);}");
3448 EXPECT_EQ(1, Result.activeParameter);
3449 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3450 }
3451}
3452
3453TEST(SignatureHelpTest, VariadicMethod) {
3454 const std::string Header = R"cpp(
3455 class C {
3456 template<typename T, typename ...Args>
3457 void fun(T t, Args ...args) {}
3458 };
3459 void test() {C c; )cpp";
3460 const std::string ExpectedSig = "fun([[T t]], [[Args args...]]) -> void";
3461
3462 {
3463 const auto Result = signatures(Header + "c.fun(^);}");
3464 EXPECT_EQ(0, Result.activeParameter);
3465 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3466 }
3467 {
3468 const auto Result = signatures(Header + "c.fun(1, ^);}");
3469 EXPECT_EQ(1, Result.activeParameter);
3470 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3471 }
3472 {
3473 const auto Result = signatures(Header + "c.fun(1, 2, ^);}");
3474 EXPECT_EQ(1, Result.activeParameter);
3475 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3476 }
3477}
3478
3479TEST(SignatureHelpTest, VariadicType) {
3480 const std::string Header = R"cpp(
3481 void fun(int x, ...) {}
3482 auto get_fun() { return fun; }
3483 void test() {
3484 )cpp";
3485 const std::string ExpectedSig = "([[int]], [[...]]) -> void";
3486
3487 {
3488 const auto Result = signatures(Header + "get_fun()(^);}");
3489 EXPECT_EQ(0, Result.activeParameter);
3490 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3491 }
3492 {
3493 const auto Result = signatures(Header + "get_fun()(1, ^);}");
3494 EXPECT_EQ(1, Result.activeParameter);
3495 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3496 }
3497 {
3498 const auto Result = signatures(Header + "get_fun()(1, 2, ^);}");
3499 EXPECT_EQ(1, Result.activeParameter);
3500 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3501 }
3502}
3503
3504TEST(SignatureHelpTest, SkipExplicitObjectParameter) {
3505 Annotations Code(R"cpp(
3506 struct A {
3507 void foo(this auto&& self, int arg);
3508 void bar(this A self, int arg);
3509 };
3510 int main() {
3511 A a {};
3512 a.foo($c1^);
3513 (&A::bar)($c2^);
3514 (&A::foo)($c3^);
3515 }
3516 )cpp");
3517
3518 auto TU = TestTU::withCode(Code.code());
3519 TU.ExtraArgs = {"-std=c++23"};
3520
3521 MockFS FS;
3522 auto Inputs = TU.inputs(FS);
3523
3524 auto Preamble = TU.preamble();
3525 ASSERT_TRUE(Preamble);
3526
3527 {
3528 const auto Result = signatureHelp(testPath(TU.Filename), Code.point("c1"),
3530
3531 EXPECT_EQ(1U, Result.signatures.size());
3532
3533 EXPECT_THAT(Result.signatures[0], AllOf(sig("foo([[int arg]]) -> void")));
3534 }
3535 {
3536 const auto Result = signatureHelp(testPath(TU.Filename), Code.point("c2"),
3538
3539 EXPECT_EQ(1U, Result.signatures.size());
3540
3541 EXPECT_THAT(Result.signatures[0], AllOf(sig("([[A]], [[int]]) -> void")));
3542 }
3543 {
3544 // TODO: llvm/llvm-project/146649
3545 const auto Result = signatureHelp(testPath(TU.Filename), Code.point("c3"),
3547 // TODO: We expect 1 signature here, with this signature
3548 EXPECT_EQ(0U, Result.signatures.size());
3549 // EXPECT_THAT(Result.signatures[0], AllOf(sig("([[auto&&]], [[int]]) ->
3550 // void")));
3551 }
3552}
3553
3554TEST(CompletionTest, IncludedCompletionKinds) {
3555 Annotations Test(R"cpp(#include "^)cpp");
3556 auto TU = TestTU::withCode(Test.code());
3557 TU.AdditionalFiles["sub/bar.h"] = "";
3558 TU.ExtraArgs.push_back("-I" + testPath("sub"));
3559
3560 auto Results = completions(TU, Test.point());
3561 EXPECT_THAT(Results.Completions,
3562 AllOf(has("sub/", CompletionItemKind::Folder),
3563 has("bar.h\"", CompletionItemKind::File)));
3564}
3565
3566TEST(CompletionTest, NoCrashAtNonAlphaIncludeHeader) {
3567 completions(
3568 R"cpp(
3569 #include "./^"
3570 )cpp");
3571}
3572
3573TEST(CompletionTest, NoAllScopesCompletionWhenQualified) {
3574 clangd::CodeCompleteOptions Opts = {};
3575 Opts.AllScopes = true;
3576
3577 auto Results = completions(
3578 R"cpp(
3579 void f() { na::Clangd^ }
3580 )cpp",
3581 {cls("na::ClangdA"), cls("nx::ClangdX"), cls("Clangd3")}, Opts);
3582 EXPECT_THAT(Results.Completions,
3583 UnorderedElementsAre(
3584 AllOf(qualifier(""), scope("na::"), named("ClangdA"))));
3585}
3586
3587TEST(CompletionTest, AllScopesCompletion) {
3588 clangd::CodeCompleteOptions Opts = {};
3589 Opts.AllScopes = true;
3590
3591 auto Results = completions(
3592 R"cpp(
3593 namespace na {
3594 void f() { Clangd^ }
3595 }
3596 )cpp",
3597 {cls("nx::Clangd1"), cls("ny::Clangd2"), cls("Clangd3"),
3598 cls("na::nb::Clangd4"), enmConstant("na::C::Clangd5")},
3599 Opts);
3600 EXPECT_THAT(
3601 Results.Completions,
3602 UnorderedElementsAre(AllOf(qualifier("nx::"), named("Clangd1"),
3604 AllOf(qualifier("ny::"), named("Clangd2"),
3606 AllOf(qualifier(""), scope(""), named("Clangd3"),
3608 AllOf(qualifier("nb::"), named("Clangd4"),
3610 AllOf(qualifier("C::"), named("Clangd5"),
3612}
3613
3614TEST(CompletionTest, NoCodePatternsIfDisabled) {
3615 clangd::CodeCompleteOptions Opts = {};
3616 Opts.EnableSnippets = true;
3617 Opts.CodePatterns = Config::CodePatternsPolicy::None;
3618
3619 auto Results = completions(R"cpp(
3620 void function() {
3621 /// Trying to trigger "for (init-statement; condition; inc-expression)
3622 /// {statements}~" code pattern
3623 for^
3624 }
3625 )cpp",
3626 {}, Opts);
3627
3628 EXPECT_THAT(Results.Completions,
3629 Not(Contains(kind(CompletionItemKind::Snippet))));
3630}
3631
3632TEST(CompletionTest, CompleteIncludeIfCodePatternsNone) {
3633 clangd::CodeCompleteOptions Opts = {};
3634 Opts.EnableSnippets = true;
3635 Opts.CodePatterns = Config::CodePatternsPolicy::None;
3636
3637 Annotations Test(R"cpp(#include "^)cpp");
3638 auto TU = TestTU::withCode(Test.code());
3639 TU.AdditionalFiles["foo/bar.h"] = "";
3640 TU.ExtraArgs.push_back("-I" + testPath("foo"));
3641
3642 auto Results = completions(TU, Test.point(), {}, Opts);
3643 EXPECT_THAT(Results.Completions,
3644 AllOf(has("foo/", CompletionItemKind::Folder),
3645 has("bar.h\"", CompletionItemKind::File)));
3646}
3647
3648TEST(CompletionTest, NoQualifierIfShadowed) {
3649 clangd::CodeCompleteOptions Opts = {};
3650 Opts.AllScopes = true;
3651
3652 auto Results = completions(R"cpp(
3653 namespace nx { class Clangd1 {}; }
3654 using nx::Clangd1;
3655 void f() { Clangd^ }
3656 )cpp",
3657 {cls("nx::Clangd1"), cls("nx::Clangd2")}, Opts);
3658 // Although Clangd1 is from another namespace, Sema tells us it's in-scope and
3659 // needs no qualifier.
3660 EXPECT_THAT(Results.Completions,
3661 UnorderedElementsAre(AllOf(qualifier(""), named("Clangd1")),
3662 AllOf(qualifier("nx::"), named("Clangd2"))));
3663}
3664
3665TEST(CompletionTest, NoCompletionsForNewNames) {
3666 clangd::CodeCompleteOptions Opts;
3667 Opts.AllScopes = true;
3668 auto Results = completions(R"cpp(
3669 void f() { int n^ }
3670 )cpp",
3671 {cls("naber"), cls("nx::naber")}, Opts);
3672 EXPECT_THAT(Results.Completions, UnorderedElementsAre());
3673}
3674
3675TEST(CompletionTest, Lambda) {
3676 clangd::CodeCompleteOptions Opts = {};
3677
3678 auto Results = completions(R"cpp(
3679 void function() {
3680 auto Lambda = [](int a, const double &b) {return 1.f;};
3681 Lam^
3682 }
3683 )cpp",
3684 {}, Opts);
3685
3686 ASSERT_EQ(Results.Completions.size(), 1u);
3687 const auto &A = Results.Completions.front();
3688 EXPECT_EQ(A.Name, "Lambda");
3689 EXPECT_EQ(A.Signature, "(int a, const double &b) const");
3690 EXPECT_EQ(A.Kind, CompletionItemKind::Variable);
3691 EXPECT_EQ(A.ReturnType, "float");
3692 EXPECT_EQ(A.SnippetSuffix, "(${1:int a}, ${2:const double &b})");
3693}
3694
3695TEST(CompletionTest, StructuredBinding) {
3696 clangd::CodeCompleteOptions Opts = {};
3697
3698 auto Results = completions(R"cpp(
3699 struct S {
3700 using Float = float;
3701 int x;
3702 Float y;
3703 };
3704 void function() {
3705 const auto &[xxx, yyy] = S{};
3706 yyy^
3707 }
3708 )cpp",
3709 {}, Opts);
3710
3711 ASSERT_EQ(Results.Completions.size(), 1u);
3712 const auto &A = Results.Completions.front();
3713 EXPECT_EQ(A.Name, "yyy");
3714 EXPECT_EQ(A.Kind, CompletionItemKind::Variable);
3715 EXPECT_EQ(A.ReturnType, "const Float");
3716}
3717
3718TEST(CompletionTest, ObjectiveCMethodNoArguments) {
3719 auto Results = completions(R"objc(
3720 @interface Foo
3721 @property(nonatomic, setter=setXToIgnoreComplete:) int value;
3722 @end
3723 Foo *foo = [Foo new]; int y = [foo v^]
3724 )objc",
3725 /*IndexSymbols=*/{},
3726 /*Opts=*/{}, "Foo.m");
3727
3728 auto C = Results.Completions;
3729 EXPECT_THAT(C, ElementsAre(named("value")));
3730 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3731 EXPECT_THAT(C, ElementsAre(returnType("int")));
3732 EXPECT_THAT(C, ElementsAre(signature("")));
3733 EXPECT_THAT(C, ElementsAre(snippetSuffix("")));
3734}
3735
3736TEST(CompletionTest, ObjectiveCMethodOneArgument) {
3737 auto Results = completions(R"objc(
3738 @interface Foo
3739 - (int)valueForCharacter:(char)c;
3740 @end
3741 Foo *foo = [Foo new]; int y = [foo v^]
3742 )objc",
3743 /*IndexSymbols=*/{},
3744 /*Opts=*/{}, "Foo.m");
3745
3746 auto C = Results.Completions;
3747 EXPECT_THAT(C, ElementsAre(named("valueForCharacter:")));
3748 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3749 EXPECT_THAT(C, ElementsAre(returnType("int")));
3750 EXPECT_THAT(C, ElementsAre(signature("(char)")));
3751 EXPECT_THAT(C, ElementsAre(snippetSuffix("${1:(char)}")));
3752}
3753
3754TEST(CompletionTest, ObjectiveCMethodTwoArgumentsFromBeginning) {
3755 auto Results = completions(R"objc(
3756 @interface Foo
3757 + (id)fooWithValue:(int)value fooey:(unsigned int)fooey;
3758 @end
3759 id val = [Foo foo^]
3760 )objc",
3761 /*IndexSymbols=*/{},
3762 /*Opts=*/{}, "Foo.m");
3763
3764 auto C = Results.Completions;
3765 EXPECT_THAT(C, ElementsAre(named("fooWithValue:")));
3766 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3767 EXPECT_THAT(C, ElementsAre(returnType("id")));
3768 EXPECT_THAT(C, ElementsAre(signature("(int) fooey:(unsigned int)")));
3769 EXPECT_THAT(
3770 C, ElementsAre(snippetSuffix("${1:(int)} fooey:${2:(unsigned int)}")));
3771}
3772
3773TEST(CompletionTest, ObjectiveCMethodTwoArgumentsFromMiddle) {
3774 auto Results = completions(R"objc(
3775 @interface Foo
3776 + (id)fooWithValue:(int)value fooey:(unsigned int)fooey;
3777 @end
3778 id val = [Foo fooWithValue:10 f^]
3779 )objc",
3780 /*IndexSymbols=*/{},
3781 /*Opts=*/{}, "Foo.m");
3782
3783 auto C = Results.Completions;
3784 EXPECT_THAT(C, ElementsAre(named("fooey:")));
3785 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3786 EXPECT_THAT(C, ElementsAre(returnType("id")));
3787 EXPECT_THAT(C, ElementsAre(signature("(unsigned int)")));
3788 EXPECT_THAT(C, ElementsAre(snippetSuffix("${1:(unsigned int)}")));
3789}
3790
3791TEST(CompletionTest, ObjectiveCMethodFilterOnEntireSelector) {
3792 auto Results = completions(R"objc(
3793 @interface Foo
3794 + (id)player:(id)player willRun:(id)run;
3795 @end
3796 id val = [Foo wi^]
3797 )objc",
3798 /*IndexSymbols=*/{},
3799 /*Opts=*/{}, "Foo.m");
3800
3801 auto C = Results.Completions;
3802 EXPECT_THAT(C, ElementsAre(named("player:")));
3803 EXPECT_THAT(C, ElementsAre(filterText("player:willRun:")));
3804 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3805 EXPECT_THAT(C, ElementsAre(returnType("id")));
3806 EXPECT_THAT(C, ElementsAre(signature("(id) willRun:(id)")));
3807 EXPECT_THAT(C, ElementsAre(snippetSuffix("${1:(id)} willRun:${2:(id)}")));
3808}
3809
3810TEST(CompletionTest, ObjectiveCSimpleMethodDeclaration) {
3811 auto Results = completions(R"objc(
3812 @interface Foo
3813 - (void)foo;
3814 @end
3815 @implementation Foo
3816 fo^
3817 @end
3818 )objc",
3819 /*IndexSymbols=*/{},
3820 /*Opts=*/{}, "Foo.m");
3821
3822 auto C = Results.Completions;
3823 EXPECT_THAT(C, ElementsAre(named("foo")));
3824 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3825 EXPECT_THAT(C, ElementsAre(qualifier("- (void)")));
3826}
3827
3828TEST(CompletionTest, ObjectiveCMethodDeclaration) {
3829 auto Results = completions(R"objc(
3830 @interface Foo
3831 - (int)valueForCharacter:(char)c secondArgument:(id)object;
3832 @end
3833 @implementation Foo
3834 valueFor^
3835 @end
3836 )objc",
3837 /*IndexSymbols=*/{},
3838 /*Opts=*/{}, "Foo.m");
3839
3840 auto C = Results.Completions;
3841 EXPECT_THAT(C, ElementsAre(named("valueForCharacter:")));
3842 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3843 EXPECT_THAT(C, ElementsAre(qualifier("- (int)")));
3844 EXPECT_THAT(C, ElementsAre(signature("(char)c secondArgument:(id)object")));
3845}
3846
3847TEST(CompletionTest, ObjectiveCMethodDeclarationFilterOnEntireSelector) {
3848 auto Results = completions(R"objc(
3849 @interface Foo
3850 - (int)valueForCharacter:(char)c secondArgument:(id)object;
3851 @end
3852 @implementation Foo
3853 secondArg^
3854 @end
3855 )objc",
3856 /*IndexSymbols=*/{},
3857 /*Opts=*/{}, "Foo.m");
3858
3859 auto C = Results.Completions;
3860 EXPECT_THAT(C, ElementsAre(named("valueForCharacter:")));
3861 EXPECT_THAT(C, ElementsAre(filterText("valueForCharacter:secondArgument:")));
3862 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3863 EXPECT_THAT(C, ElementsAre(qualifier("- (int)")));
3864 EXPECT_THAT(C, ElementsAre(signature("(char)c secondArgument:(id)object")));
3865}
3866
3867TEST(CompletionTest, ObjectiveCMethodDeclarationPrefixTyped) {
3868 auto Results = completions(R"objc(
3869 @interface Foo
3870 - (int)valueForCharacter:(char)c;
3871 @end
3872 @implementation Foo
3873 - (int)valueFor^
3874 @end
3875 )objc",
3876 /*IndexSymbols=*/{},
3877 /*Opts=*/{}, "Foo.m");
3878
3879 auto C = Results.Completions;
3880 EXPECT_THAT(C, ElementsAre(named("valueForCharacter:")));
3881 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3882 EXPECT_THAT(C, ElementsAre(signature("(char)c")));
3883}
3884
3885TEST(CompletionTest, ObjectiveCMethodDeclarationFromMiddle) {
3886 auto Results = completions(R"objc(
3887 @interface Foo
3888 - (int)valueForCharacter:(char)c secondArgument:(id)object;
3889 @end
3890 @implementation Foo
3891 - (int)valueForCharacter:(char)c second^
3892 @end
3893 )objc",
3894 /*IndexSymbols=*/{},
3895 /*Opts=*/{}, "Foo.m");
3896
3897 auto C = Results.Completions;
3898 EXPECT_THAT(C, ElementsAre(named("secondArgument:")));
3899 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3900 EXPECT_THAT(C, ElementsAre(signature("(id)object")));
3901}
3902
3903TEST(CompletionTest, ObjectiveCProtocolFromIndex) {
3904 Symbol FoodClass = objcClass("FoodClass");
3905 Symbol SymFood = objcProtocol("Food");
3906 Symbol SymFooey = objcProtocol("Fooey");
3907 auto Results = completions("id<Foo^>", {SymFood, FoodClass, SymFooey},
3908 /*Opts=*/{}, "Foo.m");
3909
3910 // Should only give protocols for ObjC protocol completions.
3911 EXPECT_THAT(Results.Completions,
3912 UnorderedElementsAre(
3913 AllOf(named("Food"), kind(CompletionItemKind::Interface)),
3914 AllOf(named("Fooey"), kind(CompletionItemKind::Interface))));
3915
3916 Results = completions("Fo^", {SymFood, FoodClass, SymFooey},
3917 /*Opts=*/{}, "Foo.m");
3918 // Shouldn't give protocols for non protocol completions.
3919 EXPECT_THAT(
3920 Results.Completions,
3921 ElementsAre(AllOf(named("FoodClass"), kind(CompletionItemKind::Class))));
3922}
3923
3924TEST(CompletionTest, ObjectiveCProtocolFromIndexSpeculation) {
3925 MockFS FS;
3927 ClangdServer Server(CDB, FS, ClangdServer::optsForTest());
3928
3929 auto File = testPath("Foo.m");
3930 Annotations Test(R"cpp(
3931 @protocol Food
3932 @end
3933 id<Foo$1^> foo;
3934 Foo$2^ bar;
3935 )cpp");
3936 runAddDocument(Server, File, Test.code());
3937 clangd::CodeCompleteOptions Opts = {};
3938
3939 Symbol FoodClass = objcClass("FoodClass");
3940 IndexRequestCollector Requests({FoodClass});
3941 Opts.Index = &Requests;
3942
3943 auto CompleteAtPoint = [&](StringRef P) {
3944 return cantFail(runCodeComplete(Server, File, Test.point(P), Opts))
3945 .Completions;
3946 };
3947
3948 auto C = CompleteAtPoint("1");
3949 auto Reqs1 = Requests.consumeRequests(1);
3950 ASSERT_EQ(Reqs1.size(), 1u);
3951 EXPECT_THAT(C, ElementsAre(AllOf(named("Food"),
3953
3954 C = CompleteAtPoint("2");
3955 auto Reqs2 = Requests.consumeRequests(1);
3956 // Speculation succeeded. Used speculative index result, but filtering now to
3957 // now include FoodClass.
3958 ASSERT_EQ(Reqs2.size(), 1u);
3959 EXPECT_EQ(Reqs2[0], Reqs1[0]);
3960 EXPECT_THAT(C, ElementsAre(AllOf(named("FoodClass"),
3962}
3963
3964TEST(CompletionTest, ObjectiveCCategoryFromIndexIgnored) {
3965 Symbol FoodCategory = objcCategory("FoodClass", "Extension");
3966 auto Results = completions(R"objc(
3967 @interface Foo
3968 @end
3969 @interface Foo (^)
3970 @end
3971 )objc",
3972 {FoodCategory},
3973 /*Opts=*/{}, "Foo.m");
3974 EXPECT_THAT(Results.Completions, IsEmpty());
3975}
3976
3977TEST(CompletionTest, ObjectiveCForwardDeclFromIndex) {
3978 Symbol FoodClass = objcClass("FoodClass");
3979 FoodClass.IncludeHeaders.emplace_back("\"Foo.h\"", 2, Symbol::Import);
3980 Symbol SymFood = objcProtocol("Food");
3981 auto Results = completions("@class Foo^", {SymFood, FoodClass},
3982 /*Opts=*/{}, "Foo.m");
3983
3984 // Should only give class names without any include insertion.
3985 EXPECT_THAT(Results.Completions,
3986 UnorderedElementsAre(AllOf(named("FoodClass"),
3988 Not(insertInclude()))));
3989}
3990
3991TEST(CompletionTest, CursorInSnippets) {
3992 clangd::CodeCompleteOptions Options;
3993 Options.EnableSnippets = true;
3994 auto Results = completions(
3995 R"cpp(
3996 void while_foo(int a, int b);
3997 void test() {
3998 whil^
3999 })cpp",
4000 /*IndexSymbols=*/{}, Options);
4001
4002 // Last placeholder in code patterns should be $0 to put the cursor there.
4003 EXPECT_THAT(Results.Completions,
4004 Contains(AllOf(named("while"),
4005 snippetSuffix(" (${1:condition}) {\n$0\n}"))));
4006 // However, snippets for functions must *not* end with $0.
4007 EXPECT_THAT(Results.Completions,
4008 Contains(AllOf(named("while_foo"),
4009 snippetSuffix("(${1:int a}, ${2:int b})"))));
4010
4011 Results = completions(R"cpp(
4012 struct Base {
4013 Base(int a, int b) {}
4014 };
4015
4016 struct Derived : Base {
4017 Derived() : Base^
4018 };
4019 )cpp",
4020 /*IndexSymbols=*/{}, Options);
4021 // Constructors from base classes are a kind of pattern that shouldn't end
4022 // with $0.
4023 EXPECT_THAT(Results.Completions,
4024 Contains(AllOf(named("Base"),
4025 snippetSuffix("(${1:int a}, ${2:int b})"))));
4026}
4027
4028TEST(CompletionTest, WorksWithNullType) {
4029 auto R = completions(R"cpp(
4030 int main() {
4031 for (auto [loopVar] : y ) { // y has to be unresolved.
4032 int z = loopV^;
4033 }
4034 }
4035 )cpp");
4036 EXPECT_THAT(R.Completions, ElementsAre(named("loopVar")));
4037}
4038
4039TEST(CompletionTest, UsingDecl) {
4040 const char *Header(R"cpp(
4041 void foo(int);
4042 namespace std {
4043 using ::foo;
4044 })cpp");
4045 const char *Source(R"cpp(
4046 void bar() {
4047 std::^;
4048 })cpp");
4049 auto Index = TestTU::withHeaderCode(Header).index();
4050 clangd::CodeCompleteOptions Opts;
4051 Opts.Index = Index.get();
4052 Opts.AllScopes = true;
4053 auto R = completions(Source, {}, Opts);
4054 EXPECT_THAT(R.Completions,
4055 ElementsAre(AllOf(scope("std::"), named("foo"),
4057}
4058
4059TEST(CompletionTest, Enums) {
4060 const char *Header(R"cpp(
4061 namespace ns {
4062 enum Unscoped { Clangd1 };
4063 class C {
4064 enum Unscoped { Clangd2 };
4065 };
4066 enum class Scoped { Clangd3 };
4067 })cpp");
4068 const char *Source(R"cpp(
4069 void bar() {
4070 Clangd^
4071 })cpp");
4072 auto Index = TestTU::withHeaderCode(Header).index();
4073 clangd::CodeCompleteOptions Opts;
4074 Opts.Index = Index.get();
4075 Opts.AllScopes = true;
4076 auto R = completions(Source, {}, Opts);
4077 EXPECT_THAT(R.Completions, UnorderedElementsAre(
4078 AllOf(scope("ns::"), named("Clangd1"),
4080 AllOf(scope("ns::C::"), named("Clangd2"),
4082 AllOf(scope("ns::Scoped::"), named("Clangd3"),
4084}
4085
4086TEST(CompletionTest, ScopeIsUnresolved) {
4087 clangd::CodeCompleteOptions Opts = {};
4088 Opts.AllScopes = true;
4089
4090 auto Results = completions(R"cpp(
4091 namespace a {
4092 void f() { b::X^ }
4093 }
4094 )cpp",
4095 {cls("a::b::XYZ")}, Opts);
4096 EXPECT_THAT(Results.Completions,
4097 UnorderedElementsAre(AllOf(qualifier(""), named("XYZ"))));
4098}
4099
4100TEST(CompletionTest, NestedScopeIsUnresolved) {
4101 clangd::CodeCompleteOptions Opts = {};
4102 Opts.AllScopes = true;
4103
4104 auto Results = completions(R"cpp(
4105 namespace a {
4106 namespace b {}
4107 void f() { b::c::X^ }
4108 }
4109 )cpp",
4110 {cls("a::b::c::XYZ")}, Opts);
4111 EXPECT_THAT(Results.Completions,
4112 UnorderedElementsAre(AllOf(qualifier(""), named("XYZ"))));
4113}
4114
4115// Clang parser gets confused here and doesn't report the ns:: prefix.
4116// Naive behavior is to insert it again. We examine the source and recover.
4117TEST(CompletionTest, NamespaceDoubleInsertion) {
4118 clangd::CodeCompleteOptions Opts = {};
4119
4120 auto Results = completions(R"cpp(
4121 namespace foo {
4122 namespace ns {}
4123 #define M(X) < X
4124 M(ns::ABC^
4125 }
4126 )cpp",
4127 {cls("foo::ns::ABCDE")}, Opts);
4128 EXPECT_THAT(Results.Completions,
4129 UnorderedElementsAre(AllOf(qualifier(""), named("ABCDE"))));
4130}
4131
4132TEST(CompletionTest, DerivedMethodsAreAlwaysVisible) {
4133 // Despite the fact that base method matches the ref-qualifier better,
4134 // completion results should only include the derived method.
4135 auto Completions = completions(R"cpp(
4136 struct deque_base {
4137 float size();
4138 double size() const;
4139 };
4140 struct deque : deque_base {
4141 int size() const;
4142 };
4143
4144 auto x = deque().^
4145 )cpp")
4146 .Completions;
4147 EXPECT_THAT(Completions,
4148 ElementsAre(AllOf(returnType("int"), named("size"))));
4149}
4150
4151TEST(CompletionTest, NoCrashWithIncompleteLambda) {
4152 auto Completions = completions("auto&& x = []{^").Completions;
4153 // The completion of x itself can cause a problem: in the code completion
4154 // callback, its type is not known, which affects the linkage calculation.
4155 // A bad linkage value gets cached, and subsequently updated.
4156 EXPECT_THAT(Completions, Contains(named("x")));
4157
4158 auto Signatures = signatures("auto x() { x(^").signatures;
4159 EXPECT_THAT(Signatures, Contains(sig("x() -> auto")));
4160}
4161
4162TEST(CompletionTest, DelayedTemplateParsing) {
4163 Annotations Test(R"cpp(
4164 int xxx;
4165 template <typename T> int foo() { return xx^; }
4166 )cpp");
4167 auto TU = TestTU::withCode(Test.code());
4168 // Even though delayed-template-parsing is on, we will disable it to provide
4169 // completion in templates.
4170 TU.ExtraArgs.push_back("-fdelayed-template-parsing");
4171
4172 EXPECT_THAT(completions(TU, Test.point()).Completions,
4173 Contains(named("xxx")));
4174}
4175
4176TEST(CompletionTest, CompletionRange) {
4177 const char *WithRange = "auto x = [[abc]]^";
4178 auto Completions = completions(WithRange);
4179 EXPECT_EQ(Completions.InsertRange, Annotations(WithRange).range());
4180 Completions = completionsNoCompile(WithRange);
4181 EXPECT_EQ(Completions.InsertRange, Annotations(WithRange).range());
4182
4183 const char *EmptyRange = "auto x = [[]]^";
4184 Completions = completions(EmptyRange);
4185 EXPECT_EQ(Completions.InsertRange, Annotations(EmptyRange).range());
4186 Completions = completionsNoCompile(EmptyRange);
4187 EXPECT_EQ(Completions.InsertRange, Annotations(EmptyRange).range());
4188
4189 // Sema doesn't trigger at all here, while the no-sema completion runs
4190 // heuristics as normal and reports a range. It'd be nice to be consistent.
4191 const char *NoCompletion = "/* foo [[]]^ */";
4192 Completions = completions(NoCompletion);
4193 EXPECT_EQ(Completions.InsertRange, std::nullopt);
4194 Completions = completionsNoCompile(NoCompletion);
4195 EXPECT_EQ(Completions.InsertRange, Annotations(NoCompletion).range());
4196}
4197
4198TEST(CompletionTest, ReplaceRange) {
4199 clangd::CodeCompleteOptions Opts;
4200 Opts.EnableInsertReplace = true;
4201
4202 // Cursor at end of token: insert == replace.
4203 const char *EndOfToken =
4204 "struct S { int abc; }; void f() { S s; s.[[abc]]^; }";
4205 CodeCompleteResult Completions =
4206 completions(EndOfToken, /*IndexSymbols=*/{}, Opts);
4207 Annotations A(EndOfToken);
4208 EXPECT_EQ(Completions.InsertRange, A.range());
4209 EXPECT_EQ(Completions.ReplaceRange, A.range());
4210
4211 // Cursor mid-word: replace extends past cursor.
4212 const char *MidWord = "struct S { int abcd; }; void f() { S s; "
4213 "s.$replace[[$insert[[ab^]]cd]]; }";
4214 Completions = completions(MidWord, /*IndexSymbols=*/{}, Opts);
4215 A = Annotations(MidWord);
4216 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4217 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4218
4219 // Empty prefix: insert range is empty, replace covers the word.
4220 const char *EmptyPrefix = "struct S { int abcd; }; void f() { S s; "
4221 "s.$replace[[$insert[[^]]abcd]]; }";
4222 Completions = completions(EmptyPrefix, /*IndexSymbols=*/{}, Opts);
4223 A = Annotations(EmptyPrefix);
4224 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4225 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4226
4227 // Cursor mid-word with UTF-8 continuation: replace extends past UTF-8.
4228 const char *MidWordUTF8 = "struct S { int naïve; }; void f() { S s; "
4229 "s.$replace[[$insert[[na^]]ïve]]; }";
4230 Completions = completions(MidWordUTF8, /*IndexSymbols=*/{}, Opts);
4231 A = Annotations(MidWordUTF8);
4232 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4233 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4234
4235 // Replace range stops at '(' (method call).
4236 const char *BeforeParen = "struct S { int abcd(); }; void f() { S s; "
4237 "s.$replace[[$insert[[ab^]]cd]](123); }";
4238 Completions = completions(BeforeParen, /*IndexSymbols=*/{}, Opts);
4239 A = Annotations(BeforeParen);
4240 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4241 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4242
4243 // Replace range stops at '<' (template arguments).
4244 const char *BeforeAngle =
4245 "struct S { template <typename T> int abcd(); }; void f() { S s; "
4246 "s.$replace[[$insert[[ab^]]cd]]<int>(); }";
4247 Completions = completions(BeforeAngle, /*IndexSymbols=*/{}, Opts);
4248 A = Annotations(BeforeAngle);
4249 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4250 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4251
4252 // Replace range stops at ' ' (before '=').
4253 const char *BeforeEquals =
4254 "void f() { int $replace[[$insert[[ab^]]cd]] = 1; }";
4255 Completions = completions(BeforeEquals, /*IndexSymbols=*/{}, Opts);
4256 A = Annotations(BeforeEquals);
4257 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4258 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4259
4260 // EnableInsertReplace off: ReplaceRange should not be set.
4261 Opts.EnableInsertReplace = false;
4262 const char *NoReplace = "auto x = [[abc]]^";
4263 Completions = completions(NoReplace, /*IndexSymbols=*/{}, Opts);
4264 EXPECT_EQ(Completions.InsertRange, Annotations(NoReplace).range());
4265 EXPECT_EQ(Completions.ReplaceRange, std::nullopt);
4266}
4267
4268TEST(CompletionTest, ReplaceRangeNoCompile) {
4269 clangd::CodeCompleteOptions Opts;
4270 Opts.EnableInsertReplace = true;
4271
4272 // Cursor at end of token: insert == replace.
4273 const char *EndOfToken = "auto x = [[abc]]^";
4274 Annotations A(EndOfToken);
4275 CodeCompleteResult Results =
4276 completionsNoCompile(EndOfToken, /*IndexSymbols=*/{}, Opts);
4277 EXPECT_EQ(Results.InsertRange, A.range());
4278 EXPECT_EQ(Results.ReplaceRange, A.range());
4279
4280 // Cursor mid-word: replace extends past cursor.
4281 const char *MidWord = "auto x = $replace[[$insert[[ab^]]cd]]";
4282 Results = completionsNoCompile(MidWord, /*IndexSymbols=*/{}, Opts);
4283 A = Annotations(MidWord);
4284 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4285 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4286
4287 // Empty prefix: insert range is empty, replace covers the word.
4288 const char *EmptyPrefix = "auto x = $replace[[$insert[[^]]abcd]]";
4289 Results = completionsNoCompile(EmptyPrefix, /*IndexSymbols=*/{}, Opts);
4290 A = Annotations(EmptyPrefix);
4291 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4292 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4293
4294 // ASCII heuristic stops at non-ASCII: replace doesn't extend past UTF-8.
4295 const char *MidWordUTF8 = "auto x = $replace[[$insert[[na^]]]]ïve";
4296 Results = completionsNoCompile(MidWordUTF8, /*IndexSymbols=*/{}, Opts);
4297 A = Annotations(MidWordUTF8);
4298 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4299 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4300
4301 // Replace range stops at '(' (method call).
4302 const char *BeforeParen = "auto x = $replace[[$insert[[ab^]]cd]](123);";
4303 Results = completionsNoCompile(BeforeParen, /*IndexSymbols=*/{}, Opts);
4304 A = Annotations(BeforeParen);
4305 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4306 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4307
4308 // Replace range stops at '<' (template arguments).
4309 const char *BeforeAngle = "auto x = $replace[[$insert[[ab^]]cd]]<int>();";
4310 Results = completionsNoCompile(BeforeAngle, /*IndexSymbols=*/{}, Opts);
4311 A = Annotations(BeforeAngle);
4312 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4313 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4314
4315 // Replace range stops at ' ' (before '=').
4316 const char *BeforeEquals = "auto $replace[[$insert[[ab^]]cd]] = 1;";
4317 Results = completionsNoCompile(BeforeEquals, /*IndexSymbols=*/{}, Opts);
4318 A = Annotations(BeforeEquals);
4319 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4320 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4321
4322 // EnableInsertReplace off: ReplaceRange should not be set.
4323 Opts.EnableInsertReplace = false;
4324 const char *NoReplace = "auto x = [[abc]]^";
4325 Results = completionsNoCompile(NoReplace, /*IndexSymbols=*/{}, Opts);
4326 EXPECT_EQ(Results.InsertRange, Annotations(NoReplace).range());
4327 EXPECT_EQ(Results.ReplaceRange, std::nullopt);
4328}
4329
4330TEST(NoCompileCompletionTest, Basic) {
4331 auto Results = completionsNoCompile(R"cpp(
4332 void func() {
4333 int xyz;
4334 int abc;
4335 ^
4336 }
4337 )cpp");
4338 EXPECT_FALSE(Results.RanParser);
4339 EXPECT_THAT(Results.Completions,
4340 UnorderedElementsAre(named("void"), named("func"), named("int"),
4341 named("xyz"), named("abc")));
4342}
4343
4344TEST(NoCompileCompletionTest, WithFilter) {
4345 auto Results = completionsNoCompile(R"cpp(
4346 void func() {
4347 int sym1;
4348 int sym2;
4349 int xyz1;
4350 int xyz2;
4351 sy^
4352 }
4353 )cpp");
4354 EXPECT_THAT(Results.Completions,
4355 UnorderedElementsAre(named("sym1"), named("sym2")));
4356}
4357
4358TEST(NoCompileCompletionTest, WithIndex) {
4359 std::vector<Symbol> Syms = {func("xxx"), func("a::xxx"), func("ns::b::xxx"),
4360 func("c::xxx"), func("ns::d::xxx")};
4361 auto Results = completionsNoCompile(
4362 R"cpp(
4363 // Current-scopes, unqualified completion.
4364 using namespace a;
4365 namespace ns {
4366 using namespace b;
4367 void foo() {
4368 xx^
4369 }
4370 }
4371 )cpp",
4372 Syms);
4373 EXPECT_THAT(Results.Completions,
4374 UnorderedElementsAre(AllOf(qualifier(""), scope("")),
4375 AllOf(qualifier(""), scope("a::")),
4376 AllOf(qualifier(""), scope("ns::b::"))));
4378 Opts.AllScopes = true;
4379 Results = completionsNoCompile(
4380 R"cpp(
4381 // All-scopes unqualified completion.
4382 using namespace a;
4383 namespace ns {
4384 using namespace b;
4385 void foo() {
4386 xx^
4387 }
4388 }
4389 )cpp",
4390 Syms, Opts);
4391 EXPECT_THAT(Results.Completions,
4392 UnorderedElementsAre(AllOf(qualifier(""), scope("")),
4393 AllOf(qualifier(""), scope("a::")),
4394 AllOf(qualifier(""), scope("ns::b::")),
4395 AllOf(qualifier("c::"), scope("c::")),
4396 AllOf(qualifier("d::"), scope("ns::d::"))));
4397 Results = completionsNoCompile(
4398 R"cpp(
4399 // Qualified completion.
4400 using namespace a;
4401 namespace ns {
4402 using namespace b;
4403 void foo() {
4404 b::xx^
4405 }
4406 }
4407 )cpp",
4408 Syms, Opts);
4409 EXPECT_THAT(Results.Completions,
4410 ElementsAre(AllOf(qualifier(""), scope("ns::b::"))));
4411 Results = completionsNoCompile(
4412 R"cpp(
4413 // Absolutely qualified completion.
4414 using namespace a;
4415 namespace ns {
4416 using namespace b;
4417 void foo() {
4418 ::a::xx^
4419 }
4420 }
4421 )cpp",
4422 Syms, Opts);
4423 EXPECT_THAT(Results.Completions,
4424 ElementsAre(AllOf(qualifier(""), scope("a::"))));
4425}
4426
4427TEST(AllowImplicitCompletion, All) {
4428 const char *Yes[] = {
4429 "foo.^bar",
4430 "foo->^bar",
4431 "foo::^bar",
4432 " # include <^foo.h>",
4433 "#import <foo/^bar.h>",
4434 "#include_next \"^",
4435 };
4436 const char *No[] = {
4437 "foo>^bar",
4438 "foo:^bar",
4439 "foo\n^bar",
4440 "#include <foo.h> //^",
4441 "#include \"foo.h\"^",
4442 "#error <^",
4443 "#<^",
4444 };
4445 for (const char *Test : Yes) {
4446 llvm::Annotations A(Test);
4447 EXPECT_TRUE(allowImplicitCompletion(A.code(), A.point())) << Test;
4448 }
4449 for (const char *Test : No) {
4450 llvm::Annotations A(Test);
4451 EXPECT_FALSE(allowImplicitCompletion(A.code(), A.point())) << Test;
4452 }
4453}
4454
4455TEST(CompletionTest, FunctionArgsExist) {
4456 clangd::CodeCompleteOptions Opts;
4457 Opts.EnableSnippets = true;
4458 std::string Context = R"cpp(
4459 #define MACRO(x)
4460 int foo(int A);
4461 int bar();
4462 struct Object {
4463 Object(int B) {}
4464 };
4465 template <typename T>
4466 struct Container {
4467 Container(int Size) {}
4468 };
4469 )cpp";
4470 EXPECT_THAT(completions(Context + "int y = fo^", {}, Opts).Completions,
4471 UnorderedElementsAre(
4472 AllOf(labeled("foo(int A)"), snippetSuffix("(${1:int A})"))));
4473 EXPECT_THAT(
4474 completions(Context + "int y = fo^(42)", {}, Opts).Completions,
4475 UnorderedElementsAre(AllOf(labeled("foo(int A)"), snippetSuffix(""))));
4476 EXPECT_THAT(
4477 completions(Context + "int y = fo^o(42)", {}, Opts).Completions,
4478 UnorderedElementsAre(AllOf(labeled("foo(int A)"), snippetSuffix(""))));
4479 EXPECT_THAT(
4480 completions(Context + "int y = ba^", {}, Opts).Completions,
4481 UnorderedElementsAre(AllOf(labeled("bar()"), snippetSuffix("()"))));
4482 EXPECT_THAT(completions(Context + "int y = ba^()", {}, Opts).Completions,
4483 UnorderedElementsAre(AllOf(labeled("bar()"), snippetSuffix(""))));
4484 EXPECT_THAT(completions(Context + "int y = ba^r()", {}, Opts).Completions,
4485 UnorderedElementsAre(AllOf(labeled("bar()"), snippetSuffix(""))));
4486 EXPECT_THAT(
4487 completions(Context + "Object o = Obj^", {}, Opts).Completions,
4488 Contains(AllOf(labeled("Object(int B)"), snippetSuffix("(${1:int B})"),
4490 EXPECT_THAT(completions(Context + "Object o = Obj^()", {}, Opts).Completions,
4491 Contains(AllOf(labeled("Object(int B)"), snippetSuffix(""),
4493 EXPECT_THAT(
4494 completions(Context + "Container c = Cont^", {}, Opts).Completions,
4495 Contains(AllOf(labeled("Container<typename T>(int Size)"),
4496 snippetSuffix("<${1:typename T}>(${2:int Size})"),
4498 EXPECT_THAT(
4499 completions(Context + "Container c = Cont^()", {}, Opts).Completions,
4500 Contains(AllOf(labeled("Container<typename T>(int Size)"),
4501 snippetSuffix("<${1:typename T}>"),
4503 EXPECT_THAT(
4504 completions(Context + "Container c = Cont^<int>()", {}, Opts).Completions,
4505 Contains(AllOf(labeled("Container<typename T>(int Size)"),
4506 snippetSuffix(""),
4508 EXPECT_THAT(
4509 completions(Context + "Container c = Cont^ainer()", {}, Opts).Completions,
4510 Contains(AllOf(labeled("Container<typename T>(int Size)"),
4511 snippetSuffix("<${1:typename T}>"),
4513 EXPECT_THAT(completions(Context + "MAC^(2)", {}, Opts).Completions,
4514 Contains(AllOf(labeled("MACRO(x)"), snippetSuffix(""),
4516 EXPECT_THAT(completions(Context + "MAC^RO(2)", {}, Opts).Completions,
4517 Contains(AllOf(labeled("MACRO(x)"), snippetSuffix(""),
4519}
4520
4521TEST(CompletionTest, FunctionArgsExist_Issue1785) {
4522 // This is a scenario where the implementation of our check for
4523 // "is there a function argument list right after the cursor"
4524 // gave a bogus result.
4525 clangd::CodeCompleteOptions Opts;
4526 Opts.EnableSnippets = true;
4527 // The whitespace in this testcase is important!
4528 std::string Code = R"cpp(
4529void waldo(int);
4530
4531int main()
4532{
4533 wal^
4534
4535
4536 // ( )
4537}
4538 )cpp";
4539 EXPECT_THAT(
4540 completions(Code, {}, Opts).Completions,
4541 Contains(AllOf(labeled("waldo(int)"), snippetSuffix("(${1:int})"))));
4542}
4543
4544TEST(CompletionTest, NoCrashDueToMacroOrdering) {
4545 EXPECT_THAT(completions(R"cpp(
4546 #define ECHO(X) X
4547 #define ECHO2(X) ECHO(X)
4548 int finish_preamble = EC^HO(2);)cpp")
4549 .Completions,
4550 UnorderedElementsAre(labeled("ECHO(X)"), labeled("ECHO2(X)")));
4551}
4552
4553TEST(CompletionTest, ObjCCategoryDecls) {
4554 TestTU TU;
4555 TU.ExtraArgs.push_back("-xobjective-c");
4556 TU.HeaderCode = R"objc(
4557 @interface Foo
4558 @end
4559
4560 @interface Foo (FooExt1)
4561 @end
4562
4563 @interface Foo (FooExt2)
4564 @end
4565
4566 @interface Bar
4567 @end
4568
4569 @interface Bar (BarExt)
4570 @end)objc";
4571
4572 {
4573 Annotations Test(R"objc(
4574 @implementation Foo (^)
4575 @end
4576 )objc");
4577 TU.Code = Test.code().str();
4578 auto Results = completions(TU, Test.point());
4579 EXPECT_THAT(Results.Completions,
4580 UnorderedElementsAre(labeled("FooExt1"), labeled("FooExt2")));
4581 }
4582 {
4583 Annotations Test(R"objc(
4584 @interface Foo (^)
4585 @end
4586 )objc");
4587 TU.Code = Test.code().str();
4588 auto Results = completions(TU, Test.point());
4589 EXPECT_THAT(Results.Completions, UnorderedElementsAre(labeled("BarExt")));
4590 }
4591}
4592
4593TEST(CompletionTest, PreambleCodeComplete) {
4594 llvm::StringLiteral Baseline = "\n#define MACRO 12\nint num = MACRO;";
4595 llvm::StringLiteral ModifiedCC =
4596 "#include \"header.h\"\n#define MACRO 12\nint num = MACRO; int num2 = M^";
4597
4598 Annotations Test(ModifiedCC);
4599 auto BaselineTU = TestTU::withCode(Baseline);
4600 auto ModifiedTU = TestTU::withCode(Test.code());
4601
4602 MockFS FS;
4603 auto Inputs = ModifiedTU.inputs(FS);
4604 auto Result = codeComplete(testPath(ModifiedTU.Filename), Test.point(),
4605 BaselineTU.preamble().get(), Inputs, {});
4606 EXPECT_THAT(Result.Completions, Not(testing::IsEmpty()));
4607}
4608
4609TEST(CompletionTest, CommentParamName) {
4610 const std::string Code = R"cpp(
4611 void fun(int foo, int bar);
4612 void overloaded(int param_int);
4613 void overloaded(int param_int, int param_other);
4614 void overloaded(char param_char);
4615 int main() {
4616 )cpp";
4617
4618 EXPECT_THAT(completions(Code + "fun(/*^").Completions,
4619 UnorderedElementsAre(labeled("foo=*/")));
4620 EXPECT_THAT(completions(Code + "fun(1, /*^").Completions,
4621 UnorderedElementsAre(labeled("bar=*/")));
4622 EXPECT_THAT(completions(Code + "/*^").Completions, IsEmpty());
4623 // Test de-duplication.
4624 EXPECT_THAT(
4625 completions(Code + "overloaded(/*^").Completions,
4626 UnorderedElementsAre(labeled("param_int=*/"), labeled("param_char=*/")));
4627 // Comment already has some text in it.
4628 EXPECT_THAT(completions(Code + "fun(/* ^").Completions,
4629 UnorderedElementsAre(labeled("foo=*/")));
4630 EXPECT_THAT(completions(Code + "fun(/* f^").Completions,
4631 UnorderedElementsAre(labeled("foo=*/")));
4632 EXPECT_THAT(completions(Code + "fun(/* x^").Completions, IsEmpty());
4633 EXPECT_THAT(completions(Code + "fun(/* f ^").Completions, IsEmpty());
4634
4635 // Test ranges
4636 {
4637 std::string CompletionRangeTest(Code + "fun(/*[[^]]");
4638 auto Results = completions(CompletionRangeTest);
4639 EXPECT_THAT(Results.InsertRange,
4640 llvm::ValueIs(Annotations(CompletionRangeTest).range()));
4641 EXPECT_THAT(
4642 Results.Completions,
4643 testing::Each(
4644 AllOf(replacesRange(Annotations(CompletionRangeTest).range()),
4646 }
4647 {
4648 std::string CompletionRangeTest(Code + "fun(/*[[fo^]]");
4649 auto Results = completions(CompletionRangeTest);
4650 EXPECT_THAT(Results.InsertRange,
4651 llvm::ValueIs(Annotations(CompletionRangeTest).range()));
4652 EXPECT_THAT(
4653 Results.Completions,
4654 testing::Each(
4655 AllOf(replacesRange(Annotations(CompletionRangeTest).range()),
4657 }
4658
4659 // Test replace ranges (comment completion replaces up to */).
4660 clangd::CodeCompleteOptions ReplaceOpts;
4661 ReplaceOpts.EnableInsertReplace = true;
4662 {
4663 // With */ (no =): replace extends past suffix to */.
4664 const std::string NoEquals(Code + "fun(/*$replace[[$insert[[fo^]]o*/]])");
4665 const CodeCompleteResult Results = completions(NoEquals, {}, ReplaceOpts);
4666 const Annotations A(NoEquals);
4667 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4668 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4669 }
4670 {
4671 // With = and */: replace extends past = to */.
4672 const std::string WithEquals(Code +
4673 "fun(/*$replace[[$insert[[fo^]]o=*/]])");
4674 const CodeCompleteResult Results = completions(WithEquals, {}, ReplaceOpts);
4675 const Annotations A(WithEquals);
4676 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4677 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4678 }
4679 {
4680 // Without */: replace == insert.
4681 const std::string NoClose(Code + "fun(/*[[fo^]]");
4682 const CodeCompleteResult Results = completions(NoClose, {}, ReplaceOpts);
4683 const Annotations A(NoClose);
4684 EXPECT_EQ(Results.InsertRange, A.range());
4685 EXPECT_EQ(Results.ReplaceRange, A.range());
4686 }
4687 {
4688 // With */ and UTF-8 suffix: replace extends past UTF-8 to */.
4689 const std::string WithUTF8(Code + "fun(/*$replace[[$insert[[ca^]]fé=*/]])");
4690 const CodeCompleteResult Results = completions(WithUTF8, {}, ReplaceOpts);
4691 const Annotations A(WithUTF8);
4692 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4693 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4694 }
4695}
4696
4697TEST(CompletionTest, Concepts) {
4698 Annotations Code(R"cpp(
4699 template<class T>
4700 concept A = sizeof(T) <= 8;
4701
4702 template<$tparam^A U>
4703 int foo();
4704
4705 template<typename T>
4706 int bar(T t) requires $expr^A<int>;
4707
4708 template<class T>
4709 concept b = $expr^A && $expr^sizeof(T) % 2 == 0 || $expr^A && sizeof(T) == 1;
4710
4711 $toplevel^A auto i = 19;
4712
4713 template<$toplevel^A auto i> void constrainedNTTP();
4714
4715 // FIXME: The first parameter should be dropped in this case.
4716 void abbreviated($expr^A auto x) {}
4717 )cpp");
4718 TestTU TU;
4719 TU.Code = Code.code().str();
4720 TU.ExtraArgs = {"-std=c++20"};
4721
4722 auto Sym = conceptSym("same_as");
4723 Sym.Signature = "<typename Tp, typename Up>";
4724 Sym.CompletionSnippetSuffix = "<${1:typename Tp}, ${2:typename Up}>";
4725 std::vector<Symbol> Syms = {Sym};
4726 for (auto P : Code.points("tparam")) {
4727 ASSERT_THAT(
4728 completions(TU, P, Syms).Completions,
4729 AllOf(Contains(AllOf(named("A"), signature(""), snippetSuffix(""))),
4730 Contains(AllOf(named("same_as"), signature("<typename Up>"),
4731 snippetSuffix("<${2:typename Up}>"))),
4732 Contains(named("class")), Contains(named("typename"))))
4733 << "Completing template parameter at position " << P;
4734 }
4735
4736 for (auto P : Code.points("toplevel")) {
4737 EXPECT_THAT(
4738 completions(TU, P, Syms).Completions,
4739 AllOf(Contains(AllOf(named("A"), signature(""), snippetSuffix(""))),
4740 Contains(AllOf(named("same_as"), signature("<typename Up>"),
4741 snippetSuffix("<${2:typename Up}>")))))
4742 << "Completing 'requires' expression at position " << P;
4743 }
4744
4745 for (auto P : Code.points("expr")) {
4746 EXPECT_THAT(
4747 completions(TU, P, Syms).Completions,
4748 AllOf(Contains(AllOf(named("A"), signature("<class T>"),
4749 snippetSuffix("<${1:class T}>"))),
4750 Contains(AllOf(
4751 named("same_as"), signature("<typename Tp, typename Up>"),
4752 snippetSuffix("<${1:typename Tp}, ${2:typename Up}>")))))
4753 << "Completing 'requires' expression at position " << P;
4754 }
4755}
4756
4757TEST(SignatureHelp, DocFormat) {
4758 Annotations Code(R"cpp(
4759 // Comment `with` markup.
4760 void foo(int);
4761 void bar() { foo(^); }
4762 )cpp");
4763 for (auto DocumentationFormat :
4765 auto Sigs = signatures(Code.code(), Code.point(), /*IndexSymbols=*/{},
4766 DocumentationFormat);
4767 ASSERT_EQ(Sigs.signatures.size(), 1U);
4768 EXPECT_EQ(Sigs.signatures[0].documentation.kind, DocumentationFormat);
4769 }
4770}
4771
4772TEST(SignatureHelp, TemplateArguments) {
4773 std::string Top = R"cpp(
4774 template <typename T, int> bool foo(char);
4775 template <int I, int> bool foo(float);
4776 )cpp";
4777
4778 auto First = signatures(Top + "bool x = foo<^");
4779 EXPECT_THAT(
4780 First.signatures,
4781 UnorderedElementsAre(sig("foo<[[typename T]], [[int]]>() -> bool"),
4782 sig("foo<[[int I]], [[int]]>() -> bool")));
4783 EXPECT_EQ(First.activeParameter, 0);
4784
4785 auto Second = signatures(Top + "bool x = foo<1, ^");
4786 EXPECT_THAT(Second.signatures,
4787 ElementsAre(sig("foo<[[int I]], [[int]]>() -> bool")));
4788 EXPECT_EQ(Second.activeParameter, 1);
4789}
4790
4791TEST(CompletionTest, DoNotCrash) {
4792 llvm::StringLiteral Cases[] = {
4793 R"cpp(
4794 template <typename = int> struct Foo {};
4795 auto a = [x(3)](Foo<^>){};
4796 )cpp",
4797 };
4798 for (auto Case : Cases) {
4799 SCOPED_TRACE(Case);
4800 auto Completions = completions(Case);
4801 }
4802}
4803TEST(CompletionTest, PreambleFromDifferentTarget) {
4804 constexpr std::string_view PreambleTarget = "x86_64";
4805 constexpr std::string_view Contents =
4806 "int foo(int); int num; int num2 = foo(n^";
4807
4808 Annotations Test(Contents);
4809 auto TU = TestTU::withCode(Test.code());
4810 TU.ExtraArgs.emplace_back("-target");
4811 TU.ExtraArgs.emplace_back(PreambleTarget);
4812 auto Preamble = TU.preamble();
4813 ASSERT_TRUE(Preamble);
4814 // Switch target to wasm.
4815 TU.ExtraArgs.pop_back();
4816 TU.ExtraArgs.emplace_back("wasm32");
4817
4818 MockFS FS;
4819 auto Inputs = TU.inputs(FS);
4820 auto Result = codeComplete(testPath(TU.Filename), Test.point(),
4821 Preamble.get(), Inputs, {});
4822 auto Signatures =
4823 signatureHelp(testPath(TU.Filename), Test.point(), *Preamble, Inputs, {});
4824
4825 // Make sure we don't crash.
4826 EXPECT_THAT(Result.Completions, Not(testing::IsEmpty()));
4827 EXPECT_THAT(Signatures.signatures, Not(testing::IsEmpty()));
4828}
4829
4830TEST(CompletionTest, SkipExplicitObjectParameter) {
4831 Annotations Code(R"cpp(
4832 struct A {
4833 void foo(this auto&& self, int arg);
4834 void bar(this A self, int arg);
4835 };
4836
4837 int main() {
4838 A a {};
4839 a.$c1^;
4840 (&A::fo$c2^;
4841 (&A::ba$c3^;
4842 }
4843 )cpp");
4844
4845 // TODO: llvm/llvm-project/146649
4846 // This is incorrect behavior. Correct Result should be a variant of,
4847 // c2: signature = (auto&& self, int arg)
4848 // snippet = (${1: auto&& self}, ${2: int arg})
4849 // c3: signature = (A self, int arg)
4850 // snippet = (${1: A self}, ${2: int arg})
4851
4852 auto TU = TestTU::withCode(Code.code());
4853 TU.ExtraArgs = {"-std=c++23"};
4854
4855 auto Preamble = TU.preamble();
4856 ASSERT_TRUE(Preamble);
4857
4858 CodeCompleteOptions Opts{};
4859
4860 MockFS FS;
4861 auto Inputs = TU.inputs(FS);
4862 {
4863 auto Result = codeComplete(testPath(TU.Filename), Code.point("c1"),
4864 Preamble.get(), Inputs, Opts);
4865
4866 EXPECT_THAT(Result.Completions,
4867 UnorderedElementsAre(AllOf(named("foo"), signature("(int arg)"),
4868 snippetSuffix("(${1:int arg})")),
4869 AllOf(named("bar"), signature("(int arg)"),
4870 snippetSuffix("(${1:int arg})"))));
4871 }
4872 {
4873 auto Result = codeComplete(testPath(TU.Filename), Code.point("c2"),
4874 Preamble.get(), Inputs, Opts);
4875 EXPECT_THAT(
4876 Result.Completions,
4877 ElementsAre(AllOf(named("foo"), signature("<class self:auto>(int arg)"),
4878 snippetSuffix("<${1:class self:auto}>"))));
4879 }
4880 {
4881 auto Result = codeComplete(testPath(TU.Filename), Code.point("c3"),
4882 Preamble.get(), Inputs, Opts);
4883 EXPECT_THAT(Result.Completions,
4884 ElementsAre(AllOf(named("bar"), signature("(int arg)"),
4885 snippetSuffix(""))));
4886 }
4887}
4888
4889TEST(CompletionTest, MemberAccessInExplicitObjMemfn) {
4890 Annotations Code(R"cpp(
4891 struct A {
4892 int member {};
4893 int memberFnA(int a);
4894 int memberFnA(this A&, float a);
4895
4896 void foo(this A& self) {
4897 // Should not offer any members here, since
4898 // it needs to be referenced through `self`.
4899 mem$c1^;
4900 // should offer all results
4901 self.mem$c2^;
4902
4903 [&]() {
4904 // should not offer any results
4905 mem$c3^;
4906 }();
4907 }
4908 };
4909 )cpp");
4910
4911 auto TU = TestTU::withCode(Code.code());
4912 TU.ExtraArgs = {"-std=c++23"};
4913
4914 auto Preamble = TU.preamble();
4915 ASSERT_TRUE(Preamble);
4916
4917 CodeCompleteOptions Opts{};
4918
4919 MockFS FS;
4920 auto Inputs = TU.inputs(FS);
4921
4922 {
4923 auto Result = codeComplete(testPath(TU.Filename), Code.point("c1"),
4924 Preamble.get(), Inputs, Opts);
4925
4926 EXPECT_THAT(Result.Completions, ElementsAre());
4927 }
4928 {
4929 auto Result = codeComplete(testPath(TU.Filename), Code.point("c2"),
4930 Preamble.get(), Inputs, Opts);
4931
4932 EXPECT_THAT(
4933 Result.Completions,
4934 UnorderedElementsAre(named("member"),
4935 AllOf(named("memberFnA"), signature("(int a)"),
4936 snippetSuffix("(${1:int a})")),
4937 AllOf(named("memberFnA"), signature("(float a)"),
4938 snippetSuffix("(${1:float a})"))));
4939 }
4940 {
4941 auto Result = codeComplete(testPath(TU.Filename), Code.point("c3"),
4942 Preamble.get(), Inputs, Opts);
4943
4944 EXPECT_THAT(Result.Completions, ElementsAre());
4945 }
4946}
4947
4948TEST(CompletionTest, ListExplicitObjectOverloads) {
4949 Annotations Code(R"cpp(
4950 struct S {
4951 void foo1(int a);
4952 void foo2(int a) const;
4953 void foo2(this const S& self, float a);
4954 void foo3(this const S& self, int a);
4955 void foo4(this S& self, int a);
4956 };
4957
4958 void S::foo1(int a) {
4959 this->$c1^;
4960 }
4961
4962 void S::foo2(int a) const {
4963 this->$c2^;
4964 }
4965
4966 void S::foo3(this const S& self, int a) {
4967 self.$c3^;
4968 }
4969
4970 void S::foo4(this S& self, int a) {
4971 self.$c4^;
4972 }
4973
4974 void test1(S s) {
4975 s.$c5^;
4976 }
4977
4978 void test2(const S s) {
4979 s.$c6^;
4980 }
4981 )cpp");
4982
4983 auto TU = TestTU::withCode(Code.code());
4984 TU.ExtraArgs = {"-std=c++23"};
4985
4986 auto Preamble = TU.preamble();
4987 ASSERT_TRUE(Preamble);
4988
4989 CodeCompleteOptions Opts{};
4990
4991 MockFS FS;
4992 auto Inputs = TU.inputs(FS);
4993
4994 {
4995 auto Result = codeComplete(testPath(TU.Filename), Code.point("c1"),
4996 Preamble.get(), Inputs, Opts);
4997 EXPECT_THAT(
4998 Result.Completions,
4999 UnorderedElementsAre(AllOf(named("foo1"), signature("(int a)"),
5000 snippetSuffix("(${1:int a})")),
5001 AllOf(named("foo2"), signature("(int a) const"),
5002 snippetSuffix("(${1:int a})")),
5003 AllOf(named("foo2"), signature("(float a) const"),
5004 snippetSuffix("(${1:float a})")),
5005 AllOf(named("foo3"), signature("(int a) const"),
5006 snippetSuffix("(${1:int a})")),
5007 AllOf(named("foo4"), signature("(int a)"),
5008 snippetSuffix("(${1:int a})"))));
5009 }
5010 {
5011 auto Result = codeComplete(testPath(TU.Filename), Code.point("c2"),
5012 Preamble.get(), Inputs, Opts);
5013 EXPECT_THAT(
5014 Result.Completions,
5015 UnorderedElementsAre(AllOf(named("foo2"), signature("(int a) const"),
5016 snippetSuffix("(${1:int a})")),
5017 AllOf(named("foo2"), signature("(float a) const"),
5018 snippetSuffix("(${1:float a})")),
5019 AllOf(named("foo3"), signature("(int a) const"),
5020 snippetSuffix("(${1:int a})"))));
5021 }
5022 {
5023 auto Result = codeComplete(testPath(TU.Filename), Code.point("c3"),
5024 Preamble.get(), Inputs, Opts);
5025 EXPECT_THAT(
5026 Result.Completions,
5027 UnorderedElementsAre(AllOf(named("foo2"), signature("(int a) const"),
5028 snippetSuffix("(${1:int a})")),
5029 AllOf(named("foo2"), signature("(float a) const"),
5030 snippetSuffix("(${1:float a})")),
5031 AllOf(named("foo3"), signature("(int a) const"),
5032 snippetSuffix("(${1:int a})"))));
5033 }
5034 {
5035 auto Result = codeComplete(testPath(TU.Filename), Code.point("c4"),
5036 Preamble.get(), Inputs, Opts);
5037 EXPECT_THAT(
5038 Result.Completions,
5039 UnorderedElementsAre(AllOf(named("foo1"), signature("(int a)"),
5040 snippetSuffix("(${1:int a})")),
5041 AllOf(named("foo2"), signature("(int a) const"),
5042 snippetSuffix("(${1:int a})")),
5043 AllOf(named("foo2"), signature("(float a) const"),
5044 snippetSuffix("(${1:float a})")),
5045 AllOf(named("foo3"), signature("(int a) const"),
5046 snippetSuffix("(${1:int a})")),
5047 AllOf(named("foo4"), signature("(int a)"),
5048 snippetSuffix("(${1:int a})"))));
5049 }
5050 {
5051 auto Result = codeComplete(testPath(TU.Filename), Code.point("c5"),
5052 Preamble.get(), Inputs, Opts);
5053 EXPECT_THAT(
5054 Result.Completions,
5055 UnorderedElementsAre(AllOf(named("foo1"), signature("(int a)"),
5056 snippetSuffix("(${1:int a})")),
5057 AllOf(named("foo2"), signature("(int a) const"),
5058 snippetSuffix("(${1:int a})")),
5059 AllOf(named("foo2"), signature("(float a) const"),
5060 snippetSuffix("(${1:float a})")),
5061 AllOf(named("foo3"), signature("(int a) const"),
5062 snippetSuffix("(${1:int a})")),
5063 AllOf(named("foo4"), signature("(int a)"),
5064 snippetSuffix("(${1:int a})"))));
5065 }
5066 {
5067 auto Result = codeComplete(testPath(TU.Filename), Code.point("c6"),
5068 Preamble.get(), Inputs, Opts);
5069 EXPECT_THAT(
5070 Result.Completions,
5071 UnorderedElementsAre(AllOf(named("foo2"), signature("(int a) const"),
5072 snippetSuffix("(${1:int a})")),
5073 AllOf(named("foo2"), signature("(float a) const"),
5074 snippetSuffix("(${1:float a})")),
5075 AllOf(named("foo3"), signature("(int a) const"),
5076 snippetSuffix("(${1:int a})"))));
5077 }
5078}
5079
5080TEST(CompletionTest, FuzzyMatchMacro) {
5081 Annotations Code(R"cpp(
5082 #define gl_foo() 42
5083 #define _gl_foo() 42
5084 #define glfbar() 42
5085
5086 int gl_frob();
5087 int _gl_frob();
5088
5089 int main() {
5090 int y = glf$c1^;
5091 int y = _gl$c2^;
5092 }
5093 )cpp");
5094
5095 auto TU = TestTU::withCode(Code.code());
5096
5097 // Exact prefix should match macro or symbol
5098 {
5099 CodeCompleteOptions Opts{};
5100 EXPECT_EQ(Opts.MacroFilter, Config::MacroFilterPolicy::ExactPrefix);
5101
5102 {
5103 auto Results = completions(TU, Code.point("c1"), {}, Opts);
5104 EXPECT_THAT(
5105 Results.Completions,
5106 ElementsAre(named("gl_frob"), named("_gl_frob"), named("glfbar")));
5107 }
5108
5109 {
5110 auto Results = completions(TU, Code.point("c2"), {}, Opts);
5111 EXPECT_THAT(Results.Completions,
5112 ElementsAre(named("_gl_frob"), named("_gl_foo")));
5113 }
5114 }
5115
5116 // but with fuzzy match
5117 {
5118 CodeCompleteOptions Opts{};
5119 Opts.MacroFilter = Config::MacroFilterPolicy::FuzzyMatch;
5120
5121 // don't suggest underscore macros in general,
5122 {
5123 auto Results = completions(TU, Code.point("c1"), {}, Opts);
5124 EXPECT_THAT(Results.Completions,
5125 ElementsAre(named("gl_frob"), named("_gl_frob"),
5126 named("glfbar"), named("gl_foo")));
5127 }
5128
5129 // but do suggest when macro contains exact prefix
5130 {
5131 auto Results = completions(TU, Code.point("c2"), {}, Opts);
5132 EXPECT_THAT(Results.Completions,
5133 ElementsAre(named("_gl_frob"), named("_gl_foo")));
5134 }
5135 }
5136}
5137
5138} // namespace
5139} // namespace clangd
5140} // namespace clang
#define EXPECT_IFF(condition, value, matcher)
Same as llvm::Annotations, but adjusts functions to LSP-specific types for positions and ranges.
Definition Annotations.h:23
clangd::Range range(llvm::StringRef Name="") const
Manages a collection of source files and derived data (ASTs, indexes), and provides language-aware fe...
A context is an immutable container for per-request data that must be propagated through layers that ...
Definition Context.h:69
static std::unique_ptr< SymbolIndex > build(SymbolSlab Symbols, RefSlab Refs, RelationSlab Relations)
Builds an index from slabs. The index takes ownership of the data.
Definition MemIndex.cpp:18
llvm::StringMap< std::string > Files
Definition TestFS.h:45
An efficient structure of storing large set of symbol references in memory.
Definition Ref.h:111
Interface for symbol indexes that can be used for searching or matching symbols among a set of symbol...
Definition Index.h:134
SymbolSlab::Builder is a mutable container that can 'freeze' to SymbolSlab.
Definition Symbol.h:224
void insert(const Symbol &S)
Adds a symbol, overwriting any existing one with the same ID.
Definition Symbol.cpp:52
static llvm::Expected< URI > create(llvm::StringRef AbsolutePath, llvm::StringRef Scheme)
Creates a URI for a file in the given scheme.
Definition URI.cpp:208
WithContextValue extends Context::current() with a single value.
Definition Context.h:200
FIXME: Skip testing on windows temporarily due to the different escaping code mode.
Definition AST.cpp:44
Symbol objcProtocol(llvm::StringRef Name)
Symbol objcClass(llvm::StringRef Name)
Symbol func(llvm::StringRef Name)
Definition TestIndex.cpp:62
Symbol cls(llvm::StringRef Name)
Definition TestIndex.cpp:66
Symbol objcCategory(llvm::StringRef Name, llvm::StringRef CategoryName)
std::string sortText(float Score, llvm::StringRef Name)
Returns a string that sorts in the same order as (-Score, Tiebreak), for LSP.
Definition Quality.cpp:552
Symbol conceptSym(llvm::StringRef Name)
Definition TestIndex.cpp:86
IndexContents
Describes what data is covered by an index.
Definition Index.h:114
size_t lspLength(llvm::StringRef Code)
CompletionPrefix guessCompletionPrefix(llvm::StringRef Content, unsigned Offset)
std::unique_ptr< CompilerInvocation > buildCompilerInvocation(const ParseInputs &Inputs, clang::DiagnosticConsumer &D, std::vector< std::string > *CC1Args)
Builds compiler invocation that could be used to build AST or preamble.
Definition Compiler.cpp:96
Symbol sym(llvm::StringRef QName, index::SymbolKind Kind, llvm::StringRef USRFormat, llvm::StringRef Signature)
Definition TestIndex.cpp:40
CompletionItemKind
The kind of a completion entry.
Definition Protocol.h:351
Symbol ns(llvm::StringRef Name)
Definition TestIndex.cpp:82
bool allowImplicitCompletion(llvm::StringRef Content, unsigned Offset)
llvm::unique_function< void(llvm::Expected< T >)> Callback
A Callback<T> is a void function that accepts Expected<T>.
Definition Function.h:28
llvm::raw_ostream & operator<<(llvm::raw_ostream &OS, const CodeCompletion &C)
llvm::Expected< CodeCompleteResult > runCodeComplete(ClangdServer &Server, PathRef File, Position Pos, clangd::CodeCompleteOptions Opts)
Definition SyncAPI.cpp:72
MATCHER_P(named, N, "")
llvm::Expected< SignatureHelp > runSignatureHelp(ClangdServer &Server, PathRef File, Position Pos, MarkupKind DocumentationFormat)
Definition SyncAPI.cpp:79
std::string testPath(PathRef File, llvm::sys::path::Style Style)
Definition TestFS.cpp:94
std::shared_ptr< const PreambleData > buildPreamble(PathRef FileName, CompilerInvocation CI, const ParseInputs &Inputs, bool StoreInMemory, PreambleParsedCallback PreambleCallback, PreambleBuildStats *Stats)
Build a preamble for the new inputs unless an old one can be reused.
Definition Preamble.cpp:573
TEST(BackgroundQueueTest, Priority)
void wait(std::unique_lock< std::mutex > &Lock, std::condition_variable &CV, Deadline D)
Wait once on CV for the specified duration.
llvm::Expected< size_t > positionToOffset(llvm::StringRef Code, Position P, bool AllowColumnsBeyondLineLength)
Turn a [line, column] pair into an offset in Code.
void runAddDocument(ClangdServer &Server, PathRef File, llvm::StringRef Contents, llvm::StringRef Version, WantDiagnostics WantDiags, bool ForceRebuild)
Definition SyncAPI.cpp:17
Symbol macro(llvm::StringRef Name, llvm::StringRef ArgList)
Definition TestIndex.cpp:90
llvm::StringRef PathRef
A typedef to represent a ref to file path.
Definition Path.h:29
@ No
Diagnostics must be generated for this snapshot.
Definition TUScheduler.h:55
std::vector< std::string > lookup(const SymbolIndex &I, llvm::ArrayRef< SymbolID > IDs)
Symbol enmConstant(llvm::StringRef Name)
Definition TestIndex.cpp:74
Deadline timeoutSeconds(std::optional< double > Seconds)
Makes a deadline from a timeout in seconds. std::nullopt means wait forever.
CodeCompleteResult codeComplete(PathRef FileName, Position Pos, const PreambleData *Preamble, const ParseInputs &ParseInput, CodeCompleteOptions Opts, SpeculativeFuzzyFind *SpecFuzzyFind)
Gets code completions at a specified Pos in FileName.
@ PlainText
The primary text to be inserted is treated as a plain string.
Definition Protocol.h:1327
@ Snippet
The primary text to be inserted is treated as a snippet.
Definition Protocol.h:1337
SignatureHelp signatureHelp(PathRef FileName, Position Pos, const PreambleData &Preamble, const ParseInputs &ParseInput, MarkupKind DocumentationFormat)
Get signature help at a specified Pos in FileName.
PolySubsequenceMatcher< Args... > HasSubsequence(Args &&... M)
Symbol var(llvm::StringRef Name)
Definition TestIndex.cpp:78
cppcoreguidelines::ProBoundsAvoidUncheckedContainerAccessCheck P
===– Representation.cpp - ClangDoc Representation --------—*- C++ -*-===//
Signals derived from a valid AST of a file.
Definition ASTSignals.h:27
llvm::DenseMap< SymbolID, unsigned > ReferencedSymbols
Number of occurrences of each symbol present in the file.
Definition ASTSignals.h:29
Symbol::IncludeDirective InsertionDirective
Preferred preprocessor directive to use for inclusions by the file.
Definition ASTSignals.h:34
Represents a collection of completion items to be presented in the editor.
Definition Protocol.h:1433
Settings that express user/project preferences and control clangd behavior.
Definition Config.h:45
static clangd::Key< Config > Key
Context key which can be used to set the current Config.
Definition Config.h:49
@ None
nothing, no argument list and also NO Delimiters "()" or "<>".
Definition Config.h:142
@ Delimiters
empty pair of delimiters "()" or "<>".
Definition Config.h:146
@ OpenDelimiter
open, only opening delimiter "(" or "<".
Definition Config.h:144
Same semantics as CodeComplete::Score.
Definition Quality.h:179
std::vector< std::string > Scopes
If this is non-empty, symbols must be in at least one of the scopes (e.g.
Definition Index.h:36
Information required to run clang, e.g. to parse AST or do code completion.
Definition Compiler.h:51
int line
Line position in a document (zero-based).
Definition Protocol.h:159
int character
Character offset on a line in a document (zero-based).
Definition Protocol.h:164
Position end
The range's end position.
Definition Protocol.h:191
Represents the signature of a callable.
Definition Protocol.h:1477
Attributes of a symbol that affect how much we like it.
Definition Quality.h:56
Attributes of a symbol-query pair that affect how much we like it.
Definition Quality.h:86
The class presents a C++ symbol, e.g.
Definition Symbol.h:39
@ IndexedForCodeCompletion
Whether or not this symbol is meant to be used for the code completion.
Definition Symbol.h:141
@ Include
#include "header.h"
Definition Symbol.h:93
@ Import
#import "header.h"
Definition Symbol.h:95
SymbolID ID
The ID of the symbol.
Definition Symbol.h:41
std::vector< std::string > ExtraArgs
Definition TestTU.h:60
std::string Code
Definition TestTU.h:49
static TestTU withHeaderCode(llvm::StringRef HeaderCode)
Definition TestTU.h:42
static TestTU withCode(llvm::StringRef Code)
Definition TestTU.h:36
llvm::StringMap< std::string > AdditionalFiles
Definition TestTU.h:57
std::unique_ptr< SymbolIndex > index() const
Definition TestTU.cpp:176
Range range
The range of the text document to be manipulated.
Definition Protocol.h:247