clang-tools 23.0.0git
CodeCompleteTests.cpp
Go to the documentation of this file.
1//===-- CodeCompleteTests.cpp -----------------------------------*- C++ -*-===//
2//
3// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6//
7//===----------------------------------------------------------------------===//
8
9#include "ASTSignals.h"
10#include "Annotations.h"
11#include "ClangdServer.h"
12#include "CodeComplete.h"
13#include "Compiler.h"
14#include "Config.h"
15#include "Feature.h"
16#include "Matchers.h"
17#include "Protocol.h"
18#include "Quality.h"
19#include "SourceCode.h"
20#include "SyncAPI.h"
21#include "TestFS.h"
22#include "TestIndex.h"
23#include "TestTU.h"
24#include "index/Index.h"
25#include "index/MemIndex.h"
26#include "index/SymbolOrigin.h"
27#include "support/Threading.h"
28#include "clang/Sema/CodeCompleteConsumer.h"
29#include "clang/Tooling/CompilationDatabase.h"
30#include "llvm/ADT/StringRef.h"
31#include "llvm/Support/Error.h"
32#include "llvm/Support/Path.h"
33#include "llvm/Testing/Annotations/Annotations.h"
34#include "llvm/Testing/Support/Error.h"
35#include "llvm/Testing/Support/SupportHelpers.h"
36#include "gmock/gmock.h"
37#include "gtest/gtest.h"
38#include <condition_variable>
39#include <functional>
40#include <mutex>
41#include <vector>
42
43namespace clang {
44namespace clangd {
45
46namespace {
47using ::llvm::Failed;
48using ::testing::AllOf;
49using ::testing::Contains;
50using ::testing::ElementsAre;
51using ::testing::Field;
52using ::testing::HasSubstr;
53using ::testing::IsEmpty;
54using ::testing::Not;
55using ::testing::UnorderedElementsAre;
56using ContextKind = CodeCompletionContext::Kind;
57
58// GMock helpers for matching completion items.
59MATCHER_P(named, Name, "") { return arg.Name == Name; }
60MATCHER_P(mainFileRefs, Refs, "") { return arg.MainFileRefs == Refs; }
61MATCHER_P(scopeRefs, Refs, "") { return arg.ScopeRefsInFile == Refs; }
62MATCHER_P(nameStartsWith, Prefix, "") {
63 return llvm::StringRef(arg.Name).starts_with(Prefix);
64}
65MATCHER_P(filterText, F, "") { return arg.FilterText == F; }
66MATCHER_P(scope, S, "") { return arg.Scope == S; }
67MATCHER_P(qualifier, Q, "") { return arg.RequiredQualifier == Q; }
68MATCHER_P(labeled, Label, "") {
69 return arg.RequiredQualifier + arg.Name + arg.Signature == Label;
70}
71MATCHER_P(sigHelpLabeled, Label, "") { return arg.label == Label; }
72MATCHER_P(kind, K, "") { return arg.Kind == K; }
73MATCHER_P(doc, D, "") {
74 return arg.Documentation && arg.Documentation->asPlainText() == D;
75}
76MATCHER_P(returnType, D, "") { return arg.ReturnType == D; }
77MATCHER_P(hasInclude, IncludeHeader, "") {
78 return !arg.Includes.empty() && arg.Includes[0].Header == IncludeHeader;
79}
80MATCHER_P(insertInclude, IncludeHeader, "") {
81 return !arg.Includes.empty() && arg.Includes[0].Header == IncludeHeader &&
82 bool(arg.Includes[0].Insertion);
83}
84MATCHER_P(insertIncludeText, InsertedText, "") {
85 return !arg.Includes.empty() && arg.Includes[0].Insertion &&
86 arg.Includes[0].Insertion->newText == InsertedText;
87}
88MATCHER(insertInclude, "") {
89 return !arg.Includes.empty() && bool(arg.Includes[0].Insertion);
90}
91MATCHER_P(snippetSuffix, Text, "") { return arg.SnippetSuffix == Text; }
92MATCHER_P(origin, OriginSet, "") { return arg.Origin == OriginSet; }
93MATCHER_P(signature, S, "") { return arg.Signature == S; }
94MATCHER_P(replacesRange, Range, "") {
95 return arg.CompletionInsertRange == Range;
96}
97
98// Shorthand for Contains(named(Name)).
99Matcher<const std::vector<CodeCompletion> &> has(std::string Name) {
100 return Contains(named(std::move(Name)));
101}
102Matcher<const std::vector<CodeCompletion> &> has(std::string Name,
104 return Contains(AllOf(named(std::move(Name)), kind(K)));
105}
106MATCHER(isDocumented, "") { return arg.Documentation.has_value(); }
107MATCHER(deprecated, "") { return arg.Deprecated; }
108
109std::unique_ptr<SymbolIndex> memIndex(std::vector<Symbol> Symbols) {
111 for (const auto &Sym : Symbols)
112 Slab.insert(Sym);
113 return MemIndex::build(std::move(Slab).build(), RefSlab(), RelationSlab());
114}
115
116// Runs code completion.
117// If IndexSymbols is non-empty, an index will be built and passed to opts.
118CodeCompleteResult completions(const TestTU &TU, Position Point,
119 std::vector<Symbol> IndexSymbols = {},
120 clangd::CodeCompleteOptions Opts = {}) {
121 std::unique_ptr<SymbolIndex> OverrideIndex;
122 if (!IndexSymbols.empty()) {
123 assert(!Opts.Index && "both Index and IndexSymbols given!");
124 OverrideIndex = memIndex(std::move(IndexSymbols));
125 Opts.Index = OverrideIndex.get();
126 }
127
128 MockFS FS;
129 auto Inputs = TU.inputs(FS);
130 IgnoreDiagnostics Diags;
131 auto CI = buildCompilerInvocation(Inputs, Diags);
132 if (!CI) {
133 ADD_FAILURE() << "Couldn't build CompilerInvocation";
134 return {};
135 }
136 auto Preamble = buildPreamble(testPath(TU.Filename), *CI, Inputs,
137 /*InMemory=*/true, /*Callback=*/nullptr);
138 return codeComplete(testPath(TU.Filename), Point, Preamble.get(), Inputs,
139 Opts);
140}
141
142// Runs code completion.
143CodeCompleteResult completions(llvm::StringRef Text,
144 std::vector<Symbol> IndexSymbols = {},
145 clangd::CodeCompleteOptions Opts = {},
146 PathRef FilePath = "foo.cpp") {
147 Annotations Test(Text);
148 auto TU = TestTU::withCode(Test.code());
149 // To make sure our tests for completiopns inside templates work on Windows.
150 TU.Filename = FilePath.str();
151 return completions(TU, Test.point(), std::move(IndexSymbols),
152 std::move(Opts));
153}
154
155// Runs code completion without the clang parser.
156CodeCompleteResult completionsNoCompile(llvm::StringRef Text,
157 std::vector<Symbol> IndexSymbols = {},
158 clangd::CodeCompleteOptions Opts = {},
159 PathRef FilePath = "foo.cpp") {
160 std::unique_ptr<SymbolIndex> OverrideIndex;
161 if (!IndexSymbols.empty()) {
162 assert(!Opts.Index && "both Index and IndexSymbols given!");
163 OverrideIndex = memIndex(std::move(IndexSymbols));
164 Opts.Index = OverrideIndex.get();
165 }
166
167 MockFS FS;
168 Annotations Test(Text);
169 ParseInputs ParseInput{tooling::CompileCommand(), &FS, Test.code().str()};
170 return codeComplete(FilePath, Test.point(), /*Preamble=*/nullptr, ParseInput,
171 Opts);
172}
173
174Symbol withReferences(int N, Symbol S) {
175 S.References = N;
176 return S;
177}
178
179#if CLANGD_DECISION_FOREST
180TEST(DecisionForestRankingModel, NameMatchSanityTest) {
181 clangd::CodeCompleteOptions Opts;
182 Opts.RankingModel = CodeCompleteOptions::DecisionForest;
183 auto Results = completions(
184 R"cpp(
185struct MemberAccess {
186 int ABG();
187 int AlphaBetaGamma();
188};
189int func() { MemberAccess().ABG^ }
190)cpp",
191 /*IndexSymbols=*/{}, Opts);
192 EXPECT_THAT(Results.Completions,
193 ElementsAre(named("ABG"), named("AlphaBetaGamma")));
194}
195
196TEST(DecisionForestRankingModel, ReferencesAffectRanking) {
197 clangd::CodeCompleteOptions Opts;
198 Opts.RankingModel = CodeCompleteOptions::DecisionForest;
199 constexpr int NumReferences = 100000;
200 EXPECT_THAT(
201 completions("int main() { clang^ }",
202 {ns("clangA"), withReferences(NumReferences, func("clangD"))},
203 Opts)
204 .Completions,
205 ElementsAre(named("clangD"), named("clangA")));
206 EXPECT_THAT(
207 completions("int main() { clang^ }",
208 {withReferences(NumReferences, ns("clangA")), func("clangD")},
209 Opts)
210 .Completions,
211 ElementsAre(named("clangA"), named("clangD")));
212}
213#endif // CLANGD_DECISION_FOREST
214
215TEST(DecisionForestRankingModel, DecisionForestScorerCallbackTest) {
216 clangd::CodeCompleteOptions Opts;
217 constexpr float MagicNumber = 1234.5678f;
218 Opts.RankingModel = CodeCompleteOptions::DecisionForest;
219 Opts.DecisionForestScorer = [&](const SymbolQualitySignals &,
220 const SymbolRelevanceSignals &, float Base) {
222 Scores.Total = MagicNumber;
223 Scores.ExcludingName = MagicNumber;
224 return Scores;
225 };
226 llvm::StringRef Code = "int func() { int xyz; xy^ }";
227 auto Results = completions(Code,
228 /*IndexSymbols=*/{}, Opts);
229 ASSERT_EQ(Results.Completions.size(), 1u);
230 EXPECT_EQ(Results.Completions[0].Score.Total, MagicNumber);
231 EXPECT_EQ(Results.Completions[0].Score.ExcludingName, MagicNumber);
232
233 // Do not use DecisionForestScorer for heuristics model.
234 Opts.RankingModel = CodeCompleteOptions::Heuristics;
235 Results = completions(Code,
236 /*IndexSymbols=*/{}, Opts);
237 ASSERT_EQ(Results.Completions.size(), 1u);
238 EXPECT_NE(Results.Completions[0].Score.Total, MagicNumber);
239 EXPECT_NE(Results.Completions[0].Score.ExcludingName, MagicNumber);
240}
241
242TEST(CompletionTest, Limit) {
243 clangd::CodeCompleteOptions Opts;
244 Opts.Limit = 2;
245 auto Results = completions(R"cpp(
246struct ClassWithMembers {
247 int AAA();
248 int BBB();
249 int CCC();
250};
251
252int main() { ClassWithMembers().^ }
253 )cpp",
254 /*IndexSymbols=*/{}, Opts);
255
256 EXPECT_TRUE(Results.HasMore);
257 EXPECT_THAT(Results.Completions, ElementsAre(named("AAA"), named("BBB")));
258}
259
260TEST(CompletionTest, Filter) {
261 std::string Body = R"cpp(
262 #define MotorCar
263 int Car;
264 struct S {
265 int FooBar;
266 int FooBaz;
267 int Qux;
268 };
269 )cpp";
270
271 // Only items matching the fuzzy query are returned.
272 EXPECT_THAT(completions(Body + "int main() { S().Foba^ }").Completions,
273 AllOf(has("FooBar"), has("FooBaz"), Not(has("Qux"))));
274
275 // Macros require prefix match, either from index or AST.
276 Symbol Sym = var("MotorCarIndex");
277 Sym.SymInfo.Kind = index::SymbolKind::Macro;
278 EXPECT_THAT(
279 completions(Body + "int main() { C^ }", {Sym}).Completions,
280 AllOf(has("Car"), Not(has("MotorCar")), Not(has("MotorCarIndex"))));
281 EXPECT_THAT(completions(Body + "int main() { M^ }", {Sym}).Completions,
282 AllOf(has("MotorCar"), has("MotorCarIndex")));
283}
284
285void testAfterDotCompletion(clangd::CodeCompleteOptions Opts) {
286 auto Results = completions(
287 R"cpp(
288 int global_var;
289
290 int global_func();
291
292 // Make sure this is not in preamble.
293 #define MACRO X
294
295 struct GlobalClass {};
296
297 struct ClassWithMembers {
298 /// doc for method.
299 int method();
300
301 int field;
302 private:
303 int private_field;
304 };
305
306 int test() {
307 struct LocalClass {};
308
309 /// doc for local_var.
310 int local_var;
311
312 ClassWithMembers().^
313 }
314 )cpp",
315 {cls("IndexClass"), var("index_var"), func("index_func")}, Opts);
316
317 EXPECT_TRUE(Results.RanParser);
318 // Class members. The only items that must be present in after-dot
319 // completion.
320 EXPECT_THAT(Results.Completions,
321 AllOf(has("method"), has("field"), Not(has("ClassWithMembers")),
322 Not(has("operator=")), Not(has("~ClassWithMembers"))));
323 EXPECT_IFF(Opts.IncludeIneligibleResults, Results.Completions,
324 has("private_field"));
325 // Global items.
326 EXPECT_THAT(
327 Results.Completions,
328 Not(AnyOf(has("global_var"), has("index_var"), has("global_func"),
329 has("global_func()"), has("index_func"), has("GlobalClass"),
330 has("IndexClass"), has("MACRO"), has("LocalClass"))));
331 // There should be no code patterns (aka snippets) in after-dot
332 // completion. At least there aren't any we're aware of.
333 EXPECT_THAT(Results.Completions,
334 Not(Contains(kind(CompletionItemKind::Snippet))));
335 // Check documentation.
336 EXPECT_THAT(Results.Completions, Contains(isDocumented()));
337}
338
339void testGlobalScopeCompletion(clangd::CodeCompleteOptions Opts) {
340 auto Results = completions(
341 R"cpp(
342 int global_var;
343 int global_func();
344
345 // Make sure this is not in preamble.
346 #define MACRO X
347
348 struct GlobalClass {};
349
350 struct ClassWithMembers {
351 /// doc for method.
352 int method();
353 };
354
355 int test() {
356 struct LocalClass {};
357
358 /// doc for local_var.
359 int local_var;
360
361 ^
362 }
363 )cpp",
364 {cls("IndexClass"), var("index_var"), func("index_func")}, Opts);
365
366 EXPECT_TRUE(Results.RanParser);
367 // Class members. Should never be present in global completions.
368 EXPECT_THAT(Results.Completions,
369 Not(AnyOf(has("method"), has("method()"), has("field"))));
370 // Global items.
371 EXPECT_THAT(Results.Completions,
372 AllOf(has("global_var"), has("index_var"), has("global_func"),
373 has("index_func" /* our fake symbol doesn't include () */),
374 has("GlobalClass"), has("IndexClass")));
375 // A macro.
376 EXPECT_THAT(Results.Completions, has("MACRO"));
377 // Local items. Must be present always.
378 EXPECT_THAT(Results.Completions,
379 AllOf(has("local_var"), has("LocalClass"),
380 Contains(kind(CompletionItemKind::Snippet))));
381 // Check documentation.
382 EXPECT_THAT(Results.Completions, Contains(isDocumented()));
383}
384
385TEST(CompletionTest, CompletionOptions) {
386 auto Test = [&](const clangd::CodeCompleteOptions &Opts) {
387 testAfterDotCompletion(Opts);
388 testGlobalScopeCompletion(Opts);
389 };
390 // We used to test every combination of options, but that got too slow (2^N).
391 auto Flags = {
392 &clangd::CodeCompleteOptions::IncludeIneligibleResults,
393 };
394 // Test default options.
395 Test({});
396 // Test with one flag flipped.
397 for (auto &F : Flags) {
398 clangd::CodeCompleteOptions O;
399 O.*F ^= true;
400 Test(O);
401 }
402}
403
404TEST(CompletionTest, Accessible) {
405 auto Internal = completions(R"cpp(
406 class Foo {
407 public: void pub();
408 protected: void prot();
409 private: void priv();
410 };
411 void Foo::pub() { this->^ }
412 )cpp");
413 EXPECT_THAT(Internal.Completions,
414 AllOf(has("priv"), has("prot"), has("pub")));
415
416 auto External = completions(R"cpp(
417 class Foo {
418 public: void pub();
419 protected: void prot();
420 private: void priv();
421 };
422 void test() {
423 Foo F;
424 F.^
425 }
426 )cpp");
427 EXPECT_THAT(External.Completions,
428 AllOf(has("pub"), Not(has("prot")), Not(has("priv"))));
429
430 auto Results = completions(R"cpp(
431 struct Foo {
432 public: void pub();
433 protected: void prot();
434 private: void priv();
435 };
436 struct Bar : public Foo {
437 private: using Foo::pub;
438 };
439 void test() {
440 Bar B;
441 B.^
442 }
443 )cpp");
444 EXPECT_THAT(Results.Completions,
445 AllOf(Not(has("priv")), Not(has("prot")), Not(has("pub"))));
446}
447
448TEST(CompletionTest, Qualifiers) {
449 auto Results = completions(R"cpp(
450 class Foo {
451 public: int foo() const;
452 int bar() const;
453 };
454 class Bar : public Foo {
455 int foo() const;
456 };
457 void test() { Bar().^ }
458 )cpp");
459 EXPECT_THAT(Results.Completions,
460 Contains(AllOf(qualifier(""), named("bar"))));
461 // Hidden members are not shown.
462 EXPECT_THAT(Results.Completions,
463 Not(Contains(AllOf(qualifier("Foo::"), named("foo")))));
464 // Private members are not shown.
465 EXPECT_THAT(Results.Completions,
466 Not(Contains(AllOf(qualifier(""), named("foo")))));
467}
468
469// https://github.com/clangd/clangd/issues/1451
470TEST(CompletionTest, QualificationWithInlineNamespace) {
471 auto Results = completions(R"cpp(
472 namespace a { inline namespace b {} }
473 using namespace a::b;
474 void f() { Foo^ }
475 )cpp",
476 {cls("a::Foo")});
477 EXPECT_THAT(Results.Completions,
478 UnorderedElementsAre(AllOf(qualifier("a::"), named("Foo"))));
479}
480
481TEST(CompletionTest, InjectedTypename) {
482 // These are suppressed when accessed as a member...
483 EXPECT_THAT(completions("struct X{}; void foo(){ X().^ }").Completions,
484 Not(has("X")));
485 EXPECT_THAT(completions("struct X{ void foo(){ this->^ } };").Completions,
486 Not(has("X")));
487 // ...but accessible in other, more useful cases.
488 EXPECT_THAT(completions("struct X{ void foo(){ ^ } };").Completions,
489 has("X"));
490 EXPECT_THAT(
491 completions("struct Y{}; struct X:Y{ void foo(){ ^ } };").Completions,
492 has("Y"));
493 EXPECT_THAT(
494 completions(
495 "template<class> struct Y{}; struct X:Y<int>{ void foo(){ ^ } };")
496 .Completions,
497 has("Y"));
498 // This case is marginal (`using X::X` is useful), we allow it for now.
499 EXPECT_THAT(completions("struct X{}; void foo(){ X::^ }").Completions,
500 has("X"));
501}
502
503TEST(CompletionTest, SkipInjectedWhenUnqualified) {
504 EXPECT_THAT(completions("struct X { void f() { X^ }};").Completions,
505 ElementsAre(named("X"), named("~X")));
506}
507
508TEST(CompletionTest, Snippets) {
509 clangd::CodeCompleteOptions Opts;
510 auto Results = completions(
511 R"cpp(
512 struct fake {
513 int a;
514 int f(int i, const float f) const;
515 };
516 int main() {
517 fake f;
518 f.^
519 }
520 )cpp",
521 /*IndexSymbols=*/{}, Opts);
522 EXPECT_THAT(
523 Results.Completions,
524 HasSubsequence(named("a"),
525 snippetSuffix("(${1:int i}, ${2:const float f})")));
526}
527
528TEST(CompletionTest, HeuristicsForMemberFunctionCompletion) {
529 clangd::CodeCompleteOptions Opts;
530 Opts.EnableSnippets = true;
531
532 Annotations Code(R"cpp(
533 struct Foo {
534 static int staticMethod(int name);
535 int method(int name) const;
536 template <typename T, typename U, typename V = int>
537 T generic(U nameU, V nameV);
538 template <typename T, int U>
539 static T staticGeneric();
540 Foo() {
541 this->$canBeCallNoStatic^
542 $canBeCall^
543 Foo::$canBeCall^
544 }
545 };
546
547 int Foo::$isDefinition^ {
548 }
549 ;
550
551 int i = Foo::$canBeCallStaticOnly^
552 ;
553
554 struct Derived : Foo {
555 using Foo::method;
556 using Foo::generic;
557 Derived() {
558 Foo::$canBeCall^
559 }
560 };
561
562 struct OtherClass {
563 OtherClass() {
564 Foo f;
565 Derived d;
566 f.$canBeCallNoStatic^
567 ; // Prevent parsing as 'f.f'
568 f.Foo::$canBeCall^
569 ;
570 &Foo::$canNotBeCall^
571 ;
572 d.Foo::$canBeCall^
573 ;
574 d.Derived::$canBeCall^
575 }
576 };
577
578 int main() {
579 Foo f;
580 Derived d;
581 f.$canBeCall^
582 ; // Prevent parsing as 'f.f'
583 f.Foo::$canBeCall^
584 ;
585 &Foo::$canNotBeCall^
586 ;
587 d.Foo::$canBeCall^
588 ;
589 d.Derived::$canBeCall^
590 }
591 )cpp");
592 auto TU = TestTU::withCode(Code.code());
593
594 for (const auto &P : Code.points("canNotBeCall")) {
595 auto Results = completions(TU, P, /*IndexSymbols*/ {}, Opts);
596 EXPECT_THAT(Results.Completions,
597 Contains(AllOf(named("method"), signature("(int name) const"),
598 snippetSuffix(""))));
599 // We don't have any arguments to deduce against if this isn't a call.
600 EXPECT_THAT(
601 Results.Completions,
602 Contains(AllOf(named("generic"),
603 signature("<typename T, typename U>(U nameU, V nameV)"),
604 snippetSuffix("<${1:typename T}, ${2:typename U}>"))));
605 EXPECT_THAT(Results.Completions,
606 Contains(AllOf(named("staticMethod"), signature("(int name)"),
607 snippetSuffix(""))));
608 EXPECT_THAT(Results.Completions,
609 Contains(AllOf(
610 named("staticGeneric"), signature("<typename T, int U>()"),
611 snippetSuffix("<${1:typename T}, ${2:int U}>"))));
612 }
613
614 for (const auto &P : Code.points("canBeCall")) {
615 auto Results = completions(TU, P, /*IndexSymbols*/ {}, Opts);
616 EXPECT_THAT(Results.Completions,
617 Contains(AllOf(named("method"), signature("(int name) const"),
618 snippetSuffix("(${1:int name})"))));
619 EXPECT_THAT(
620 Results.Completions,
621 Contains(AllOf(
622 named("generic"), signature("<typename T>(U nameU, V nameV)"),
623 snippetSuffix("<${1:typename T}>(${2:U nameU}, ${3:V nameV})"))));
624 EXPECT_THAT(Results.Completions,
625 Contains(AllOf(named("staticMethod"), signature("(int name)"),
626 snippetSuffix("(${1:int name})"))));
627 EXPECT_THAT(Results.Completions,
628 Contains(AllOf(
629 named("staticGeneric"), signature("<typename T, int U>()"),
630 snippetSuffix("<${1:typename T}, ${2:int U}>()"))));
631 }
632
633 for (const auto &P : Code.points("canBeCallNoStatic")) {
634 auto Results = completions(TU, P, /*IndexSymbols*/ {}, Opts);
635 EXPECT_THAT(Results.Completions,
636 Contains(AllOf(named("method"), signature("(int name) const"),
637 snippetSuffix("(${1:int name})"))));
638 EXPECT_THAT(
639 Results.Completions,
640 Contains(AllOf(
641 named("generic"), signature("<typename T>(U nameU, V nameV)"),
642 snippetSuffix("<${1:typename T}>(${2:U nameU}, ${3:V nameV})"))));
643 }
644
645 for (const auto &P : Code.points("canBeCallStaticOnly")) {
646 auto Results = completions(TU, P, /*IndexSymbols*/ {}, Opts);
647 EXPECT_THAT(Results.Completions,
648 Contains(AllOf(named("method"), signature("(int name) const"),
649 snippetSuffix(""))));
650 EXPECT_THAT(
651 Results.Completions,
652 Contains(AllOf(named("generic"),
653 signature("<typename T, typename U>(U nameU, V nameV)"),
654 snippetSuffix("<${1:typename T}, ${2:typename U}>"))));
655 EXPECT_THAT(Results.Completions,
656 Contains(AllOf(named("staticMethod"), signature("(int name)"),
657 snippetSuffix("(${1:int name})"))));
658 EXPECT_THAT(Results.Completions,
659 Contains(AllOf(
660 named("staticGeneric"), signature("<typename T, int U>()"),
661 snippetSuffix("<${1:typename T}, ${2:int U}>()"))));
662 }
663
664 for (const auto &P : Code.points("isDefinition")) {
665 auto Results = completions(TU, P, /*IndexSymbols*/ {}, Opts);
666
667 EXPECT_THAT(Results.Completions,
668 Contains(AllOf(named("method"), signature("(int name) const"),
669 snippetSuffix("(int name) const"))));
670 EXPECT_THAT(
671 Results.Completions,
672 Contains(AllOf(named("generic"),
673 signature("<typename T, typename U>(U nameU, V nameV)"),
674 snippetSuffix("(U nameU, V nameV)"))));
675 EXPECT_THAT(Results.Completions,
676 Contains(AllOf(named("staticMethod"), signature("(int name)"),
677 snippetSuffix("(int name)"))));
678 EXPECT_THAT(Results.Completions,
679 Contains(AllOf(named("staticGeneric"),
680 signature("<typename T, int U>()"),
681 snippetSuffix("()"))));
682 }
683}
684
685TEST(CompletionTest, PrivateMemberDefinition) {
686 clangd::CodeCompleteOptions Opts;
687 Opts.EnableSnippets = true;
688 auto Results = completions(
689 R"cpp(
690 class Foo {
691 int func(int a, int b);
692 };
693 int Foo::func^
694 )cpp",
695 /*IndexSymbols=*/{}, Opts);
696 EXPECT_THAT(Results.Completions,
697 Contains(AllOf(named("func"), signature("(int a, int b)"),
698 snippetSuffix("(int a, int b)"))));
699}
700
701TEST(CompletionTest, DefaultArgsWithValues) {
702 clangd::CodeCompleteOptions Opts;
703 Opts.EnableSnippets = true;
704 auto Results = completions(
705 R"cpp(
706 struct Arg {
707 Arg(int a, int b);
708 };
709 struct Foo {
710 void foo(int x = 42, int y = 0, Arg arg = Arg(42, 0));
711 };
712 void Foo::foo^
713 )cpp",
714 /*IndexSymbols=*/{}, Opts);
715 EXPECT_THAT(Results.Completions,
716 Contains(AllOf(
717 named("foo"),
718 signature("(int x = 42, int y = 0, Arg arg = Arg(42, 0))"),
719 snippetSuffix("(int x, int y, Arg arg)"))));
720}
721
722TEST(CompletionTest, NoSnippetsInUsings) {
723 clangd::CodeCompleteOptions Opts;
724 Opts.EnableSnippets = true;
725 auto Results = completions(
726 R"cpp(
727 namespace ns {
728 int func(int a, int b);
729 }
730
731 using ns::^;
732 )cpp",
733 /*IndexSymbols=*/{}, Opts);
734 EXPECT_THAT(Results.Completions,
735 ElementsAre(AllOf(named("func"), labeled("func(int a, int b)"),
736 snippetSuffix(""))));
737
738 // Check index completions too.
739 auto Func = func("ns::func");
740 Func.CompletionSnippetSuffix = "(${1:int a}, ${2: int b})";
741 Func.Signature = "(int a, int b)";
742 Func.ReturnType = "void";
743
744 Results = completions(R"cpp(
745 namespace ns {}
746 using ns::^;
747 )cpp",
748 /*IndexSymbols=*/{Func}, Opts);
749 EXPECT_THAT(Results.Completions,
750 ElementsAre(AllOf(named("func"), labeled("func(int a, int b)"),
751 snippetSuffix(""))));
752
753 // Check all-scopes completions too.
754 Opts.AllScopes = true;
755 Results = completions(R"cpp(
756 using ^;
757 )cpp",
758 /*IndexSymbols=*/{Func}, Opts);
759 EXPECT_THAT(Results.Completions,
760 Contains(AllOf(named("func"), labeled("ns::func(int a, int b)"),
761 snippetSuffix(""))));
762}
763
764TEST(CompletionTest, Kinds) {
765 auto Results = completions(
766 R"cpp(
767 int variable;
768 struct Struct {};
769 int function();
770 // make sure MACRO is not included in preamble.
771 #define MACRO 10
772 int X = ^
773 )cpp",
774 {func("indexFunction"), var("indexVariable"), cls("indexClass"),
775 macro("indexObjMacro"), macro("indexFuncMacro", "(x, y)")});
776 EXPECT_THAT(Results.Completions,
777 AllOf(has("function", CompletionItemKind::Function),
778 has("variable", CompletionItemKind::Variable),
779 has("int", CompletionItemKind::Keyword),
780 has("Struct", CompletionItemKind::Struct),
781 has("MACRO", CompletionItemKind::Constant),
782 has("indexFunction", CompletionItemKind::Function),
783 has("indexVariable", CompletionItemKind::Variable),
784 has("indexClass", CompletionItemKind::Class),
785 has("indexObjMacro", CompletionItemKind::Constant),
786 has("indexFuncMacro", CompletionItemKind::Function)));
787
788 Results = completions("nam^");
789 EXPECT_THAT(Results.Completions,
790 has("namespace", CompletionItemKind::Snippet));
791
792 // Members of anonymous unions are of kind 'field'.
793 Results = completions(
794 R"cpp(
795 struct X{
796 union {
797 void *a;
798 };
799 };
800 auto u = X().^
801 )cpp");
802 EXPECT_THAT(
803 Results.Completions,
804 UnorderedElementsAre(AllOf(named("a"), kind(CompletionItemKind::Field))));
805
806 // Completion kinds for templates should not be unknown.
807 Results = completions(
808 R"cpp(
809 template <class T> struct complete_class {};
810 template <class T> void complete_function();
811 template <class T> using complete_type_alias = int;
812 template <class T> int complete_variable = 10;
813
814 struct X {
815 template <class T> static int complete_static_member = 10;
816
817 static auto x = complete_^
818 }
819 )cpp");
820 EXPECT_THAT(
821 Results.Completions,
822 UnorderedElementsAre(
823 AllOf(named("complete_class"), kind(CompletionItemKind::Class)),
824 AllOf(named("complete_function"), kind(CompletionItemKind::Function)),
825 AllOf(named("complete_type_alias"),
827 AllOf(named("complete_variable"), kind(CompletionItemKind::Variable)),
828 AllOf(named("complete_static_member"),
830
831 Results = completions(
832 R"cpp(
833 enum Color {
834 Red
835 };
836 Color u = ^
837 )cpp");
838 EXPECT_THAT(
839 Results.Completions,
840 Contains(AllOf(named("Red"), kind(CompletionItemKind::EnumMember))));
841}
842
843TEST(CompletionTest, NoDuplicates) {
844 auto Results = completions(
845 R"cpp(
846 class Adapter {
847 };
848
849 void f() {
850 Adapter^
851 }
852 )cpp",
853 {cls("Adapter")});
854
855 // Make sure there are no duplicate entries of 'Adapter'.
856 EXPECT_THAT(Results.Completions, ElementsAre(named("Adapter")));
857}
858
859TEST(CompletionTest, ScopedNoIndex) {
860 auto Results = completions(
861 R"cpp(
862 namespace fake { int BigBang, Babble, Box; };
863 int main() { fake::ba^ }
864 ")cpp");
865 // Babble is a better match than BigBang. Box doesn't match at all.
866 EXPECT_THAT(Results.Completions,
867 ElementsAre(named("Babble"), named("BigBang")));
868}
869
870TEST(CompletionTest, Scoped) {
871 auto Results = completions(
872 R"cpp(
873 namespace fake { int Babble, Box; };
874 int main() { fake::ba^ }
875 ")cpp",
876 {var("fake::BigBang")});
877 EXPECT_THAT(Results.Completions,
878 ElementsAre(named("Babble"), named("BigBang")));
879}
880
881TEST(CompletionTest, ScopedWithFilter) {
882 auto Results = completions(
883 R"cpp(
884 void f() { ns::x^ }
885 )cpp",
886 {cls("ns::XYZ"), func("ns::foo")});
887 EXPECT_THAT(Results.Completions, UnorderedElementsAre(named("XYZ")));
888}
889
890TEST(CompletionTest, ReferencesAffectRanking) {
891 EXPECT_THAT(completions("int main() { abs^ }", {func("absA"), func("absB")})
892 .Completions,
893 HasSubsequence(named("absA"), named("absB")));
894 EXPECT_THAT(completions("int main() { abs^ }",
895 {func("absA"), withReferences(1000, func("absB"))})
896 .Completions,
897 HasSubsequence(named("absB"), named("absA")));
898}
899
900TEST(CompletionTest, ContextWords) {
901 auto Results = completions(R"cpp(
902 enum class Color { RED, YELLOW, BLUE };
903
904 // (blank lines so the definition above isn't "context")
905
906 // "It was a yellow car," he said. "Big yellow car, new."
907 auto Finish = Color::^
908 )cpp");
909 // Yellow would normally sort last (alphabetic).
910 // But the recent mention should bump it up.
911 ASSERT_THAT(Results.Completions,
912 HasSubsequence(named("YELLOW"), named("BLUE")));
913}
914
915TEST(CompletionTest, GlobalQualified) {
916 auto Results = completions(
917 R"cpp(
918 void f() { ::^ }
919 )cpp",
920 {cls("XYZ")});
921 EXPECT_THAT(Results.Completions,
922 AllOf(has("XYZ", CompletionItemKind::Class),
924}
925
926TEST(CompletionTest, FullyQualified) {
927 auto Results = completions(
928 R"cpp(
929 namespace ns { void bar(); }
930 void f() { ::ns::^ }
931 )cpp",
932 {cls("ns::XYZ")});
933 EXPECT_THAT(Results.Completions,
934 AllOf(has("XYZ", CompletionItemKind::Class),
935 has("bar", CompletionItemKind::Function)));
936}
937
938TEST(CompletionTest, SemaIndexMerge) {
939 auto Results = completions(
940 R"cpp(
941 namespace ns { int local; void both(); }
942 void f() { ::ns::^ }
943 )cpp",
944 {func("ns::both"), cls("ns::Index")});
945 // We get results from both index and sema, with no duplicates.
946 EXPECT_THAT(Results.Completions,
947 UnorderedElementsAre(
948 AllOf(named("local"), origin(SymbolOrigin::AST)),
949 AllOf(named("Index"), origin(SymbolOrigin::Static)),
950 AllOf(named("both"),
952}
953
954TEST(CompletionTest, SemaIndexMergeWithLimit) {
955 clangd::CodeCompleteOptions Opts;
956 Opts.Limit = 1;
957 auto Results = completions(
958 R"cpp(
959 namespace ns { int local; void both(); }
960 void f() { ::ns::^ }
961 )cpp",
962 {func("ns::both"), cls("ns::Index")}, Opts);
963 EXPECT_EQ(Results.Completions.size(), Opts.Limit);
964 EXPECT_TRUE(Results.HasMore);
965}
966
967TEST(CompletionTest, IncludeInsertionPreprocessorIntegrationTests) {
968 TestTU TU;
969 TU.ExtraArgs.push_back("-I" + testPath("sub"));
970 TU.AdditionalFiles["sub/bar.h"] = "";
971 auto BarURI = URI::create(testPath("sub/bar.h")).toString();
972
973 Symbol Sym = cls("ns::X");
974 Sym.CanonicalDeclaration.FileURI = BarURI.c_str();
975 Sym.IncludeHeaders.emplace_back(BarURI, 1, Symbol::Include);
976 // Shorten include path based on search directory and insert.
977 Annotations Test("int main() { ns::^ }");
978 TU.Code = Test.code().str();
979 auto Results = completions(TU, Test.point(), {Sym});
980 EXPECT_THAT(Results.Completions,
981 ElementsAre(AllOf(named("X"), insertInclude("\"bar.h\""))));
982 // Can be disabled via option.
983 CodeCompleteOptions NoInsertion;
984 NoInsertion.InsertIncludes = Config::HeaderInsertionPolicy::NeverInsert;
985 Results = completions(TU, Test.point(), {Sym}, NoInsertion);
986 EXPECT_THAT(Results.Completions,
987 ElementsAre(AllOf(named("X"), Not(insertInclude()))));
988 // Duplicate based on inclusions in preamble.
989 Test = Annotations(R"cpp(
990 #include "sub/bar.h" // not shortest, so should only match resolved.
991 int main() { ns::^ }
992 )cpp");
993 TU.Code = Test.code().str();
994 Results = completions(TU, Test.point(), {Sym});
995 EXPECT_THAT(Results.Completions, ElementsAre(AllOf(named("X"), labeled("X"),
996 Not(insertInclude()))));
997}
998
999TEST(CompletionTest, NoIncludeInsertionWhenDeclFoundInFile) {
1000 Symbol SymX = cls("ns::X");
1001 Symbol SymY = cls("ns::Y");
1002 std::string BarHeader = testPath("bar.h");
1003 auto BarURI = URI::create(BarHeader).toString();
1004 SymX.CanonicalDeclaration.FileURI = BarURI.c_str();
1005 SymY.CanonicalDeclaration.FileURI = BarURI.c_str();
1006 SymX.IncludeHeaders.emplace_back("<bar>", 1, Symbol::Include);
1007 SymY.IncludeHeaders.emplace_back("<bar>", 1, Symbol::Include);
1008 // Shorten include path based on search directory and insert.
1009 auto Results = completions(R"cpp(
1010 namespace ns {
1011 class X;
1012 class Y {};
1013 }
1014 int main() { ns::^ }
1015 )cpp",
1016 {SymX, SymY});
1017 EXPECT_THAT(Results.Completions,
1018 ElementsAre(AllOf(named("X"), Not(insertInclude())),
1019 AllOf(named("Y"), Not(insertInclude()))));
1020}
1021
1022TEST(CompletionTest, IncludeInsertionRespectsQuotedAngledConfig) {
1023 TestTU TU;
1024 TU.ExtraArgs.push_back("-I" + testPath("sub"));
1025 TU.AdditionalFiles["sub/bar.h"] = "";
1026 auto BarURI = URI::create(testPath("sub/bar.h")).toString();
1027
1028 Symbol Sym = cls("ns::X");
1029 Sym.CanonicalDeclaration.FileURI = BarURI.c_str();
1030 Sym.IncludeHeaders.emplace_back(BarURI, 1, Symbol::Include);
1031 Annotations Test("int main() { ns::^ }");
1032 TU.Code = Test.code().str();
1033 auto Results = completions(TU, Test.point(), {Sym});
1034 // Default for a local path is quoted include
1035 EXPECT_THAT(Results.Completions,
1036 ElementsAre(AllOf(named("X"), insertInclude("\"bar.h\""))));
1037 {
1038 Config C;
1039 C.Style.AngledHeaders.push_back(
1040 [](auto header) { return header.contains("bar.h"); });
1041 WithContextValue WithCfg(Config::Key, std::move(C));
1042 Results = completions(TU, Test.point(), {Sym});
1043 EXPECT_THAT(Results.Completions,
1044 ElementsAre(AllOf(named("X"), insertInclude("<bar.h>"))));
1045 }
1046 {
1047 Config C;
1048 C.Style.QuotedHeaders.push_back(
1049 [](auto header) { return header.contains("bar.h"); });
1050 WithContextValue WithCfg(Config::Key, std::move(C));
1051 Results = completions(TU, Test.point(), {Sym});
1052 EXPECT_THAT(Results.Completions,
1053 ElementsAre(AllOf(named("X"), insertInclude("\"bar.h\""))));
1054 }
1055}
1056
1057TEST(CompletionTest, IndexSuppressesPreambleCompletions) {
1058 Annotations Test(R"cpp(
1059 #include "bar.h"
1060 namespace ns { int local; }
1061 void f() { ns::^; }
1062 void f2() { ns::preamble().$2^; }
1063 )cpp");
1064 auto TU = TestTU::withCode(Test.code());
1065 TU.AdditionalFiles["bar.h"] =
1066 R"cpp(namespace ns { struct preamble { int member; }; })cpp";
1067
1068 clangd::CodeCompleteOptions Opts = {};
1069 auto I = memIndex({var("ns::index")});
1070 Opts.Index = I.get();
1071 auto WithIndex = completions(TU, Test.point(), {}, Opts);
1072 EXPECT_THAT(WithIndex.Completions,
1073 UnorderedElementsAre(named("local"), named("index")));
1074 auto ClassFromPreamble = completions(TU, Test.point("2"), {}, Opts);
1075 EXPECT_THAT(ClassFromPreamble.Completions, Contains(named("member")));
1076
1077 Opts.Index = nullptr;
1078 auto WithoutIndex = completions(TU, Test.point(), {}, Opts);
1079 EXPECT_THAT(WithoutIndex.Completions,
1080 UnorderedElementsAre(named("local"), named("preamble")));
1081}
1082
1083// This verifies that we get normal preprocessor completions in the preamble.
1084// This is a regression test for an old bug: if we override the preamble and
1085// try to complete inside it, clang kicks our completion point just outside the
1086// preamble, resulting in always getting top-level completions.
1087TEST(CompletionTest, CompletionInPreamble) {
1088 auto Results = completions(R"cpp(
1089 #ifnd^ef FOO_H_
1090 #define BAR_H_
1091 #include <bar.h>
1092 int foo() {}
1093 #endif
1094 )cpp")
1095 .Completions;
1096 EXPECT_THAT(Results, ElementsAre(named("ifndef")));
1097}
1098
1099TEST(CompletionTest, CompletionRecoveryASTType) {
1100 auto Results = completions(R"cpp(
1101 struct S { int member; };
1102 S overloaded(int);
1103 void foo() {
1104 // No overload matches, but we have recovery-expr with the correct type.
1105 overloaded().^
1106 })cpp")
1107 .Completions;
1108 EXPECT_THAT(Results, ElementsAre(named("member")));
1109}
1110
1111TEST(CompletionTest, DynamicIndexIncludeInsertion) {
1112 MockFS FS;
1115 Opts.BuildDynamicSymbolIndex = true;
1116 ClangdServer Server(CDB, FS, Opts);
1117
1118 FS.Files[testPath("foo_header.h")] = R"cpp(
1119 #pragma once
1120 struct Foo {
1121 // Member doc
1122 int foo();
1123 };
1124 )cpp";
1125 const std::string FileContent(R"cpp(
1126 #include "foo_header.h"
1127 int Foo::foo() {
1128 return 42;
1129 }
1130 )cpp");
1131 Server.addDocument(testPath("foo_impl.cpp"), FileContent);
1132 // Wait for the dynamic index being built.
1133 ASSERT_TRUE(Server.blockUntilIdleForTest());
1134
1135 auto File = testPath("foo.cpp");
1136 Annotations Test("Foo^ foo;");
1137 runAddDocument(Server, File, Test.code());
1138 auto CompletionList =
1139 llvm::cantFail(runCodeComplete(Server, File, Test.point(), {}));
1140
1141 EXPECT_THAT(CompletionList.Completions,
1142 ElementsAre(AllOf(named("Foo"), hasInclude("\"foo_header.h\""),
1143 insertInclude())));
1144}
1145
1146TEST(CompletionTest, DynamicIndexMultiFile) {
1147 MockFS FS;
1149 auto Opts = ClangdServer::optsForTest();
1150 Opts.BuildDynamicSymbolIndex = true;
1151 ClangdServer Server(CDB, FS, Opts);
1152
1153 FS.Files[testPath("foo.h")] = R"cpp(
1154 namespace ns { class XYZ {}; void foo(int x) {} }
1155 )cpp";
1156 runAddDocument(Server, testPath("foo.cpp"), R"cpp(
1157 #include "foo.h"
1158 )cpp");
1159
1160 auto File = testPath("bar.cpp");
1161 Annotations Test(R"cpp(
1162 namespace ns {
1163 class XXX {};
1164 /// Doooc
1165 void fooooo() {}
1166 }
1167 void f() { ns::^ }
1168 )cpp");
1169 runAddDocument(Server, File, Test.code());
1170
1171 auto Results = cantFail(runCodeComplete(Server, File, Test.point(), {}));
1172 // "XYZ" and "foo" are not included in the file being completed but are still
1173 // visible through the index.
1174 EXPECT_THAT(Results.Completions, has("XYZ", CompletionItemKind::Class));
1175 EXPECT_THAT(Results.Completions, has("foo", CompletionItemKind::Function));
1176 EXPECT_THAT(Results.Completions, has("XXX", CompletionItemKind::Class));
1177 EXPECT_THAT(Results.Completions,
1178 Contains((named("fooooo"), kind(CompletionItemKind::Function),
1179 doc("Doooc"), returnType("void"))));
1180}
1181
1182TEST(CompletionTest, Documentation) {
1183 auto Results = completions(
1184 R"cpp(
1185 // Non-doxygen comment.
1186 __attribute__((annotate("custom_annotation"))) int foo();
1187 /// Doxygen comment.
1188 /// \param int a
1189 int bar(int a);
1190 /* Multi-line
1191 block comment
1192 */
1193 int baz();
1194
1195 int x = ^
1196 )cpp");
1197 EXPECT_THAT(
1198 Results.Completions,
1199 Contains(
1200 AllOf(named("foo"),
1201 doc("Annotation: custom_annotation\n\nNon-doxygen comment."))));
1202 EXPECT_THAT(
1203 Results.Completions,
1204 Contains(AllOf(named("bar"), doc("Doxygen comment.\n\\param int a"))));
1205 EXPECT_THAT(Results.Completions,
1206 Contains(AllOf(named("baz"), doc("Multi-line block comment"))));
1207}
1208
1209TEST(CompletionTest, CommentsFromSystemHeaders) {
1210 MockFS FS;
1212
1213 auto Opts = ClangdServer::optsForTest();
1214 Opts.BuildDynamicSymbolIndex = true;
1215
1216 ClangdServer Server(CDB, FS, Opts);
1217
1218 FS.Files[testPath("foo.h")] = R"cpp(
1219 #pragma GCC system_header
1220
1221 // This comment should be retained!
1222 int foo();
1223 )cpp";
1224
1225 auto File = testPath("foo.cpp");
1226 Annotations Test(R"cpp(
1227#include "foo.h"
1228int x = foo^
1229 )cpp");
1230 runAddDocument(Server, File, Test.code());
1231 auto CompletionList =
1232 llvm::cantFail(runCodeComplete(Server, File, Test.point(), {}));
1233
1234 EXPECT_THAT(
1235 CompletionList.Completions,
1236 Contains(AllOf(named("foo"), doc("This comment should be retained!"))));
1237}
1238
1239TEST(CompletionTest, CommentsOnMembersFromHeader) {
1240 MockFS FS;
1242
1243 auto Opts = ClangdServer::optsForTest();
1244 Opts.BuildDynamicSymbolIndex = true;
1245
1246 ClangdServer Server(CDB, FS, Opts);
1247
1248 FS.Files[testPath("foo.h")] = R"cpp(
1249 struct alpha {
1250 /// This is a member field.
1251 int gamma;
1252
1253 /// This is a member function.
1254 int delta();
1255 };
1256
1257 template <typename T>
1258 struct beta {
1259 /// This is a member field inside a template.
1260 int omega;
1261
1262 /// This is a member function inside a template.
1263 int epsilon();
1264 };
1265 )cpp";
1266
1267 auto File = testPath("foo.cpp");
1268 Annotations Test(R"cpp(
1269#include "foo.h"
1270alpha a;
1271beta<int> b;
1272int x = a.$p1^;
1273int y = b.$p2^;
1274 )cpp");
1275 runAddDocument(Server, File, Test.code());
1276 auto CompletionList =
1277 llvm::cantFail(runCodeComplete(Server, File, Test.point("p1"), {}));
1278
1279 EXPECT_THAT(CompletionList.Completions,
1280 Contains(AllOf(named("gamma"), doc("This is a member field."))));
1281 EXPECT_THAT(
1282 CompletionList.Completions,
1283 Contains(AllOf(named("delta"), doc("This is a member function."))));
1284
1286 llvm::cantFail(runCodeComplete(Server, File, Test.point("p2"), {}));
1287
1288 EXPECT_THAT(CompletionList.Completions,
1289 Contains(AllOf(named("omega")
1290 /* FIXME: Doc retrieval does not work yet*/)));
1291 EXPECT_THAT(
1292 CompletionList.Completions,
1293 Contains(AllOf(named("epsilon"),
1294 doc("This is a member function inside a template."))));
1295}
1296
1297TEST(CompletionTest, CommentsOnMembersFromHeaderOverloadBundling) {
1298 using testing::AnyOf;
1299 MockFS FS;
1301
1302 auto Opts = ClangdServer::optsForTest();
1303 Opts.BuildDynamicSymbolIndex = true;
1304
1305 ClangdServer Server(CDB, FS, Opts);
1306
1307 FS.Files[testPath("foo.h")] = R"cpp(
1308 struct alpha {
1309 /// bool overload.
1310 int delta(bool b);
1311
1312 /// int overload.
1313 int delta(int i);
1314
1315 void epsilon(long l);
1316
1317 /// This one has a comment.
1318 void epsilon(int i);
1319 };
1320 )cpp";
1321
1322 auto File = testPath("foo.cpp");
1323 Annotations Test(R"cpp(
1324#include "foo.h"
1325alpha a;
1326int x = a.^
1327 )cpp");
1328 runAddDocument(Server, File, Test.code());
1329 clangd::CodeCompleteOptions CCOpts;
1330 CCOpts.BundleOverloads = true;
1331 auto CompletionList =
1332 llvm::cantFail(runCodeComplete(Server, File, Test.point(), CCOpts));
1333
1334 EXPECT_THAT(
1335 CompletionList.Completions,
1336 Contains(AllOf(named("epsilon"), doc("This one has a comment."))));
1337 EXPECT_THAT(CompletionList.Completions,
1338 Contains(AllOf(named("delta"), AnyOf(doc("bool overload."),
1339 doc("int overload.")))));
1340}
1341
1342TEST(CompletionTest, GlobalCompletionFiltering) {
1343
1344 Symbol Class = cls("XYZ");
1345 Class.Flags = static_cast<Symbol::SymbolFlag>(
1347 Symbol Func = func("XYZ::foooo");
1348 Func.Flags = static_cast<Symbol::SymbolFlag>(
1349 Func.Flags & ~(Symbol::IndexedForCodeCompletion));
1350
1351 auto Results = completions(R"(// void f() {
1352 XYZ::foooo^
1353 })",
1354 {Class, Func});
1355 EXPECT_THAT(Results.Completions, IsEmpty());
1356}
1357
1358TEST(CodeCompleteTest, DisableTypoCorrection) {
1359 auto Results = completions(R"cpp(
1360 namespace clang { int v; }
1361 void f() { clangd::^
1362 )cpp");
1363 EXPECT_TRUE(Results.Completions.empty());
1364}
1365
1366TEST(CodeCompleteTest, NoColonColonAtTheEnd) {
1367 auto Results = completions(R"cpp(
1368 namespace clang { }
1369 void f() {
1370 clan^
1371 }
1372 )cpp");
1373
1374 EXPECT_THAT(Results.Completions, Contains(labeled("clang")));
1375 EXPECT_THAT(Results.Completions, Not(Contains(labeled("clang::"))));
1376}
1377
1378TEST(CompletionTests, EmptySnippetDoesNotCrash) {
1379 // See https://github.com/clangd/clangd/issues/1216
1380 auto Results = completions(R"cpp(
1381 int main() {
1382 auto w = [&](auto &&f) { return f(f); };
1383 auto f = w([&](auto &&f) {
1384 return [&](auto &&n) {
1385 if (n == 0) {
1386 return 1;
1387 }
1388 return n * ^(f)(n - 1);
1389 };
1390 })(10);
1391 }
1392 )cpp");
1393}
1394
1395TEST(CompletionTest, Issue1427Crash) {
1396 // Need to provide main file signals to ensure that the branch in
1397 // SymbolRelevanceSignals::computeASTSignals() that tries to
1398 // compute a symbol ID is taken.
1399 ASTSignals MainFileSignals;
1401 Opts.MainFileSignals = &MainFileSignals;
1402 completions(R"cpp(
1403 auto f = []() {
1404 1.0_^
1405 };
1406 )cpp",
1407 {}, Opts);
1408}
1409
1410TEST(CompletionTest, BacktrackCrashes) {
1411 // Sema calls code completion callbacks twice in these cases.
1412 auto Results = completions(R"cpp(
1413 namespace ns {
1414 struct FooBarBaz {};
1415 } // namespace ns
1416
1417 int foo(ns::FooBar^
1418 )cpp");
1419
1420 EXPECT_THAT(Results.Completions, ElementsAre(labeled("FooBarBaz")));
1421
1422 // Check we don't crash in that case too.
1423 completions(R"cpp(
1424 struct FooBarBaz {};
1425 void test() {
1426 if (FooBarBaz * x^) {}
1427 }
1428)cpp");
1429}
1430
1431TEST(CompletionTest, CompleteInMacroWithStringification) {
1432 auto Results = completions(R"cpp(
1433void f(const char *, int x);
1434#define F(x) f(#x, x)
1435
1436namespace ns {
1437int X;
1438int Y;
1439} // namespace ns
1440
1441int f(int input_num) {
1442 F(ns::^)
1443}
1444)cpp");
1445
1446 EXPECT_THAT(Results.Completions,
1447 UnorderedElementsAre(named("X"), named("Y")));
1448}
1449
1450TEST(CompletionTest, CompleteInMacroAndNamespaceWithStringification) {
1451 auto Results = completions(R"cpp(
1452void f(const char *, int x);
1453#define F(x) f(#x, x)
1454
1455namespace ns {
1456int X;
1457
1458int f(int input_num) {
1459 F(^)
1460}
1461} // namespace ns
1462)cpp");
1463
1464 EXPECT_THAT(Results.Completions, Contains(named("X")));
1465}
1466
1467TEST(CompletionTest, IgnoreCompleteInExcludedPPBranchWithRecoveryContext) {
1468 auto Results = completions(R"cpp(
1469 int bar(int param_in_bar) {
1470 }
1471
1472 int foo(int param_in_foo) {
1473#if 0
1474 // In recovery mode, "param_in_foo" will also be suggested among many other
1475 // unrelated symbols; however, this is really a special case where this works.
1476 // If the #if block is outside of the function, "param_in_foo" is still
1477 // suggested, but "bar" and "foo" are missing. So the recovery mode doesn't
1478 // really provide useful results in excluded branches.
1479 par^
1480#endif
1481 }
1482)cpp");
1483
1484 EXPECT_TRUE(Results.Completions.empty());
1485}
1486
1487TEST(CompletionTest, DefaultArgs) {
1488 clangd::CodeCompleteOptions Opts;
1489 std::string Context = R"cpp(
1490 int X(int A = 0);
1491 int Y(int A, int B = 0);
1492 int Z(int A, int B = 0, int C = 0, int D = 0);
1493 )cpp";
1494 EXPECT_THAT(completions(Context + "int y = X^", {}, Opts).Completions,
1495 UnorderedElementsAre(labeled("X(int A = 0)")));
1496 EXPECT_THAT(completions(Context + "int y = Y^", {}, Opts).Completions,
1497 UnorderedElementsAre(AllOf(labeled("Y(int A, int B = 0)"),
1498 snippetSuffix("(${1:int A})"))));
1499 EXPECT_THAT(completions(Context + "int y = Z^", {}, Opts).Completions,
1500 UnorderedElementsAre(
1501 AllOf(labeled("Z(int A, int B = 0, int C = 0, int D = 0)"),
1502 snippetSuffix("(${1:int A})"))));
1503}
1504
1505TEST(CompletionTest, NoCrashWithTemplateParamsAndPreferredTypes) {
1506 auto Completions = completions(R"cpp(
1507template <template <class> class TT> int foo() {
1508 int a = ^
1509}
1510)cpp")
1511 .Completions;
1512 EXPECT_THAT(Completions, Contains(named("TT")));
1513}
1514
1515TEST(CompletionTest, NestedTemplateHeuristics) {
1516 auto Completions = completions(R"cpp(
1517struct Plain { int xxx; };
1518template <typename T> class Templ { Plain ppp; };
1519template <typename T> void foo(Templ<T> &t) {
1520 // Formally ppp has DependentTy, because Templ may be specialized.
1521 // However we sholud be able to see into it using the primary template.
1522 t.ppp.^
1523}
1524)cpp")
1525 .Completions;
1526 EXPECT_THAT(Completions, Contains(named("xxx")));
1527}
1528
1529TEST(CompletionTest, RecordCCResultCallback) {
1530 std::vector<CodeCompletion> RecordedCompletions;
1532 Opts.RecordCCResult = [&RecordedCompletions](const CodeCompletion &CC,
1533 const SymbolQualitySignals &,
1534 const SymbolRelevanceSignals &,
1535 float Score) {
1536 RecordedCompletions.push_back(CC);
1537 };
1538
1539 completions("int xy1, xy2; int a = xy^", /*IndexSymbols=*/{}, Opts);
1540 EXPECT_THAT(RecordedCompletions,
1541 UnorderedElementsAre(named("xy1"), named("xy2")));
1542}
1543
1544TEST(CompletionTest, ASTSignals) {
1545 struct Completion {
1546 std::string Name;
1547 unsigned MainFileRefs;
1548 unsigned ScopeRefsInFile;
1549 };
1551 std::vector<Completion> RecordedCompletions;
1552 Opts.RecordCCResult = [&RecordedCompletions](const CodeCompletion &CC,
1553 const SymbolQualitySignals &,
1554 const SymbolRelevanceSignals &R,
1555 float Score) {
1556 RecordedCompletions.push_back({CC.Name, R.MainFileRefs, R.ScopeRefsInFile});
1557 };
1558 ASTSignals MainFileSignals;
1559 MainFileSignals.ReferencedSymbols[var("xy1").ID] = 3;
1560 MainFileSignals.ReferencedSymbols[var("xy2").ID] = 1;
1561 MainFileSignals.ReferencedSymbols[var("xyindex").ID] = 10;
1562 MainFileSignals.RelatedNamespaces["tar::"] = 5;
1563 MainFileSignals.RelatedNamespaces["bar::"] = 3;
1564 Opts.MainFileSignals = &MainFileSignals;
1565 Opts.AllScopes = true;
1566 completions(
1567 R"cpp(
1568 int xy1;
1569 int xy2;
1570 namespace bar {
1571 int xybar = 1;
1572 int a = xy^
1573 }
1574 )cpp",
1575 /*IndexSymbols=*/{var("xyindex"), var("tar::xytar"), var("bar::xybar")},
1576 Opts);
1577 EXPECT_THAT(RecordedCompletions,
1578 UnorderedElementsAre(
1579 AllOf(named("xy1"), mainFileRefs(3u), scopeRefs(0u)),
1580 AllOf(named("xy2"), mainFileRefs(1u), scopeRefs(0u)),
1581 AllOf(named("xyindex"), mainFileRefs(10u), scopeRefs(0u)),
1582 AllOf(named("xytar"), mainFileRefs(0u), scopeRefs(5u)),
1583 AllOf(/*both from sema and index*/ named("xybar"),
1584 mainFileRefs(0u), scopeRefs(3u))));
1585}
1586
1588signatures(llvm::StringRef Text, Position Point,
1589 std::vector<Symbol> IndexSymbols = {},
1590 MarkupKind DocumentationFormat = MarkupKind::PlainText) {
1591 std::unique_ptr<SymbolIndex> Index;
1592 if (!IndexSymbols.empty())
1593 Index = memIndex(IndexSymbols);
1594
1595 auto TU = TestTU::withCode(Text);
1596 MockFS FS;
1597 auto Inputs = TU.inputs(FS);
1598 Inputs.Index = Index.get();
1599 IgnoreDiagnostics Diags;
1600 auto CI = buildCompilerInvocation(Inputs, Diags);
1601 if (!CI) {
1602 ADD_FAILURE() << "Couldn't build CompilerInvocation";
1603 return {};
1604 }
1605 auto Preamble = buildPreamble(testPath(TU.Filename), *CI, Inputs,
1606 /*InMemory=*/true, /*Callback=*/nullptr);
1607 if (!Preamble) {
1608 ADD_FAILURE() << "Couldn't build Preamble";
1609 return {};
1610 }
1611 return signatureHelp(testPath(TU.Filename), Point, *Preamble, Inputs,
1612 DocumentationFormat);
1613}
1614
1616signatures(llvm::StringRef Text, std::vector<Symbol> IndexSymbols = {},
1617 MarkupKind DocumentationFormat = MarkupKind::PlainText) {
1618 Annotations Test(Text);
1619 return signatures(Test.code(), Test.point(), std::move(IndexSymbols),
1620 DocumentationFormat);
1621}
1622
1623struct ExpectedParameter {
1624 std::string Text;
1625 std::pair<unsigned, unsigned> Offsets;
1626};
1627llvm::raw_ostream &operator<<(llvm::raw_ostream &OS,
1628 const ExpectedParameter &P) {
1629 return OS << P.Text;
1630}
1631MATCHER_P(paramsAre, P, "") {
1632 if (P.size() != arg.parameters.size())
1633 return false;
1634 for (unsigned I = 0; I < P.size(); ++I) {
1635 if (P[I].Text != arg.parameters[I].labelString ||
1636 P[I].Offsets != arg.parameters[I].labelOffsets)
1637 return false;
1638 }
1639 return true;
1640}
1641MATCHER_P(sigDoc, doc, "") { return arg.documentation.value == doc; }
1642
1643/// \p AnnotatedLabel is a signature label with ranges marking parameters, e.g.
1644/// foo([[int p1]], [[double p2]]) -> void
1645Matcher<SignatureInformation> sig(llvm::StringRef AnnotatedLabel) {
1646 llvm::Annotations A(AnnotatedLabel);
1647 std::string Label = std::string(A.code());
1648 std::vector<ExpectedParameter> Parameters;
1649 for (auto Range : A.ranges()) {
1650 Parameters.emplace_back();
1651
1652 ExpectedParameter &P = Parameters.back();
1653 P.Text = Label.substr(Range.Begin, Range.End - Range.Begin);
1654 P.Offsets.first = lspLength(llvm::StringRef(Label).substr(0, Range.Begin));
1655 P.Offsets.second = lspLength(llvm::StringRef(Label).substr(1, Range.End));
1656 }
1657 return AllOf(sigHelpLabeled(Label), paramsAre(Parameters));
1658}
1659
1660TEST(SignatureHelpTest, Overloads) {
1661 auto Results = signatures(R"cpp(
1662 void foo(int x, int y);
1663 void foo(int x, float y);
1664 void foo(float x, int y);
1665 void foo(float x, float y);
1666 void bar(int x, int y = 0);
1667 int main() { foo(^); }
1668 )cpp");
1669 EXPECT_THAT(Results.signatures,
1670 UnorderedElementsAre(sig("foo([[float x]], [[float y]]) -> void"),
1671 sig("foo([[float x]], [[int y]]) -> void"),
1672 sig("foo([[int x]], [[float y]]) -> void"),
1673 sig("foo([[int x]], [[int y]]) -> void")));
1674 // We always prefer the first signature.
1675 EXPECT_EQ(0, Results.activeSignature);
1676 EXPECT_EQ(0, Results.activeParameter);
1677}
1678
1679TEST(SignatureHelpTest, FunctionPointers) {
1680 llvm::StringLiteral Tests[] = {
1681 // Variable of function pointer type
1682 R"cpp(
1683 void (*foo)(int x, int y);
1684 int main() { foo(^); }
1685 )cpp",
1686 // Wrapped in an AttributedType
1687 R"cpp(
1688 void (__stdcall *foo)(int x, int y);
1689 int main() { foo(^); }
1690 )cpp",
1691 // Another syntax for an AttributedType
1692 R"cpp(
1693 void (__attribute__(stdcall) *foo)(int x, int y);
1694 int main() { foo(^); },
1695 )cpp",
1696 // Wrapped in a typedef
1697 R"cpp(
1698 typedef void (*fn)(int x, int y);
1699 fn foo;
1700 int main() { foo(^); }
1701 )cpp",
1702 // Wrapped in both a typedef and an AttributedTyped
1703 R"cpp(
1704 typedef void (__stdcall *fn)(int x, int y);
1705 fn foo;
1706 int main() { foo(^); }
1707 )cpp",
1708 // Field of function pointer type
1709 R"cpp(
1710 struct S {
1711 void (*foo)(int x, int y);
1712 };
1713 S s;
1714 int main() { s.foo(^); }
1715 )cpp",
1716 // Field of function pointer typedef type
1717 R"cpp(
1718 typedef void (*fn)(int x, int y);
1719 struct S {
1720 fn foo;
1721 };
1722 S s;
1723 int main() { s.foo(^); }
1724 )cpp"};
1725 for (auto Test : Tests)
1726 EXPECT_THAT(signatures(Test).signatures,
1727 UnorderedElementsAre(sig("([[int x]], [[int y]]) -> void")));
1728}
1729
1730TEST(SignatureHelpTest, Constructors) {
1731 std::string Top = R"cpp(
1732 struct S {
1733 S(int);
1734 S(const S &) = delete;
1735 };
1736 )cpp";
1737
1738 auto CheckParenInit = [&](std::string Init) {
1739 EXPECT_THAT(signatures(Top + Init).signatures,
1740 UnorderedElementsAre(sig("S([[int]])")))
1741 << Init;
1742 };
1743 CheckParenInit("S s(^);");
1744 CheckParenInit("auto s = S(^);");
1745 CheckParenInit("auto s = new S(^);");
1746
1747 auto CheckBracedInit = [&](std::string Init) {
1748 EXPECT_THAT(signatures(Top + Init).signatures,
1749 UnorderedElementsAre(sig("S{[[int]]}")))
1750 << Init;
1751 };
1752 CheckBracedInit("S s{^};");
1753 CheckBracedInit("S s = {^};");
1754 CheckBracedInit("auto s = S{^};");
1755 // FIXME: doesn't work: no ExpectedType set in ParseCXXNewExpression.
1756 // CheckBracedInit("auto s = new S{^};");
1757 CheckBracedInit("int x(S); int i = x({^});");
1758}
1759
1760TEST(SignatureHelpTest, Aggregates) {
1761 std::string Top = R"cpp(
1762 struct S {
1763 int a, b, c, d;
1764 };
1765 )cpp";
1766 auto AggregateSig = sig("S{[[int a]], [[int b]], [[int c]], [[int d]]}");
1767 EXPECT_THAT(signatures(Top + "S s{^}").signatures,
1768 UnorderedElementsAre(AggregateSig, sig("S{}"),
1769 sig("S{[[const S &]]}"),
1770 sig("S{[[S &&]]}")));
1771 EXPECT_THAT(signatures(Top + "S s{1,^}").signatures,
1772 ElementsAre(AggregateSig));
1773 EXPECT_EQ(signatures(Top + "S s{1,^}").activeParameter, 1);
1774 EXPECT_THAT(signatures(Top + "S s{.c=3,^}").signatures,
1775 ElementsAre(AggregateSig));
1776 EXPECT_EQ(signatures(Top + "S s{.c=3,^}").activeParameter, 3);
1777}
1778
1779TEST(SignatureHelpTest, OverloadInitListRegression) {
1780 auto Results = signatures(R"cpp(
1781 struct A {int x;};
1782 struct B {B(A);};
1783 void f();
1784 int main() {
1785 B b({1});
1786 f(^);
1787 }
1788 )cpp");
1789 EXPECT_THAT(Results.signatures, UnorderedElementsAre(sig("f() -> void")));
1790}
1791
1792TEST(SignatureHelpTest, DefaultArgs) {
1793 auto Results = signatures(R"cpp(
1794 void bar(int x, int y = 0);
1795 void bar(float x = 0, int y = 42);
1796 int main() { bar(^
1797 )cpp");
1798 EXPECT_THAT(Results.signatures,
1799 UnorderedElementsAre(
1800 sig("bar([[int x]], [[int y = 0]]) -> void"),
1801 sig("bar([[float x = 0]], [[int y = 42]]) -> void")));
1802 EXPECT_EQ(0, Results.activeSignature);
1803 EXPECT_EQ(0, Results.activeParameter);
1804}
1805
1806TEST(SignatureHelpTest, ActiveArg) {
1807 auto Results = signatures(R"cpp(
1808 int baz(int a, int b, int c);
1809 int main() { baz(baz(1,2,3), ^); }
1810 )cpp");
1811 EXPECT_THAT(Results.signatures,
1812 ElementsAre(sig("baz([[int a]], [[int b]], [[int c]]) -> int")));
1813 EXPECT_EQ(0, Results.activeSignature);
1814 EXPECT_EQ(1, Results.activeParameter);
1815}
1816
1817TEST(SignatureHelpTest, OpeningParen) {
1818 llvm::StringLiteral Tests[] = {
1819 // Recursive function call.
1820 R"cpp(
1821 int foo(int a, int b, int c);
1822 int main() {
1823 foo(foo $p^( foo(10, 10, 10), ^ )));
1824 })cpp",
1825 // Functional type cast.
1826 R"cpp(
1827 struct Foo {
1828 Foo(int a, int b, int c);
1829 };
1830 int main() {
1831 Foo $p^( 10, ^ );
1832 })cpp",
1833 // New expression.
1834 R"cpp(
1835 struct Foo {
1836 Foo(int a, int b, int c);
1837 };
1838 int main() {
1839 new Foo $p^( 10, ^ );
1840 })cpp",
1841 // Macro expansion.
1842 R"cpp(
1843 int foo(int a, int b, int c);
1844 #define FOO foo(
1845
1846 int main() {
1847 // Macro expansions.
1848 $p^FOO 10, ^ );
1849 })cpp",
1850 // Macro arguments.
1851 R"cpp(
1852 int foo(int a, int b, int c);
1853 int main() {
1854 #define ID(X) X
1855 // FIXME: figure out why ID(foo (foo(10), )) doesn't work when preserving
1856 // the recovery expression.
1857 ID(foo $p^( 10, ^ ))
1858 })cpp",
1859 // Dependent args.
1860 R"cpp(
1861 int foo(int a, int b);
1862 template <typename T> void bar(T t) {
1863 foo$p^(t, ^t);
1864 })cpp",
1865 // Dependent args on templated func.
1866 R"cpp(
1867 template <typename T>
1868 int foo(T, T);
1869 template <typename T> void bar(T t) {
1870 foo$p^(t, ^t);
1871 })cpp",
1872 // Dependent args on member.
1873 R"cpp(
1874 struct Foo { int foo(int, int); };
1875 template <typename T> void bar(T t) {
1876 Foo f;
1877 f.foo$p^(t, ^t);
1878 })cpp",
1879 // Dependent args on templated member.
1880 R"cpp(
1881 struct Foo { template <typename T> int foo(T, T); };
1882 template <typename T> void bar(T t) {
1883 Foo f;
1884 f.foo$p^(t, ^t);
1885 })cpp",
1886 };
1887
1888 for (auto Test : Tests) {
1889 Annotations Code(Test);
1890 EXPECT_EQ(signatures(Code.code(), Code.point()).argListStart,
1891 Code.point("p"))
1892 << "Test source:" << Test;
1893 }
1894}
1895
1896TEST(SignatureHelpTest, StalePreamble) {
1897 TestTU TU;
1898 TU.Code = "";
1899 IgnoreDiagnostics Diags;
1900 MockFS FS;
1901 auto Inputs = TU.inputs(FS);
1902 auto CI = buildCompilerInvocation(Inputs, Diags);
1903 ASSERT_TRUE(CI);
1904 auto EmptyPreamble = buildPreamble(testPath(TU.Filename), *CI, Inputs,
1905 /*InMemory=*/true, /*Callback=*/nullptr);
1906 ASSERT_TRUE(EmptyPreamble);
1907
1908 TU.AdditionalFiles["a.h"] = "int foo(int x);";
1909 const Annotations Test(R"cpp(
1910 #include "a.h"
1911 void bar() { foo(^2); })cpp");
1912 TU.Code = Test.code().str();
1913 auto Results =
1914 signatureHelp(testPath(TU.Filename), Test.point(), *EmptyPreamble,
1915 TU.inputs(FS), MarkupKind::PlainText);
1916 EXPECT_THAT(Results.signatures, ElementsAre(sig("foo([[int x]]) -> int")));
1917 EXPECT_EQ(0, Results.activeSignature);
1918 EXPECT_EQ(0, Results.activeParameter);
1919}
1920
1921class IndexRequestCollector : public SymbolIndex {
1922public:
1923 IndexRequestCollector(std::vector<Symbol> Syms = {}) : Symbols(Syms) {}
1924
1925 bool
1926 fuzzyFind(const FuzzyFindRequest &Req,
1927 llvm::function_ref<void(const Symbol &)> Callback) const override {
1928 std::unique_lock<std::mutex> Lock(Mut);
1929 Requests.push_back(Req);
1930 ReceivedRequestCV.notify_one();
1931 for (const auto &Sym : Symbols)
1932 Callback(Sym);
1933 return true;
1934 }
1935
1936 void lookup(const LookupRequest &,
1937 llvm::function_ref<void(const Symbol &)>) const override {}
1938
1939 bool refs(const RefsRequest &,
1940 llvm::function_ref<void(const Ref &)>) const override {
1941 return false;
1942 }
1943
1944 bool containedRefs(
1945 const ContainedRefsRequest &,
1946 llvm::function_ref<void(const ContainedRefsResult &)>) const override {
1947 return false;
1948 }
1949
1950 void relations(const RelationsRequest &,
1951 llvm::function_ref<void(const SymbolID &, const Symbol &)>)
1952 const override {}
1953
1954 void
1955 reverseRelations(const RelationsRequest &,
1956 llvm::function_ref<void(const SymbolID &, const Symbol &)>)
1957 const override {}
1958
1959 llvm::unique_function<IndexContents(llvm::StringRef) const>
1960 indexedFiles() const override {
1961 return [](llvm::StringRef) { return IndexContents::None; };
1962 }
1963
1964 // This is incorrect, but IndexRequestCollector is not an actual index and it
1965 // isn't used in production code.
1966 size_t estimateMemoryUsage() const override { return 0; }
1967
1968 const std::vector<FuzzyFindRequest> consumeRequests(size_t Num) const {
1969 std::unique_lock<std::mutex> Lock(Mut);
1970 EXPECT_TRUE(wait(Lock, ReceivedRequestCV, timeoutSeconds(30),
1971 [this, Num] { return Requests.size() == Num; }));
1972 auto Reqs = std::move(Requests);
1973 Requests = {};
1974 return Reqs;
1975 }
1976
1977private:
1978 std::vector<Symbol> Symbols;
1979 // We need a mutex to handle async fuzzy find requests.
1980 mutable std::condition_variable ReceivedRequestCV;
1981 mutable std::mutex Mut;
1982 mutable std::vector<FuzzyFindRequest> Requests;
1983};
1984
1985// Clients have to consume exactly Num requests.
1986std::vector<FuzzyFindRequest> captureIndexRequests(llvm::StringRef Code,
1987 size_t Num = 1) {
1988 clangd::CodeCompleteOptions Opts;
1989 IndexRequestCollector Requests;
1990 Opts.Index = &Requests;
1991 completions(Code, {}, Opts);
1992 const auto Reqs = Requests.consumeRequests(Num);
1993 EXPECT_EQ(Reqs.size(), Num);
1994 return Reqs;
1995}
1996
1997TEST(CompletionTest, UnqualifiedIdQuery) {
1998 auto Requests = captureIndexRequests(R"cpp(
1999 namespace std {}
2000 using namespace std;
2001 namespace ns {
2002 void f() {
2003 vec^
2004 }
2005 }
2006 )cpp");
2007
2008 EXPECT_THAT(Requests,
2009 ElementsAre(Field(&FuzzyFindRequest::Scopes,
2010 UnorderedElementsAre("", "ns::", "std::"))));
2011}
2012
2013TEST(CompletionTest, EnclosingScopeComesFirst) {
2014 auto Requests = captureIndexRequests(R"cpp(
2015 namespace std {}
2016 using namespace std;
2017 namespace nx {
2018 namespace ns {
2019 namespace {
2020 void f() {
2021 vec^
2022 }
2023 }
2024 }
2025 }
2026 )cpp");
2027
2028 EXPECT_THAT(Requests,
2029 ElementsAre(Field(
2031 UnorderedElementsAre("", "std::", "nx::ns::", "nx::"))));
2032 EXPECT_EQ(Requests[0].Scopes[0], "nx::ns::");
2033}
2034
2035TEST(CompletionTest, ResolvedQualifiedIdQuery) {
2036 auto Requests = captureIndexRequests(R"cpp(
2037 namespace ns1 {}
2038 namespace ns2 {} // ignore
2039 namespace ns3 { namespace nns3 {} }
2040 namespace foo {
2041 using namespace ns1;
2042 using namespace ns3::nns3;
2043 }
2044 namespace ns {
2045 void f() {
2046 foo::^
2047 }
2048 }
2049 )cpp");
2050
2051 EXPECT_THAT(Requests,
2052 ElementsAre(Field(
2054 UnorderedElementsAre("foo::", "ns1::", "ns3::nns3::"))));
2055}
2056
2057TEST(CompletionTest, UnresolvedQualifierIdQuery) {
2058 auto Requests = captureIndexRequests(R"cpp(
2059 namespace a {}
2060 using namespace a;
2061 namespace ns {
2062 void f() {
2063 bar::^
2064 }
2065 } // namespace ns
2066 )cpp");
2067
2068 EXPECT_THAT(Requests,
2069 ElementsAre(Field(
2071 UnorderedElementsAre("a::bar::", "ns::bar::", "bar::"))));
2072}
2073
2074TEST(CompletionTest, UnresolvedNestedQualifierIdQuery) {
2075 auto Requests = captureIndexRequests(R"cpp(
2076 namespace a {}
2077 using namespace a;
2078 namespace ns {
2079 void f() {
2080 ::a::bar::^
2081 }
2082 } // namespace ns
2083 )cpp");
2084
2085 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes,
2086 UnorderedElementsAre("a::bar::"))));
2087}
2088
2089TEST(CompletionTest, EmptyQualifiedQuery) {
2090 auto Requests = captureIndexRequests(R"cpp(
2091 namespace ns {
2092 void f() {
2093 ^
2094 }
2095 } // namespace ns
2096 )cpp");
2097
2098 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes,
2099 UnorderedElementsAre("", "ns::"))));
2100}
2101
2102TEST(CompletionTest, GlobalQualifiedQuery) {
2103 auto Requests = captureIndexRequests(R"cpp(
2104 namespace ns {
2105 void f() {
2106 ::^
2107 }
2108 } // namespace ns
2109 )cpp");
2110
2111 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes,
2112 UnorderedElementsAre(""))));
2113}
2114
2115TEST(CompletionTest, NoDuplicatedQueryScopes) {
2116 auto Requests = captureIndexRequests(R"cpp(
2117 namespace {}
2118
2119 namespace na {
2120 namespace {}
2121 namespace nb {
2122 ^
2123 } // namespace nb
2124 } // namespace na
2125 )cpp");
2126
2127 EXPECT_THAT(Requests,
2128 ElementsAre(Field(&FuzzyFindRequest::Scopes,
2129 UnorderedElementsAre("na::", "na::nb::", ""))));
2130}
2131
2132TEST(CompletionTest, NoIndexCompletionsInsideClasses) {
2133 auto Completions = completions(
2134 R"cpp(
2135 struct Foo {
2136 int SomeNameOfField;
2137 typedef int SomeNameOfTypedefField;
2138 };
2139
2140 Foo::^)cpp",
2141 {func("::SomeNameInTheIndex"), func("::Foo::SomeNameInTheIndex")});
2142
2143 EXPECT_THAT(Completions.Completions,
2144 AllOf(Contains(labeled("SomeNameOfField")),
2145 Contains(labeled("SomeNameOfTypedefField")),
2146 Not(Contains(labeled("SomeNameInTheIndex")))));
2147}
2148
2149TEST(CompletionTest, NoIndexCompletionsInsideDependentCode) {
2150 {
2151 auto Completions = completions(
2152 R"cpp(
2153 template <class T>
2154 void foo() {
2155 T::^
2156 }
2157 )cpp",
2158 {func("::SomeNameInTheIndex")});
2159
2160 EXPECT_THAT(Completions.Completions,
2161 Not(Contains(labeled("SomeNameInTheIndex"))));
2162 }
2163
2164 {
2165 auto Completions = completions(
2166 R"cpp(
2167 template <class T>
2168 void foo() {
2169 T::template Y<int>::^
2170 }
2171 )cpp",
2172 {func("::SomeNameInTheIndex")});
2173
2174 EXPECT_THAT(Completions.Completions,
2175 Not(Contains(labeled("SomeNameInTheIndex"))));
2176 }
2177
2178 {
2179 auto Completions = completions(
2180 R"cpp(
2181 template <class T>
2182 void foo() {
2183 T::foo::^
2184 }
2185 )cpp",
2186 {func("::SomeNameInTheIndex")});
2187
2188 EXPECT_THAT(Completions.Completions,
2189 Not(Contains(labeled("SomeNameInTheIndex"))));
2190 }
2191}
2192
2193TEST(CompletionTest, OverloadBundling) {
2194 clangd::CodeCompleteOptions Opts;
2195 Opts.BundleOverloads = true;
2196
2197 std::string Context = R"cpp(
2198 struct X {
2199 // Overload with int
2200 int a(int) __attribute__((deprecated("", "")));
2201 // Overload with bool
2202 int a(bool);
2203 int b(float);
2204
2205 X(int);
2206 X(float);
2207 };
2208 int GFuncC(int);
2209 int GFuncD(int);
2210 )cpp";
2211
2212 // Member completions are bundled.
2213 EXPECT_THAT(completions(Context + "int y = X().^", {}, Opts).Completions,
2214 UnorderedElementsAre(labeled("a(…)"), labeled("b(float)")));
2215
2216 // Constructor completions are bundled.
2217 EXPECT_THAT(completions(Context + "X z = X^", {}, Opts).Completions,
2218 UnorderedElementsAre(labeled("X"), labeled("X(…)")));
2219
2220 // Non-member completions are bundled, including index+sema.
2221 Symbol NoArgsGFunc = func("GFuncC");
2222 EXPECT_THAT(
2223 completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).Completions,
2224 UnorderedElementsAre(labeled("GFuncC(…)"), labeled("GFuncD(int)")));
2225
2226 // Differences in header-to-insert suppress bundling.
2227 std::string DeclFile = URI::create(testPath("foo")).toString();
2228 NoArgsGFunc.CanonicalDeclaration.FileURI = DeclFile.c_str();
2229 NoArgsGFunc.IncludeHeaders.emplace_back("<foo>", 1, Symbol::Include);
2230 EXPECT_THAT(
2231 completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).Completions,
2232 UnorderedElementsAre(AllOf(named("GFuncC"), insertInclude("<foo>")),
2233 labeled("GFuncC(int)"), labeled("GFuncD(int)")));
2234
2235 // Examine a bundled completion in detail.
2236 auto A =
2237 completions(Context + "int y = X().a^", {}, Opts).Completions.front();
2238 EXPECT_EQ(A.Name, "a");
2239 EXPECT_EQ(A.Signature, "(…)");
2240 EXPECT_EQ(A.BundleSize, 2u);
2241 EXPECT_EQ(A.Kind, CompletionItemKind::Method);
2242 EXPECT_EQ(A.ReturnType, "int"); // All overloads return int.
2243 // For now we just return one of the doc strings arbitrarily.
2244 ASSERT_TRUE(A.Documentation);
2245 ASSERT_FALSE(A.Deprecated); // Not all overloads deprecated.
2246 EXPECT_THAT(
2247 A.Documentation->asPlainText(),
2248 AnyOf(HasSubstr("Overload with int"), HasSubstr("Overload with bool")));
2249 EXPECT_EQ(A.SnippetSuffix, "($0)");
2250}
2251
2252TEST(CompletionTest, OverloadBundlingSameFileDifferentURI) {
2253 clangd::CodeCompleteOptions Opts;
2254 Opts.BundleOverloads = true;
2255
2256 Symbol SymX = sym("ns::X", index::SymbolKind::Function, "@F@\\0#");
2257 Symbol SymY = sym("ns::X", index::SymbolKind::Function, "@F@\\0#I#");
2258 std::string BarHeader = testPath("bar.h");
2259 auto BarURI = URI::create(BarHeader).toString();
2260 SymX.CanonicalDeclaration.FileURI = BarURI.c_str();
2261 SymY.CanonicalDeclaration.FileURI = BarURI.c_str();
2262 // The include header is different, but really it's the same file.
2263 SymX.IncludeHeaders.emplace_back("\"bar.h\"", 1, Symbol::Include);
2264 SymY.IncludeHeaders.emplace_back(BarURI.c_str(), 1, Symbol::Include);
2265
2266 auto Results = completions("void f() { ::ns::^ }", {SymX, SymY}, Opts);
2267 // Expect both results are bundled, despite the different-but-same
2268 // IncludeHeader.
2269 ASSERT_EQ(1u, Results.Completions.size());
2270 const auto &R = Results.Completions.front();
2271 EXPECT_EQ("X", R.Name);
2272 EXPECT_EQ(2u, R.BundleSize);
2273}
2274
2275TEST(CompletionTest, DocumentationFromChangedFileCrash) {
2276 MockFS FS;
2277 auto FooH = testPath("foo.h");
2278 auto FooCpp = testPath("foo.cpp");
2279 FS.Files[FooH] = R"cpp(
2280 // this is my documentation comment.
2281 int func();
2282 )cpp";
2283 FS.Files[FooCpp] = "";
2284
2286 ClangdServer Server(CDB, FS, ClangdServer::optsForTest());
2287
2288 Annotations Source(R"cpp(
2289 #include "foo.h"
2290 int func() {
2291 // This makes sure we have func from header in the AST.
2292 }
2293 int a = fun^
2294 )cpp");
2295 Server.addDocument(FooCpp, Source.code(), "null", WantDiagnostics::Yes);
2296 // We need to wait for preamble to build.
2297 ASSERT_TRUE(Server.blockUntilIdleForTest());
2298
2299 // Change the header file. Completion will reuse the old preamble!
2300 FS.Files[FooH] = R"cpp(
2301 int func();
2302 )cpp";
2303
2304 clangd::CodeCompleteOptions Opts;
2305 CodeCompleteResult Completions =
2306 cantFail(runCodeComplete(Server, FooCpp, Source.point(), Opts));
2307 // We shouldn't crash. Unfortunately, current workaround is to not produce
2308 // comments for symbols from headers.
2309 EXPECT_THAT(Completions.Completions,
2310 Contains(AllOf(Not(isDocumented()), named("func"))));
2311}
2312
2313TEST(CompletionTest, NonDocComments) {
2314 const char *Text = R"cpp(
2315 // We ignore namespace comments, for rationale see CodeCompletionStrings.h.
2316 namespace comments_ns {
2317 }
2318
2319 // ------------------
2320 int comments_foo();
2321
2322 // A comment and a decl are separated by newlines.
2323 // Therefore, the comment shouldn't show up as doc comment.
2324
2325 int comments_bar();
2326
2327 // this comment should be in the results.
2328 int comments_baz();
2329
2330
2331 template <class T>
2332 struct Struct {
2333 int comments_qux();
2334 int comments_quux();
2335 };
2336
2337
2338 // This comment should not be there.
2339
2340 template <class T>
2341 int Struct<T>::comments_qux() {
2342 }
2343
2344 // This comment **should** be in results.
2345 template <class T>
2346 int Struct<T>::comments_quux() {
2347 int a = comments^;
2348 }
2349 )cpp";
2350
2351 // We should not get any of those comments in completion.
2352 EXPECT_THAT(
2353 completions(Text).Completions,
2354 UnorderedElementsAre(AllOf(Not(isDocumented()), named("comments_foo")),
2355 AllOf(isDocumented(), named("comments_baz")),
2356 AllOf(isDocumented(), named("comments_quux")),
2357 AllOf(Not(isDocumented()), named("comments_ns")),
2358 // FIXME(ibiryukov): the following items should have
2359 // empty documentation, since they are separated from
2360 // a comment with an empty line. Unfortunately, I
2361 // couldn't make Sema tests pass if we ignore those.
2362 AllOf(isDocumented(), named("comments_bar")),
2363 AllOf(isDocumented(), named("comments_qux"))));
2364}
2365
2366TEST(CompletionTest, CompleteOnInvalidLine) {
2367 auto FooCpp = testPath("foo.cpp");
2368
2370 MockFS FS;
2371 FS.Files[FooCpp] = "// empty file";
2372
2373 ClangdServer Server(CDB, FS, ClangdServer::optsForTest());
2374 // Run completion outside the file range.
2375 Position Pos;
2376 Pos.line = 100;
2377 Pos.character = 0;
2378 EXPECT_THAT_EXPECTED(
2379 runCodeComplete(Server, FooCpp, Pos, clangd::CodeCompleteOptions()),
2380 Failed());
2381}
2382
2383TEST(CompletionTest, QualifiedNames) {
2384 auto Results = completions(
2385 R"cpp(
2386 namespace ns { int local; void both(); }
2387 void f() { ::ns::^ }
2388 )cpp",
2389 {func("ns::both"), cls("ns::Index")});
2390 // We get results from both index and sema, with no duplicates.
2391 EXPECT_THAT(
2392 Results.Completions,
2393 UnorderedElementsAre(scope("ns::"), scope("ns::"), scope("ns::")));
2394}
2395
2396TEST(CompletionTest, Render) {
2397 CodeCompletion C;
2398 C.Name = "x";
2399 C.FilterText = "x";
2400 C.Signature = "(bool) const";
2401 C.SnippetSuffix = "(${0:bool})";
2402 C.ReturnType = "int";
2403 C.RequiredQualifier = "Foo::";
2404 C.Scope = "ns::Foo::";
2405 C.Documentation.emplace();
2406 C.Documentation->addParagraph().appendText("This is ").appendCode("x()");
2407 C.Includes.emplace_back();
2408 auto &Include = C.Includes.back();
2409 Include.Header = "\"foo.h\"";
2411 C.Score.Total = 1.0;
2412 C.Score.ExcludingName = .5;
2414
2416 Opts.IncludeIndicator.Insert = "^";
2417 Opts.IncludeIndicator.NoInsert = "";
2418 Opts.EnableSnippets = false;
2419
2420 auto R = C.render(Opts);
2421 EXPECT_EQ(R.label, "Foo::x");
2422 EXPECT_EQ(R.labelDetails->detail, "(bool) const");
2423 EXPECT_EQ(R.insertText, "Foo::x");
2424 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::PlainText);
2425 EXPECT_EQ(R.filterText, "x");
2426 EXPECT_EQ(R.detail, "int");
2427 EXPECT_EQ(R.documentation->value, "From \"foo.h\"\n\nThis is x()");
2428 EXPECT_THAT(R.additionalTextEdits, IsEmpty());
2429 EXPECT_EQ(R.sortText, sortText(1.0, "x"));
2430 EXPECT_FALSE(R.deprecated);
2431 EXPECT_EQ(R.score, .5f);
2432
2433 C.FilterText = "xtra";
2434 R = C.render(Opts);
2435 EXPECT_EQ(R.filterText, "xtra");
2436 EXPECT_EQ(R.sortText, sortText(1.0, "xtra"));
2437
2438 Opts.EnableSnippets = true;
2439 R = C.render(Opts);
2440 EXPECT_EQ(R.insertText, "Foo::x(${0:bool})");
2441 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::Snippet);
2442
2443 C.SnippetSuffix = "";
2444 R = C.render(Opts);
2445 EXPECT_EQ(R.insertText, "Foo::x");
2446 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::PlainText);
2447
2448 Include.Insertion.emplace();
2449 R = C.render(Opts);
2450 EXPECT_EQ(R.label, "^Foo::x");
2451 EXPECT_EQ(R.labelDetails->detail, "(bool) const");
2452 EXPECT_THAT(R.additionalTextEdits, Not(IsEmpty()));
2453
2454 Opts.ShowOrigins = true;
2455 R = C.render(Opts);
2456 EXPECT_EQ(R.label, "^[AS]Foo::x");
2457 EXPECT_EQ(R.labelDetails->detail, "(bool) const");
2458
2459 C.BundleSize = 2;
2460 R = C.render(Opts);
2461 EXPECT_EQ(R.detail, "[2 overloads]");
2462 EXPECT_EQ(R.documentation->value, "From \"foo.h\"\n\nThis is x()");
2463
2464 C.Deprecated = true;
2465 R = C.render(Opts);
2466 EXPECT_TRUE(R.deprecated);
2467
2468 Opts.DocumentationFormat = MarkupKind::Markdown;
2469 R = C.render(Opts);
2470 EXPECT_EQ(R.documentation->value, "From `\"foo.h\"`\n\nThis is `x()`");
2471}
2472
2473TEST(CompletionTest, IgnoreRecoveryResults) {
2474 auto Results = completions(
2475 R"cpp(
2476 namespace ns { int NotRecovered() { return 0; } }
2477 void f() {
2478 // Sema enters recovery mode first and then normal mode.
2479 if (auto x = ns::NotRecover^)
2480 }
2481 )cpp");
2482 EXPECT_THAT(Results.Completions, UnorderedElementsAre(named("NotRecovered")));
2483}
2484
2485TEST(CompletionTest, ScopeOfClassFieldInConstructorInitializer) {
2486 auto Results = completions(
2487 R"cpp(
2488 namespace ns {
2489 class X { public: X(); int x_; };
2490 X::X() : x_^(0) {}
2491 }
2492 )cpp");
2493 EXPECT_THAT(Results.Completions,
2494 UnorderedElementsAre(AllOf(scope("ns::X::"), named("x_"))));
2495}
2496
2497// Like other class members, constructor init lists have to parse what's below,
2498// after the completion point.
2499// But recovering from an incomplete constructor init list is particularly
2500// tricky because the bulk of the list is not surrounded by brackets.
2501TEST(CompletionTest, ConstructorInitListIncomplete) {
2502 auto Results = completions(
2503 R"cpp(
2504 namespace ns {
2505 struct X {
2506 X() : x^
2507 int xyz_;
2508 };
2509 }
2510 )cpp");
2511 EXPECT_THAT(Results.Completions, ElementsAre(named("xyz_")));
2512
2513 Results = completions(
2514 R"cpp(
2515 int foo();
2516
2517 namespace ns {
2518 struct X {
2519 X() : xyz_(fo^
2520 int xyz_;
2521 };
2522 }
2523 )cpp");
2524 EXPECT_THAT(Results.Completions, ElementsAre(named("foo")));
2525}
2526
2527TEST(CompletionTest, CodeCompletionContext) {
2528 auto Results = completions(
2529 R"cpp(
2530 namespace ns {
2531 class X { public: X(); int x_; };
2532 void f() {
2533 X x;
2534 x.^;
2535 }
2536 }
2537 )cpp");
2538
2539 EXPECT_THAT(Results.Context, CodeCompletionContext::CCC_DotMemberAccess);
2540}
2541
2542TEST(CompletionTest, OffsetOfDesignator) {
2543 auto Results = completions(R"cpp(
2544 struct S { int field; int other; void fieldFn(); };
2545 int x = __builtin_offsetof(S, fiel^d);
2546 )cpp");
2547 EXPECT_THAT(
2548 Results.Completions,
2549 ElementsAre(AllOf(named("field"), kind(CompletionItemKind::Field))));
2550 EXPECT_THAT(Results.Context, CodeCompletionContext::CCC_DotMemberAccess);
2551
2552 Results = completions(R"cpp(
2553 struct Inner { int field; void fieldFn(); };
2554 struct Outer { Inner inner; };
2555 int x = __builtin_offsetof(Outer, inner.fiel^d);
2556 )cpp");
2557 EXPECT_THAT(
2558 Results.Completions,
2559 ElementsAre(AllOf(named("field"), kind(CompletionItemKind::Field))));
2560
2561 Results = completions(R"cpp(
2562 struct Inner { int field; void fieldFn(); };
2563 struct Outer { Inner inner[2]; };
2564 int i;
2565 int x = __builtin_offsetof(Outer, inner[i].fiel^d);
2566 )cpp");
2567 EXPECT_THAT(
2568 Results.Completions,
2569 ElementsAre(AllOf(named("field"), kind(CompletionItemKind::Field))));
2570
2571 Results = completions(R"cpp(
2572 struct Base { int field; void fieldFn(); };
2573 struct Derived : Base {};
2574 int x = __builtin_offsetof(Derived, fiel^d);
2575 )cpp");
2576 EXPECT_THAT(
2577 Results.Completions,
2578 ElementsAre(AllOf(named("field"), kind(CompletionItemKind::Field))));
2579}
2580
2581TEST(CompletionTest, FixItForArrowToDot) {
2582 MockFS FS;
2584
2586 Opts.IncludeFixIts = true;
2587 const char *Code =
2588 R"cpp(
2589 class Auxilary {
2590 public:
2591 void AuxFunction();
2592 };
2593 class ClassWithPtr {
2594 public:
2595 void MemberFunction();
2596 Auxilary* operator->() const;
2597 Auxilary* Aux;
2598 };
2599 void f() {
2600 ClassWithPtr x;
2601 x[[->]]^;
2602 }
2603 )cpp";
2604 auto Results = completions(Code, {}, Opts);
2605 EXPECT_EQ(Results.Completions.size(), 3u);
2606
2607 TextEdit ReplacementEdit;
2608 ReplacementEdit.range = Annotations(Code).range();
2609 ReplacementEdit.newText = ".";
2610 for (const auto &C : Results.Completions) {
2611 EXPECT_TRUE(C.FixIts.size() == 1u || C.Name == "AuxFunction");
2612 if (!C.FixIts.empty()) {
2613 EXPECT_THAT(C.FixIts, ElementsAre(ReplacementEdit));
2614 }
2615 }
2616}
2617
2618TEST(CompletionTest, FixItForDotToArrow) {
2620 Opts.IncludeFixIts = true;
2621 const char *Code =
2622 R"cpp(
2623 class Auxilary {
2624 public:
2625 void AuxFunction();
2626 };
2627 class ClassWithPtr {
2628 public:
2629 void MemberFunction();
2630 Auxilary* operator->() const;
2631 Auxilary* Aux;
2632 };
2633 void f() {
2634 ClassWithPtr x;
2635 x[[.]]^;
2636 }
2637 )cpp";
2638 auto Results = completions(Code, {}, Opts);
2639 EXPECT_EQ(Results.Completions.size(), 3u);
2640
2641 TextEdit ReplacementEdit;
2642 ReplacementEdit.range = Annotations(Code).range();
2643 ReplacementEdit.newText = "->";
2644 for (const auto &C : Results.Completions) {
2645 EXPECT_TRUE(C.FixIts.empty() || C.Name == "AuxFunction");
2646 if (!C.FixIts.empty()) {
2647 EXPECT_THAT(C.FixIts, ElementsAre(ReplacementEdit));
2648 }
2649 }
2650}
2651
2652TEST(CompletionTest, RenderWithFixItMerged) {
2653 TextEdit FixIt;
2654 FixIt.range.end.character = 5;
2655 FixIt.newText = "->";
2656
2657 CodeCompletion C;
2658 C.Name = "x";
2659 C.RequiredQualifier = "Foo::";
2660 C.FixIts = {FixIt};
2661 C.CompletionInsertRange.start.character = 5;
2662
2664 Opts.IncludeFixIts = true;
2665
2666 auto R = C.render(Opts);
2667 EXPECT_TRUE(R.textEdit);
2668 EXPECT_EQ(std::get<TextEdit>(*R.textEdit).newText, "->Foo::x");
2669 EXPECT_TRUE(R.additionalTextEdits.empty());
2670}
2671
2672TEST(CompletionTest, RenderWithFixItNonMerged) {
2673 TextEdit FixIt;
2674 FixIt.range.end.character = 4;
2675 FixIt.newText = "->";
2676
2677 CodeCompletion C;
2678 C.Name = "x";
2679 C.RequiredQualifier = "Foo::";
2680 C.FixIts = {FixIt};
2681 C.CompletionInsertRange.start.character = 5;
2682
2684 Opts.IncludeFixIts = true;
2685
2686 auto R = C.render(Opts);
2687 EXPECT_TRUE(R.textEdit);
2688 EXPECT_EQ(std::get<TextEdit>(*R.textEdit).newText, "Foo::x");
2689 EXPECT_THAT(R.additionalTextEdits, UnorderedElementsAre(FixIt));
2690}
2691
2692TEST(CompletionTest, CompletionInsertRange) {
2693 MockFS FS;
2695 TestTU TU;
2696 TU.AdditionalFiles["foo/abc/foo.h"] = "";
2697
2698 constexpr const char *TestCodes[] = {
2699 R"cpp(
2700 class Auxilary {
2701 public:
2702 void AuxFunction();
2703 };
2704 void f() {
2705 Auxilary x;
2706 x.[[Aux]]^;
2707 }
2708 )cpp",
2709 R"cpp(
2710 class Auxilary {
2711 public:
2712 void AuxFunction();
2713 };
2714 void f() {
2715 Auxilary x;
2716 x.[[]]^;
2717 }
2718 )cpp",
2719 R"cpp(
2720 #include "foo/[[a^/]]foo.h"
2721 )cpp",
2722 R"cpp(
2723 #include "foo/abc/[[fo^o.h"]]
2724 )cpp",
2725 };
2726 for (const auto &Text : TestCodes) {
2727 Annotations TestCode(Text);
2728 TU.Code = TestCode.code().str();
2729 auto Results = completions(TU, TestCode.point());
2730 if (Results.Completions.size() != 1) {
2731 ADD_FAILURE() << "Results.Completions.size() != 1" << Text;
2732 continue;
2733 }
2734 EXPECT_THAT(Results.Completions.front().CompletionInsertRange,
2735 TestCode.range());
2736 }
2737}
2738
2739TEST(SignatureHelpTest, OverloadsOrdering) {
2740 const auto Results = signatures(R"cpp(
2741 void foo(int x);
2742 void foo(int x, float y);
2743 void foo(float x, int y);
2744 void foo(float x, float y);
2745 void foo(int x, int y = 0);
2746 int main() { foo(^); }
2747 )cpp");
2748 EXPECT_THAT(Results.signatures,
2749 ElementsAre(sig("foo([[int x]]) -> void"),
2750 sig("foo([[int x]], [[int y = 0]]) -> void"),
2751 sig("foo([[float x]], [[int y]]) -> void"),
2752 sig("foo([[int x]], [[float y]]) -> void"),
2753 sig("foo([[float x]], [[float y]]) -> void")));
2754 // We always prefer the first signature.
2755 EXPECT_EQ(0, Results.activeSignature);
2756 EXPECT_EQ(0, Results.activeParameter);
2757}
2758
2759TEST(SignatureHelpTest, InstantiatedSignatures) {
2760 StringRef Sig0 = R"cpp(
2761 template <class T>
2762 void foo(T, T, T);
2763
2764 int main() {
2765 foo<int>(^);
2766 }
2767 )cpp";
2768
2769 EXPECT_THAT(signatures(Sig0).signatures,
2770 ElementsAre(sig("foo([[T]], [[T]], [[T]]) -> void")));
2771
2772 StringRef Sig1 = R"cpp(
2773 template <class T>
2774 void foo(T, T, T);
2775
2776 int main() {
2777 foo(10, ^);
2778 })cpp";
2779
2780 EXPECT_THAT(signatures(Sig1).signatures,
2781 ElementsAre(sig("foo([[T]], [[T]], [[T]]) -> void")));
2782
2783 StringRef Sig2 = R"cpp(
2784 template <class ...T>
2785 void foo(T...);
2786
2787 int main() {
2788 foo<int>(^);
2789 }
2790 )cpp";
2791
2792 EXPECT_THAT(signatures(Sig2).signatures,
2793 ElementsAre(sig("foo([[T...]]) -> void")));
2794
2795 // It is debatable whether we should substitute the outer template parameter
2796 // ('T') in that case. Currently we don't substitute it in signature help, but
2797 // do substitute in code complete.
2798 // FIXME: make code complete and signature help consistent, figure out which
2799 // way is better.
2800 StringRef Sig3 = R"cpp(
2801 template <class T>
2802 struct X {
2803 template <class U>
2804 void foo(T, U);
2805 };
2806
2807 int main() {
2808 X<int>().foo<double>(^)
2809 }
2810 )cpp";
2811
2812 EXPECT_THAT(signatures(Sig3).signatures,
2813 ElementsAre(sig("foo([[T]], [[U]]) -> void")));
2814}
2815
2816TEST(SignatureHelpTest, IndexDocumentation) {
2817 Symbol Foo0 = sym("foo", index::SymbolKind::Function, "@F@\\0#");
2818 Foo0.Documentation = "doc from the index";
2819 Symbol Foo1 = sym("foo", index::SymbolKind::Function, "@F@\\0#I#");
2820 Foo1.Documentation = "doc from the index";
2821 Symbol Foo2 = sym("foo", index::SymbolKind::Function, "@F@\\0#I#I#");
2822
2823 StringRef Sig0 = R"cpp(
2824 int foo();
2825 int foo(double);
2826
2827 void test() {
2828 foo(^);
2829 }
2830 )cpp";
2831
2832 EXPECT_THAT(
2833 signatures(Sig0, {Foo0}).signatures,
2834 ElementsAre(AllOf(sig("foo() -> int"), sigDoc("doc from the index")),
2835 AllOf(sig("foo([[double]]) -> int"), sigDoc(""))));
2836
2837 StringRef Sig1 = R"cpp(
2838 int foo();
2839 // Overriden doc from sema
2840 int foo(int);
2841 // doc from sema
2842 int foo(int, int);
2843
2844 void test() {
2845 foo(^);
2846 }
2847 )cpp";
2848
2849 EXPECT_THAT(
2850 signatures(Sig1, {Foo0, Foo1, Foo2}).signatures,
2851 ElementsAre(
2852 AllOf(sig("foo() -> int"), sigDoc("doc from the index")),
2853 AllOf(sig("foo([[int]]) -> int"), sigDoc("Overriden doc from sema")),
2854 AllOf(sig("foo([[int]], [[int]]) -> int"), sigDoc("doc from sema"))));
2855}
2856
2857TEST(SignatureHelpTest, DynamicIndexDocumentation) {
2858 MockFS FS;
2861 Opts.BuildDynamicSymbolIndex = true;
2862 ClangdServer Server(CDB, FS, Opts);
2863
2864 FS.Files[testPath("foo.h")] = R"cpp(
2865 struct Foo {
2866 // Member doc
2867 int foo();
2868 };
2869 )cpp";
2870 Annotations FileContent(R"cpp(
2871 #include "foo.h"
2872 void test() {
2873 Foo f;
2874 f.foo(^);
2875 }
2876 )cpp");
2877 auto File = testPath("test.cpp");
2878 Server.addDocument(File, FileContent.code());
2879 // Wait for the dynamic index being built.
2880 ASSERT_TRUE(Server.blockUntilIdleForTest());
2881 EXPECT_THAT(llvm::cantFail(runSignatureHelp(Server, File, FileContent.point(),
2883 .signatures,
2884 ElementsAre(AllOf(sig("foo() -> int"), sigDoc("Member doc"))));
2885}
2886
2887TEST(CompletionTest, ArgumentListsPolicy) {
2889 Opts.EnableSnippets = true;
2890 Opts.ArgumentLists = Config::ArgumentListsPolicy::Delimiters;
2891
2892 {
2893 auto Results = completions(
2894 R"cpp(
2895 void xfoo();
2896 void xfoo(int x, int y);
2897 void f() { xfo^ })cpp",
2898 {}, Opts);
2899 EXPECT_THAT(
2900 Results.Completions,
2901 UnorderedElementsAre(AllOf(named("xfoo"), snippetSuffix("()")),
2902 AllOf(named("xfoo"), snippetSuffix("($0)"))));
2903 }
2904 {
2905 auto Results = completions(
2906 R"cpp(
2907 void xbar();
2908 void f() { xba^ })cpp",
2909 {}, Opts);
2910 EXPECT_THAT(Results.Completions, UnorderedElementsAre(AllOf(
2911 named("xbar"), snippetSuffix("()"))));
2912 }
2913 {
2914 Opts.BundleOverloads = true;
2915 auto Results = completions(
2916 R"cpp(
2917 void xfoo();
2918 void xfoo(int x, int y);
2919 void f() { xfo^ })cpp",
2920 {}, Opts);
2921 EXPECT_THAT(
2922 Results.Completions,
2923 UnorderedElementsAre(AllOf(named("xfoo"), snippetSuffix("($0)"))));
2924 }
2925 {
2926 auto Results = completions(
2927 R"cpp(
2928 template <class T, class U>
2929 void xfoo(int a, U b);
2930 void f() { xfo^ })cpp",
2931 {}, Opts);
2932 EXPECT_THAT(
2933 Results.Completions,
2934 UnorderedElementsAre(AllOf(named("xfoo"), snippetSuffix("<$1>($0)"))));
2935 }
2936 {
2937 auto Results = completions(
2938 R"cpp(
2939 template <class T>
2940 class foo_class{};
2941 template <class T>
2942 using foo_alias = T**;
2943 template <class T>
2944 T foo_var = T{};
2945 void f() { foo_^ })cpp",
2946 {}, Opts);
2947 EXPECT_THAT(
2948 Results.Completions,
2949 UnorderedElementsAre(AllOf(named("foo_class"), snippetSuffix("<$0>")),
2950 AllOf(named("foo_alias"), snippetSuffix("<$0>")),
2951 AllOf(named("foo_var"), snippetSuffix("<$0>"))));
2952 }
2953 {
2954 auto Results = completions(
2955 R"cpp(
2956 #define FOO(x, y) x##f
2957 FO^ )cpp",
2958 {}, Opts);
2959 EXPECT_THAT(Results.Completions, UnorderedElementsAre(AllOf(
2960 named("FOO"), snippetSuffix("($0)"))));
2961 }
2962 {
2963 auto Results = completions(
2964 R"cpp(
2965 void function() {
2966 auto Lambda = [](int a, const double &b) {return 1.f;};
2967 Lam^
2968 })cpp",
2969 {}, Opts);
2970 EXPECT_THAT(
2971 Results.Completions,
2972 UnorderedElementsAre(AllOf(named("Lambda"), snippetSuffix("($0)"))));
2973 }
2974 {
2975 Opts.ArgumentLists = Config::ArgumentListsPolicy::None;
2976 auto Results = completions(
2977 R"cpp(
2978 void xfoo(int x, int y);
2979 void f() { xfo^ })cpp",
2980 {}, Opts);
2981 EXPECT_THAT(Results.Completions,
2982 UnorderedElementsAre(AllOf(named("xfoo"), snippetSuffix(""))));
2983 }
2984 {
2985 Opts.ArgumentLists = Config::ArgumentListsPolicy::OpenDelimiter;
2986 auto Results = completions(
2987 R"cpp(
2988 void xfoo(int x, int y);
2989 void f() { xfo^ })cpp",
2990 {}, Opts);
2991 EXPECT_THAT(Results.Completions,
2992 UnorderedElementsAre(AllOf(named("xfoo"), snippetSuffix("("))));
2993 }
2994}
2995
2996TEST(CompletionTest, SuggestOverrides) {
2997 constexpr const char *const Text(R"cpp(
2998 class A {
2999 public:
3000 virtual void vfunc(bool param);
3001 virtual void vfunc(bool param, int p);
3002 void func(bool param);
3003 };
3004 class B : public A {
3005 virtual void ttt(bool param) const;
3006 void vfunc(bool param, int p) override;
3007 };
3008 class C : public B {
3009 public:
3010 void vfunc(bool param) override;
3011 ^
3012 };
3013 )cpp");
3014 const auto Results = completions(Text);
3015 EXPECT_THAT(
3016 Results.Completions,
3017 AllOf(Contains(AllOf(labeled("void vfunc(bool param, int p) override"),
3018 nameStartsWith("vfunc"))),
3019 Contains(AllOf(labeled("void ttt(bool param) const override"),
3020 nameStartsWith("ttt"))),
3021 Not(Contains(labeled("void vfunc(bool param) override")))));
3022}
3023
3024TEST(CompletionTest, OverridesNonIdentName) {
3025 // Check the completions call does not crash.
3026 completions(R"cpp(
3027 struct Base {
3028 virtual ~Base() = 0;
3029 virtual operator int() = 0;
3030 virtual Base& operator+(Base&) = 0;
3031 };
3032
3033 struct Derived : Base {
3034 ^
3035 };
3036 )cpp");
3037}
3038
3039TEST(CompletionTest, NoCrashOnMissingNewLineAtEOF) {
3040 auto FooCpp = testPath("foo.cpp");
3041
3043 MockFS FS;
3044 Annotations F("#pragma ^ // no new line");
3045 FS.Files[FooCpp] = F.code().str();
3046 ClangdServer Server(CDB, FS, ClangdServer::optsForTest());
3047 runAddDocument(Server, FooCpp, F.code());
3048 // Run completion outside the file range.
3049 EXPECT_THAT(cantFail(runCodeComplete(Server, FooCpp, F.point(),
3050 clangd::CodeCompleteOptions()))
3051 .Completions,
3052 IsEmpty());
3053 EXPECT_THAT(cantFail(runSignatureHelp(Server, FooCpp, F.point(),
3055 .signatures,
3056 IsEmpty());
3057}
3058
3059TEST(GuessCompletionPrefix, Filters) {
3060 for (llvm::StringRef Case : {
3061 "[[scope::]][[ident]]^",
3062 "[[]][[]]^",
3063 "\n[[]][[]]^",
3064 "[[]][[ab]]^",
3065 "x.[[]][[ab]]^",
3066 "x.[[]][[]]^",
3067 "[[x::]][[ab]]^",
3068 "[[x::]][[]]^",
3069 "[[::x::]][[ab]]^",
3070 "some text [[scope::more::]][[identif]]^ier",
3071 "some text [[scope::]][[mor]]^e::identifier",
3072 "weird case foo::[[::bar::]][[baz]]^",
3073 "/* [[]][[]]^ */",
3074 }) {
3075 Annotations F(Case);
3076 auto Offset = cantFail(positionToOffset(F.code(), F.point()));
3077 auto ToStringRef = [&](Range R) {
3078 return F.code().slice(cantFail(positionToOffset(F.code(), R.start)),
3079 cantFail(positionToOffset(F.code(), R.end)));
3080 };
3081 auto WantQualifier = ToStringRef(F.ranges()[0]),
3082 WantName = ToStringRef(F.ranges()[1]);
3083
3084 auto Prefix = guessCompletionPrefix(F.code(), Offset);
3085 // Even when components are empty, check their offsets are correct.
3086 EXPECT_EQ(WantQualifier, Prefix.Qualifier) << Case;
3087 EXPECT_EQ(WantQualifier.begin(), Prefix.Qualifier.begin()) << Case;
3088 EXPECT_EQ(WantName, Prefix.Name) << Case;
3089 EXPECT_EQ(WantName.begin(), Prefix.Name.begin()) << Case;
3090 }
3091}
3092
3093TEST(CompletionTest, EnableSpeculativeIndexRequest) {
3094 MockFS FS;
3096 ClangdServer Server(CDB, FS, ClangdServer::optsForTest());
3097
3098 auto File = testPath("foo.cpp");
3099 Annotations Test(R"cpp(
3100 namespace ns1 { int abc; }
3101 namespace ns2 { int abc; }
3102 void f() { ns1::ab$1^; ns1::ab$2^; }
3103 void f2() { ns2::ab$3^; }
3104 )cpp");
3105 runAddDocument(Server, File, Test.code());
3106 clangd::CodeCompleteOptions Opts = {};
3107
3108 IndexRequestCollector Requests;
3109 Opts.Index = &Requests;
3110
3111 auto CompleteAtPoint = [&](StringRef P) {
3112 auto CCR = cantFail(runCodeComplete(Server, File, Test.point(P), Opts));
3113 EXPECT_TRUE(CCR.HasMore);
3114 };
3115
3116 CompleteAtPoint("1");
3117 auto Reqs1 = Requests.consumeRequests(1);
3118 ASSERT_EQ(Reqs1.size(), 1u);
3119 EXPECT_THAT(Reqs1[0].Scopes, UnorderedElementsAre("ns1::"));
3120
3121 CompleteAtPoint("2");
3122 auto Reqs2 = Requests.consumeRequests(1);
3123 // Speculation succeeded. Used speculative index result.
3124 ASSERT_EQ(Reqs2.size(), 1u);
3125 EXPECT_EQ(Reqs2[0], Reqs1[0]);
3126
3127 CompleteAtPoint("3");
3128 // Speculation failed. Sent speculative index request and the new index
3129 // request after sema.
3130 auto Reqs3 = Requests.consumeRequests(2);
3131 ASSERT_EQ(Reqs3.size(), 2u);
3132}
3133
3134TEST(CompletionTest, InsertTheMostPopularHeader) {
3135 std::string DeclFile = URI::create(testPath("foo")).toString();
3136 Symbol Sym = func("Func");
3137 Sym.CanonicalDeclaration.FileURI = DeclFile.c_str();
3138 Sym.IncludeHeaders.emplace_back("\"foo.h\"", 2, Symbol::Include);
3139 Sym.IncludeHeaders.emplace_back("\"bar.h\"", 1000, Symbol::Include);
3140
3141 auto Results = completions("Fun^", {Sym}).Completions;
3142 assert(!Results.empty());
3143 EXPECT_THAT(Results[0], AllOf(named("Func"), insertInclude("\"bar.h\"")));
3144 EXPECT_EQ(Results[0].Includes.size(), 2u);
3145}
3146
3147TEST(CompletionTest, InsertIncludeOrImport) {
3148 std::string DeclFile = URI::create(testPath("foo")).toString();
3149 Symbol Sym = func("Func");
3150 Sym.CanonicalDeclaration.FileURI = DeclFile.c_str();
3151 Sym.IncludeHeaders.emplace_back("\"bar.h\"", 1000,
3154 // Should only take effect in import contexts.
3155 Opts.ImportInsertions = true;
3156 auto Results = completions("Fun^", {Sym}, Opts).Completions;
3157 assert(!Results.empty());
3158 EXPECT_THAT(Results[0],
3159 AllOf(named("Func"), insertIncludeText("#include \"bar.h\"\n")));
3160
3161 ASTSignals Signals;
3163 Opts.MainFileSignals = &Signals;
3164 Results = completions("Fun^", {Sym}, Opts, "Foo.m").Completions;
3165 assert(!Results.empty());
3166 EXPECT_THAT(Results[0],
3167 AllOf(named("Func"), insertIncludeText("#import \"bar.h\"\n")));
3168
3169 Sym.IncludeHeaders[0].SupportedDirectives = Symbol::Import;
3170 Results = completions("Fun^", {Sym}).Completions;
3171 assert(!Results.empty());
3172 EXPECT_THAT(Results[0], AllOf(named("Func"), Not(insertInclude())));
3173}
3174
3175TEST(CompletionTest, NoInsertIncludeIfOnePresent) {
3176 Annotations Test(R"cpp(
3177 #include "foo.h"
3178 Fun^
3179 )cpp");
3180 auto TU = TestTU::withCode(Test.code());
3181 TU.AdditionalFiles["foo.h"] = "";
3182
3183 std::string DeclFile = URI::create(testPath("foo")).toString();
3184 Symbol Sym = func("Func");
3185 Sym.CanonicalDeclaration.FileURI = DeclFile.c_str();
3186 Sym.IncludeHeaders.emplace_back("\"foo.h\"", 2, Symbol::Include);
3187 Sym.IncludeHeaders.emplace_back("\"bar.h\"", 1000, Symbol::Include);
3188
3189 EXPECT_THAT(completions(TU, Test.point(), {Sym}).Completions,
3190 UnorderedElementsAre(AllOf(named("Func"), hasInclude("\"foo.h\""),
3191 Not(insertInclude()))));
3192}
3193
3194TEST(CompletionTest, MergeMacrosFromIndexAndSema) {
3195 Symbol Sym;
3196 Sym.Name = "Clangd_Macro_Test";
3197 Sym.ID = SymbolID("c:foo.cpp@8@macro@Clangd_Macro_Test");
3198 Sym.SymInfo.Kind = index::SymbolKind::Macro;
3200 EXPECT_THAT(completions("#define Clangd_Macro_Test\nClangd_Macro_T^", {Sym})
3201 .Completions,
3202 UnorderedElementsAre(named("Clangd_Macro_Test")));
3203}
3204
3205TEST(CompletionTest, MacroFromPreamble) {
3206 Annotations Test(R"cpp(#define CLANGD_PREAMBLE_MAIN x
3207
3208 int x = 0;
3209 #define CLANGD_MAIN x
3210 void f() { CLANGD_^ }
3211 )cpp");
3212 auto TU = TestTU::withCode(Test.code());
3213 TU.HeaderCode = "#define CLANGD_PREAMBLE_HEADER x";
3214 auto Results = completions(TU, Test.point(), {func("CLANGD_INDEX")});
3215 // We should get results from the main file, including the preamble section.
3216 // However no results from included files (the index should cover them).
3217 EXPECT_THAT(Results.Completions,
3218 UnorderedElementsAre(named("CLANGD_PREAMBLE_MAIN"),
3219 named("CLANGD_MAIN"),
3220 named("CLANGD_INDEX")));
3221}
3222
3223TEST(CompletionTest, DeprecatedResults) {
3224 std::string Body = R"cpp(
3225 void TestClangd();
3226 void TestClangc() __attribute__((deprecated("", "")));
3227 )cpp";
3228
3229 EXPECT_THAT(
3230 completions(Body + "int main() { TestClang^ }").Completions,
3231 UnorderedElementsAre(AllOf(named("TestClangd"), Not(deprecated())),
3232 AllOf(named("TestClangc"), deprecated())));
3233}
3234
3235TEST(SignatureHelpTest, PartialSpec) {
3236 const auto Results = signatures(R"cpp(
3237 template <typename T> struct Foo {};
3238 template <typename T> struct Foo<T*> { Foo(T); };
3239 Foo<int*> F(^);)cpp");
3240 EXPECT_THAT(Results.signatures, Contains(sig("Foo([[T]])")));
3241 EXPECT_EQ(0, Results.activeParameter);
3242}
3243
3244TEST(SignatureHelpTest, InsideArgument) {
3245 {
3246 const auto Results = signatures(R"cpp(
3247 void foo(int x);
3248 void foo(int x, int y);
3249 int main() { foo(1+^); }
3250 )cpp");
3251 EXPECT_THAT(Results.signatures,
3252 ElementsAre(sig("foo([[int x]]) -> void"),
3253 sig("foo([[int x]], [[int y]]) -> void")));
3254 EXPECT_EQ(0, Results.activeParameter);
3255 }
3256 {
3257 const auto Results = signatures(R"cpp(
3258 void foo(int x);
3259 void foo(int x, int y);
3260 int main() { foo(1^); }
3261 )cpp");
3262 EXPECT_THAT(Results.signatures,
3263 ElementsAre(sig("foo([[int x]]) -> void"),
3264 sig("foo([[int x]], [[int y]]) -> void")));
3265 EXPECT_EQ(0, Results.activeParameter);
3266 }
3267 {
3268 const auto Results = signatures(R"cpp(
3269 void foo(int x);
3270 void foo(int x, int y);
3271 int main() { foo(1^0); }
3272 )cpp");
3273 EXPECT_THAT(Results.signatures,
3274 ElementsAre(sig("foo([[int x]]) -> void"),
3275 sig("foo([[int x]], [[int y]]) -> void")));
3276 EXPECT_EQ(0, Results.activeParameter);
3277 }
3278 {
3279 const auto Results = signatures(R"cpp(
3280 void foo(int x);
3281 void foo(int x, int y);
3282 int bar(int x, int y);
3283 int main() { bar(foo(2, 3^)); }
3284 )cpp");
3285 EXPECT_THAT(Results.signatures,
3286 ElementsAre(sig("foo([[int x]], [[int y]]) -> void")));
3287 EXPECT_EQ(1, Results.activeParameter);
3288 }
3289}
3290
3291TEST(SignatureHelpTest, ConstructorInitializeFields) {
3292 {
3293 const auto Results = signatures(R"cpp(
3294 struct A { A(int); };
3295 struct B {
3296 B() : a_elem(^) {}
3297 A a_elem;
3298 };
3299 )cpp");
3300 EXPECT_THAT(Results.signatures,
3301 UnorderedElementsAre(sig("A([[int]])"), sig("A([[A &&]])"),
3302 sig("A([[const A &]])")));
3303 }
3304 {
3305 const auto Results = signatures(R"cpp(
3306 struct A { A(int); };
3307 struct B {
3308 B() : a_elem(^
3309 A a_elem;
3310 };
3311 )cpp");
3312 // FIXME: currently the parser skips over the decl of a_elem as part of the
3313 // (broken) init list, so we don't get signatures for the first member.
3314 EXPECT_THAT(Results.signatures, IsEmpty());
3315 }
3316 {
3317 const auto Results = signatures(R"cpp(
3318 struct A { A(int); };
3319 struct B {
3320 B() : a_elem(^
3321 int dummy_elem;
3322 A a_elem;
3323 };
3324 )cpp");
3325 EXPECT_THAT(Results.signatures,
3326 UnorderedElementsAre(sig("A([[int]])"), sig("A([[A &&]])"),
3327 sig("A([[const A &]])")));
3328 }
3329 {
3330 const auto Results = signatures(R"cpp(
3331 struct A {
3332 A(int);
3333 };
3334 struct C {
3335 C(int);
3336 C(A);
3337 };
3338 struct B {
3339 B() : c_elem(A(1^)) {}
3340 C c_elem;
3341 };
3342 )cpp");
3343 EXPECT_THAT(Results.signatures,
3344 UnorderedElementsAre(sig("A([[int]])"), sig("A([[A &&]])"),
3345 sig("A([[const A &]])")));
3346 }
3347}
3348
3349TEST(SignatureHelpTest, Variadic) {
3350 const std::string Header = R"cpp(
3351 void fun(int x, ...) {}
3352 void test() {)cpp";
3353 const std::string ExpectedSig = "fun([[int x]], [[...]]) -> void";
3354
3355 {
3356 const auto Result = signatures(Header + "fun(^);}");
3357 EXPECT_EQ(0, Result.activeParameter);
3358 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3359 }
3360 {
3361 const auto Result = signatures(Header + "fun(1, ^);}");
3362 EXPECT_EQ(1, Result.activeParameter);
3363 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3364 }
3365 {
3366 const auto Result = signatures(Header + "fun(1, 2, ^);}");
3367 EXPECT_EQ(1, Result.activeParameter);
3368 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3369 }
3370}
3371
3372TEST(SignatureHelpTest, VariadicTemplate) {
3373 const std::string Header = R"cpp(
3374 template<typename T, typename ...Args>
3375 void fun(T t, Args ...args) {}
3376 void test() {)cpp";
3377 const std::string ExpectedSig = "fun([[T t]], [[Args args...]]) -> void";
3378
3379 {
3380 const auto Result = signatures(Header + "fun(^);}");
3381 EXPECT_EQ(0, Result.activeParameter);
3382 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3383 }
3384 {
3385 const auto Result = signatures(Header + "fun(1, ^);}");
3386 EXPECT_EQ(1, Result.activeParameter);
3387 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3388 }
3389 {
3390 const auto Result = signatures(Header + "fun(1, 2, ^);}");
3391 EXPECT_EQ(1, Result.activeParameter);
3392 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3393 }
3394}
3395
3396TEST(SignatureHelpTest, VariadicMethod) {
3397 const std::string Header = R"cpp(
3398 class C {
3399 template<typename T, typename ...Args>
3400 void fun(T t, Args ...args) {}
3401 };
3402 void test() {C c; )cpp";
3403 const std::string ExpectedSig = "fun([[T t]], [[Args args...]]) -> void";
3404
3405 {
3406 const auto Result = signatures(Header + "c.fun(^);}");
3407 EXPECT_EQ(0, Result.activeParameter);
3408 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3409 }
3410 {
3411 const auto Result = signatures(Header + "c.fun(1, ^);}");
3412 EXPECT_EQ(1, Result.activeParameter);
3413 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3414 }
3415 {
3416 const auto Result = signatures(Header + "c.fun(1, 2, ^);}");
3417 EXPECT_EQ(1, Result.activeParameter);
3418 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3419 }
3420}
3421
3422TEST(SignatureHelpTest, VariadicType) {
3423 const std::string Header = R"cpp(
3424 void fun(int x, ...) {}
3425 auto get_fun() { return fun; }
3426 void test() {
3427 )cpp";
3428 const std::string ExpectedSig = "([[int]], [[...]]) -> void";
3429
3430 {
3431 const auto Result = signatures(Header + "get_fun()(^);}");
3432 EXPECT_EQ(0, Result.activeParameter);
3433 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3434 }
3435 {
3436 const auto Result = signatures(Header + "get_fun()(1, ^);}");
3437 EXPECT_EQ(1, Result.activeParameter);
3438 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3439 }
3440 {
3441 const auto Result = signatures(Header + "get_fun()(1, 2, ^);}");
3442 EXPECT_EQ(1, Result.activeParameter);
3443 EXPECT_THAT(Result.signatures, UnorderedElementsAre(sig(ExpectedSig)));
3444 }
3445}
3446
3447TEST(SignatureHelpTest, SkipExplicitObjectParameter) {
3448 Annotations Code(R"cpp(
3449 struct A {
3450 void foo(this auto&& self, int arg);
3451 void bar(this A self, int arg);
3452 };
3453 int main() {
3454 A a {};
3455 a.foo($c1^);
3456 (&A::bar)($c2^);
3457 (&A::foo)($c3^);
3458 }
3459 )cpp");
3460
3461 auto TU = TestTU::withCode(Code.code());
3462 TU.ExtraArgs = {"-std=c++23"};
3463
3464 MockFS FS;
3465 auto Inputs = TU.inputs(FS);
3466
3467 auto Preamble = TU.preamble();
3468 ASSERT_TRUE(Preamble);
3469
3470 {
3471 const auto Result = signatureHelp(testPath(TU.Filename), Code.point("c1"),
3473
3474 EXPECT_EQ(1U, Result.signatures.size());
3475
3476 EXPECT_THAT(Result.signatures[0], AllOf(sig("foo([[int arg]]) -> void")));
3477 }
3478 {
3479 const auto Result = signatureHelp(testPath(TU.Filename), Code.point("c2"),
3481
3482 EXPECT_EQ(1U, Result.signatures.size());
3483
3484 EXPECT_THAT(Result.signatures[0], AllOf(sig("([[A]], [[int]]) -> void")));
3485 }
3486 {
3487 // TODO: llvm/llvm-project/146649
3488 const auto Result = signatureHelp(testPath(TU.Filename), Code.point("c3"),
3490 // TODO: We expect 1 signature here, with this signature
3491 EXPECT_EQ(0U, Result.signatures.size());
3492 // EXPECT_THAT(Result.signatures[0], AllOf(sig("([[auto&&]], [[int]]) ->
3493 // void")));
3494 }
3495}
3496
3497TEST(CompletionTest, IncludedCompletionKinds) {
3498 Annotations Test(R"cpp(#include "^)cpp");
3499 auto TU = TestTU::withCode(Test.code());
3500 TU.AdditionalFiles["sub/bar.h"] = "";
3501 TU.ExtraArgs.push_back("-I" + testPath("sub"));
3502
3503 auto Results = completions(TU, Test.point());
3504 EXPECT_THAT(Results.Completions,
3505 AllOf(has("sub/", CompletionItemKind::Folder),
3506 has("bar.h\"", CompletionItemKind::File)));
3507}
3508
3509TEST(CompletionTest, NoCrashAtNonAlphaIncludeHeader) {
3510 completions(
3511 R"cpp(
3512 #include "./^"
3513 )cpp");
3514}
3515
3516TEST(CompletionTest, NoAllScopesCompletionWhenQualified) {
3517 clangd::CodeCompleteOptions Opts = {};
3518 Opts.AllScopes = true;
3519
3520 auto Results = completions(
3521 R"cpp(
3522 void f() { na::Clangd^ }
3523 )cpp",
3524 {cls("na::ClangdA"), cls("nx::ClangdX"), cls("Clangd3")}, Opts);
3525 EXPECT_THAT(Results.Completions,
3526 UnorderedElementsAre(
3527 AllOf(qualifier(""), scope("na::"), named("ClangdA"))));
3528}
3529
3530TEST(CompletionTest, AllScopesCompletion) {
3531 clangd::CodeCompleteOptions Opts = {};
3532 Opts.AllScopes = true;
3533
3534 auto Results = completions(
3535 R"cpp(
3536 namespace na {
3537 void f() { Clangd^ }
3538 }
3539 )cpp",
3540 {cls("nx::Clangd1"), cls("ny::Clangd2"), cls("Clangd3"),
3541 cls("na::nb::Clangd4"), enmConstant("na::C::Clangd5")},
3542 Opts);
3543 EXPECT_THAT(
3544 Results.Completions,
3545 UnorderedElementsAre(AllOf(qualifier("nx::"), named("Clangd1"),
3547 AllOf(qualifier("ny::"), named("Clangd2"),
3549 AllOf(qualifier(""), scope(""), named("Clangd3"),
3551 AllOf(qualifier("nb::"), named("Clangd4"),
3553 AllOf(qualifier("C::"), named("Clangd5"),
3555}
3556
3557TEST(CompletionTest, NoCodePatternsIfDisabled) {
3558 clangd::CodeCompleteOptions Opts = {};
3559 Opts.EnableSnippets = true;
3560 Opts.CodePatterns = Config::CodePatternsPolicy::None;
3561
3562 auto Results = completions(R"cpp(
3563 void function() {
3564 /// Trying to trigger "for (init-statement; condition; inc-expression)
3565 /// {statements}~" code pattern
3566 for^
3567 }
3568 )cpp",
3569 {}, Opts);
3570
3571 EXPECT_THAT(Results.Completions,
3572 Not(Contains(kind(CompletionItemKind::Snippet))));
3573}
3574
3575TEST(CompletionTest, CompleteIncludeIfCodePatternsNone) {
3576 clangd::CodeCompleteOptions Opts = {};
3577 Opts.EnableSnippets = true;
3578 Opts.CodePatterns = Config::CodePatternsPolicy::None;
3579
3580 Annotations Test(R"cpp(#include "^)cpp");
3581 auto TU = TestTU::withCode(Test.code());
3582 TU.AdditionalFiles["foo/bar.h"] = "";
3583 TU.ExtraArgs.push_back("-I" + testPath("foo"));
3584
3585 auto Results = completions(TU, Test.point(), {}, Opts);
3586 EXPECT_THAT(Results.Completions,
3587 AllOf(has("foo/", CompletionItemKind::Folder),
3588 has("bar.h\"", CompletionItemKind::File)));
3589}
3590
3591TEST(CompletionTest, NoQualifierIfShadowed) {
3592 clangd::CodeCompleteOptions Opts = {};
3593 Opts.AllScopes = true;
3594
3595 auto Results = completions(R"cpp(
3596 namespace nx { class Clangd1 {}; }
3597 using nx::Clangd1;
3598 void f() { Clangd^ }
3599 )cpp",
3600 {cls("nx::Clangd1"), cls("nx::Clangd2")}, Opts);
3601 // Although Clangd1 is from another namespace, Sema tells us it's in-scope and
3602 // needs no qualifier.
3603 EXPECT_THAT(Results.Completions,
3604 UnorderedElementsAre(AllOf(qualifier(""), named("Clangd1")),
3605 AllOf(qualifier("nx::"), named("Clangd2"))));
3606}
3607
3608TEST(CompletionTest, NoCompletionsForNewNames) {
3609 clangd::CodeCompleteOptions Opts;
3610 Opts.AllScopes = true;
3611 auto Results = completions(R"cpp(
3612 void f() { int n^ }
3613 )cpp",
3614 {cls("naber"), cls("nx::naber")}, Opts);
3615 EXPECT_THAT(Results.Completions, UnorderedElementsAre());
3616}
3617
3618TEST(CompletionTest, Lambda) {
3619 clangd::CodeCompleteOptions Opts = {};
3620
3621 auto Results = completions(R"cpp(
3622 void function() {
3623 auto Lambda = [](int a, const double &b) {return 1.f;};
3624 Lam^
3625 }
3626 )cpp",
3627 {}, Opts);
3628
3629 ASSERT_EQ(Results.Completions.size(), 1u);
3630 const auto &A = Results.Completions.front();
3631 EXPECT_EQ(A.Name, "Lambda");
3632 EXPECT_EQ(A.Signature, "(int a, const double &b) const");
3633 EXPECT_EQ(A.Kind, CompletionItemKind::Variable);
3634 EXPECT_EQ(A.ReturnType, "float");
3635 EXPECT_EQ(A.SnippetSuffix, "(${1:int a}, ${2:const double &b})");
3636}
3637
3638TEST(CompletionTest, StructuredBinding) {
3639 clangd::CodeCompleteOptions Opts = {};
3640
3641 auto Results = completions(R"cpp(
3642 struct S {
3643 using Float = float;
3644 int x;
3645 Float y;
3646 };
3647 void function() {
3648 const auto &[xxx, yyy] = S{};
3649 yyy^
3650 }
3651 )cpp",
3652 {}, Opts);
3653
3654 ASSERT_EQ(Results.Completions.size(), 1u);
3655 const auto &A = Results.Completions.front();
3656 EXPECT_EQ(A.Name, "yyy");
3657 EXPECT_EQ(A.Kind, CompletionItemKind::Variable);
3658 EXPECT_EQ(A.ReturnType, "const Float");
3659}
3660
3661TEST(CompletionTest, ObjectiveCMethodNoArguments) {
3662 auto Results = completions(R"objc(
3663 @interface Foo
3664 @property(nonatomic, setter=setXToIgnoreComplete:) int value;
3665 @end
3666 Foo *foo = [Foo new]; int y = [foo v^]
3667 )objc",
3668 /*IndexSymbols=*/{},
3669 /*Opts=*/{}, "Foo.m");
3670
3671 auto C = Results.Completions;
3672 EXPECT_THAT(C, ElementsAre(named("value")));
3673 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3674 EXPECT_THAT(C, ElementsAre(returnType("int")));
3675 EXPECT_THAT(C, ElementsAre(signature("")));
3676 EXPECT_THAT(C, ElementsAre(snippetSuffix("")));
3677}
3678
3679TEST(CompletionTest, ObjectiveCMethodOneArgument) {
3680 auto Results = completions(R"objc(
3681 @interface Foo
3682 - (int)valueForCharacter:(char)c;
3683 @end
3684 Foo *foo = [Foo new]; int y = [foo v^]
3685 )objc",
3686 /*IndexSymbols=*/{},
3687 /*Opts=*/{}, "Foo.m");
3688
3689 auto C = Results.Completions;
3690 EXPECT_THAT(C, ElementsAre(named("valueForCharacter:")));
3691 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3692 EXPECT_THAT(C, ElementsAre(returnType("int")));
3693 EXPECT_THAT(C, ElementsAre(signature("(char)")));
3694 EXPECT_THAT(C, ElementsAre(snippetSuffix("${1:(char)}")));
3695}
3696
3697TEST(CompletionTest, ObjectiveCMethodTwoArgumentsFromBeginning) {
3698 auto Results = completions(R"objc(
3699 @interface Foo
3700 + (id)fooWithValue:(int)value fooey:(unsigned int)fooey;
3701 @end
3702 id val = [Foo foo^]
3703 )objc",
3704 /*IndexSymbols=*/{},
3705 /*Opts=*/{}, "Foo.m");
3706
3707 auto C = Results.Completions;
3708 EXPECT_THAT(C, ElementsAre(named("fooWithValue:")));
3709 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3710 EXPECT_THAT(C, ElementsAre(returnType("id")));
3711 EXPECT_THAT(C, ElementsAre(signature("(int) fooey:(unsigned int)")));
3712 EXPECT_THAT(
3713 C, ElementsAre(snippetSuffix("${1:(int)} fooey:${2:(unsigned int)}")));
3714}
3715
3716TEST(CompletionTest, ObjectiveCMethodTwoArgumentsFromMiddle) {
3717 auto Results = completions(R"objc(
3718 @interface Foo
3719 + (id)fooWithValue:(int)value fooey:(unsigned int)fooey;
3720 @end
3721 id val = [Foo fooWithValue:10 f^]
3722 )objc",
3723 /*IndexSymbols=*/{},
3724 /*Opts=*/{}, "Foo.m");
3725
3726 auto C = Results.Completions;
3727 EXPECT_THAT(C, ElementsAre(named("fooey:")));
3728 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3729 EXPECT_THAT(C, ElementsAre(returnType("id")));
3730 EXPECT_THAT(C, ElementsAre(signature("(unsigned int)")));
3731 EXPECT_THAT(C, ElementsAre(snippetSuffix("${1:(unsigned int)}")));
3732}
3733
3734TEST(CompletionTest, ObjectiveCMethodFilterOnEntireSelector) {
3735 auto Results = completions(R"objc(
3736 @interface Foo
3737 + (id)player:(id)player willRun:(id)run;
3738 @end
3739 id val = [Foo wi^]
3740 )objc",
3741 /*IndexSymbols=*/{},
3742 /*Opts=*/{}, "Foo.m");
3743
3744 auto C = Results.Completions;
3745 EXPECT_THAT(C, ElementsAre(named("player:")));
3746 EXPECT_THAT(C, ElementsAre(filterText("player:willRun:")));
3747 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3748 EXPECT_THAT(C, ElementsAre(returnType("id")));
3749 EXPECT_THAT(C, ElementsAre(signature("(id) willRun:(id)")));
3750 EXPECT_THAT(C, ElementsAre(snippetSuffix("${1:(id)} willRun:${2:(id)}")));
3751}
3752
3753TEST(CompletionTest, ObjectiveCSimpleMethodDeclaration) {
3754 auto Results = completions(R"objc(
3755 @interface Foo
3756 - (void)foo;
3757 @end
3758 @implementation Foo
3759 fo^
3760 @end
3761 )objc",
3762 /*IndexSymbols=*/{},
3763 /*Opts=*/{}, "Foo.m");
3764
3765 auto C = Results.Completions;
3766 EXPECT_THAT(C, ElementsAre(named("foo")));
3767 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3768 EXPECT_THAT(C, ElementsAre(qualifier("- (void)")));
3769}
3770
3771TEST(CompletionTest, ObjectiveCMethodDeclaration) {
3772 auto Results = completions(R"objc(
3773 @interface Foo
3774 - (int)valueForCharacter:(char)c secondArgument:(id)object;
3775 @end
3776 @implementation Foo
3777 valueFor^
3778 @end
3779 )objc",
3780 /*IndexSymbols=*/{},
3781 /*Opts=*/{}, "Foo.m");
3782
3783 auto C = Results.Completions;
3784 EXPECT_THAT(C, ElementsAre(named("valueForCharacter:")));
3785 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3786 EXPECT_THAT(C, ElementsAre(qualifier("- (int)")));
3787 EXPECT_THAT(C, ElementsAre(signature("(char)c secondArgument:(id)object")));
3788}
3789
3790TEST(CompletionTest, ObjectiveCMethodDeclarationFilterOnEntireSelector) {
3791 auto Results = completions(R"objc(
3792 @interface Foo
3793 - (int)valueForCharacter:(char)c secondArgument:(id)object;
3794 @end
3795 @implementation Foo
3796 secondArg^
3797 @end
3798 )objc",
3799 /*IndexSymbols=*/{},
3800 /*Opts=*/{}, "Foo.m");
3801
3802 auto C = Results.Completions;
3803 EXPECT_THAT(C, ElementsAre(named("valueForCharacter:")));
3804 EXPECT_THAT(C, ElementsAre(filterText("valueForCharacter:secondArgument:")));
3805 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3806 EXPECT_THAT(C, ElementsAre(qualifier("- (int)")));
3807 EXPECT_THAT(C, ElementsAre(signature("(char)c secondArgument:(id)object")));
3808}
3809
3810TEST(CompletionTest, ObjectiveCMethodDeclarationPrefixTyped) {
3811 auto Results = completions(R"objc(
3812 @interface Foo
3813 - (int)valueForCharacter:(char)c;
3814 @end
3815 @implementation Foo
3816 - (int)valueFor^
3817 @end
3818 )objc",
3819 /*IndexSymbols=*/{},
3820 /*Opts=*/{}, "Foo.m");
3821
3822 auto C = Results.Completions;
3823 EXPECT_THAT(C, ElementsAre(named("valueForCharacter:")));
3824 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3825 EXPECT_THAT(C, ElementsAre(signature("(char)c")));
3826}
3827
3828TEST(CompletionTest, ObjectiveCMethodDeclarationFromMiddle) {
3829 auto Results = completions(R"objc(
3830 @interface Foo
3831 - (int)valueForCharacter:(char)c secondArgument:(id)object;
3832 @end
3833 @implementation Foo
3834 - (int)valueForCharacter:(char)c second^
3835 @end
3836 )objc",
3837 /*IndexSymbols=*/{},
3838 /*Opts=*/{}, "Foo.m");
3839
3840 auto C = Results.Completions;
3841 EXPECT_THAT(C, ElementsAre(named("secondArgument:")));
3842 EXPECT_THAT(C, ElementsAre(kind(CompletionItemKind::Method)));
3843 EXPECT_THAT(C, ElementsAre(signature("(id)object")));
3844}
3845
3846TEST(CompletionTest, ObjectiveCProtocolFromIndex) {
3847 Symbol FoodClass = objcClass("FoodClass");
3848 Symbol SymFood = objcProtocol("Food");
3849 Symbol SymFooey = objcProtocol("Fooey");
3850 auto Results = completions("id<Foo^>", {SymFood, FoodClass, SymFooey},
3851 /*Opts=*/{}, "Foo.m");
3852
3853 // Should only give protocols for ObjC protocol completions.
3854 EXPECT_THAT(Results.Completions,
3855 UnorderedElementsAre(
3856 AllOf(named("Food"), kind(CompletionItemKind::Interface)),
3857 AllOf(named("Fooey"), kind(CompletionItemKind::Interface))));
3858
3859 Results = completions("Fo^", {SymFood, FoodClass, SymFooey},
3860 /*Opts=*/{}, "Foo.m");
3861 // Shouldn't give protocols for non protocol completions.
3862 EXPECT_THAT(
3863 Results.Completions,
3864 ElementsAre(AllOf(named("FoodClass"), kind(CompletionItemKind::Class))));
3865}
3866
3867TEST(CompletionTest, ObjectiveCProtocolFromIndexSpeculation) {
3868 MockFS FS;
3870 ClangdServer Server(CDB, FS, ClangdServer::optsForTest());
3871
3872 auto File = testPath("Foo.m");
3873 Annotations Test(R"cpp(
3874 @protocol Food
3875 @end
3876 id<Foo$1^> foo;
3877 Foo$2^ bar;
3878 )cpp");
3879 runAddDocument(Server, File, Test.code());
3880 clangd::CodeCompleteOptions Opts = {};
3881
3882 Symbol FoodClass = objcClass("FoodClass");
3883 IndexRequestCollector Requests({FoodClass});
3884 Opts.Index = &Requests;
3885
3886 auto CompleteAtPoint = [&](StringRef P) {
3887 return cantFail(runCodeComplete(Server, File, Test.point(P), Opts))
3888 .Completions;
3889 };
3890
3891 auto C = CompleteAtPoint("1");
3892 auto Reqs1 = Requests.consumeRequests(1);
3893 ASSERT_EQ(Reqs1.size(), 1u);
3894 EXPECT_THAT(C, ElementsAre(AllOf(named("Food"),
3896
3897 C = CompleteAtPoint("2");
3898 auto Reqs2 = Requests.consumeRequests(1);
3899 // Speculation succeeded. Used speculative index result, but filtering now to
3900 // now include FoodClass.
3901 ASSERT_EQ(Reqs2.size(), 1u);
3902 EXPECT_EQ(Reqs2[0], Reqs1[0]);
3903 EXPECT_THAT(C, ElementsAre(AllOf(named("FoodClass"),
3905}
3906
3907TEST(CompletionTest, ObjectiveCCategoryFromIndexIgnored) {
3908 Symbol FoodCategory = objcCategory("FoodClass", "Extension");
3909 auto Results = completions(R"objc(
3910 @interface Foo
3911 @end
3912 @interface Foo (^)
3913 @end
3914 )objc",
3915 {FoodCategory},
3916 /*Opts=*/{}, "Foo.m");
3917 EXPECT_THAT(Results.Completions, IsEmpty());
3918}
3919
3920TEST(CompletionTest, ObjectiveCForwardDeclFromIndex) {
3921 Symbol FoodClass = objcClass("FoodClass");
3922 FoodClass.IncludeHeaders.emplace_back("\"Foo.h\"", 2, Symbol::Import);
3923 Symbol SymFood = objcProtocol("Food");
3924 auto Results = completions("@class Foo^", {SymFood, FoodClass},
3925 /*Opts=*/{}, "Foo.m");
3926
3927 // Should only give class names without any include insertion.
3928 EXPECT_THAT(Results.Completions,
3929 UnorderedElementsAre(AllOf(named("FoodClass"),
3931 Not(insertInclude()))));
3932}
3933
3934TEST(CompletionTest, CursorInSnippets) {
3935 clangd::CodeCompleteOptions Options;
3936 Options.EnableSnippets = true;
3937 auto Results = completions(
3938 R"cpp(
3939 void while_foo(int a, int b);
3940 void test() {
3941 whil^
3942 })cpp",
3943 /*IndexSymbols=*/{}, Options);
3944
3945 // Last placeholder in code patterns should be $0 to put the cursor there.
3946 EXPECT_THAT(Results.Completions,
3947 Contains(AllOf(named("while"),
3948 snippetSuffix(" (${1:condition}) {\n$0\n}"))));
3949 // However, snippets for functions must *not* end with $0.
3950 EXPECT_THAT(Results.Completions,
3951 Contains(AllOf(named("while_foo"),
3952 snippetSuffix("(${1:int a}, ${2:int b})"))));
3953
3954 Results = completions(R"cpp(
3955 struct Base {
3956 Base(int a, int b) {}
3957 };
3958
3959 struct Derived : Base {
3960 Derived() : Base^
3961 };
3962 )cpp",
3963 /*IndexSymbols=*/{}, Options);
3964 // Constructors from base classes are a kind of pattern that shouldn't end
3965 // with $0.
3966 EXPECT_THAT(Results.Completions,
3967 Contains(AllOf(named("Base"),
3968 snippetSuffix("(${1:int a}, ${2:int b})"))));
3969}
3970
3971TEST(CompletionTest, WorksWithNullType) {
3972 auto R = completions(R"cpp(
3973 int main() {
3974 for (auto [loopVar] : y ) { // y has to be unresolved.
3975 int z = loopV^;
3976 }
3977 }
3978 )cpp");
3979 EXPECT_THAT(R.Completions, ElementsAre(named("loopVar")));
3980}
3981
3982TEST(CompletionTest, UsingDecl) {
3983 const char *Header(R"cpp(
3984 void foo(int);
3985 namespace std {
3986 using ::foo;
3987 })cpp");
3988 const char *Source(R"cpp(
3989 void bar() {
3990 std::^;
3991 })cpp");
3992 auto Index = TestTU::withHeaderCode(Header).index();
3993 clangd::CodeCompleteOptions Opts;
3994 Opts.Index = Index.get();
3995 Opts.AllScopes = true;
3996 auto R = completions(Source, {}, Opts);
3997 EXPECT_THAT(R.Completions,
3998 ElementsAre(AllOf(scope("std::"), named("foo"),
4000}
4001
4002TEST(CompletionTest, Enums) {
4003 const char *Header(R"cpp(
4004 namespace ns {
4005 enum Unscoped { Clangd1 };
4006 class C {
4007 enum Unscoped { Clangd2 };
4008 };
4009 enum class Scoped { Clangd3 };
4010 })cpp");
4011 const char *Source(R"cpp(
4012 void bar() {
4013 Clangd^
4014 })cpp");
4015 auto Index = TestTU::withHeaderCode(Header).index();
4016 clangd::CodeCompleteOptions Opts;
4017 Opts.Index = Index.get();
4018 Opts.AllScopes = true;
4019 auto R = completions(Source, {}, Opts);
4020 EXPECT_THAT(R.Completions, UnorderedElementsAre(
4021 AllOf(scope("ns::"), named("Clangd1"),
4023 AllOf(scope("ns::C::"), named("Clangd2"),
4025 AllOf(scope("ns::Scoped::"), named("Clangd3"),
4027}
4028
4029TEST(CompletionTest, ScopeIsUnresolved) {
4030 clangd::CodeCompleteOptions Opts = {};
4031 Opts.AllScopes = true;
4032
4033 auto Results = completions(R"cpp(
4034 namespace a {
4035 void f() { b::X^ }
4036 }
4037 )cpp",
4038 {cls("a::b::XYZ")}, Opts);
4039 EXPECT_THAT(Results.Completions,
4040 UnorderedElementsAre(AllOf(qualifier(""), named("XYZ"))));
4041}
4042
4043TEST(CompletionTest, NestedScopeIsUnresolved) {
4044 clangd::CodeCompleteOptions Opts = {};
4045 Opts.AllScopes = true;
4046
4047 auto Results = completions(R"cpp(
4048 namespace a {
4049 namespace b {}
4050 void f() { b::c::X^ }
4051 }
4052 )cpp",
4053 {cls("a::b::c::XYZ")}, Opts);
4054 EXPECT_THAT(Results.Completions,
4055 UnorderedElementsAre(AllOf(qualifier(""), named("XYZ"))));
4056}
4057
4058// Clang parser gets confused here and doesn't report the ns:: prefix.
4059// Naive behavior is to insert it again. We examine the source and recover.
4060TEST(CompletionTest, NamespaceDoubleInsertion) {
4061 clangd::CodeCompleteOptions Opts = {};
4062
4063 auto Results = completions(R"cpp(
4064 namespace foo {
4065 namespace ns {}
4066 #define M(X) < X
4067 M(ns::ABC^
4068 }
4069 )cpp",
4070 {cls("foo::ns::ABCDE")}, Opts);
4071 EXPECT_THAT(Results.Completions,
4072 UnorderedElementsAre(AllOf(qualifier(""), named("ABCDE"))));
4073}
4074
4075TEST(CompletionTest, DerivedMethodsAreAlwaysVisible) {
4076 // Despite the fact that base method matches the ref-qualifier better,
4077 // completion results should only include the derived method.
4078 auto Completions = completions(R"cpp(
4079 struct deque_base {
4080 float size();
4081 double size() const;
4082 };
4083 struct deque : deque_base {
4084 int size() const;
4085 };
4086
4087 auto x = deque().^
4088 )cpp")
4089 .Completions;
4090 EXPECT_THAT(Completions,
4091 ElementsAre(AllOf(returnType("int"), named("size"))));
4092}
4093
4094TEST(CompletionTest, NoCrashWithIncompleteLambda) {
4095 auto Completions = completions("auto&& x = []{^").Completions;
4096 // The completion of x itself can cause a problem: in the code completion
4097 // callback, its type is not known, which affects the linkage calculation.
4098 // A bad linkage value gets cached, and subsequently updated.
4099 EXPECT_THAT(Completions, Contains(named("x")));
4100
4101 auto Signatures = signatures("auto x() { x(^").signatures;
4102 EXPECT_THAT(Signatures, Contains(sig("x() -> auto")));
4103}
4104
4105TEST(CompletionTest, DelayedTemplateParsing) {
4106 Annotations Test(R"cpp(
4107 int xxx;
4108 template <typename T> int foo() { return xx^; }
4109 )cpp");
4110 auto TU = TestTU::withCode(Test.code());
4111 // Even though delayed-template-parsing is on, we will disable it to provide
4112 // completion in templates.
4113 TU.ExtraArgs.push_back("-fdelayed-template-parsing");
4114
4115 EXPECT_THAT(completions(TU, Test.point()).Completions,
4116 Contains(named("xxx")));
4117}
4118
4119TEST(CompletionTest, CompletionRange) {
4120 const char *WithRange = "auto x = [[abc]]^";
4121 auto Completions = completions(WithRange);
4122 EXPECT_EQ(Completions.InsertRange, Annotations(WithRange).range());
4123 Completions = completionsNoCompile(WithRange);
4124 EXPECT_EQ(Completions.InsertRange, Annotations(WithRange).range());
4125
4126 const char *EmptyRange = "auto x = [[]]^";
4127 Completions = completions(EmptyRange);
4128 EXPECT_EQ(Completions.InsertRange, Annotations(EmptyRange).range());
4129 Completions = completionsNoCompile(EmptyRange);
4130 EXPECT_EQ(Completions.InsertRange, Annotations(EmptyRange).range());
4131
4132 // Sema doesn't trigger at all here, while the no-sema completion runs
4133 // heuristics as normal and reports a range. It'd be nice to be consistent.
4134 const char *NoCompletion = "/* foo [[]]^ */";
4135 Completions = completions(NoCompletion);
4136 EXPECT_EQ(Completions.InsertRange, std::nullopt);
4137 Completions = completionsNoCompile(NoCompletion);
4138 EXPECT_EQ(Completions.InsertRange, Annotations(NoCompletion).range());
4139}
4140
4141TEST(CompletionTest, ReplaceRange) {
4142 clangd::CodeCompleteOptions Opts;
4143 Opts.EnableInsertReplace = true;
4144
4145 // Cursor at end of token: insert == replace.
4146 const char *EndOfToken =
4147 "struct S { int abc; }; void f() { S s; s.[[abc]]^; }";
4148 CodeCompleteResult Completions =
4149 completions(EndOfToken, /*IndexSymbols=*/{}, Opts);
4150 Annotations A(EndOfToken);
4151 EXPECT_EQ(Completions.InsertRange, A.range());
4152 EXPECT_EQ(Completions.ReplaceRange, A.range());
4153
4154 // Cursor mid-word: replace extends past cursor.
4155 const char *MidWord = "struct S { int abcd; }; void f() { S s; "
4156 "s.$replace[[$insert[[ab^]]cd]]; }";
4157 Completions = completions(MidWord, /*IndexSymbols=*/{}, Opts);
4158 A = Annotations(MidWord);
4159 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4160 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4161
4162 // Empty prefix: insert range is empty, replace covers the word.
4163 const char *EmptyPrefix = "struct S { int abcd; }; void f() { S s; "
4164 "s.$replace[[$insert[[^]]abcd]]; }";
4165 Completions = completions(EmptyPrefix, /*IndexSymbols=*/{}, Opts);
4166 A = Annotations(EmptyPrefix);
4167 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4168 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4169
4170 // Cursor mid-word with UTF-8 continuation: replace extends past UTF-8.
4171 const char *MidWordUTF8 = "struct S { int naïve; }; void f() { S s; "
4172 "s.$replace[[$insert[[na^]]ïve]]; }";
4173 Completions = completions(MidWordUTF8, /*IndexSymbols=*/{}, Opts);
4174 A = Annotations(MidWordUTF8);
4175 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4176 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4177
4178 // Replace range stops at '(' (method call).
4179 const char *BeforeParen = "struct S { int abcd(); }; void f() { S s; "
4180 "s.$replace[[$insert[[ab^]]cd]](123); }";
4181 Completions = completions(BeforeParen, /*IndexSymbols=*/{}, Opts);
4182 A = Annotations(BeforeParen);
4183 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4184 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4185
4186 // Replace range stops at '<' (template arguments).
4187 const char *BeforeAngle =
4188 "struct S { template <typename T> int abcd(); }; void f() { S s; "
4189 "s.$replace[[$insert[[ab^]]cd]]<int>(); }";
4190 Completions = completions(BeforeAngle, /*IndexSymbols=*/{}, Opts);
4191 A = Annotations(BeforeAngle);
4192 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4193 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4194
4195 // Replace range stops at ' ' (before '=').
4196 const char *BeforeEquals =
4197 "void f() { int $replace[[$insert[[ab^]]cd]] = 1; }";
4198 Completions = completions(BeforeEquals, /*IndexSymbols=*/{}, Opts);
4199 A = Annotations(BeforeEquals);
4200 EXPECT_EQ(Completions.InsertRange, A.range("insert"));
4201 EXPECT_EQ(Completions.ReplaceRange, A.range("replace"));
4202
4203 // EnableInsertReplace off: ReplaceRange should not be set.
4204 Opts.EnableInsertReplace = false;
4205 const char *NoReplace = "auto x = [[abc]]^";
4206 Completions = completions(NoReplace, /*IndexSymbols=*/{}, Opts);
4207 EXPECT_EQ(Completions.InsertRange, Annotations(NoReplace).range());
4208 EXPECT_EQ(Completions.ReplaceRange, std::nullopt);
4209}
4210
4211TEST(CompletionTest, ReplaceRangeNoCompile) {
4212 clangd::CodeCompleteOptions Opts;
4213 Opts.EnableInsertReplace = true;
4214
4215 // Cursor at end of token: insert == replace.
4216 const char *EndOfToken = "auto x = [[abc]]^";
4217 Annotations A(EndOfToken);
4218 CodeCompleteResult Results =
4219 completionsNoCompile(EndOfToken, /*IndexSymbols=*/{}, Opts);
4220 EXPECT_EQ(Results.InsertRange, A.range());
4221 EXPECT_EQ(Results.ReplaceRange, A.range());
4222
4223 // Cursor mid-word: replace extends past cursor.
4224 const char *MidWord = "auto x = $replace[[$insert[[ab^]]cd]]";
4225 Results = completionsNoCompile(MidWord, /*IndexSymbols=*/{}, Opts);
4226 A = Annotations(MidWord);
4227 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4228 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4229
4230 // Empty prefix: insert range is empty, replace covers the word.
4231 const char *EmptyPrefix = "auto x = $replace[[$insert[[^]]abcd]]";
4232 Results = completionsNoCompile(EmptyPrefix, /*IndexSymbols=*/{}, Opts);
4233 A = Annotations(EmptyPrefix);
4234 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4235 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4236
4237 // ASCII heuristic stops at non-ASCII: replace doesn't extend past UTF-8.
4238 const char *MidWordUTF8 = "auto x = $replace[[$insert[[na^]]]]ïve";
4239 Results = completionsNoCompile(MidWordUTF8, /*IndexSymbols=*/{}, Opts);
4240 A = Annotations(MidWordUTF8);
4241 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4242 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4243
4244 // Replace range stops at '(' (method call).
4245 const char *BeforeParen = "auto x = $replace[[$insert[[ab^]]cd]](123);";
4246 Results = completionsNoCompile(BeforeParen, /*IndexSymbols=*/{}, Opts);
4247 A = Annotations(BeforeParen);
4248 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4249 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4250
4251 // Replace range stops at '<' (template arguments).
4252 const char *BeforeAngle = "auto x = $replace[[$insert[[ab^]]cd]]<int>();";
4253 Results = completionsNoCompile(BeforeAngle, /*IndexSymbols=*/{}, Opts);
4254 A = Annotations(BeforeAngle);
4255 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4256 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4257
4258 // Replace range stops at ' ' (before '=').
4259 const char *BeforeEquals = "auto $replace[[$insert[[ab^]]cd]] = 1;";
4260 Results = completionsNoCompile(BeforeEquals, /*IndexSymbols=*/{}, Opts);
4261 A = Annotations(BeforeEquals);
4262 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4263 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4264
4265 // EnableInsertReplace off: ReplaceRange should not be set.
4266 Opts.EnableInsertReplace = false;
4267 const char *NoReplace = "auto x = [[abc]]^";
4268 Results = completionsNoCompile(NoReplace, /*IndexSymbols=*/{}, Opts);
4269 EXPECT_EQ(Results.InsertRange, Annotations(NoReplace).range());
4270 EXPECT_EQ(Results.ReplaceRange, std::nullopt);
4271}
4272
4273TEST(NoCompileCompletionTest, Basic) {
4274 auto Results = completionsNoCompile(R"cpp(
4275 void func() {
4276 int xyz;
4277 int abc;
4278 ^
4279 }
4280 )cpp");
4281 EXPECT_FALSE(Results.RanParser);
4282 EXPECT_THAT(Results.Completions,
4283 UnorderedElementsAre(named("void"), named("func"), named("int"),
4284 named("xyz"), named("abc")));
4285}
4286
4287TEST(NoCompileCompletionTest, WithFilter) {
4288 auto Results = completionsNoCompile(R"cpp(
4289 void func() {
4290 int sym1;
4291 int sym2;
4292 int xyz1;
4293 int xyz2;
4294 sy^
4295 }
4296 )cpp");
4297 EXPECT_THAT(Results.Completions,
4298 UnorderedElementsAre(named("sym1"), named("sym2")));
4299}
4300
4301TEST(NoCompileCompletionTest, WithIndex) {
4302 std::vector<Symbol> Syms = {func("xxx"), func("a::xxx"), func("ns::b::xxx"),
4303 func("c::xxx"), func("ns::d::xxx")};
4304 auto Results = completionsNoCompile(
4305 R"cpp(
4306 // Current-scopes, unqualified completion.
4307 using namespace a;
4308 namespace ns {
4309 using namespace b;
4310 void foo() {
4311 xx^
4312 }
4313 }
4314 )cpp",
4315 Syms);
4316 EXPECT_THAT(Results.Completions,
4317 UnorderedElementsAre(AllOf(qualifier(""), scope("")),
4318 AllOf(qualifier(""), scope("a::")),
4319 AllOf(qualifier(""), scope("ns::b::"))));
4321 Opts.AllScopes = true;
4322 Results = completionsNoCompile(
4323 R"cpp(
4324 // All-scopes unqualified completion.
4325 using namespace a;
4326 namespace ns {
4327 using namespace b;
4328 void foo() {
4329 xx^
4330 }
4331 }
4332 )cpp",
4333 Syms, Opts);
4334 EXPECT_THAT(Results.Completions,
4335 UnorderedElementsAre(AllOf(qualifier(""), scope("")),
4336 AllOf(qualifier(""), scope("a::")),
4337 AllOf(qualifier(""), scope("ns::b::")),
4338 AllOf(qualifier("c::"), scope("c::")),
4339 AllOf(qualifier("d::"), scope("ns::d::"))));
4340 Results = completionsNoCompile(
4341 R"cpp(
4342 // Qualified completion.
4343 using namespace a;
4344 namespace ns {
4345 using namespace b;
4346 void foo() {
4347 b::xx^
4348 }
4349 }
4350 )cpp",
4351 Syms, Opts);
4352 EXPECT_THAT(Results.Completions,
4353 ElementsAre(AllOf(qualifier(""), scope("ns::b::"))));
4354 Results = completionsNoCompile(
4355 R"cpp(
4356 // Absolutely qualified completion.
4357 using namespace a;
4358 namespace ns {
4359 using namespace b;
4360 void foo() {
4361 ::a::xx^
4362 }
4363 }
4364 )cpp",
4365 Syms, Opts);
4366 EXPECT_THAT(Results.Completions,
4367 ElementsAre(AllOf(qualifier(""), scope("a::"))));
4368}
4369
4370TEST(AllowImplicitCompletion, All) {
4371 const char *Yes[] = {
4372 "foo.^bar",
4373 "foo->^bar",
4374 "foo::^bar",
4375 " # include <^foo.h>",
4376 "#import <foo/^bar.h>",
4377 "#include_next \"^",
4378 };
4379 const char *No[] = {
4380 "foo>^bar",
4381 "foo:^bar",
4382 "foo\n^bar",
4383 "#include <foo.h> //^",
4384 "#include \"foo.h\"^",
4385 "#error <^",
4386 "#<^",
4387 };
4388 for (const char *Test : Yes) {
4389 llvm::Annotations A(Test);
4390 EXPECT_TRUE(allowImplicitCompletion(A.code(), A.point())) << Test;
4391 }
4392 for (const char *Test : No) {
4393 llvm::Annotations A(Test);
4394 EXPECT_FALSE(allowImplicitCompletion(A.code(), A.point())) << Test;
4395 }
4396}
4397
4398TEST(CompletionTest, FunctionArgsExist) {
4399 clangd::CodeCompleteOptions Opts;
4400 Opts.EnableSnippets = true;
4401 std::string Context = R"cpp(
4402 #define MACRO(x)
4403 int foo(int A);
4404 int bar();
4405 struct Object {
4406 Object(int B) {}
4407 };
4408 template <typename T>
4409 struct Container {
4410 Container(int Size) {}
4411 };
4412 )cpp";
4413 EXPECT_THAT(completions(Context + "int y = fo^", {}, Opts).Completions,
4414 UnorderedElementsAre(
4415 AllOf(labeled("foo(int A)"), snippetSuffix("(${1:int A})"))));
4416 EXPECT_THAT(
4417 completions(Context + "int y = fo^(42)", {}, Opts).Completions,
4418 UnorderedElementsAre(AllOf(labeled("foo(int A)"), snippetSuffix(""))));
4419 EXPECT_THAT(
4420 completions(Context + "int y = fo^o(42)", {}, Opts).Completions,
4421 UnorderedElementsAre(AllOf(labeled("foo(int A)"), snippetSuffix(""))));
4422 EXPECT_THAT(
4423 completions(Context + "int y = ba^", {}, Opts).Completions,
4424 UnorderedElementsAre(AllOf(labeled("bar()"), snippetSuffix("()"))));
4425 EXPECT_THAT(completions(Context + "int y = ba^()", {}, Opts).Completions,
4426 UnorderedElementsAre(AllOf(labeled("bar()"), snippetSuffix(""))));
4427 EXPECT_THAT(completions(Context + "int y = ba^r()", {}, Opts).Completions,
4428 UnorderedElementsAre(AllOf(labeled("bar()"), snippetSuffix(""))));
4429 EXPECT_THAT(
4430 completions(Context + "Object o = Obj^", {}, Opts).Completions,
4431 Contains(AllOf(labeled("Object(int B)"), snippetSuffix("(${1:int B})"),
4433 EXPECT_THAT(completions(Context + "Object o = Obj^()", {}, Opts).Completions,
4434 Contains(AllOf(labeled("Object(int B)"), snippetSuffix(""),
4436 EXPECT_THAT(
4437 completions(Context + "Container c = Cont^", {}, Opts).Completions,
4438 Contains(AllOf(labeled("Container<typename T>(int Size)"),
4439 snippetSuffix("<${1:typename T}>(${2:int Size})"),
4441 EXPECT_THAT(
4442 completions(Context + "Container c = Cont^()", {}, Opts).Completions,
4443 Contains(AllOf(labeled("Container<typename T>(int Size)"),
4444 snippetSuffix("<${1:typename T}>"),
4446 EXPECT_THAT(
4447 completions(Context + "Container c = Cont^<int>()", {}, Opts).Completions,
4448 Contains(AllOf(labeled("Container<typename T>(int Size)"),
4449 snippetSuffix(""),
4451 EXPECT_THAT(
4452 completions(Context + "Container c = Cont^ainer()", {}, Opts).Completions,
4453 Contains(AllOf(labeled("Container<typename T>(int Size)"),
4454 snippetSuffix("<${1:typename T}>"),
4456 EXPECT_THAT(completions(Context + "MAC^(2)", {}, Opts).Completions,
4457 Contains(AllOf(labeled("MACRO(x)"), snippetSuffix(""),
4459 EXPECT_THAT(completions(Context + "MAC^RO(2)", {}, Opts).Completions,
4460 Contains(AllOf(labeled("MACRO(x)"), snippetSuffix(""),
4462}
4463
4464TEST(CompletionTest, FunctionArgsExist_Issue1785) {
4465 // This is a scenario where the implementation of our check for
4466 // "is there a function argument list right after the cursor"
4467 // gave a bogus result.
4468 clangd::CodeCompleteOptions Opts;
4469 Opts.EnableSnippets = true;
4470 // The whitespace in this testcase is important!
4471 std::string Code = R"cpp(
4472void waldo(int);
4473
4474int main()
4475{
4476 wal^
4477
4478
4479 // ( )
4480}
4481 )cpp";
4482 EXPECT_THAT(
4483 completions(Code, {}, Opts).Completions,
4484 Contains(AllOf(labeled("waldo(int)"), snippetSuffix("(${1:int})"))));
4485}
4486
4487TEST(CompletionTest, NoCrashDueToMacroOrdering) {
4488 EXPECT_THAT(completions(R"cpp(
4489 #define ECHO(X) X
4490 #define ECHO2(X) ECHO(X)
4491 int finish_preamble = EC^HO(2);)cpp")
4492 .Completions,
4493 UnorderedElementsAre(labeled("ECHO(X)"), labeled("ECHO2(X)")));
4494}
4495
4496TEST(CompletionTest, ObjCCategoryDecls) {
4497 TestTU TU;
4498 TU.ExtraArgs.push_back("-xobjective-c");
4499 TU.HeaderCode = R"objc(
4500 @interface Foo
4501 @end
4502
4503 @interface Foo (FooExt1)
4504 @end
4505
4506 @interface Foo (FooExt2)
4507 @end
4508
4509 @interface Bar
4510 @end
4511
4512 @interface Bar (BarExt)
4513 @end)objc";
4514
4515 {
4516 Annotations Test(R"objc(
4517 @implementation Foo (^)
4518 @end
4519 )objc");
4520 TU.Code = Test.code().str();
4521 auto Results = completions(TU, Test.point());
4522 EXPECT_THAT(Results.Completions,
4523 UnorderedElementsAre(labeled("FooExt1"), labeled("FooExt2")));
4524 }
4525 {
4526 Annotations Test(R"objc(
4527 @interface Foo (^)
4528 @end
4529 )objc");
4530 TU.Code = Test.code().str();
4531 auto Results = completions(TU, Test.point());
4532 EXPECT_THAT(Results.Completions, UnorderedElementsAre(labeled("BarExt")));
4533 }
4534}
4535
4536TEST(CompletionTest, PreambleCodeComplete) {
4537 llvm::StringLiteral Baseline = "\n#define MACRO 12\nint num = MACRO;";
4538 llvm::StringLiteral ModifiedCC =
4539 "#include \"header.h\"\n#define MACRO 12\nint num = MACRO; int num2 = M^";
4540
4541 Annotations Test(ModifiedCC);
4542 auto BaselineTU = TestTU::withCode(Baseline);
4543 auto ModifiedTU = TestTU::withCode(Test.code());
4544
4545 MockFS FS;
4546 auto Inputs = ModifiedTU.inputs(FS);
4547 auto Result = codeComplete(testPath(ModifiedTU.Filename), Test.point(),
4548 BaselineTU.preamble().get(), Inputs, {});
4549 EXPECT_THAT(Result.Completions, Not(testing::IsEmpty()));
4550}
4551
4552TEST(CompletionTest, CommentParamName) {
4553 const std::string Code = R"cpp(
4554 void fun(int foo, int bar);
4555 void overloaded(int param_int);
4556 void overloaded(int param_int, int param_other);
4557 void overloaded(char param_char);
4558 int main() {
4559 )cpp";
4560
4561 EXPECT_THAT(completions(Code + "fun(/*^").Completions,
4562 UnorderedElementsAre(labeled("foo=*/")));
4563 EXPECT_THAT(completions(Code + "fun(1, /*^").Completions,
4564 UnorderedElementsAre(labeled("bar=*/")));
4565 EXPECT_THAT(completions(Code + "/*^").Completions, IsEmpty());
4566 // Test de-duplication.
4567 EXPECT_THAT(
4568 completions(Code + "overloaded(/*^").Completions,
4569 UnorderedElementsAre(labeled("param_int=*/"), labeled("param_char=*/")));
4570 // Comment already has some text in it.
4571 EXPECT_THAT(completions(Code + "fun(/* ^").Completions,
4572 UnorderedElementsAre(labeled("foo=*/")));
4573 EXPECT_THAT(completions(Code + "fun(/* f^").Completions,
4574 UnorderedElementsAre(labeled("foo=*/")));
4575 EXPECT_THAT(completions(Code + "fun(/* x^").Completions, IsEmpty());
4576 EXPECT_THAT(completions(Code + "fun(/* f ^").Completions, IsEmpty());
4577
4578 // Test ranges
4579 {
4580 std::string CompletionRangeTest(Code + "fun(/*[[^]]");
4581 auto Results = completions(CompletionRangeTest);
4582 EXPECT_THAT(Results.InsertRange,
4583 llvm::ValueIs(Annotations(CompletionRangeTest).range()));
4584 EXPECT_THAT(
4585 Results.Completions,
4586 testing::Each(
4587 AllOf(replacesRange(Annotations(CompletionRangeTest).range()),
4589 }
4590 {
4591 std::string CompletionRangeTest(Code + "fun(/*[[fo^]]");
4592 auto Results = completions(CompletionRangeTest);
4593 EXPECT_THAT(Results.InsertRange,
4594 llvm::ValueIs(Annotations(CompletionRangeTest).range()));
4595 EXPECT_THAT(
4596 Results.Completions,
4597 testing::Each(
4598 AllOf(replacesRange(Annotations(CompletionRangeTest).range()),
4600 }
4601
4602 // Test replace ranges (comment completion replaces up to */).
4603 clangd::CodeCompleteOptions ReplaceOpts;
4604 ReplaceOpts.EnableInsertReplace = true;
4605 {
4606 // With */ (no =): replace extends past suffix to */.
4607 const std::string NoEquals(Code + "fun(/*$replace[[$insert[[fo^]]o*/]])");
4608 const CodeCompleteResult Results = completions(NoEquals, {}, ReplaceOpts);
4609 const Annotations A(NoEquals);
4610 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4611 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4612 }
4613 {
4614 // With = and */: replace extends past = to */.
4615 const std::string WithEquals(Code +
4616 "fun(/*$replace[[$insert[[fo^]]o=*/]])");
4617 const CodeCompleteResult Results = completions(WithEquals, {}, ReplaceOpts);
4618 const Annotations A(WithEquals);
4619 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4620 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4621 }
4622 {
4623 // Without */: replace == insert.
4624 const std::string NoClose(Code + "fun(/*[[fo^]]");
4625 const CodeCompleteResult Results = completions(NoClose, {}, ReplaceOpts);
4626 const Annotations A(NoClose);
4627 EXPECT_EQ(Results.InsertRange, A.range());
4628 EXPECT_EQ(Results.ReplaceRange, A.range());
4629 }
4630 {
4631 // With */ and UTF-8 suffix: replace extends past UTF-8 to */.
4632 const std::string WithUTF8(Code + "fun(/*$replace[[$insert[[ca^]]fé=*/]])");
4633 const CodeCompleteResult Results = completions(WithUTF8, {}, ReplaceOpts);
4634 const Annotations A(WithUTF8);
4635 EXPECT_EQ(Results.InsertRange, A.range("insert"));
4636 EXPECT_EQ(Results.ReplaceRange, A.range("replace"));
4637 }
4638}
4639
4640TEST(CompletionTest, Concepts) {
4641 Annotations Code(R"cpp(
4642 template<class T>
4643 concept A = sizeof(T) <= 8;
4644
4645 template<$tparam^A U>
4646 int foo();
4647
4648 template<typename T>
4649 int bar(T t) requires $expr^A<int>;
4650
4651 template<class T>
4652 concept b = $expr^A && $expr^sizeof(T) % 2 == 0 || $expr^A && sizeof(T) == 1;
4653
4654 $toplevel^A auto i = 19;
4655
4656 template<$toplevel^A auto i> void constrainedNTTP();
4657
4658 // FIXME: The first parameter should be dropped in this case.
4659 void abbreviated($expr^A auto x) {}
4660 )cpp");
4661 TestTU TU;
4662 TU.Code = Code.code().str();
4663 TU.ExtraArgs = {"-std=c++20"};
4664
4665 auto Sym = conceptSym("same_as");
4666 Sym.Signature = "<typename Tp, typename Up>";
4667 Sym.CompletionSnippetSuffix = "<${1:typename Tp}, ${2:typename Up}>";
4668 std::vector<Symbol> Syms = {Sym};
4669 for (auto P : Code.points("tparam")) {
4670 ASSERT_THAT(
4671 completions(TU, P, Syms).Completions,
4672 AllOf(Contains(AllOf(named("A"), signature(""), snippetSuffix(""))),
4673 Contains(AllOf(named("same_as"), signature("<typename Up>"),
4674 snippetSuffix("<${2:typename Up}>"))),
4675 Contains(named("class")), Contains(named("typename"))))
4676 << "Completing template parameter at position " << P;
4677 }
4678
4679 for (auto P : Code.points("toplevel")) {
4680 EXPECT_THAT(
4681 completions(TU, P, Syms).Completions,
4682 AllOf(Contains(AllOf(named("A"), signature(""), snippetSuffix(""))),
4683 Contains(AllOf(named("same_as"), signature("<typename Up>"),
4684 snippetSuffix("<${2:typename Up}>")))))
4685 << "Completing 'requires' expression at position " << P;
4686 }
4687
4688 for (auto P : Code.points("expr")) {
4689 EXPECT_THAT(
4690 completions(TU, P, Syms).Completions,
4691 AllOf(Contains(AllOf(named("A"), signature("<class T>"),
4692 snippetSuffix("<${1:class T}>"))),
4693 Contains(AllOf(
4694 named("same_as"), signature("<typename Tp, typename Up>"),
4695 snippetSuffix("<${1:typename Tp}, ${2:typename Up}>")))))
4696 << "Completing 'requires' expression at position " << P;
4697 }
4698}
4699
4700TEST(SignatureHelp, DocFormat) {
4701 Annotations Code(R"cpp(
4702 // Comment `with` markup.
4703 void foo(int);
4704 void bar() { foo(^); }
4705 )cpp");
4706 for (auto DocumentationFormat :
4708 auto Sigs = signatures(Code.code(), Code.point(), /*IndexSymbols=*/{},
4709 DocumentationFormat);
4710 ASSERT_EQ(Sigs.signatures.size(), 1U);
4711 EXPECT_EQ(Sigs.signatures[0].documentation.kind, DocumentationFormat);
4712 }
4713}
4714
4715TEST(SignatureHelp, TemplateArguments) {
4716 std::string Top = R"cpp(
4717 template <typename T, int> bool foo(char);
4718 template <int I, int> bool foo(float);
4719 )cpp";
4720
4721 auto First = signatures(Top + "bool x = foo<^");
4722 EXPECT_THAT(
4723 First.signatures,
4724 UnorderedElementsAre(sig("foo<[[typename T]], [[int]]>() -> bool"),
4725 sig("foo<[[int I]], [[int]]>() -> bool")));
4726 EXPECT_EQ(First.activeParameter, 0);
4727
4728 auto Second = signatures(Top + "bool x = foo<1, ^");
4729 EXPECT_THAT(Second.signatures,
4730 ElementsAre(sig("foo<[[int I]], [[int]]>() -> bool")));
4731 EXPECT_EQ(Second.activeParameter, 1);
4732}
4733
4734TEST(CompletionTest, DoNotCrash) {
4735 llvm::StringLiteral Cases[] = {
4736 R"cpp(
4737 template <typename = int> struct Foo {};
4738 auto a = [x(3)](Foo<^>){};
4739 )cpp",
4740 };
4741 for (auto Case : Cases) {
4742 SCOPED_TRACE(Case);
4743 auto Completions = completions(Case);
4744 }
4745}
4746TEST(CompletionTest, PreambleFromDifferentTarget) {
4747 constexpr std::string_view PreambleTarget = "x86_64";
4748 constexpr std::string_view Contents =
4749 "int foo(int); int num; int num2 = foo(n^";
4750
4751 Annotations Test(Contents);
4752 auto TU = TestTU::withCode(Test.code());
4753 TU.ExtraArgs.emplace_back("-target");
4754 TU.ExtraArgs.emplace_back(PreambleTarget);
4755 auto Preamble = TU.preamble();
4756 ASSERT_TRUE(Preamble);
4757 // Switch target to wasm.
4758 TU.ExtraArgs.pop_back();
4759 TU.ExtraArgs.emplace_back("wasm32");
4760
4761 MockFS FS;
4762 auto Inputs = TU.inputs(FS);
4763 auto Result = codeComplete(testPath(TU.Filename), Test.point(),
4764 Preamble.get(), Inputs, {});
4765 auto Signatures =
4766 signatureHelp(testPath(TU.Filename), Test.point(), *Preamble, Inputs, {});
4767
4768 // Make sure we don't crash.
4769 EXPECT_THAT(Result.Completions, Not(testing::IsEmpty()));
4770 EXPECT_THAT(Signatures.signatures, Not(testing::IsEmpty()));
4771}
4772
4773TEST(CompletionTest, SkipExplicitObjectParameter) {
4774 Annotations Code(R"cpp(
4775 struct A {
4776 void foo(this auto&& self, int arg);
4777 void bar(this A self, int arg);
4778 };
4779
4780 int main() {
4781 A a {};
4782 a.$c1^;
4783 (&A::fo$c2^;
4784 (&A::ba$c3^;
4785 }
4786 )cpp");
4787
4788 // TODO: llvm/llvm-project/146649
4789 // This is incorrect behavior. Correct Result should be a variant of,
4790 // c2: signature = (auto&& self, int arg)
4791 // snippet = (${1: auto&& self}, ${2: int arg})
4792 // c3: signature = (A self, int arg)
4793 // snippet = (${1: A self}, ${2: int arg})
4794
4795 auto TU = TestTU::withCode(Code.code());
4796 TU.ExtraArgs = {"-std=c++23"};
4797
4798 auto Preamble = TU.preamble();
4799 ASSERT_TRUE(Preamble);
4800
4801 CodeCompleteOptions Opts{};
4802
4803 MockFS FS;
4804 auto Inputs = TU.inputs(FS);
4805 {
4806 auto Result = codeComplete(testPath(TU.Filename), Code.point("c1"),
4807 Preamble.get(), Inputs, Opts);
4808
4809 EXPECT_THAT(Result.Completions,
4810 UnorderedElementsAre(AllOf(named("foo"), signature("(int arg)"),
4811 snippetSuffix("(${1:int arg})")),
4812 AllOf(named("bar"), signature("(int arg)"),
4813 snippetSuffix("(${1:int arg})"))));
4814 }
4815 {
4816 auto Result = codeComplete(testPath(TU.Filename), Code.point("c2"),
4817 Preamble.get(), Inputs, Opts);
4818 EXPECT_THAT(
4819 Result.Completions,
4820 ElementsAre(AllOf(named("foo"), signature("<class self:auto>(int arg)"),
4821 snippetSuffix("<${1:class self:auto}>"))));
4822 }
4823 {
4824 auto Result = codeComplete(testPath(TU.Filename), Code.point("c3"),
4825 Preamble.get(), Inputs, Opts);
4826 EXPECT_THAT(Result.Completions,
4827 ElementsAre(AllOf(named("bar"), signature("(int arg)"),
4828 snippetSuffix(""))));
4829 }
4830}
4831
4832TEST(CompletionTest, MemberAccessInExplicitObjMemfn) {
4833 Annotations Code(R"cpp(
4834 struct A {
4835 int member {};
4836 int memberFnA(int a);
4837 int memberFnA(this A&, float a);
4838
4839 void foo(this A& self) {
4840 // Should not offer any members here, since
4841 // it needs to be referenced through `self`.
4842 mem$c1^;
4843 // should offer all results
4844 self.mem$c2^;
4845
4846 [&]() {
4847 // should not offer any results
4848 mem$c3^;
4849 }();
4850 }
4851 };
4852 )cpp");
4853
4854 auto TU = TestTU::withCode(Code.code());
4855 TU.ExtraArgs = {"-std=c++23"};
4856
4857 auto Preamble = TU.preamble();
4858 ASSERT_TRUE(Preamble);
4859
4860 CodeCompleteOptions Opts{};
4861
4862 MockFS FS;
4863 auto Inputs = TU.inputs(FS);
4864
4865 {
4866 auto Result = codeComplete(testPath(TU.Filename), Code.point("c1"),
4867 Preamble.get(), Inputs, Opts);
4868
4869 EXPECT_THAT(Result.Completions, ElementsAre());
4870 }
4871 {
4872 auto Result = codeComplete(testPath(TU.Filename), Code.point("c2"),
4873 Preamble.get(), Inputs, Opts);
4874
4875 EXPECT_THAT(
4876 Result.Completions,
4877 UnorderedElementsAre(named("member"),
4878 AllOf(named("memberFnA"), signature("(int a)"),
4879 snippetSuffix("(${1:int a})")),
4880 AllOf(named("memberFnA"), signature("(float a)"),
4881 snippetSuffix("(${1:float a})"))));
4882 }
4883 {
4884 auto Result = codeComplete(testPath(TU.Filename), Code.point("c3"),
4885 Preamble.get(), Inputs, Opts);
4886
4887 EXPECT_THAT(Result.Completions, ElementsAre());
4888 }
4889}
4890
4891TEST(CompletionTest, ListExplicitObjectOverloads) {
4892 Annotations Code(R"cpp(
4893 struct S {
4894 void foo1(int a);
4895 void foo2(int a) const;
4896 void foo2(this const S& self, float a);
4897 void foo3(this const S& self, int a);
4898 void foo4(this S& self, int a);
4899 };
4900
4901 void S::foo1(int a) {
4902 this->$c1^;
4903 }
4904
4905 void S::foo2(int a) const {
4906 this->$c2^;
4907 }
4908
4909 void S::foo3(this const S& self, int a) {
4910 self.$c3^;
4911 }
4912
4913 void S::foo4(this S& self, int a) {
4914 self.$c4^;
4915 }
4916
4917 void test1(S s) {
4918 s.$c5^;
4919 }
4920
4921 void test2(const S s) {
4922 s.$c6^;
4923 }
4924 )cpp");
4925
4926 auto TU = TestTU::withCode(Code.code());
4927 TU.ExtraArgs = {"-std=c++23"};
4928
4929 auto Preamble = TU.preamble();
4930 ASSERT_TRUE(Preamble);
4931
4932 CodeCompleteOptions Opts{};
4933
4934 MockFS FS;
4935 auto Inputs = TU.inputs(FS);
4936
4937 {
4938 auto Result = codeComplete(testPath(TU.Filename), Code.point("c1"),
4939 Preamble.get(), Inputs, Opts);
4940 EXPECT_THAT(
4941 Result.Completions,
4942 UnorderedElementsAre(AllOf(named("foo1"), signature("(int a)"),
4943 snippetSuffix("(${1:int a})")),
4944 AllOf(named("foo2"), signature("(int a) const"),
4945 snippetSuffix("(${1:int a})")),
4946 AllOf(named("foo2"), signature("(float a) const"),
4947 snippetSuffix("(${1:float a})")),
4948 AllOf(named("foo3"), signature("(int a) const"),
4949 snippetSuffix("(${1:int a})")),
4950 AllOf(named("foo4"), signature("(int a)"),
4951 snippetSuffix("(${1:int a})"))));
4952 }
4953 {
4954 auto Result = codeComplete(testPath(TU.Filename), Code.point("c2"),
4955 Preamble.get(), Inputs, Opts);
4956 EXPECT_THAT(
4957 Result.Completions,
4958 UnorderedElementsAre(AllOf(named("foo2"), signature("(int a) const"),
4959 snippetSuffix("(${1:int a})")),
4960 AllOf(named("foo2"), signature("(float a) const"),
4961 snippetSuffix("(${1:float a})")),
4962 AllOf(named("foo3"), signature("(int a) const"),
4963 snippetSuffix("(${1:int a})"))));
4964 }
4965 {
4966 auto Result = codeComplete(testPath(TU.Filename), Code.point("c3"),
4967 Preamble.get(), Inputs, Opts);
4968 EXPECT_THAT(
4969 Result.Completions,
4970 UnorderedElementsAre(AllOf(named("foo2"), signature("(int a) const"),
4971 snippetSuffix("(${1:int a})")),
4972 AllOf(named("foo2"), signature("(float a) const"),
4973 snippetSuffix("(${1:float a})")),
4974 AllOf(named("foo3"), signature("(int a) const"),
4975 snippetSuffix("(${1:int a})"))));
4976 }
4977 {
4978 auto Result = codeComplete(testPath(TU.Filename), Code.point("c4"),
4979 Preamble.get(), Inputs, Opts);
4980 EXPECT_THAT(
4981 Result.Completions,
4982 UnorderedElementsAre(AllOf(named("foo1"), signature("(int a)"),
4983 snippetSuffix("(${1:int a})")),
4984 AllOf(named("foo2"), signature("(int a) const"),
4985 snippetSuffix("(${1:int a})")),
4986 AllOf(named("foo2"), signature("(float a) const"),
4987 snippetSuffix("(${1:float a})")),
4988 AllOf(named("foo3"), signature("(int a) const"),
4989 snippetSuffix("(${1:int a})")),
4990 AllOf(named("foo4"), signature("(int a)"),
4991 snippetSuffix("(${1:int a})"))));
4992 }
4993 {
4994 auto Result = codeComplete(testPath(TU.Filename), Code.point("c5"),
4995 Preamble.get(), Inputs, Opts);
4996 EXPECT_THAT(
4997 Result.Completions,
4998 UnorderedElementsAre(AllOf(named("foo1"), signature("(int a)"),
4999 snippetSuffix("(${1:int a})")),
5000 AllOf(named("foo2"), signature("(int a) const"),
5001 snippetSuffix("(${1:int a})")),
5002 AllOf(named("foo2"), signature("(float a) const"),
5003 snippetSuffix("(${1:float a})")),
5004 AllOf(named("foo3"), signature("(int a) const"),
5005 snippetSuffix("(${1:int a})")),
5006 AllOf(named("foo4"), signature("(int a)"),
5007 snippetSuffix("(${1:int a})"))));
5008 }
5009 {
5010 auto Result = codeComplete(testPath(TU.Filename), Code.point("c6"),
5011 Preamble.get(), Inputs, Opts);
5012 EXPECT_THAT(
5013 Result.Completions,
5014 UnorderedElementsAre(AllOf(named("foo2"), signature("(int a) const"),
5015 snippetSuffix("(${1:int a})")),
5016 AllOf(named("foo2"), signature("(float a) const"),
5017 snippetSuffix("(${1:float a})")),
5018 AllOf(named("foo3"), signature("(int a) const"),
5019 snippetSuffix("(${1:int a})"))));
5020 }
5021}
5022
5023TEST(CompletionTest, FuzzyMatchMacro) {
5024 Annotations Code(R"cpp(
5025 #define gl_foo() 42
5026 #define _gl_foo() 42
5027 #define glfbar() 42
5028
5029 int gl_frob();
5030 int _gl_frob();
5031
5032 int main() {
5033 int y = glf$c1^;
5034 int y = _gl$c2^;
5035 }
5036 )cpp");
5037
5038 auto TU = TestTU::withCode(Code.code());
5039
5040 // Exact prefix should match macro or symbol
5041 {
5042 CodeCompleteOptions Opts{};
5043 EXPECT_EQ(Opts.MacroFilter, Config::MacroFilterPolicy::ExactPrefix);
5044
5045 {
5046 auto Results = completions(TU, Code.point("c1"), {}, Opts);
5047 EXPECT_THAT(
5048 Results.Completions,
5049 ElementsAre(named("gl_frob"), named("_gl_frob"), named("glfbar")));
5050 }
5051
5052 {
5053 auto Results = completions(TU, Code.point("c2"), {}, Opts);
5054 EXPECT_THAT(Results.Completions,
5055 ElementsAre(named("_gl_frob"), named("_gl_foo")));
5056 }
5057 }
5058
5059 // but with fuzzy match
5060 {
5061 CodeCompleteOptions Opts{};
5062 Opts.MacroFilter = Config::MacroFilterPolicy::FuzzyMatch;
5063
5064 // don't suggest underscore macros in general,
5065 {
5066 auto Results = completions(TU, Code.point("c1"), {}, Opts);
5067 EXPECT_THAT(Results.Completions,
5068 ElementsAre(named("gl_frob"), named("_gl_frob"),
5069 named("glfbar"), named("gl_foo")));
5070 }
5071
5072 // but do suggest when macro contains exact prefix
5073 {
5074 auto Results = completions(TU, Code.point("c2"), {}, Opts);
5075 EXPECT_THAT(Results.Completions,
5076 ElementsAre(named("_gl_frob"), named("_gl_foo")));
5077 }
5078 }
5079}
5080
5081} // namespace
5082} // namespace clangd
5083} // namespace clang
#define EXPECT_IFF(condition, value, matcher)
Same as llvm::Annotations, but adjusts functions to LSP-specific types for positions and ranges.
Definition Annotations.h:23
clangd::Range range(llvm::StringRef Name="") const
Manages a collection of source files and derived data (ASTs, indexes), and provides language-aware fe...
A context is an immutable container for per-request data that must be propagated through layers that ...
Definition Context.h:69
static std::unique_ptr< SymbolIndex > build(SymbolSlab Symbols, RefSlab Refs, RelationSlab Relations)
Builds an index from slabs. The index takes ownership of the data.
Definition MemIndex.cpp:18
llvm::StringMap< std::string > Files
Definition TestFS.h:45
An efficient structure of storing large set of symbol references in memory.
Definition Ref.h:111
Interface for symbol indexes that can be used for searching or matching symbols among a set of symbol...
Definition Index.h:134
SymbolSlab::Builder is a mutable container that can 'freeze' to SymbolSlab.
Definition Symbol.h:224
void insert(const Symbol &S)
Adds a symbol, overwriting any existing one with the same ID.
Definition Symbol.cpp:52
static llvm::Expected< URI > create(llvm::StringRef AbsolutePath, llvm::StringRef Scheme)
Creates a URI for a file in the given scheme.
Definition URI.cpp:208
WithContextValue extends Context::current() with a single value.
Definition Context.h:200
FIXME: Skip testing on windows temporarily due to the different escaping code mode.
Definition AST.cpp:44
Symbol objcProtocol(llvm::StringRef Name)
Symbol objcClass(llvm::StringRef Name)
Symbol func(llvm::StringRef Name)
Definition TestIndex.cpp:62
Symbol cls(llvm::StringRef Name)
Definition TestIndex.cpp:66
Symbol objcCategory(llvm::StringRef Name, llvm::StringRef CategoryName)
std::string sortText(float Score, llvm::StringRef Name)
Returns a string that sorts in the same order as (-Score, Tiebreak), for LSP.
Definition Quality.cpp:552
Symbol conceptSym(llvm::StringRef Name)
Definition TestIndex.cpp:86
IndexContents
Describes what data is covered by an index.
Definition Index.h:114
size_t lspLength(llvm::StringRef Code)
CompletionPrefix guessCompletionPrefix(llvm::StringRef Content, unsigned Offset)
std::unique_ptr< CompilerInvocation > buildCompilerInvocation(const ParseInputs &Inputs, clang::DiagnosticConsumer &D, std::vector< std::string > *CC1Args)
Builds compiler invocation that could be used to build AST or preamble.
Definition Compiler.cpp:96
Symbol sym(llvm::StringRef QName, index::SymbolKind Kind, llvm::StringRef USRFormat, llvm::StringRef Signature)
Definition TestIndex.cpp:40
CompletionItemKind
The kind of a completion entry.
Definition Protocol.h:351
Symbol ns(llvm::StringRef Name)
Definition TestIndex.cpp:82
bool allowImplicitCompletion(llvm::StringRef Content, unsigned Offset)
llvm::unique_function< void(llvm::Expected< T >)> Callback
A Callback<T> is a void function that accepts Expected<T>.
Definition Function.h:28
llvm::raw_ostream & operator<<(llvm::raw_ostream &OS, const CodeCompletion &C)
llvm::Expected< CodeCompleteResult > runCodeComplete(ClangdServer &Server, PathRef File, Position Pos, clangd::CodeCompleteOptions Opts)
Definition SyncAPI.cpp:72
MATCHER_P(named, N, "")
llvm::Expected< SignatureHelp > runSignatureHelp(ClangdServer &Server, PathRef File, Position Pos, MarkupKind DocumentationFormat)
Definition SyncAPI.cpp:79
std::string testPath(PathRef File, llvm::sys::path::Style Style)
Definition TestFS.cpp:94
std::shared_ptr< const PreambleData > buildPreamble(PathRef FileName, CompilerInvocation CI, const ParseInputs &Inputs, bool StoreInMemory, PreambleParsedCallback PreambleCallback, PreambleBuildStats *Stats)
Build a preamble for the new inputs unless an old one can be reused.
Definition Preamble.cpp:573
TEST(BackgroundQueueTest, Priority)
void wait(std::unique_lock< std::mutex > &Lock, std::condition_variable &CV, Deadline D)
Wait once on CV for the specified duration.
llvm::Expected< size_t > positionToOffset(llvm::StringRef Code, Position P, bool AllowColumnsBeyondLineLength)
Turn a [line, column] pair into an offset in Code.
void runAddDocument(ClangdServer &Server, PathRef File, llvm::StringRef Contents, llvm::StringRef Version, WantDiagnostics WantDiags, bool ForceRebuild)
Definition SyncAPI.cpp:17
Symbol macro(llvm::StringRef Name, llvm::StringRef ArgList)
Definition TestIndex.cpp:90
llvm::StringRef PathRef
A typedef to represent a ref to file path.
Definition Path.h:29
@ No
Diagnostics must be generated for this snapshot.
Definition TUScheduler.h:55
std::vector< std::string > lookup(const SymbolIndex &I, llvm::ArrayRef< SymbolID > IDs)
Symbol enmConstant(llvm::StringRef Name)
Definition TestIndex.cpp:74
Deadline timeoutSeconds(std::optional< double > Seconds)
Makes a deadline from a timeout in seconds. std::nullopt means wait forever.
CodeCompleteResult codeComplete(PathRef FileName, Position Pos, const PreambleData *Preamble, const ParseInputs &ParseInput, CodeCompleteOptions Opts, SpeculativeFuzzyFind *SpecFuzzyFind)
Gets code completions at a specified Pos in FileName.
@ PlainText
The primary text to be inserted is treated as a plain string.
Definition Protocol.h:1327
@ Snippet
The primary text to be inserted is treated as a snippet.
Definition Protocol.h:1337
SignatureHelp signatureHelp(PathRef FileName, Position Pos, const PreambleData &Preamble, const ParseInputs &ParseInput, MarkupKind DocumentationFormat)
Get signature help at a specified Pos in FileName.
PolySubsequenceMatcher< Args... > HasSubsequence(Args &&... M)
Symbol var(llvm::StringRef Name)
Definition TestIndex.cpp:78
cppcoreguidelines::ProBoundsAvoidUncheckedContainerAccessCheck P
===– Representation.cpp - ClangDoc Representation --------—*- C++ -*-===//
Signals derived from a valid AST of a file.
Definition ASTSignals.h:27
llvm::DenseMap< SymbolID, unsigned > ReferencedSymbols
Number of occurrences of each symbol present in the file.
Definition ASTSignals.h:29
Symbol::IncludeDirective InsertionDirective
Preferred preprocessor directive to use for inclusions by the file.
Definition ASTSignals.h:34
Represents a collection of completion items to be presented in the editor.
Definition Protocol.h:1433
Settings that express user/project preferences and control clangd behavior.
Definition Config.h:45
static clangd::Key< Config > Key
Context key which can be used to set the current Config.
Definition Config.h:49
@ None
nothing, no argument list and also NO Delimiters "()" or "<>".
Definition Config.h:142
@ Delimiters
empty pair of delimiters "()" or "<>".
Definition Config.h:146
@ OpenDelimiter
open, only opening delimiter "(" or "<".
Definition Config.h:144
Same semantics as CodeComplete::Score.
Definition Quality.h:179
std::vector< std::string > Scopes
If this is non-empty, symbols must be in at least one of the scopes (e.g.
Definition Index.h:36
Information required to run clang, e.g. to parse AST or do code completion.
Definition Compiler.h:51
int line
Line position in a document (zero-based).
Definition Protocol.h:159
int character
Character offset on a line in a document (zero-based).
Definition Protocol.h:164
Position end
The range's end position.
Definition Protocol.h:191
Represents the signature of a callable.
Definition Protocol.h:1477
Attributes of a symbol that affect how much we like it.
Definition Quality.h:56
Attributes of a symbol-query pair that affect how much we like it.
Definition Quality.h:86
The class presents a C++ symbol, e.g.
Definition Symbol.h:39
@ IndexedForCodeCompletion
Whether or not this symbol is meant to be used for the code completion.
Definition Symbol.h:141
@ Include
#include "header.h"
Definition Symbol.h:93
@ Import
#import "header.h"
Definition Symbol.h:95
SymbolID ID
The ID of the symbol.
Definition Symbol.h:41
std::vector< std::string > ExtraArgs
Definition TestTU.h:60
std::string Code
Definition TestTU.h:49
static TestTU withHeaderCode(llvm::StringRef HeaderCode)
Definition TestTU.h:42
static TestTU withCode(llvm::StringRef Code)
Definition TestTU.h:36
llvm::StringMap< std::string > AdditionalFiles
Definition TestTU.h:57
std::unique_ptr< SymbolIndex > index() const
Definition TestTU.cpp:176
Range range
The range of the text document to be manipulated.
Definition Protocol.h:247