clang-tools 23.0.0git
InlayHintTests.cpp
Go to the documentation of this file.
1//===-- InlayHintTests.cpp -------------------------------*- C++ -*-------===//
2//
3// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6//
7//===----------------------------------------------------------------------===//
8#include "Annotations.h"
9#include "Config.h"
10#include "InlayHints.h"
11#include "Protocol.h"
12#include "TestTU.h"
13#include "TestWorkspace.h"
14#include "XRefs.h"
15#include "support/Context.h"
16#include "llvm/ADT/StringRef.h"
17#include "llvm/Support/ScopedPrinter.h"
18#include "llvm/Support/raw_ostream.h"
19#include "gmock/gmock.h"
20#include "gtest/gtest.h"
21#include <optional>
22#include <string>
23#include <utility>
24#include <vector>
25
26namespace clang {
27namespace clangd {
28
29llvm::raw_ostream &operator<<(llvm::raw_ostream &Stream,
30 const InlayHint &Hint) {
31 return Stream << Hint.joinLabels() << "@" << Hint.range;
32}
33
34namespace {
35
36using ::testing::ElementsAre;
37using ::testing::IsEmpty;
38
39constexpr InlayHintOptions DefaultOptsForTests{2};
40
41std::vector<InlayHint> hintsOfKind(ParsedAST &AST, InlayHintKind Kind,
42 InlayHintOptions Opts) {
43 std::vector<InlayHint> Result;
44 for (auto &Hint : inlayHints(AST, /*RestrictRange=*/std::nullopt, Opts)) {
45 if (Hint.kind == Kind)
46 Result.push_back(Hint);
47 }
48 return Result;
49}
50
51enum HintSide { Left, Right };
52
53struct ExpectedHint {
54 std::string Label;
55 std::string RangeName;
56 HintSide Side = Left;
57
58 friend llvm::raw_ostream &operator<<(llvm::raw_ostream &Stream,
59 const ExpectedHint &Hint) {
60 return Stream << Hint.Label << "@$" << Hint.RangeName;
61 }
62};
63
64MATCHER_P2(HintMatcher, Expected, Code, llvm::to_string(Expected)) {
65 llvm::StringRef ExpectedView(Expected.Label);
66 std::string ResultLabel = arg.joinLabels();
67 if (ResultLabel != ExpectedView.trim(" ") ||
68 arg.paddingLeft != ExpectedView.starts_with(" ") ||
69 arg.paddingRight != ExpectedView.ends_with(" ")) {
70 *result_listener << "label is '" << ResultLabel << "'";
71 return false;
72 }
73 if (arg.range != Code.range(Expected.RangeName)) {
74 *result_listener << "range is " << llvm::to_string(arg.range) << " but $"
75 << Expected.RangeName << " is "
76 << llvm::to_string(Code.range(Expected.RangeName));
77 return false;
78 }
79 return true;
80}
81
82MATCHER_P(labelIs, Label, "") { return arg.joinLabels() == Label; }
83
84Config noHintsConfig() {
85 Config C;
86 C.InlayHints.Parameters = false;
87 C.InlayHints.DeducedTypes = false;
88 C.InlayHints.Designators = false;
89 C.InlayHints.BlockEnd = false;
90 C.InlayHints.DefaultArguments = false;
91 return C;
92}
93
94template <typename... ExpectedHints>
95void assertHintsWithHeader(InlayHintKind Kind, llvm::StringRef AnnotatedSource,
96 llvm::StringRef HeaderContent, InlayHintOptions Opts,
97 ExpectedHints... Expected) {
98 Annotations Source(AnnotatedSource);
99 TestTU TU = TestTU::withCode(Source.code());
100 TU.ExtraArgs.push_back("-std=c++23");
101 TU.HeaderCode = HeaderContent;
102 auto AST = TU.build();
103
104 EXPECT_THAT(hintsOfKind(AST, Kind, Opts),
105 ElementsAre(HintMatcher(Expected, Source)...));
106 // Sneak in a cross-cutting check that hints are disabled by config.
107 // We'll hit an assertion failure if addInlayHint still gets called.
108 WithContextValue WithCfg(Config::Key, noHintsConfig());
109 EXPECT_THAT(inlayHints(AST, std::nullopt, Opts), IsEmpty());
110}
111
112template <typename... ExpectedHints>
113void assertHints(InlayHintKind Kind, llvm::StringRef AnnotatedSource,
114 InlayHintOptions Opts, ExpectedHints... Expected) {
115 return assertHintsWithHeader(Kind, AnnotatedSource, "", Opts,
116 std::move(Expected)...);
117}
118
119// Hack to allow expression-statements operating on parameter packs in C++14.
120template <typename... T> void ignore(T &&...) {}
121
122template <typename... ExpectedHints>
123void assertParameterHints(llvm::StringRef AnnotatedSource,
124 ExpectedHints... Expected) {
125 ignore(Expected.Side = Left...);
126 assertHints(InlayHintKind::Parameter, AnnotatedSource, DefaultOptsForTests,
127 Expected...);
128}
129
130template <typename... ExpectedHints>
131void assertTypeHints(llvm::StringRef AnnotatedSource,
132 ExpectedHints... Expected) {
133 ignore(Expected.Side = Right...);
134 assertHints(InlayHintKind::Type, AnnotatedSource, DefaultOptsForTests,
135 Expected...);
136}
137
138template <typename... ExpectedHints>
139void assertDesignatorHints(llvm::StringRef AnnotatedSource,
140 ExpectedHints... Expected) {
141 Config Cfg;
142 Cfg.InlayHints.Designators = true;
143 WithContextValue WithCfg(Config::Key, std::move(Cfg));
144 assertHints(InlayHintKind::Designator, AnnotatedSource, DefaultOptsForTests,
145 Expected...);
146}
147
148template <typename... ExpectedHints>
149void assertBlockEndHintsWithOpts(llvm::StringRef AnnotatedSource,
150 InlayHintOptions Opts,
151 ExpectedHints... Expected) {
152 Config Cfg;
153 Cfg.InlayHints.BlockEnd = true;
154 WithContextValue WithCfg(Config::Key, std::move(Cfg));
155 assertHints(InlayHintKind::BlockEnd, AnnotatedSource, Opts, Expected...);
156}
157
158template <typename... ExpectedHints>
159void assertBlockEndHints(llvm::StringRef AnnotatedSource,
160 ExpectedHints... Expected) {
161 assertBlockEndHintsWithOpts(AnnotatedSource, DefaultOptsForTests,
162 Expected...);
163}
164
165TEST(ParameterHints, Smoke) {
166 assertParameterHints(R"cpp(
167 void foo(int param);
168 void bar() {
169 foo($param[[42]]);
170 }
171 )cpp",
172 ExpectedHint{"param: ", "param"});
173}
174
175TEST(ParameterHints, NoName) {
176 // No hint for anonymous parameter.
177 assertParameterHints(R"cpp(
178 void foo(int);
179 void bar() {
180 foo(42);
181 }
182 )cpp");
183}
184
185TEST(ParameterHints, NoNameConstReference) {
186 // No hint for anonymous const l-value ref parameter.
187 assertParameterHints(R"cpp(
188 void foo(const int&);
189 void bar() {
190 foo(42);
191 }
192 )cpp");
193}
194
195TEST(ParameterHints, NoNameReference) {
196 // Reference hint for anonymous l-value ref parameter.
197 assertParameterHints(R"cpp(
198 void foo(int&);
199 void bar() {
200 int i;
201 foo($param[[i]]);
202 }
203 )cpp",
204 ExpectedHint{"&: ", "param"});
205}
206
207TEST(ParameterHints, NoNameRValueReference) {
208 // No reference hint for anonymous r-value ref parameter.
209 assertParameterHints(R"cpp(
210 void foo(int&&);
211 void bar() {
212 foo(42);
213 }
214 )cpp");
215}
216
217TEST(ParameterHints, NoNameVariadicDeclaration) {
218 // No hint for anonymous variadic parameter
219 assertParameterHints(R"cpp(
220 template <typename... Args>
221 void foo(Args&& ...);
222 void bar() {
223 foo(42);
224 }
225 )cpp");
226}
227
228TEST(ParameterHints, NoNameVariadicForwarded) {
229 // No hint for anonymous variadic parameter
230 // This prototype of std::forward is sufficient for clang to recognize it
231 assertParameterHints(R"cpp(
232 namespace std { template <typename T> T&& forward(T&); }
233 void foo(int);
234 template <typename... Args>
235 void bar(Args&&... args) { return foo(std::forward<Args>(args)...); }
236 void baz() {
237 bar(42);
238 }
239 )cpp");
240}
241
242TEST(ParameterHints, NoNameVariadicPlain) {
243 // No hint for anonymous variadic parameter
244 assertParameterHints(R"cpp(
245 void foo(int);
246 template <typename... Args>
247 void bar(Args&&... args) { return foo(args...); }
248 void baz() {
249 bar(42);
250 }
251 )cpp");
252}
253
254TEST(ParameterHints, NameInDefinition) {
255 // Parameter name picked up from definition if necessary.
256 assertParameterHints(R"cpp(
257 void foo(int);
258 void bar() {
259 foo($param[[42]]);
260 }
261 void foo(int param) {};
262 )cpp",
263 ExpectedHint{"param: ", "param"});
264}
265
266TEST(ParameterHints, NamePartiallyInDefinition) {
267 // Parameter name picked up from definition if necessary.
268 assertParameterHints(R"cpp(
269 void foo(int, int b);
270 void bar() {
271 foo($param1[[42]], $param2[[42]]);
272 }
273 void foo(int a, int) {};
274 )cpp",
275 ExpectedHint{"a: ", "param1"},
276 ExpectedHint{"b: ", "param2"});
277}
278
279TEST(ParameterHints, NameInDefinitionVariadic) {
280 // Parameter name picked up from definition in a resolved forwarded parameter.
281 assertParameterHints(R"cpp(
282 void foo(int, int);
283 template <typename... Args>
284 void bar(Args... args) {
285 foo(args...);
286 }
287 void baz() {
288 bar($param1[[42]], $param2[[42]]);
289 }
290 void foo(int a, int b) {};
291 )cpp",
292 ExpectedHint{"a: ", "param1"},
293 ExpectedHint{"b: ", "param2"});
294}
295
296TEST(ParameterHints, NameMismatch) {
297 // Prefer name from declaration.
298 assertParameterHints(R"cpp(
299 void foo(int good);
300 void bar() {
301 foo($good[[42]]);
302 }
303 void foo(int bad) {};
304 )cpp",
305 ExpectedHint{"good: ", "good"});
306}
307
308TEST(ParameterHints, NameConstReference) {
309 // Only name hint for const l-value ref parameter.
310 assertParameterHints(R"cpp(
311 void foo(const int& param);
312 void bar() {
313 foo($param[[42]]);
314 }
315 )cpp",
316 ExpectedHint{"param: ", "param"});
317}
318
319TEST(ParameterHints, NameTypeAliasConstReference) {
320 // Only name hint for const l-value ref parameter via type alias.
321 assertParameterHints(R"cpp(
322 using alias = const int&;
323 void foo(alias param);
324 void bar() {
325 int i;
326 foo($param[[i]]);
327 }
328 )cpp",
329 ExpectedHint{"param: ", "param"});
330}
331
332TEST(ParameterHints, NameReference) {
333 // Reference and name hint for l-value ref parameter.
334 assertParameterHints(R"cpp(
335 void foo(int& param);
336 void bar() {
337 int i;
338 foo($param[[i]]);
339 }
340 )cpp",
341 ExpectedHint{"&param: ", "param"});
342}
343
344TEST(ParameterHints, NameTypeAliasReference) {
345 // Reference and name hint for l-value ref parameter via type alias.
346 assertParameterHints(R"cpp(
347 using alias = int&;
348 void foo(alias param);
349 void bar() {
350 int i;
351 foo($param[[i]]);
352 }
353 )cpp",
354 ExpectedHint{"&param: ", "param"});
355}
356
357TEST(ParameterHints, NameRValueReference) {
358 // Only name hint for r-value ref parameter.
359 assertParameterHints(R"cpp(
360 void foo(int&& param);
361 void bar() {
362 foo($param[[42]]);
363 }
364 )cpp",
365 ExpectedHint{"param: ", "param"});
366}
367
368TEST(ParameterHints, VariadicForwardedConstructor) {
369 // Name hint for variadic parameter using std::forward in a constructor call
370 // This prototype of std::forward is sufficient for clang to recognize it
371 assertParameterHints(R"cpp(
372 namespace std { template <typename T> T&& forward(T&); }
373 struct S { S(int a); };
374 template <typename T, typename... Args>
375 T bar(Args&&... args) { return T{std::forward<Args>(args)...}; }
376 void baz() {
377 int b;
378 bar<S>($param[[b]]);
379 }
380 )cpp",
381 ExpectedHint{"a: ", "param"});
382}
383
384TEST(ParameterHints, VariadicPlainConstructor) {
385 // Name hint for variadic parameter in a constructor call
386 assertParameterHints(R"cpp(
387 struct S { S(int a); };
388 template <typename T, typename... Args>
389 T bar(Args&&... args) { return T{args...}; }
390 void baz() {
391 int b;
392 bar<S>($param[[b]]);
393 }
394 )cpp",
395 ExpectedHint{"a: ", "param"});
396}
397
398TEST(ParameterHints, VariadicForwardedNewConstructor) {
399 // Name hint for variadic parameter using std::forward in a new expression
400 // This prototype of std::forward is sufficient for clang to recognize it
401 assertParameterHints(R"cpp(
402 namespace std { template <typename T> T&& forward(T&); }
403 struct S { S(int a); };
404 template <typename T, typename... Args>
405 T* bar(Args&&... args) { return new T{std::forward<Args>(args)...}; }
406 void baz() {
407 int b;
408 bar<S>($param[[b]]);
409 }
410 )cpp",
411 ExpectedHint{"a: ", "param"});
412}
413
414TEST(ParameterHints, VariadicPlainNewConstructor) {
415 // Name hint for variadic parameter in a new expression
416 assertParameterHints(R"cpp(
417 struct S { S(int a); };
418 template <typename T, typename... Args>
419 T* bar(Args&&... args) { return new T{args...}; }
420 void baz() {
421 int b;
422 bar<S>($param[[b]]);
423 }
424 )cpp",
425 ExpectedHint{"a: ", "param"});
426}
427
428TEST(ParameterHints, VariadicForwarded) {
429 // Name for variadic parameter using std::forward
430 // This prototype of std::forward is sufficient for clang to recognize it
431 assertParameterHints(R"cpp(
432 namespace std { template <typename T> T&& forward(T&); }
433 void foo(int a);
434 template <typename... Args>
435 void bar(Args&&... args) { return foo(std::forward<Args>(args)...); }
436 void baz() {
437 int b;
438 bar($param[[b]]);
439 }
440 )cpp",
441 ExpectedHint{"a: ", "param"});
442}
443
444TEST(ParameterHints, VariadicPlain) {
445 // Name hint for variadic parameter
446 assertParameterHints(R"cpp(
447 void foo(int a);
448 template <typename... Args>
449 void bar(Args&&... args) { return foo(args...); }
450 void baz() {
451 bar($param[[42]]);
452 }
453 )cpp",
454 ExpectedHint{"a: ", "param"});
455}
456
457TEST(ParameterHints, VariadicPlainWithPackFirst) {
458 // Name hint for variadic parameter when the parameter pack is not the last
459 // template parameter
460 assertParameterHints(R"cpp(
461 void foo(int a);
462 template <typename... Args, typename Arg>
463 void bar(Arg, Args&&... args) { return foo(args...); }
464 void baz() {
465 bar(1, $param[[42]]);
466 }
467 )cpp",
468 ExpectedHint{"a: ", "param"});
469}
470
471TEST(ParameterHints, VariadicSplitTwolevel) {
472 // Name for variadic parameter that involves both head and tail parameters to
473 // deal with.
474 // This prototype of std::forward is sufficient for clang to recognize it
475 assertParameterHints(R"cpp(
476 namespace std { template <typename T> T&& forward(T&); }
477 void baz(int, int b, double);
478 template <typename... Args>
479 void foo(int a, Args&&... args) {
480 return baz(1, std::forward<Args>(args)..., 1.0);
481 }
482 template <typename... Args>
483 void bar(Args&&... args) { return foo(std::forward<Args>(args)...); }
484 void bazz() {
485 bar($param1[[32]], $param2[[42]]);
486 }
487 )cpp",
488 ExpectedHint{"a: ", "param1"},
489 ExpectedHint{"b: ", "param2"});
490}
491
492TEST(ParameterHints, VariadicNameFromSpecialization) {
493 // We don't try to resolve forwarding parameters if the function call uses a
494 // specialization.
495 assertParameterHints(R"cpp(
496 void foo(int a);
497 template <typename... Args>
498 void bar(Args... args) {
499 foo(args...);
500 }
501 template <>
502 void bar<int>(int b);
503 void baz() {
504 bar($param[[42]]);
505 }
506 )cpp",
507 ExpectedHint{"b: ", "param"});
508}
509
510TEST(ParameterHints, VariadicNameFromSpecializationRecursive) {
511 // We don't try to resolve forwarding parameters inside a forwarding function
512 // call if that function call uses a specialization.
513 assertParameterHints(R"cpp(
514 void foo2(int a);
515 template <typename... Args>
516 void foo(Args... args) {
517 foo2(args...);
518 }
519 template <typename... Args>
520 void bar(Args... args) {
521 foo(args...);
522 }
523 template <>
524 void foo<int>(int b);
525 void baz() {
526 bar($param[[42]]);
527 }
528 )cpp",
529 ExpectedHint{"b: ", "param"});
530}
531
532TEST(ParameterHints, VariadicOverloaded) {
533 // Name for variadic parameter for an overloaded function with unique number
534 // of parameters.
535 // This prototype of std::forward is sufficient for clang to recognize it
536 assertParameterHints(
537 R"cpp(
538 namespace std { template <typename T> T&& forward(T&); }
539 void baz(int b, int c);
540 void baz(int bb, int cc, int dd);
541 template <typename... Args>
542 void foo(int a, Args&&... args) {
543 return baz(std::forward<Args>(args)...);
544 }
545 template <typename... Args>
546 void bar(Args&&... args) { return foo(std::forward<Args>(args)...); }
547 void bazz() {
548 bar($param1[[32]], $param2[[42]], $param3[[52]]);
549 bar($param4[[1]], $param5[[2]], $param6[[3]], $param7[[4]]);
550 }
551 )cpp",
552 ExpectedHint{"a: ", "param1"}, ExpectedHint{"b: ", "param2"},
553 ExpectedHint{"c: ", "param3"}, ExpectedHint{"a: ", "param4"},
554 ExpectedHint{"bb: ", "param5"}, ExpectedHint{"cc: ", "param6"},
555 ExpectedHint{"dd: ", "param7"});
556}
557
558TEST(ParameterHints, VariadicRecursive) {
559 // make_tuple-like recursive variadic call
560 assertParameterHints(
561 R"cpp(
562 void foo();
563
564 template <typename Head, typename... Tail>
565 void foo(Head head, Tail... tail) {
566 foo(tail...);
567 }
568
569 template <typename... Args>
570 void bar(Args... args) {
571 foo(args...);
572 }
573
574 int main() {
575 bar(1, 2, 3);
576 }
577 )cpp");
578}
579
580TEST(ParameterHints, VariadicVarargs) {
581 // variadic call involving varargs (to make sure we don't crash)
582 assertParameterHints(R"cpp(
583 void foo(int fixed, ...);
584 template <typename... Args>
585 void bar(Args&&... args) {
586 foo(args...);
587 }
588
589 void baz() {
590 bar($fixed[[41]], 42, 43);
591 }
592 )cpp");
593}
594
595TEST(ParameterHints, VariadicTwolevelUnresolved) {
596 // the same setting as VariadicVarargs, only with parameter pack
597 assertParameterHints(R"cpp(
598 template <typename... Args>
599 void foo(int fixed, Args&& ... args);
600 template <typename... Args>
601 void bar(Args&&... args) {
602 foo(args...);
603 }
604
605 void baz() {
606 bar($fixed[[41]], 42, 43);
607 }
608 )cpp",
609 ExpectedHint{"fixed: ", "fixed"});
610}
611
612TEST(ParameterHints, VariadicTwoCalls) {
613 // only the first call using the parameter pack should be picked up
614 assertParameterHints(
615 R"cpp(
616 void f1(int a, int b);
617 void f2(int c, int d);
618
619 bool cond;
620
621 template <typename... Args>
622 void foo(Args... args) {
623 if (cond) {
624 f1(args...);
625 } else {
626 f2(args...);
627 }
628 }
629
630 int main() {
631 foo($param1[[1]], $param2[[2]]);
632 }
633 )cpp",
634 ExpectedHint{"a: ", "param1"}, ExpectedHint{"b: ", "param2"});
635}
636
637TEST(ParameterHints, VariadicInfinite) {
638 // infinite recursion should not break clangd
639 assertParameterHints(
640 R"cpp(
641 template <typename... Args>
642 void foo(Args...);
643
644 template <typename... Args>
645 void bar(Args... args) {
646 foo(args...);
647 }
648
649 template <typename... Args>
650 void foo(Args... args) {
651 bar(args...);
652 }
653
654 int main() {
655 foo(1, 2);
656 }
657 )cpp");
658}
659
660TEST(ParameterHints, VariadicDuplicatePack) {
661 // edge cases with multiple adjacent packs should work
662 assertParameterHints(
663 R"cpp(
664 void foo(int a, int b, int c, int);
665
666 template <typename... Args>
667 void bar(int, Args... args, int d) {
668 foo(args..., d);
669 }
670
671 template <typename... Args>
672 void baz(Args... args, Args... args2) {
673 bar<Args..., int>(1, args..., args2...);
674 }
675
676 int main() {
677 baz<int, int>($p1[[1]], $p2[[2]], $p3[[3]], $p4[[4]]);
678 }
679 )cpp",
680 ExpectedHint{"a: ", "p1"}, ExpectedHint{"b: ", "p2"},
681 ExpectedHint{"c: ", "p3"}, ExpectedHint{"d: ", "p4"});
682}
683
684TEST(ParameterHints, VariadicEmplace) {
685 // emplace-like calls should forward constructor parameters
686 // This prototype of std::forward is sufficient for clang to recognize it
687 assertParameterHints(
688 R"cpp(
689 namespace std { template <typename T> T&& forward(T&); }
690 using size_t = decltype(sizeof(0));
691 void *operator new(size_t, void *);
692 struct S {
693 S(int A);
694 S(int B, int C);
695 };
696 struct alloc {
697 template <typename T>
698 T* allocate();
699 template <typename T, typename... Args>
700 void construct(T* ptr, Args&&... args) {
701 ::new ((void*)ptr) T{std::forward<Args>(args)...};
702 }
703 };
704 template <typename T>
705 struct container {
706 template <typename... Args>
707 void emplace(Args&&... args) {
708 alloc a;
709 auto ptr = a.template allocate<T>();
710 a.construct(ptr, std::forward<Args>(args)...);
711 }
712 };
713 void foo() {
714 container<S> c;
715 c.emplace($param1[[1]]);
716 c.emplace($param2[[2]], $param3[[3]]);
717 }
718 )cpp",
719 ExpectedHint{"A: ", "param1"}, ExpectedHint{"B: ", "param2"},
720 ExpectedHint{"C: ", "param3"});
721}
722
723TEST(ParameterHints, VariadicReferenceHint) {
724 assertParameterHints(R"cpp(
725 void foo(int&);
726 template <typename... Args>
727 void bar(Args... args) { return foo(args...); }
728 void baz() {
729 int a;
730 bar(a);
731 bar(1);
732 }
733 )cpp");
734}
735
736TEST(ParameterHints, VariadicReferenceHintForwardingRef) {
737 assertParameterHints(R"cpp(
738 void foo(int&);
739 template <typename... Args>
740 void bar(Args&&... args) { return foo(args...); }
741 void baz() {
742 int a;
743 bar($param[[a]]);
744 bar(1);
745 }
746 )cpp",
747 ExpectedHint{"&: ", "param"});
748}
749
750TEST(ParameterHints, VariadicReferenceHintForwardingRefStdForward) {
751 assertParameterHints(R"cpp(
752 namespace std { template <typename T> T&& forward(T&); }
753 void foo(int&);
754 template <typename... Args>
755 void bar(Args&&... args) { return foo(std::forward<Args>(args)...); }
756 void baz() {
757 int a;
758 bar($param[[a]]);
759 }
760 )cpp",
761 ExpectedHint{"&: ", "param"});
762}
763
764TEST(ParameterHints, VariadicNoReferenceHintForwardingRefStdForward) {
765 assertParameterHints(R"cpp(
766 namespace std { template <typename T> T&& forward(T&); }
767 void foo(int);
768 template <typename... Args>
769 void bar(Args&&... args) { return foo(std::forward<Args>(args)...); }
770 void baz() {
771 int a;
772 bar(a);
773 bar(1);
774 }
775 )cpp");
776}
777
778TEST(ParameterHints, VariadicNoReferenceHintUnresolvedForward) {
779 assertParameterHints(R"cpp(
780 template <typename... Args>
781 void foo(Args&&... args);
782 void bar() {
783 int a;
784 foo(a);
785 }
786 )cpp");
787}
788
789TEST(ParameterHints, MatchingNameVariadicForwarded) {
790 // No name hint for variadic parameter with matching name
791 // This prototype of std::forward is sufficient for clang to recognize it
792 assertParameterHints(R"cpp(
793 namespace std { template <typename T> T&& forward(T&); }
794 void foo(int a);
795 template <typename... Args>
796 void bar(Args&&... args) { return foo(std::forward<Args>(args)...); }
797 void baz() {
798 int a;
799 bar(a);
800 }
801 )cpp");
802}
803
804TEST(ParameterHints, MatchingNameVariadicPlain) {
805 // No name hint for variadic parameter with matching name
806 assertParameterHints(R"cpp(
807 void foo(int a);
808 template <typename... Args>
809 void bar(Args&&... args) { return foo(args...); }
810 void baz() {
811 int a;
812 bar(a);
813 }
814 )cpp");
815}
816
817TEST(ParameterHints, Operator) {
818 // No hint for operator call with operator syntax.
819 assertParameterHints(R"cpp(
820 struct S {};
821 void operator+(S lhs, S rhs);
822 void bar() {
823 S a, b;
824 a + b;
825 }
826 )cpp");
827}
828
829TEST(ParameterHints, FunctionCallOperator) {
830 assertParameterHints(R"cpp(
831 struct W {
832 void operator()(int x);
833 };
834 struct S : W {
835 using W::operator();
836 static void operator()(int x, int y);
837 };
838 void bar() {
839 auto l1 = [](int x) {};
840 auto l2 = [](int x) static {};
841
842 S s;
843 s($1[[1]]);
844 s.operator()($2[[1]]);
845 s.operator()($3[[1]], $4[[2]]);
846 S::operator()($5[[1]], $6[[2]]);
847
848 l1($7[[1]]);
849 l1.operator()($8[[1]]);
850 l2($9[[1]]);
851 l2.operator()($10[[1]]);
852
853 void (*ptr)(int a, int b) = &S::operator();
854 ptr($11[[1]], $12[[2]]);
855 }
856 )cpp",
857 ExpectedHint{"x: ", "1"}, ExpectedHint{"x: ", "2"},
858 ExpectedHint{"x: ", "3"}, ExpectedHint{"y: ", "4"},
859 ExpectedHint{"x: ", "5"}, ExpectedHint{"y: ", "6"},
860 ExpectedHint{"x: ", "7"}, ExpectedHint{"x: ", "8"},
861 ExpectedHint{"x: ", "9"}, ExpectedHint{"x: ", "10"},
862 ExpectedHint{"a: ", "11"}, ExpectedHint{"b: ", "12"});
863}
864
865TEST(ParameterHints, DeducingThis) {
866 assertParameterHints(R"cpp(
867 struct S {
868 template <typename This>
869 auto operator()(this This &&Self, int Param) {
870 return 42;
871 }
872
873 auto function(this auto &Self, int Param) {
874 return Param;
875 }
876 };
877 void work() {
878 S s;
879 s($1[[42]]);
880 s.function($2[[42]]);
881 S()($3[[42]]);
882 auto lambda = [](this auto &Self, char C) -> void {
883 return Self(C);
884 };
885 lambda($4[['A']]);
886 }
887 )cpp",
888 ExpectedHint{"Param: ", "1"},
889 ExpectedHint{"Param: ", "2"},
890 ExpectedHint{"Param: ", "3"}, ExpectedHint{"C: ", "4"});
891}
892
893TEST(ParameterHints, DependentDeducingThis) {
894 assertParameterHints(R"cpp(
895 template <typename T>
896 struct S {
897 void f1(this S& obj);
898 void f2(this S& obj, int x, int y);
899 void g(S s) {
900 s.f1(); // no crash
901 s.f2($x[[42]], $y[[43]]);
902 }
903 };
904 )cpp",
905 ExpectedHint{"x: ", "x"}, ExpectedHint{"y: ", "y"});
906}
907
908TEST(ParameterHints, Macros) {
909 // Handling of macros depends on where the call's argument list comes from.
910
911 // If it comes from a macro definition, there's nothing to hint
912 // at the invocation site.
913 assertParameterHints(R"cpp(
914 void foo(int param);
915 #define ExpandsToCall() foo(42)
916 void bar() {
917 ExpandsToCall();
918 }
919 )cpp");
920
921 // The argument expression being a macro invocation shouldn't interfere
922 // with hinting.
923 assertParameterHints(R"cpp(
924 #define PI 3.14
925 void foo(double param);
926 void bar() {
927 foo($param[[PI]]);
928 }
929 )cpp",
930 ExpectedHint{"param: ", "param"});
931
932 // If the whole argument list comes from a macro parameter, hint it.
933 assertParameterHints(R"cpp(
934 void abort();
935 #define ASSERT(expr) if (!expr) abort()
936 int foo(int param);
937 void bar() {
938 ASSERT(foo($param[[42]]) == 0);
939 }
940 )cpp",
941 ExpectedHint{"param: ", "param"});
942
943 // If the macro expands to multiple arguments, don't hint it.
944 assertParameterHints(R"cpp(
945 void foo(double x, double y);
946 #define CONSTANTS 3.14, 2.72
947 void bar() {
948 foo(CONSTANTS);
949 }
950 )cpp");
951}
952
953TEST(ParameterHints, ConstructorParens) {
954 assertParameterHints(R"cpp(
955 struct S {
956 S(int param);
957 };
958 void bar() {
959 S obj($param[[42]]);
960 }
961 )cpp",
962 ExpectedHint{"param: ", "param"});
963}
964
965TEST(ParameterHints, ConstructorBraces) {
966 assertParameterHints(R"cpp(
967 struct S {
968 S(int param);
969 };
970 void bar() {
971 S obj{$param[[42]]};
972 }
973 )cpp",
974 ExpectedHint{"param: ", "param"});
975}
976
977TEST(ParameterHints, ConstructorStdInitList) {
978 // Do not show hints for std::initializer_list constructors.
979 assertParameterHints(R"cpp(
980 namespace std {
981 template <typename E> class initializer_list { const E *a, *b; };
982 }
983 struct S {
984 S(std::initializer_list<int> param);
985 };
986 void bar() {
987 S obj{42, 43};
988 }
989 )cpp");
990}
991
992TEST(ParameterHints, MemberInit) {
993 assertParameterHints(R"cpp(
994 struct S {
995 S(int param);
996 };
997 struct T {
998 S member;
999 T() : member($param[[42]]) {}
1000 };
1001 )cpp",
1002 ExpectedHint{"param: ", "param"});
1003}
1004
1005TEST(ParameterHints, ImplicitConstructor) {
1006 assertParameterHints(R"cpp(
1007 struct S {
1008 S(int param);
1009 };
1010 void bar(S);
1011 S foo() {
1012 // Do not show hint for implicit constructor call in argument.
1013 bar(42);
1014 // Do not show hint for implicit constructor call in return.
1015 return 42;
1016 }
1017 )cpp");
1018}
1019
1020TEST(ParameterHints, FunctionPointer) {
1021 assertParameterHints(
1022 R"cpp(
1023 void (*f1)(int param);
1024 void (__stdcall *f2)(int param);
1025 using f3_t = void(*)(int param);
1026 f3_t f3;
1027 using f4_t = void(__stdcall *)(int param);
1028 f4_t f4;
1029 __attribute__((noreturn)) f4_t f5;
1030 void bar() {
1031 f1($f1[[42]]);
1032 f2($f2[[42]]);
1033 f3($f3[[42]]);
1034 f4($f4[[42]]);
1035 // This one runs into an edge case in clang's type model
1036 // and we can't extract the parameter name. But at least
1037 // we shouldn't crash.
1038 f5(42);
1039 }
1040 )cpp",
1041 ExpectedHint{"param: ", "f1"}, ExpectedHint{"param: ", "f2"},
1042 ExpectedHint{"param: ", "f3"}, ExpectedHint{"param: ", "f4"});
1043}
1044
1045TEST(ParameterHints, ArgMatchesParam) {
1046 assertParameterHints(R"cpp(
1047 void foo(int param);
1048 struct S {
1049 static const int param = 42;
1050 };
1051 void bar() {
1052 int param = 42;
1053 // Do not show redundant "param: param".
1054 foo(param);
1055 // But show it if the argument is qualified.
1056 foo($param[[S::param]]);
1057 }
1058 struct A {
1059 int param;
1060 void bar() {
1061 // Do not show "param: param" for member-expr.
1062 foo(param);
1063 }
1064 };
1065 )cpp",
1066 ExpectedHint{"param: ", "param"});
1067}
1068
1069TEST(ParameterHints, ArgMatchesParamReference) {
1070 assertParameterHints(R"cpp(
1071 void foo(int& param);
1072 void foo2(const int& param);
1073 void bar() {
1074 int param;
1075 // show reference hint on mutable reference
1076 foo($param[[param]]);
1077 // but not on const reference
1078 foo2(param);
1079 }
1080 )cpp",
1081 ExpectedHint{"&: ", "param"});
1082}
1083
1084TEST(ParameterHints, LeadingUnderscore) {
1085 assertParameterHints(R"cpp(
1086 void foo(int p1, int _p2, int __p3);
1087 void bar() {
1088 foo($p1[[41]], $p2[[42]], $p3[[43]]);
1089 }
1090 )cpp",
1091 ExpectedHint{"p1: ", "p1"}, ExpectedHint{"p2: ", "p2"},
1092 ExpectedHint{"p3: ", "p3"});
1093}
1094
1095TEST(ParameterHints, DependentCalls) {
1096 assertParameterHints(R"cpp(
1097 template <typename T>
1098 void nonmember(T par1);
1099
1100 template <typename T>
1101 struct A {
1102 void member(T par2);
1103 static void static_member(T par3);
1104 };
1105
1106 void overload(int anInt);
1107 void overload(double aDouble);
1108
1109 template <typename T>
1110 struct S {
1111 void bar(A<T> a, T t) {
1112 nonmember($par1[[t]]);
1113 a.member($par2[[t]]);
1114 A<T>::static_member($par3[[t]]);
1115 // We don't want to arbitrarily pick between
1116 // "anInt" or "aDouble", so just show no hint.
1117 overload(T{});
1118 }
1119 };
1120 )cpp",
1121 ExpectedHint{"par1: ", "par1"},
1122 ExpectedHint{"par2: ", "par2"},
1123 ExpectedHint{"par3: ", "par3"});
1124}
1125
1126TEST(ParameterHints, VariadicFunction) {
1127 assertParameterHints(R"cpp(
1128 template <typename... T>
1129 void foo(int fixed, T... variadic);
1130
1131 void bar() {
1132 foo($fixed[[41]], 42, 43);
1133 }
1134 )cpp",
1135 ExpectedHint{"fixed: ", "fixed"});
1136}
1137
1138TEST(ParameterHints, VarargsFunction) {
1139 assertParameterHints(R"cpp(
1140 void foo(int fixed, ...);
1141
1142 void bar() {
1143 foo($fixed[[41]], 42, 43);
1144 }
1145 )cpp",
1146 ExpectedHint{"fixed: ", "fixed"});
1147}
1148
1149TEST(ParameterHints, CopyOrMoveConstructor) {
1150 // Do not show hint for parameter of copy or move constructor.
1151 assertParameterHints(R"cpp(
1152 struct S {
1153 S();
1154 S(const S& other);
1155 S(S&& other);
1156 };
1157 void bar() {
1158 S a;
1159 S b(a); // copy
1160 S c(S()); // move
1161 }
1162 )cpp");
1163}
1164
1165TEST(ParameterHints, UserDefinedLiteral) {
1166 // Do not hint call to user-defined literal operator.
1167 assertParameterHints(R"cpp(
1168 long double operator"" _w(long double param);
1169 void bar() {
1170 1.2_w;
1171 }
1172 )cpp");
1173}
1174
1175TEST(ParameterHints, ParamNameComment) {
1176 // Do not hint an argument which already has a comment
1177 // with the parameter name preceding it.
1178 assertParameterHints(R"cpp(
1179 void foo(int param);
1180 void bar() {
1181 foo(/*param*/42);
1182 foo( /* param = */ 42);
1183#define X 42
1184#define Y X
1185#define Z(...) Y
1186 foo(/*param=*/Z(a));
1187 foo($macro[[Z(a)]]);
1188 foo(/* the answer */$param[[42]]);
1189 }
1190 )cpp",
1191 ExpectedHint{"param: ", "macro"},
1192 ExpectedHint{"param: ", "param"});
1193}
1194
1195TEST(ParameterHints, SetterFunctions) {
1196 assertParameterHints(R"cpp(
1197 struct S {
1198 void setParent(S* parent);
1199 void set_parent(S* parent);
1200 void setTimeout(int timeoutMillis);
1201 void setTimeoutMillis(int timeout_millis);
1202 };
1203 void bar() {
1204 S s;
1205 // Parameter name matches setter name - omit hint.
1206 s.setParent(nullptr);
1207 // Support snake_case
1208 s.set_parent(nullptr);
1209 // Parameter name may contain extra info - show hint.
1210 s.setTimeout($timeoutMillis[[120]]);
1211 // FIXME: Ideally we'd want to omit this.
1212 s.setTimeoutMillis($timeout_millis[[120]]);
1213 }
1214 )cpp",
1215 ExpectedHint{"timeoutMillis: ", "timeoutMillis"},
1216 ExpectedHint{"timeout_millis: ", "timeout_millis"});
1217}
1218
1219TEST(ParameterHints, BuiltinFunctions) {
1220 // This prototype of std::forward is sufficient for clang to recognize it
1221 assertParameterHints(R"cpp(
1222 namespace std { template <typename T> T&& forward(T&); }
1223 void foo() {
1224 int i;
1225 std::forward(i);
1226 }
1227 )cpp");
1228}
1229
1230TEST(ParameterHints, IncludeAtNonGlobalScope) {
1231 Annotations FooInc(R"cpp(
1232 void bar() { foo(42); }
1233 )cpp");
1234 Annotations FooCC(R"cpp(
1235 struct S {
1236 void foo(int param);
1237 #include "foo.inc"
1238 };
1239 )cpp");
1240
1241 TestWorkspace Workspace;
1242 Workspace.addSource("foo.inc", FooInc.code());
1243 Workspace.addMainFile("foo.cc", FooCC.code());
1244
1245 auto AST = Workspace.openFile("foo.cc");
1246 ASSERT_TRUE(bool(AST));
1247
1248 // Ensure the hint for the call in foo.inc is NOT materialized in foo.cc.
1249 EXPECT_EQ(
1250 hintsOfKind(*AST, InlayHintKind::Parameter, DefaultOptsForTests).size(),
1251 0u);
1252}
1253
1254TEST(TypeHints, Smoke) {
1255 assertTypeHints(R"cpp(
1256 auto $waldo[[waldo]] = 42;
1257 )cpp",
1258 ExpectedHint{": int", "waldo"});
1259}
1260
1261TEST(TypeHints, Decorations) {
1262 assertTypeHints(R"cpp(
1263 int x = 42;
1264 auto* $var1[[var1]] = &x;
1265 auto&& $var2[[var2]] = x;
1266 const auto& $var3[[var3]] = x;
1267 )cpp",
1268 ExpectedHint{": int *", "var1"},
1269 ExpectedHint{": int &", "var2"},
1270 ExpectedHint{": const int &", "var3"});
1271}
1272
1273TEST(TypeHints, DecltypeAuto) {
1274 assertTypeHints(R"cpp(
1275 int x = 42;
1276 int& y = x;
1277 decltype(auto) $z[[z]] = y;
1278 )cpp",
1279 ExpectedHint{": int &", "z"});
1280}
1281
1282TEST(TypeHints, NoQualifiers) {
1283 assertTypeHints(R"cpp(
1284 namespace A {
1285 namespace B {
1286 struct S1 {};
1287 S1 foo();
1288 auto $x[[x]] = foo();
1289
1290 struct S2 {
1291 template <typename T>
1292 struct Inner {};
1293 };
1294 S2::Inner<int> bar();
1295 auto $y[[y]] = bar();
1296 }
1297 }
1298 )cpp",
1299 ExpectedHint{": S1", "x"}, ExpectedHint{": Inner<int>", "y"});
1300}
1301
1302TEST(TypeHints, Lambda) {
1303 // Do not print something overly verbose like the lambda's location.
1304 // Show hints for init-captures (but not regular captures).
1305 assertTypeHints(R"cpp(
1306 void f() {
1307 int cap = 42;
1308 auto $L[[L]] = [cap, $init[[init]] = 1 + 1](int a$ret[[)]] {
1309 return a + cap + init;
1310 };
1311 }
1312 )cpp",
1313 ExpectedHint{": (lambda)", "L"},
1314 ExpectedHint{": int", "init"}, ExpectedHint{"-> int", "ret"});
1315
1316 // Lambda return hint shown even if no param list.
1317 // (The digraph :> is just a ] that doesn't conflict with the annotations).
1318 assertTypeHints("auto $L[[x]] = <:$ret[[:>]]{return 42;};",
1319 ExpectedHint{": (lambda)", "L"},
1320 ExpectedHint{"-> int", "ret"});
1321}
1322
1323// Structured bindings tests.
1324// Note, we hint the individual bindings, not the aggregate.
1325
1326TEST(TypeHints, StructuredBindings_PublicStruct) {
1327 assertTypeHints(R"cpp(
1328 // Struct with public fields.
1329 struct Point {
1330 int x;
1331 int y;
1332 };
1333 Point foo();
1334 auto [$x[[x]], $y[[y]]] = foo();
1335 )cpp",
1336 ExpectedHint{": int", "x"}, ExpectedHint{": int", "y"});
1337}
1338
1339TEST(TypeHints, StructuredBindings_Array) {
1340 assertTypeHints(R"cpp(
1341 int arr[2];
1342 auto [$x[[x]], $y[[y]]] = arr;
1343 )cpp",
1344 ExpectedHint{": int", "x"}, ExpectedHint{": int", "y"});
1345}
1346
1347TEST(TypeHints, StructuredBindings_TupleLike) {
1348 assertTypeHints(R"cpp(
1349 // Tuple-like type.
1350 struct IntPair {
1351 int a;
1352 int b;
1353 };
1354 namespace std {
1355 template <typename T>
1356 struct tuple_size {};
1357 template <>
1358 struct tuple_size<IntPair> {
1359 constexpr static unsigned value = 2;
1360 };
1361 template <unsigned I, typename T>
1362 struct tuple_element {};
1363 template <unsigned I>
1364 struct tuple_element<I, IntPair> {
1365 using type = int;
1366 };
1367 }
1368 template <unsigned I>
1369 int get(const IntPair& p) {
1370 if constexpr (I == 0) {
1371 return p.a;
1372 } else if constexpr (I == 1) {
1373 return p.b;
1374 }
1375 }
1376 IntPair bar();
1377 auto [$x[[x]], $y[[y]]] = bar();
1378 )cpp",
1379 ExpectedHint{": int", "x"}, ExpectedHint{": int", "y"});
1380}
1381
1382TEST(TypeHints, StructuredBindings_NoInitializer) {
1383 assertTypeHints(R"cpp(
1384 // No initializer (ill-formed).
1385 // Do not show useless "NULL TYPE" hint.
1386 auto [x, y]; /*error-ok*/
1387 )cpp");
1388}
1389
1390TEST(TypeHints, InvalidType) {
1391 assertTypeHints(R"cpp(
1392 auto x = (unknown_type)42; /*error-ok*/
1393 auto *y = (unknown_ptr)nullptr;
1394 )cpp");
1395}
1396
1397TEST(TypeHints, ReturnTypeDeduction) {
1398 assertTypeHints(
1399 R"cpp(
1400 auto f1(int x$ret1a[[)]]; // Hint forward declaration too
1401 auto f1(int x$ret1b[[)]] { return x + 1; }
1402
1403 // Include pointer operators in hint
1404 int s;
1405 auto& f2($ret2[[)]] { return s; }
1406
1407 // Do not hint `auto` for trailing return type.
1408 auto f3() -> int;
1409
1410 // Do not hint when a trailing return type is specified.
1411 auto f4() -> auto* { return "foo"; }
1412
1413 auto f5($noreturn[[)]] {}
1414
1415 // `auto` conversion operator
1416 struct A {
1417 operator auto($retConv[[)]] { return 42; }
1418 };
1419
1420 // FIXME: Dependent types do not work yet.
1421 template <typename T>
1422 struct S {
1423 auto method() { return T(); }
1424 };
1425 )cpp",
1426 ExpectedHint{"-> int", "ret1a"}, ExpectedHint{"-> int", "ret1b"},
1427 ExpectedHint{"-> int &", "ret2"}, ExpectedHint{"-> void", "noreturn"},
1428 ExpectedHint{"-> int", "retConv"});
1429}
1430
1431TEST(TypeHints, DependentType) {
1432 assertTypeHints(R"cpp(
1433 template <typename T>
1434 void foo(T arg) {
1435 // The hint would just be "auto" and we can't do any better.
1436 auto var1 = arg.method();
1437 // FIXME: It would be nice to show "T" as the hint.
1438 auto $var2[[var2]] = arg;
1439 }
1440
1441 template <typename T>
1442 void bar(T arg) {
1443 auto [a, b] = arg;
1444 }
1445 )cpp",
1446 ExpectedHint{": T", "var2"});
1447}
1448
1449TEST(TypeHints, LongTypeName) {
1450 assertTypeHints(R"cpp(
1451 template <typename, typename, typename>
1452 struct A {};
1453 struct MultipleWords {};
1454 A<MultipleWords, MultipleWords, MultipleWords> foo();
1455 // Omit type hint past a certain length (currently 32)
1456 auto var = foo();
1457 )cpp");
1458
1459 Config Cfg;
1460 Cfg.InlayHints.TypeNameLimit = 0;
1461 WithContextValue WithCfg(Config::Key, std::move(Cfg));
1462
1463 assertTypeHints(
1464 R"cpp(
1465 template <typename, typename, typename>
1466 struct A {};
1467 struct MultipleWords {};
1468 A<MultipleWords, MultipleWords, MultipleWords> foo();
1469 // Should have type hint with TypeNameLimit = 0
1470 auto $var[[var]] = foo();
1471 )cpp",
1472 ExpectedHint{": A<MultipleWords, MultipleWords, MultipleWords>", "var"});
1473}
1474
1475TEST(TypeHints, DefaultTemplateArgs) {
1476 assertTypeHints(R"cpp(
1477 template <typename, typename = int>
1478 struct A {};
1479 A<float> foo();
1480 auto $var[[var]] = foo();
1481 A<float> bar[1];
1482 auto [$binding[[value]]] = bar;
1483 )cpp",
1484 ExpectedHint{": A<float>", "var"},
1485 ExpectedHint{": A<float>", "binding"});
1486}
1487
1488TEST(DefaultArguments, Smoke) {
1489 Config Cfg;
1491 true; // To test interplay of parameters and default parameters
1492 Cfg.InlayHints.DeducedTypes = false;
1493 Cfg.InlayHints.Designators = false;
1494 Cfg.InlayHints.BlockEnd = false;
1495
1496 Cfg.InlayHints.DefaultArguments = true;
1497 WithContextValue WithCfg(Config::Key, std::move(Cfg));
1498
1499 const auto *Code = R"cpp(
1500 int foo(int A = 4) { return A; }
1501 int bar(int A, int B = 1, bool C = foo($default1[[)]]) { return A; }
1502 int A = bar($explicit[[2]]$default2[[)]];
1503
1504 void baz(int = 5) { if (false) baz($unnamed[[)]]; };
1505 )cpp";
1506
1507 assertHints(InlayHintKind::DefaultArgument, Code, DefaultOptsForTests,
1508 ExpectedHint{"A: 4", "default1", Left},
1509 ExpectedHint{", B: 1, C: foo()", "default2", Left},
1510 ExpectedHint{"5", "unnamed", Left});
1511
1512 assertHints(InlayHintKind::Parameter, Code, DefaultOptsForTests,
1513 ExpectedHint{"A: ", "explicit", Left});
1514}
1515
1516TEST(DefaultArguments, WithoutParameterNames) {
1517 Config Cfg;
1518 Cfg.InlayHints.Parameters = false; // To test just default args this time
1519 Cfg.InlayHints.DeducedTypes = false;
1520 Cfg.InlayHints.Designators = false;
1521 Cfg.InlayHints.BlockEnd = false;
1522
1523 Cfg.InlayHints.DefaultArguments = true;
1524 WithContextValue WithCfg(Config::Key, std::move(Cfg));
1525
1526 const auto *Code = R"cpp(
1527 struct Baz {
1528 Baz(float a = 3 //
1529 + 2);
1530 };
1531 struct Foo {
1532 Foo(int, Baz baz = //
1533 Baz{$abbreviated[[}]]
1534
1535 //
1536 ) {}
1537 };
1538
1539 int main() {
1540 Foo foo1(1$paren[[)]];
1541 Foo foo2{2$brace1[[}]];
1542 Foo foo3 = {3$brace2[[}]];
1543 auto foo4 = Foo{4$brace3[[}]];
1544 }
1545 )cpp";
1546
1547 assertHints(InlayHintKind::DefaultArgument, Code, DefaultOptsForTests,
1548 ExpectedHint{"...", "abbreviated", Left},
1549 ExpectedHint{", Baz{}", "paren", Left},
1550 ExpectedHint{", Baz{}", "brace1", Left},
1551 ExpectedHint{", Baz{}", "brace2", Left},
1552 ExpectedHint{", Baz{}", "brace3", Left});
1553
1554 assertHints(InlayHintKind::Parameter, Code, DefaultOptsForTests);
1555}
1556
1557TEST(TypeHints, Deduplication) {
1558 assertTypeHints(R"cpp(
1559 template <typename T>
1560 void foo() {
1561 auto $var[[var]] = 42;
1562 }
1563 template void foo<int>();
1564 template void foo<float>();
1565 )cpp",
1566 ExpectedHint{": int", "var"});
1567}
1568
1569TEST(TypeHints, SinglyInstantiatedTemplate) {
1570 assertTypeHints(R"cpp(
1571 auto $lambda[[x]] = [](auto *$param[[y]], auto) { return 42; };
1572 int m = x("foo", 3);
1573 )cpp",
1574 ExpectedHint{": (lambda)", "lambda"},
1575 ExpectedHint{": const char *", "param"});
1576
1577 // No hint for packs, or auto params following packs
1578 assertTypeHints(R"cpp(
1579 int x(auto $a[[a]], auto... b, auto c) { return 42; }
1580 int m = x<void*, char, float>(nullptr, 'c', 2.0, 2);
1581 )cpp",
1582 ExpectedHint{": void *", "a"});
1583}
1584
1585TEST(TypeHints, Aliased) {
1586 // Check that we don't crash for functions without a FunctionTypeLoc.
1587 // https://github.com/clangd/clangd/issues/1140
1588 TestTU TU = TestTU::withCode("void foo(void){} extern typeof(foo) foo;");
1589 TU.ExtraArgs.push_back("-xc");
1590 auto AST = TU.build();
1591
1592 EXPECT_THAT(hintsOfKind(AST, InlayHintKind::Type, DefaultOptsForTests),
1593 IsEmpty());
1594}
1595
1596TEST(TypeHints, CallingConvention) {
1597 // Check that we don't crash for lambdas with an annotation
1598 // https://github.com/clangd/clangd/issues/2223
1599 Annotations Source(R"cpp(
1600 void test() {
1601 []($lambda[[)]]__cdecl {};
1602 }
1603 )cpp");
1604 TestTU TU = TestTU::withCode(Source.code());
1605 TU.ExtraArgs.push_back("--target=x86_64-w64-mingw32");
1606 TU.PredefineMacros = true; // for the __cdecl
1607 auto AST = TU.build();
1608
1609 EXPECT_THAT(
1610 hintsOfKind(AST, InlayHintKind::Type, DefaultOptsForTests),
1611 ElementsAre(HintMatcher(ExpectedHint{"-> void", "lambda"}, Source)));
1612}
1613
1614TEST(TypeHints, Decltype) {
1615 assertTypeHints(R"cpp(
1616 $a[[decltype(0)]] a;
1617 $b[[decltype(a)]] b;
1618 const $c[[decltype(0)]] &c = b;
1619
1620 // Don't show for dependent type
1621 template <class T>
1622 constexpr decltype(T{}) d;
1623
1624 $e[[decltype(0)]] e();
1625 auto f() -> $f[[decltype(0)]];
1626
1627 template <class, class> struct Foo;
1628 using G = Foo<$g[[decltype(0)]], float>;
1629
1630 auto $h[[h]] = $i[[decltype(0)]]{};
1631
1632 // No crash
1633 /* error-ok */
1634 auto $j[[s]];
1635 )cpp",
1636 ExpectedHint{": int", "a"}, ExpectedHint{": int", "b"},
1637 ExpectedHint{": int", "c"}, ExpectedHint{": int", "e"},
1638 ExpectedHint{": int", "f"}, ExpectedHint{": int", "g"},
1639 ExpectedHint{": int", "h"}, ExpectedHint{": int", "i"});
1640}
1641
1642TEST(TypeHints, SubstTemplateParameterAliases) {
1643 llvm::StringRef Header = R"cpp(
1644 template <class T> struct allocator {};
1645
1646 template <class T, class A>
1647 struct vector_base {
1648 using pointer = T*;
1649 };
1650
1651 template <class T, class A>
1652 struct internal_iterator_type_template_we_dont_expect {};
1653
1654 struct my_iterator {};
1655
1656 template <class T, class A = allocator<T>>
1657 struct vector : vector_base<T, A> {
1658 using base = vector_base<T, A>;
1659 typedef T value_type;
1660 typedef base::pointer pointer;
1661 using allocator_type = A;
1662 using size_type = int;
1663 using iterator = internal_iterator_type_template_we_dont_expect<T, A>;
1664 using non_template_iterator = my_iterator;
1665
1666 value_type& operator[](int index) { return elements[index]; }
1667 const value_type& at(int index) const { return elements[index]; }
1668 pointer data() { return &elements[0]; }
1669 allocator_type get_allocator() { return A(); }
1670 size_type size() const { return 10; }
1671 iterator begin() { return iterator(); }
1672 non_template_iterator end() { return non_template_iterator(); }
1673
1674 T elements[10];
1675 };
1676 )cpp";
1677
1678 llvm::StringRef VectorIntPtr = R"cpp(
1679 vector<int *> array;
1680 auto $no_modifier[[x]] = array[3];
1681 auto* $ptr_modifier[[ptr]] = &array[3];
1682 auto& $ref_modifier[[ref]] = array[3];
1683 auto& $at[[immutable]] = array.at(3);
1684
1685 auto $data[[data]] = array.data();
1686 auto $allocator[[alloc]] = array.get_allocator();
1687 auto $size[[size]] = array.size();
1688 auto $begin[[begin]] = array.begin();
1689 auto $end[[end]] = array.end();
1690 )cpp";
1691
1692 assertHintsWithHeader(
1693 InlayHintKind::Type, VectorIntPtr, Header, DefaultOptsForTests,
1694 ExpectedHint{": int *", "no_modifier"},
1695 ExpectedHint{": int **", "ptr_modifier"},
1696 ExpectedHint{": int *&", "ref_modifier"},
1697 ExpectedHint{": int *const &", "at"}, ExpectedHint{": int **", "data"},
1698 ExpectedHint{": allocator<int *>", "allocator"},
1699 ExpectedHint{": size_type", "size"}, ExpectedHint{": iterator", "begin"},
1700 ExpectedHint{": non_template_iterator", "end"});
1701
1702 llvm::StringRef VectorInt = R"cpp(
1703 vector<int> array;
1704 auto $no_modifier[[by_value]] = array[3];
1705 auto* $ptr_modifier[[ptr]] = &array[3];
1706 auto& $ref_modifier[[ref]] = array[3];
1707 auto& $at[[immutable]] = array.at(3);
1708
1709 auto $data[[data]] = array.data();
1710 auto $allocator[[alloc]] = array.get_allocator();
1711 auto $size[[size]] = array.size();
1712 auto $begin[[begin]] = array.begin();
1713 auto $end[[end]] = array.end();
1714 )cpp";
1715
1716 assertHintsWithHeader(
1717 InlayHintKind::Type, VectorInt, Header, DefaultOptsForTests,
1718 ExpectedHint{": int", "no_modifier"},
1719 ExpectedHint{": int *", "ptr_modifier"},
1720 ExpectedHint{": int &", "ref_modifier"},
1721 ExpectedHint{": const int &", "at"}, ExpectedHint{": int *", "data"},
1722 ExpectedHint{": allocator<int>", "allocator"},
1723 ExpectedHint{": size_type", "size"}, ExpectedHint{": iterator", "begin"},
1724 ExpectedHint{": non_template_iterator", "end"});
1725
1726 llvm::StringRef TypeAlias = R"cpp(
1727 // If the type alias is not of substituted template parameter type,
1728 // do not show desugared type.
1729 using VeryLongLongTypeName = my_iterator;
1730 using Short = VeryLongLongTypeName;
1731
1732 auto $short_name[[my_value]] = Short();
1733
1734 // Same applies with templates.
1735 template <typename T, typename A>
1736 using basic_static_vector = vector<T, A>;
1737 template <typename T>
1738 using static_vector = basic_static_vector<T, allocator<T>>;
1739
1740 auto $vector_name[[vec]] = static_vector<int>();
1741 )cpp";
1742
1743 assertHintsWithHeader(InlayHintKind::Type, TypeAlias, Header,
1744 DefaultOptsForTests,
1745 ExpectedHint{": Short", "short_name"},
1746 ExpectedHint{": static_vector<int>", "vector_name"});
1747}
1748
1749TEST(DesignatorHints, Basic) {
1750 assertDesignatorHints(R"cpp(
1751 struct S { int x, y, z; };
1752 S s {$x[[1]], $y[[2+2]]};
1753
1754 int x[] = {$0[[0]], $1[[1]]};
1755 )cpp",
1756 ExpectedHint{".x=", "x"}, ExpectedHint{".y=", "y"},
1757 ExpectedHint{"[0]=", "0"}, ExpectedHint{"[1]=", "1"});
1758}
1759
1760TEST(DesignatorHints, Nested) {
1761 assertDesignatorHints(R"cpp(
1762 struct Inner { int x, y; };
1763 struct Outer { Inner a, b; };
1764 Outer o{ $a[[{ $x[[1]], $y[[2]] }]], $bx[[3]] };
1765 )cpp",
1766 ExpectedHint{".a=", "a"}, ExpectedHint{".x=", "x"},
1767 ExpectedHint{".y=", "y"}, ExpectedHint{".b.x=", "bx"});
1768}
1769
1770TEST(DesignatorHints, AnonymousRecord) {
1771 assertDesignatorHints(R"cpp(
1772 struct S {
1773 union {
1774 struct {
1775 struct {
1776 int y;
1777 };
1778 } x;
1779 };
1780 };
1781 S s{$xy[[42]]};
1782 )cpp",
1783 ExpectedHint{".x.y=", "xy"});
1784}
1785
1786TEST(DesignatorHints, Suppression) {
1787 assertDesignatorHints(R"cpp(
1788 struct Point { int a, b, c, d, e, f, g, h; };
1789 Point p{/*a=*/1, .c=2, /* .d = */3, $e[[4]]};
1790 )cpp",
1791 ExpectedHint{".e=", "e"});
1792}
1793
1794TEST(DesignatorHints, StdArray) {
1795 // Designators for std::array should be [0] rather than .__elements[0].
1796 // While technically correct, the designator is useless and horrible to read.
1797 assertDesignatorHints(R"cpp(
1798 template <typename T, int N> struct Array { T __elements[N]; };
1799 Array<int, 2> x = {$0[[0]], $1[[1]]};
1800 )cpp",
1801 ExpectedHint{"[0]=", "0"}, ExpectedHint{"[1]=", "1"});
1802}
1803
1804TEST(DesignatorHints, OnlyAggregateInit) {
1805 assertDesignatorHints(R"cpp(
1806 struct Copyable { int x; } c;
1807 Copyable d{c};
1808
1809 struct Constructible { Constructible(int x); };
1810 Constructible x{42};
1811 )cpp" /*no designator hints expected (but param hints!)*/);
1812}
1813
1814TEST(DesignatorHints, NoCrash) {
1815 assertDesignatorHints(R"cpp(
1816 /*error-ok*/
1817 struct A {};
1818 struct Foo {int a; int b;};
1819 void test() {
1820 Foo f{A(), $b[[1]]};
1821 }
1822 )cpp",
1823 ExpectedHint{".b=", "b"});
1824}
1825
1826TEST(DesignatorHints, ParenInit) {
1827 assertDesignatorHints(R"cpp(
1828 struct S {
1829 int x;
1830 int y;
1831 int z;
1832 };
1833 S s ($x[[1]], $y[[2+2]], $z[[4]]);
1834 )cpp",
1835 ExpectedHint{".x=", "x"}, ExpectedHint{".y=", "y"},
1836 ExpectedHint{".z=", "z"});
1837}
1838
1839TEST(DesignatorHints, ParenInitDerived) {
1840 assertDesignatorHints(R"cpp(
1841 struct S1 {
1842 int a;
1843 int b;
1844 };
1845
1846 struct S2 : S1 {
1847 int c;
1848 int d;
1849 };
1850 S2 s2 ({$a[[0]], $b[[0]]}, $c[[0]], $d[[0]]);
1851 )cpp",
1852 // ExpectedHint{"S1:", "S1"},
1853 ExpectedHint{".a=", "a"}, ExpectedHint{".b=", "b"},
1854 ExpectedHint{".c=", "c"}, ExpectedHint{".d=", "d"});
1855}
1856
1857TEST(DesignatorHints, ParenInitTemplate) {
1858 assertDesignatorHints(R"cpp(
1859 template <typename T>
1860 struct S1 {
1861 int a;
1862 int b;
1863 T* ptr;
1864 };
1865
1866 struct S2 : S1<S2> {
1867 int c;
1868 int d;
1869 S1<int> mem;
1870 };
1871
1872 int main() {
1873 S2 sa ({$a1[[0]], $b1[[0]]}, $c[[0]], $d[[0]], $mem[[S1<int>($a2[[1]], $b2[[2]], $ptr[[nullptr]])]]);
1874 }
1875 )cpp",
1876 ExpectedHint{".a=", "a1"}, ExpectedHint{".b=", "b1"},
1877 ExpectedHint{".c=", "c"}, ExpectedHint{".d=", "d"},
1878 ExpectedHint{".mem=", "mem"}, ExpectedHint{".a=", "a2"},
1879 ExpectedHint{".b=", "b2"},
1880 ExpectedHint{".ptr=", "ptr"});
1881}
1882
1883TEST(InlayHints, RestrictRange) {
1884 Annotations Code(R"cpp(
1885 auto a = false;
1886 [[auto b = 1;
1887 auto c = '2';]]
1888 auto d = 3.f;
1889 )cpp");
1890 auto AST = TestTU::withCode(Code.code()).build();
1891 EXPECT_THAT(inlayHints(AST, Code.range()),
1892 ElementsAre(labelIs(": int"), labelIs(": char")));
1893}
1894
1895TEST(ParameterHints, PseudoObjectExpr) {
1896 Annotations Code(R"cpp(
1897 struct S {
1898 __declspec(property(get=GetX, put=PutX)) int x[];
1899 int GetX(int y, int z) { return 42 + y; }
1900 void PutX(int) { }
1901
1902 // This is a PseudoObjectExpression whose syntactic form is a binary
1903 // operator.
1904 void Work(int y) { x = y; } // Not `x = y: y`.
1905 };
1906
1907 int printf(const char *Format, ...);
1908
1909 int main() {
1910 S s;
1911 __builtin_dump_struct(&s, printf); // Not `Format: __builtin_dump_struct()`
1912 printf($Param[["Hello, %d"]], 42); // Normal calls are not affected.
1913 // This builds a PseudoObjectExpr, but here it's useful for showing the
1914 // arguments from the semantic form.
1915 return s.x[ $one[[1]] ][ $two[[2]] ]; // `x[y: 1][z: 2]`
1916 }
1917 )cpp");
1918 auto TU = TestTU::withCode(Code.code());
1919 TU.ExtraArgs.push_back("-fms-extensions");
1920 auto AST = TU.build();
1921 EXPECT_THAT(inlayHints(AST, std::nullopt),
1922 ElementsAre(HintMatcher(ExpectedHint{"Format: ", "Param"}, Code),
1923 HintMatcher(ExpectedHint{"y: ", "one"}, Code),
1924 HintMatcher(ExpectedHint{"z: ", "two"}, Code)));
1925}
1926
1927TEST(ParameterHints, ArgPacksAndConstructors) {
1928 assertParameterHints(
1929 R"cpp(
1930 struct Foo{ Foo(); Foo(int x); };
1931 void foo(Foo a, int b);
1932 template <typename... Args>
1933 void bar(Args... args) {
1934 foo(args...);
1935 }
1936 template <typename... Args>
1937 void baz(Args... args) { foo($param1[[Foo{args...}]], $param2[[1]]); }
1938
1939 template <typename... Args>
1940 void bax(Args... args) { foo($param3[[{args...}]], args...); }
1941
1942 void foo() {
1943 bar($param4[[Foo{}]], $param5[[42]]);
1944 bar($param6[[42]], $param7[[42]]);
1945 baz($param8[[42]]);
1946 bax($param9[[42]]);
1947 }
1948 )cpp",
1949 ExpectedHint{"a: ", "param1"}, ExpectedHint{"b: ", "param2"},
1950 ExpectedHint{"a: ", "param3"}, ExpectedHint{"a: ", "param4"},
1951 ExpectedHint{"b: ", "param5"}, ExpectedHint{"a: ", "param6"},
1952 ExpectedHint{"b: ", "param7"}, ExpectedHint{"x: ", "param8"},
1953 ExpectedHint{"b: ", "param9"});
1954}
1955
1956TEST(ParameterHints, DoesntExpandAllArgs) {
1957 assertParameterHints(
1958 R"cpp(
1959 void foo(int x, int y);
1960 int id(int a, int b, int c);
1961 template <typename... Args>
1962 void bar(Args... args) {
1963 foo(id($param1[[args]], $param2[[1]], $param3[[args]])...);
1964 }
1965 void foo() {
1966 bar(1, 2); // FIXME: We could have `bar(a: 1, a: 2)` here.
1967 }
1968 )cpp",
1969 ExpectedHint{"a: ", "param1"}, ExpectedHint{"b: ", "param2"},
1970 ExpectedHint{"c: ", "param3"});
1971}
1972
1973TEST(BlockEndHints, Functions) {
1974 assertBlockEndHints(R"cpp(
1975 int foo() {
1976 return 41;
1977 $foo[[}]]
1978
1979 template<int X>
1980 int bar() {
1981 // No hint for lambda for now
1982 auto f = []() {
1983 return X;
1984 };
1985 return f();
1986 $bar[[}]]
1987
1988 // No hint because this isn't a definition
1989 int buz();
1990
1991 struct S{};
1992 bool operator==(S, S) {
1993 return true;
1994 $opEqual[[}]]
1995 )cpp",
1996 ExpectedHint{" // foo", "foo"},
1997 ExpectedHint{" // bar", "bar"},
1998 ExpectedHint{" // operator==", "opEqual"});
1999}
2000
2001TEST(BlockEndHints, Methods) {
2002 assertBlockEndHints(R"cpp(
2003 struct Test {
2004 // No hint because there's no function body
2005 Test() = default;
2006
2007 ~Test() {
2008 $dtor[[}]]
2009
2010 void method1() {
2011 $method1[[}]]
2012
2013 // No hint because this isn't a definition
2014 void method2();
2015
2016 template <typename T>
2017 void method3() {
2018 $method3[[}]]
2019
2020 // No hint because this isn't a definition
2021 template <typename T>
2022 void method4();
2023
2024 Test operator+(int) const {
2025 return *this;
2026 $opIdentity[[}]]
2027
2028 operator bool() const {
2029 return true;
2030 $opBool[[}]]
2031
2032 // No hint because there's no function body
2033 operator int() const = delete;
2034 } x;
2035
2036 void Test::method2() {
2037 $method2[[}]]
2038
2039 template <typename T>
2040 void Test::method4() {
2041 $method4[[}]]
2042 )cpp",
2043 ExpectedHint{" // ~Test", "dtor"},
2044 ExpectedHint{" // method1", "method1"},
2045 ExpectedHint{" // method3", "method3"},
2046 ExpectedHint{" // operator+", "opIdentity"},
2047 ExpectedHint{" // operator bool", "opBool"},
2048 ExpectedHint{" // Test::method2", "method2"},
2049 ExpectedHint{" // Test::method4", "method4"});
2050}
2051
2052TEST(BlockEndHints, Namespaces) {
2053 assertBlockEndHints(
2054 R"cpp(
2055 namespace {
2056 void foo();
2057 $anon[[}]]
2058
2059 namespace ns {
2060 void bar();
2061 $ns[[}]]
2062 )cpp",
2063 ExpectedHint{" // namespace", "anon"},
2064 ExpectedHint{" // namespace ns", "ns"});
2065}
2066
2067TEST(BlockEndHints, Types) {
2068 assertBlockEndHints(
2069 R"cpp(
2070 struct S {
2071 $S[[};]]
2072
2073 class C {
2074 $C[[};]]
2075
2076 union U {
2077 $U[[};]]
2078
2079 enum E1 {
2080 $E1[[};]]
2081
2082 enum class E2 {
2083 $E2[[};]]
2084 )cpp",
2085 ExpectedHint{" // struct S", "S"}, ExpectedHint{" // class C", "C"},
2086 ExpectedHint{" // union U", "U"}, ExpectedHint{" // enum E1", "E1"},
2087 ExpectedHint{" // enum class E2", "E2"});
2088}
2089
2090TEST(BlockEndHints, If) {
2091 assertBlockEndHints(
2092 R"cpp(
2093 void foo(bool cond) {
2094 void* ptr;
2095 if (cond)
2096 ;
2097
2098 if (cond) {
2099 $simple[[}]]
2100
2101 if (cond) {
2102 } else {
2103 $ifelse[[}]]
2104
2105 if (cond) {
2106 } else if (!cond) {
2107 $elseif[[}]]
2108
2109 if (cond) {
2110 } else {
2111 if (!cond) {
2112 $inner[[}]]
2113 $outer[[}]]
2114
2115 if (auto X = cond) {
2116 $init[[}]]
2117
2118 if (int i = 0; i > 10) {
2119 $init_cond[[}]]
2120
2121 if (ptr != nullptr) {
2122 $null_check[[}]]
2123 } // suppress
2124 )cpp",
2125 ExpectedHint{" // if cond", "simple"},
2126 ExpectedHint{" // if cond", "ifelse"}, ExpectedHint{" // if", "elseif"},
2127 ExpectedHint{" // if !cond", "inner"},
2128 ExpectedHint{" // if cond", "outer"}, ExpectedHint{" // if X", "init"},
2129 ExpectedHint{" // if i > 10", "init_cond"},
2130 ExpectedHint{" // if ptr != nullptr", "null_check"});
2131}
2132
2133TEST(BlockEndHints, Loops) {
2134 assertBlockEndHints(
2135 R"cpp(
2136 void foo() {
2137 while (true)
2138 ;
2139
2140 while (true) {
2141 $while[[}]]
2142
2143 do {
2144 } while (true);
2145
2146 for (;true;) {
2147 $forcond[[}]]
2148
2149 for (int I = 0; I < 10; ++I) {
2150 $forvar[[}]]
2151
2152 int Vs[] = {1,2,3};
2153 for (auto V : Vs) {
2154 $foreach[[}]]
2155 } // suppress
2156 )cpp",
2157 ExpectedHint{" // while true", "while"},
2158 ExpectedHint{" // for true", "forcond"},
2159 ExpectedHint{" // for I", "forvar"},
2160 ExpectedHint{" // for V", "foreach"});
2161}
2162
2163TEST(BlockEndHints, Switch) {
2164 assertBlockEndHints(
2165 R"cpp(
2166 void foo(int I) {
2167 switch (I) {
2168 case 0: break;
2169 $switch[[}]]
2170 } // suppress
2171 )cpp",
2172 ExpectedHint{" // switch I", "switch"});
2173}
2174
2175TEST(BlockEndHints, PrintLiterals) {
2176 assertBlockEndHints(
2177 R"cpp(
2178 void foo() {
2179 while ("foo") {
2180 $string[[}]]
2181
2182 while ("foo but this time it is very long") {
2183 $string_long[[}]]
2184
2185 while (true) {
2186 $boolean[[}]]
2187
2188 while (1) {
2189 $integer[[}]]
2190
2191 while (1.5) {
2192 $float[[}]]
2193 } // suppress
2194 )cpp",
2195 ExpectedHint{" // while \"foo\"", "string"},
2196 ExpectedHint{" // while \"foo but...\"", "string_long"},
2197 ExpectedHint{" // while true", "boolean"},
2198 ExpectedHint{" // while 1", "integer"},
2199 ExpectedHint{" // while 1.5", "float"});
2200}
2201
2202TEST(BlockEndHints, PrintRefs) {
2203 assertBlockEndHints(
2204 R"cpp(
2205 namespace ns {
2206 int Var;
2207 int func1();
2208 int func2(int, int);
2209 struct S {
2210 int Field;
2211 int method1() const;
2212 int method2(int, int) const;
2213 }; // suppress
2214 } // suppress
2215 void foo() {
2216 int int_a {};
2217 while (ns::Var) {
2218 $var[[}]]
2219
2220 while (ns::func1()) {
2221 $func1[[}]]
2222
2223 while (ns::func2(int_a, int_a)) {
2224 $func2[[}]]
2225
2226 while (ns::S{}.Field) {
2227 $field[[}]]
2228
2229 while (ns::S{}.method1()) {
2230 $method1[[}]]
2231
2232 while (ns::S{}.method2(int_a, int_a)) {
2233 $method2[[}]]
2234 } // suppress
2235 )cpp",
2236 ExpectedHint{" // while Var", "var"},
2237 ExpectedHint{" // while func1()", "func1"},
2238 ExpectedHint{" // while func2(...)", "func2"},
2239 ExpectedHint{" // while Field", "field"},
2240 ExpectedHint{" // while method1()", "method1"},
2241 ExpectedHint{" // while method2(...)", "method2"});
2242}
2243
2244TEST(BlockEndHints, PrintConversions) {
2245 assertBlockEndHints(
2246 R"cpp(
2247 struct S {
2248 S(int);
2249 S(int, int);
2250 explicit operator bool();
2251 }; // suppress
2252 void foo(int I) {
2253 while (float(I)) {
2254 $convert_primitive[[}]]
2255
2256 while (S(I)) {
2257 $convert_class[[}]]
2258
2259 while (S(I, I)) {
2260 $construct_class[[}]]
2261 } // suppress
2262 )cpp",
2263 ExpectedHint{" // while float", "convert_primitive"},
2264 ExpectedHint{" // while S", "convert_class"},
2265 ExpectedHint{" // while S", "construct_class"});
2266}
2267
2268TEST(BlockEndHints, PrintOperators) {
2269 std::string AnnotatedCode = R"cpp(
2270 void foo(Integer I) {
2271 while(++I){
2272 $preinc[[}]]
2273
2274 while(I++){
2275 $postinc[[}]]
2276
2277 while(+(I + I)){
2278 $unary_complex[[}]]
2279
2280 while(I < 0){
2281 $compare[[}]]
2282
2283 while((I + I) < I){
2284 $lhs_complex[[}]]
2285
2286 while(I < (I + I)){
2287 $rhs_complex[[}]]
2288
2289 while((I + I) < (I + I)){
2290 $binary_complex[[}]]
2291 } // suppress
2292 )cpp";
2293
2294 // We can't store shared expectations in a vector, assertHints uses varargs.
2295 auto AssertExpectedHints = [&](llvm::StringRef Code) {
2296 assertBlockEndHints(Code, ExpectedHint{" // while ++I", "preinc"},
2297 ExpectedHint{" // while I++", "postinc"},
2298 ExpectedHint{" // while", "unary_complex"},
2299 ExpectedHint{" // while I < 0", "compare"},
2300 ExpectedHint{" // while ... < I", "lhs_complex"},
2301 ExpectedHint{" // while I < ...", "rhs_complex"},
2302 ExpectedHint{" // while", "binary_complex"});
2303 };
2304
2305 // First with built-in operators.
2306 AssertExpectedHints("using Integer = int;" + AnnotatedCode);
2307 // And now with overloading!
2308 AssertExpectedHints(R"cpp(
2309 struct Integer {
2310 explicit operator bool();
2311 Integer operator++();
2312 Integer operator++(int);
2313 Integer operator+(Integer);
2314 Integer operator+();
2315 bool operator<(Integer);
2316 bool operator<(int);
2317 }; // suppress
2318 )cpp" + AnnotatedCode);
2319}
2320
2321TEST(BlockEndHints, TrailingSemicolon) {
2322 assertBlockEndHints(R"cpp(
2323 // The hint is placed after the trailing ';'
2324 struct S1 {
2325 $S1[[} ;]]
2326
2327 // The hint is always placed in the same line with the closing '}'.
2328 // So in this case where ';' is missing, it is attached to '}'.
2329 struct S2 {
2330 $S2[[}]]
2331
2332 ;
2333
2334 // No hint because only one trailing ';' is allowed
2335 struct S3 {
2336 };;
2337
2338 // No hint because trailing ';' is only allowed for class/struct/union/enum
2339 void foo() {
2340 };
2341
2342 // Rare case, but yes we'll have a hint here.
2343 struct {
2344 int x;
2345 $anon[[}]]
2346
2347 s2;
2348 )cpp",
2349 ExpectedHint{" // struct S1", "S1"},
2350 ExpectedHint{" // struct S2", "S2"},
2351 ExpectedHint{" // struct", "anon"});
2352}
2353
2354TEST(BlockEndHints, TrailingText) {
2355 assertBlockEndHints(R"cpp(
2356 struct S1 {
2357 $S1[[} ;]]
2358
2359 // No hint for S2 because of the trailing comment
2360 struct S2 {
2361 }; /* Put anything here */
2362
2363 struct S3 {
2364 // No hint for S4 because of the trailing source code
2365 struct S4 {
2366 };$S3[[};]]
2367
2368 // No hint for ns because of the trailing comment
2369 namespace ns {
2370 } // namespace ns
2371 )cpp",
2372 ExpectedHint{" // struct S1", "S1"},
2373 ExpectedHint{" // struct S3", "S3"});
2374}
2375
2376TEST(BlockEndHints, Macro) {
2377 assertBlockEndHints(R"cpp(
2378 #define DECL_STRUCT(NAME) struct NAME {
2379 #define RBRACE }
2380
2381 DECL_STRUCT(S1)
2382 $S1[[};]]
2383
2384 // No hint because we require a '}'
2385 DECL_STRUCT(S2)
2386 RBRACE;
2387 )cpp",
2388 ExpectedHint{" // struct S1", "S1"});
2389}
2390
2391TEST(BlockEndHints, PointerToMemberFunction) {
2392 // Do not crash trying to summarize `a->*p`.
2393 assertBlockEndHints(R"cpp(
2394 class A {};
2395 using Predicate = bool(A::*)();
2396 void foo(A* a, Predicate p) {
2397 if ((a->*p)()) {
2398 $ptrmem[[}]]
2399 } // suppress
2400 )cpp",
2401 ExpectedHint{" // if ()", "ptrmem"});
2402}
2403
2404TEST(BlockEndHints, MinLineLimit) {
2405 InlayHintOptions Opts;
2406 Opts.HintMinLineLimit = 10;
2407
2408 // namespace ns below is exactly 10 lines
2409 assertBlockEndHintsWithOpts(
2410 R"cpp(
2411 namespace ns {
2412 int Var;
2413 int func1();
2414 int func2(int, int);
2415 struct S {
2416 int Field;
2417 int method1() const;
2418 int method2(int, int) const;
2419 };
2420 $namespace[[}]]
2421 void foo() {
2422 int int_a {};
2423 while (ns::Var) {
2424 }
2425
2426 while (ns::func1()) {
2427 }
2428
2429 while (ns::func2(int_a, int_a)) {
2430 }
2431
2432 while (ns::S{}.Field) {
2433 }
2434
2435 while (ns::S{}.method1()) {
2436 }
2437
2438 while (ns::S{}.method2(int_a, int_a)) {
2439 }
2440 $foo[[}]]
2441 )cpp",
2442 Opts, ExpectedHint{" // namespace ns", "namespace"},
2443 ExpectedHint{" // foo", "foo"});
2444}
2445
2446// FIXME: Low-hanging fruit where we could omit a type hint:
2447// - auto x = TypeName(...);
2448// - auto x = (TypeName) (...);
2449// - auto x = static_cast<TypeName>(...); // and other built-in casts
2450
2451// Annoyances for which a heuristic is not obvious:
2452// - auto x = llvm::dyn_cast<LongTypeName>(y); // and similar
2453// - stdlib algos return unwieldy __normal_iterator<X*, ...> type
2454// (For this one, perhaps we should omit type hints that start
2455// with a double underscore.)
2456
2457} // namespace
2458} // namespace clangd
2459} // namespace clang
Same as llvm::Annotations, but adjusts functions to LSP-specific types for positions and ranges.
Definition Annotations.h:23
void addSource(llvm::StringRef Filename, llvm::StringRef Code)
WithContextValue extends Context::current() with a single value.
Definition Context.h:200
FIXME: Skip testing on windows temporarily due to the different escaping code mode.
Definition AST.cpp:44
MATCHER_P2(hasFlag, Flag, Path, "")
llvm::raw_ostream & operator<<(llvm::raw_ostream &OS, const CodeCompletion &C)
MATCHER_P(named, N, "")
TEST(BackgroundQueueTest, Priority)
InlayHintKind
Inlay hint kinds.
Definition Protocol.h:1725
@ BlockEnd
A hint after function, type or namespace definition, indicating the defined symbol name of the defini...
Definition Protocol.h:1755
@ DefaultArgument
An inlay hint that is for a default argument.
Definition Protocol.h:1764
@ Parameter
An inlay hint that is for a parameter.
Definition Protocol.h:1738
@ Type
An inlay hint that for a type annotation.
Definition Protocol.h:1731
@ Designator
A hint before an element of an aggregate braced initializer list, indicating what it is initializing.
Definition Protocol.h:1745
std::vector< InlayHint > inlayHints(ParsedAST &AST, std::optional< Range > RestrictRange, InlayHintOptions HintOptions)
Compute and return inlay hints for a file.
===– Representation.cpp - ClangDoc Representation --------—*- C++ -*-===//
Settings that express user/project preferences and control clangd behavior.
Definition Config.h:45
static clangd::Key< Config > Key
Context key which can be used to set the current Config.
Definition Config.h:49
struct clang::clangd::Config::@041344304366110202143331236314370324353035136032 InlayHints
uint32_t TypeNameLimit
Definition Config.h:202
Inlay hint information.
Definition Protocol.h:1817
std::string joinLabels() const
Join the label[].value together.
Range range
The range of source code to which the hint applies.
Definition Protocol.h:1850
ParsedAST build() const
Definition TestTU.cpp:115
static TestTU withCode(llvm::StringRef Code)
Definition TestTU.h:36