13#include "clang/AST/CXXInheritance.h"
14#include "clang/Lex/PPCallbacks.h"
15#include "clang/Lex/Preprocessor.h"
16#include "llvm/ADT/ArrayRef.h"
17#include "llvm/ADT/StringRef.h"
18#include "llvm/Support/Debug.h"
19#include "llvm/Support/Path.h"
20#include "llvm/Support/Regex.h"
21#include "llvm/Support/YAMLParser.h"
24#define DEBUG_TYPE "clang-tidy"
33 std::pair<readability::IdentifierNamingCheck::CaseType, StringRef>>
49 "Leading_upper_snake_case"}};
55 readability::IdentifierNamingCheck::HungarianPrefixType> {
58 static llvm::ArrayRef<std::pair<HungarianPrefixType, StringRef>>
60 static constexpr std::pair<HungarianPrefixType, StringRef> Mapping[] = {
61 {HungarianPrefixType::HPT_Off,
"Off"},
62 {HungarianPrefixType::HPT_On,
"On"},
63 {HungarianPrefixType::HPT_LowerCase,
"LowerCase"},
64 {HungarianPrefixType::HPT_CamelCase,
"CamelCase"}};
69namespace readability {
72#define NAMING_KEYS(m) \
77 m(ScopedEnumConstant) \
78 m(ConstexprVariable) \
87 m(GlobalConstexprVariable) \
89 m(GlobalConstantPointer) \
92 m(LocalConstexprVariable) \
94 m(LocalConstantPointer) \
97 m(StaticConstexprVariable) \
102 m(ConstantParameter) \
105 m(PointerParameter) \
106 m(ConstantPointerParameter) \
113 m(ConstexprFunction) \
123 m(TypeTemplateParameter) \
124 m(ValueTemplateParameter) \
125 m(TemplateTemplateParameter) \
126 m(TemplateParameter) \
133#define ENUMERATE(v) SK_ ## v,
141#define STRINGIZE(v) #v,
146#define HUNGARIAN_NOTATION_PRIMITIVE_TYPES(m) \
170 m(signed-short-int) \
171 m(signed-long-long-int) \
172 m(signed-long-long) \
176 m(unsigned-long-long-int) \
177 m(unsigned-long-long) \
178 m(unsigned-long-int) \
180 m(unsigned-short-int) \
194#define STRINGIZE(v) #v,
199#define HUNGARIAN_NOTATION_USER_DEFINED_TYPES(m) \
230#define STRINGIZE(v) #v,
240 std::optional<IdentifierNamingCheck::CaseType> Case, StringRef Prefix,
241 StringRef Suffix, StringRef IgnoredRegexpStr, HungarianPrefixType HPType)
242 : Case(Case), Prefix(Prefix), Suffix(Suffix),
243 IgnoredRegexpStr(IgnoredRegexpStr), HPType(HPType) {
244 if (!IgnoredRegexpStr.empty()) {
245 IgnoredRegexp = llvm::Regex(SmallString<128>({
"^", IgnoredRegexpStr,
"$"}));
246 if (!IgnoredRegexp.isValid())
247 llvm::errs() <<
"Invalid IgnoredRegexp regular expression: "
253 const ClangTidyCheck::OptionsView &Options)
const {
261 SmallString<64> StyleString;
262 for (
unsigned I = 0; I <
SK_Count; ++I) {
263 const size_t StyleSize =
StyleNames[I].size();
264 StyleString.assign({
StyleNames[I],
"HungarianPrefix"});
269 configurationDiag(
"invalid identifier naming option '%0'") << StyleString;
271 memcpy(&StyleString[StyleSize],
"IgnoredRegexp", 13);
272 StyleString.truncate(StyleSize + 13);
273 const std::optional<StringRef> IgnoredRegexpStr = Options.get(StyleString);
274 memcpy(&StyleString[StyleSize],
"Prefix", 6);
275 StyleString.truncate(StyleSize + 6);
276 const std::optional<StringRef> Prefix(Options.get(StyleString));
278 memcpy(&StyleString[StyleSize],
"Suf", 3);
279 const std::optional<StringRef> Postfix(Options.get(StyleString));
280 memcpy(&StyleString[StyleSize],
"Case", 4);
281 StyleString.pop_back_n(2);
282 std::optional<CaseType> CaseOptional =
285 if (CaseOptional || Prefix || Postfix || IgnoredRegexpStr || HPTOpt)
286 Styles[I].emplace(std::move(CaseOptional), Prefix.value_or(
""),
287 Postfix.value_or(
""), IgnoredRegexpStr.value_or(
""),
290 const bool IgnoreMainLike = Options.get(
"IgnoreMainLikeFunctions",
false);
291 const bool CheckAnonFieldInParent =
292 Options.get(
"CheckAnonFieldInParent",
false);
293 return {std::move(Styles), std::move(HNOption), IgnoreMainLike,
294 CheckAnonFieldInParent};
298 const NamedDecl *ND)
const {
299 const auto *VD = dyn_cast<ValueDecl>(ND);
303 if (isa<FunctionDecl, EnumConstantDecl>(ND))
307 auto &SM = VD->getASTContext().getSourceManager();
308 const char *Begin = SM.getCharacterData(VD->getBeginLoc());
309 const char *End = SM.getCharacterData(VD->getEndLoc());
310 intptr_t StrLen = End - Begin;
316 const char *EOL = strchr(Begin,
'\n');
318 EOL = Begin + strlen(Begin);
320 const char *
const PosList[] = {strchr(Begin,
'='), strchr(Begin,
';'),
321 strchr(Begin,
','), strchr(Begin,
')'), EOL};
322 for (
const auto &Pos : PosList)
324 EOL = std::min(EOL, Pos);
326 StrLen = EOL - Begin;
327 std::string TypeName;
329 std::string Type(Begin, StrLen);
331 static constexpr StringRef Keywords[] = {
333 "constexpr",
"constinit",
"consteval",
335 "const",
"volatile",
"restrict",
"mutable",
337 "register",
"static",
"extern",
"thread_local",
342 for (
const StringRef Kw : Keywords)
343 for (
size_t Pos = 0; (Pos = Type.find(Kw, Pos)) != std::string::npos;)
344 Type.replace(Pos, Kw.size(),
"");
345 TypeName = Type.erase(0, Type.find_first_not_of(
' '));
348 const size_t Pos = Type.find(
'<');
349 if (Pos != std::string::npos)
350 TypeName = Type.erase(Pos, Type.size() - Pos);
353 for (
size_t Pos = 0; (Pos = Type.find(
" ", Pos)) != std::string::npos;
354 Pos += strlen(
" ")) {
355 Type.replace(Pos, strlen(
" "),
" ");
359 for (
size_t Pos = 0; (Pos = Type.find(
" &", Pos)) != std::string::npos;
360 Pos += strlen(
"&")) {
361 Type.replace(Pos, strlen(
" &"),
"&");
365 for (
size_t Pos = 0; (Pos = Type.find(
" *", Pos)) != std::string::npos;
366 Pos += strlen(
"*")) {
367 Type.replace(Pos, strlen(
" *"),
"* ");
371 static constexpr StringRef TailsOfMultiWordType[] = {
372 " int",
" char",
" double",
" long",
" short"};
373 bool RedundantRemoved =
false;
374 for (
auto Kw : TailsOfMultiWordType) {
375 const size_t Pos = Type.rfind(Kw);
376 if (Pos != std::string::npos) {
378 Type = Type.substr(0, Pos + Kw.size() + PtrCount);
379 RedundantRemoved =
true;
384 TypeName = Type.erase(0, Type.find_first_not_of(
' '));
385 if (!RedundantRemoved) {
386 const std::size_t FoundSpace = Type.find(
' ');
387 if (FoundSpace != std::string::npos)
388 Type = Type.substr(0, FoundSpace);
391 TypeName = Type.erase(0, Type.find_first_not_of(
' '));
393 const QualType QT = VD->getType();
394 if (!QT.isNull() && QT->isArrayType())
395 TypeName.append(
"[]");
404 GetConfigPerFile(Options.get(
"GetConfigPerFile", true)),
405 IgnoreFailedSplit(Options.get(
"IgnoreFailedSplit", false)) {
406 auto IterAndInserted = NamingStylesCache.try_emplace(
407 llvm::sys::path::parent_path(Context->getCurrentFile()),
409 assert(IterAndInserted.second &&
"Couldn't insert Style");
412 MainFileStyle = &IterAndInserted.first->getValue();
418 int StyleKindIndex)
const {
419 if ((StyleKindIndex >= SK_EnumConstant) &&
420 (StyleKindIndex <= SK_ConstantParameter))
423 if ((StyleKindIndex >= SK_Parameter) && (StyleKindIndex <= SK_Enum))
430 StringRef OptionKey,
const llvm::StringMap<std::string> &StrMap)
const {
431 if (OptionKey.empty())
434 auto Iter = StrMap.find(OptionKey);
435 if (Iter == StrMap.end())
438 return llvm::yaml::parseBool(Iter->getValue()).value_or(
false);
442 const ClangTidyCheck::OptionsView &Options,
444 static constexpr StringRef HNOpts[] = {
"TreatStructAsClass"};
445 static constexpr StringRef HNDerivedTypes[] = {
"Array",
"Pointer",
448 const StringRef Section =
"HungarianNotation.";
450 SmallString<128> Buffer = {Section,
"General."};
451 size_t DefSize = Buffer.size();
452 for (
const auto &Opt : HNOpts) {
453 Buffer.truncate(DefSize);
455 const StringRef Val = Options.get(Buffer,
"");
457 HNOption.
General[Opt] = Val.str();
460 Buffer = {Section,
"DerivedType."};
461 DefSize = Buffer.size();
462 for (
const auto &Type : HNDerivedTypes) {
463 Buffer.truncate(DefSize);
465 const StringRef Val = Options.get(Buffer,
"");
470 static constexpr std::pair<StringRef, StringRef> HNCStrings[] = {
471 {
"CharPointer",
"char*"},
472 {
"CharArray",
"char[]"},
473 {
"WideCharPointer",
"wchar_t*"},
474 {
"WideCharArray",
"wchar_t[]"}};
476 Buffer = {Section,
"CString."};
477 DefSize = Buffer.size();
478 for (
const auto &CStr : HNCStrings) {
479 Buffer.truncate(DefSize);
480 Buffer.append(CStr.first);
481 const StringRef Val = Options.get(Buffer,
"");
483 HNOption.
CString[CStr.second] = Val.str();
486 Buffer = {Section,
"PrimitiveType."};
487 DefSize = Buffer.size();
489 Buffer.truncate(DefSize);
490 Buffer.append(PrimType);
491 const StringRef Val = Options.get(Buffer,
"");
493 std::string Type = PrimType.str();
494 llvm::replace(Type,
'-',
' ');
499 Buffer = {Section,
"UserDefinedType."};
500 DefSize = Buffer.size();
502 Buffer.truncate(DefSize);
504 const StringRef Val = Options.get(Buffer,
"");
515 const auto *ND = dyn_cast<NamedDecl>(D);
520 if (
const auto *ECD = dyn_cast<EnumConstantDecl>(ND)) {
522 }
else if (
const auto *CRD = dyn_cast<CXXRecordDecl>(ND)) {
524 }
else if (isa<VarDecl, FieldDecl, RecordDecl>(ND)) {
526 if (!TypeName.empty())
536 if (Words.size() <= 1)
539 const std::string CorrectName = Words[0].str();
540 const std::vector<llvm::StringMap<std::string>> MapList = {
544 for (
const auto &Map : MapList) {
545 for (
const auto &Str : Map) {
546 if (Str.getValue() == CorrectName) {
547 Words.erase(Words.begin(), Words.begin() + 1);
557 StringRef TypeName,
const NamedDecl *ND,
559 if (!ND || TypeName.empty())
560 return TypeName.str();
562 std::string ModifiedTypeName(TypeName);
565 std::string PrefixStr;
566 if (
const auto *TD = dyn_cast<ValueDecl>(ND)) {
567 const QualType QT = TD->getType();
568 if (QT->isFunctionPointerType()) {
569 PrefixStr = HNOption.
DerivedType.lookup(
"FunctionPointer");
570 }
else if (QT->isPointerType()) {
571 for (
const auto &CStr : HNOption.
CString) {
572 const std::string Key = CStr.getKey().str();
573 if (ModifiedTypeName.find(Key) == 0) {
574 PrefixStr = CStr.getValue();
575 ModifiedTypeName = ModifiedTypeName.substr(
576 Key.size(), ModifiedTypeName.size() - Key.size());
580 }
else if (QT->isArrayType()) {
581 for (
const auto &CStr : HNOption.
CString) {
582 const std::string Key = CStr.getKey().str();
583 if (ModifiedTypeName.find(Key) == 0) {
584 PrefixStr = CStr.getValue();
588 if (PrefixStr.empty())
590 }
else if (QT->isReferenceType()) {
591 const size_t Pos = ModifiedTypeName.find_last_of(
'&');
592 if (Pos != std::string::npos)
593 ModifiedTypeName = ModifiedTypeName.substr(0, Pos);
600 ModifiedTypeName = [&](std::string Str, StringRef From, StringRef To) {
602 while ((StartPos = Str.find(From, StartPos)) != std::string::npos) {
603 Str.replace(StartPos, From.size(), To);
604 StartPos += To.size();
607 }(ModifiedTypeName,
"*",
"");
611 if (PrefixStr.empty()) {
613 if (ModifiedTypeName == Type.getKey()) {
614 PrefixStr = Type.getValue();
621 if (PrefixStr.empty()) {
623 if (ModifiedTypeName == Type.getKey()) {
624 PrefixStr = Type.getValue();
630 for (
size_t Idx = 0; Idx < PtrCount; Idx++)
631 PrefixStr.insert(0, HNOption.
DerivedType.lookup(
"Pointer"));
637 const CXXRecordDecl *CRD,
642 if (CRD->isStruct() &&
646 return CRD->isAbstract() ?
"I" :
"C";
650 const EnumConstantDecl *ECD)
const {
651 const auto *ED = cast<EnumDecl>(ECD->getDeclContext());
653 std::string Name = ED->getName().str();
654 if (StringRef(Name).contains(
"enum")) {
655 Name = Name.substr(strlen(
"enum"), Name.length() - strlen(
"enum"));
656 Name = Name.erase(0, Name.find_first_not_of(
' '));
659 static const llvm::Regex Splitter(
660 "([a-z0-9A-Z]*)(_+)|([A-Z]?[a-z0-9]+)([A-Z]|$)|([A-Z]+)([A-Z]|$)");
662 const StringRef EnumName(Name);
664 EnumName.split(Substrs,
"_", -1,
false);
668 for (
auto Substr : Substrs) {
669 while (!Substr.empty()) {
671 if (!Splitter.match(Substr, &Groups))
674 if (!Groups[2].empty()) {
675 Words.push_back(Groups[1]);
676 Substr = Substr.substr(Groups[0].size());
677 }
else if (!Groups[3].empty()) {
678 Words.push_back(Groups[3]);
679 Substr = Substr.substr(Groups[0].size() - Groups[4].size());
680 }
else if (!Groups[5].empty()) {
681 Words.push_back(Groups[5]);
682 Substr = Substr.substr(Groups[0].size() - Groups[6].size());
688 for (
const StringRef Word : Words)
689 Initial += tolower(Word[0]);
695 const std::string &TypeName)
const {
696 size_t Pos = TypeName.find(
'*');
698 for (; Pos < TypeName.length(); Pos++, Count++)
699 if (
'*' != TypeName[Pos])
705 const std::string &TypeName,
const NamedDecl *ND)
const {
707 if (
const auto *TD = dyn_cast<ValueDecl>(ND)) {
708 const QualType QT = TD->getType();
709 if (QT->isPointerType())
718 static constexpr std::pair<StringRef, StringRef> General[] = {
719 {
"TreatStructAsClass",
"false"}};
720 for (
const auto &G : General)
721 HNOption.
General.try_emplace(G.first, G.second);
724 static constexpr std::pair<StringRef, StringRef> DerivedTypes[] = {
725 {
"Array",
"a"}, {
"Pointer",
"p"}, {
"FunctionPointer",
"fn"}};
726 for (
const auto &DT : DerivedTypes)
727 HNOption.
DerivedType.try_emplace(DT.first, DT.second);
730 static constexpr std::pair<StringRef, StringRef> CStrings[] = {
734 {
"wchar_t[]",
"wsz"}};
735 for (
const auto &CStr : CStrings)
736 HNOption.
CString.try_emplace(CStr.first, CStr.second);
739 static constexpr std::pair<StringRef, StringRef> PrimitiveTypes[] = {
745 {
"uint16_t",
"u16" },
746 {
"uint32_t",
"u32" },
747 {
"uint64_t",
"u64" },
749 {
"char16_t",
"c16" },
750 {
"char32_t",
"c32" },
759 {
"short int",
"si" },
761 {
"signed int",
"si" },
762 {
"signed short",
"ss" },
763 {
"signed short int",
"ssi" },
764 {
"signed long long int",
"slli"},
765 {
"signed long long",
"sll" },
766 {
"signed long int",
"sli" },
767 {
"signed long",
"sl" },
769 {
"unsigned long long int",
"ulli"},
770 {
"unsigned long long",
"ull" },
771 {
"unsigned long int",
"uli" },
772 {
"unsigned long",
"ul" },
773 {
"unsigned short int",
"usi" },
774 {
"unsigned short",
"us" },
775 {
"unsigned int",
"ui" },
776 {
"unsigned char",
"uc" },
778 {
"long long int",
"lli" },
779 {
"long double",
"ld" },
780 {
"long long",
"ll" },
786 for (
const auto &PT : PrimitiveTypes)
790 static constexpr std::pair<StringRef, StringRef> UserDefinedTypes[] = {
807 {
"ULONGLONG",
"ull" },
821 for (
const auto &UDT : UserDefinedTypes)
827 SmallString<64> StyleString;
828 const ArrayRef<std::optional<NamingStyle>> Styles =
829 MainFileStyle->getStyles();
830 for (
size_t I = 0; I <
SK_Count; ++I) {
831 const auto &StyleOpt = Styles[I];
835 const size_t StyleSize =
StyleNames[I].size();
836 StyleString.assign({
StyleNames[I],
"HungarianPrefix"});
838 Options.store(Opts, StyleString, Style.HPType);
840 memcpy(&StyleString[StyleSize],
"IgnoredRegexp", 13);
841 StyleString.truncate(StyleSize + 13);
842 Options.store(Opts, StyleString, Style.IgnoredRegexpStr);
843 memcpy(&StyleString[StyleSize],
"Prefix", 6);
844 StyleString.truncate(StyleSize + 6);
845 Options.store(Opts, StyleString, Style.Prefix);
847 memcpy(&StyleString[StyleSize],
"Suf", 3);
848 Options.store(Opts, StyleString, Style.Suffix);
850 memcpy(&StyleString[StyleSize],
"Case", 4);
851 StyleString.pop_back_n(2);
852 Options.store(Opts, StyleString, *Style.Case);
855 Options.store(Opts,
"GetConfigPerFile", GetConfigPerFile);
856 Options.store(Opts,
"IgnoreFailedSplit", IgnoreFailedSplit);
857 Options.store(Opts,
"IgnoreMainLikeFunctions",
858 MainFileStyle->isIgnoringMainLikeFunction());
859 Options.store(Opts,
"CheckAnonFieldInParent",
860 MainFileStyle->isCheckingAnonFieldInParentScope());
864 StringRef Type, StringRef Name,
867 const NamedDecl *Decl)
const {
868 static const llvm::Regex Matchers[] = {
870 llvm::Regex(
"^[a-z][a-z0-9_]*$"),
871 llvm::Regex(
"^[a-z][a-zA-Z0-9]*$"),
872 llvm::Regex(
"^[A-Z][A-Z0-9_]*$"),
873 llvm::Regex(
"^[A-Z][a-zA-Z0-9]*$"),
874 llvm::Regex(
"^[A-Z]+([a-z0-9]*_[A-Z0-9]+)*[a-z0-9]*$"),
875 llvm::Regex(
"^[a-z]+([a-z0-9]*_[A-Z0-9]+)*[a-z0-9]*$"),
876 llvm::Regex(
"^[A-Z]([a-z0-9_]*[a-z])*$"),
879 if (!Name.consume_front(Style.Prefix))
881 if (!Name.consume_back(Style.Suffix))
885 if (!HNPrefix.empty()) {
886 if (!Name.consume_front(HNPrefix))
890 !Name.consume_front(
"_"))
897 if (Name.starts_with(
'_') || Name.ends_with(
'_'))
900 if (Style.Case && !Matchers[
static_cast<size_t>(*Style.Case)].match(Name))
907 StringRef Type, StringRef Name,
const Decl *D,
911 static const llvm::Regex Splitter(
912 "([a-z0-9A-Z]*)(_+)|([A-Z]?[a-z0-9]+)([A-Z]|$)|([A-Z]+)([A-Z]|$)");
915 Name.split(Substrs,
"_", -1,
false);
919 for (
auto Substr : Substrs) {
920 while (!Substr.empty()) {
922 if (!Splitter.match(Substr, &Groups))
925 if (!Groups[2].empty()) {
926 Words.push_back(Groups[1]);
927 Substr = Substr.substr(Groups[0].size());
928 }
else if (!Groups[3].empty()) {
929 Words.push_back(Groups[3]);
930 Substr = Substr.substr(Groups[0].size() - Groups[4].size());
931 }
else if (!Groups[5].empty()) {
932 Words.push_back(Groups[5]);
933 Substr = Substr.substr(Groups[0].size() - Groups[6].size());
944 SmallString<128> Fixup;
951 for (
const auto &Word : Words) {
952 if (&Word != &Words.front())
954 Fixup += Word.lower();
959 for (
const auto &Word : Words) {
960 if (&Word != &Words.front())
962 Fixup += Word.upper();
967 for (
const auto &Word : Words) {
968 Fixup += toupper(Word.front());
969 Fixup += Word.substr(1).lower();
974 for (
const auto &Word : Words) {
975 if (&Word == &Words.front()) {
976 Fixup += Word.lower();
978 Fixup += toupper(Word.front());
979 Fixup += Word.substr(1).lower();
985 for (
const auto &Word : Words) {
986 if (&Word != &Words.front())
988 Fixup += toupper(Word.front());
989 Fixup += Word.substr(1).lower();
994 for (
const auto &Word : Words) {
995 if (&Word != &Words.front()) {
997 Fixup += toupper(Word.front());
999 Fixup += tolower(Word.front());
1001 Fixup += Word.substr(1).lower();
1006 for (
const auto &Word : Words) {
1007 if (&Word != &Words.front()) {
1009 Fixup += Word.lower();
1011 Fixup += toupper(Word.front());
1012 Fixup += Word.substr(1).lower();
1018 return Fixup.str().str();
1022 const ParmVarDecl &ParmDecl,
bool IncludeMainLike)
const {
1024 dyn_cast_or_null<FunctionDecl>(ParmDecl.getParentFunctionOrMethod());
1027 if (FDecl->isMain())
1029 if (!IncludeMainLike)
1031 if (FDecl->getAccess() != AS_public && FDecl->getAccess() != AS_none)
1035 if (!FDecl->getDeclName().isIdentifier())
1037 enum MainType { None, Main, WMain };
1038 auto IsCharPtrPtr = [](QualType QType) -> MainType {
1041 if (QType = QType->getPointeeType(), QType.isNull())
1043 if (QType = QType->getPointeeType(), QType.isNull())
1045 if (QType->isCharType())
1047 if (QType->isWideCharType())
1051 auto IsIntType = [](QualType QType) {
1054 if (
const auto *Builtin =
1055 dyn_cast<BuiltinType>(QType->getUnqualifiedDesugaredType())) {
1056 return Builtin->getKind() == BuiltinType::Int;
1060 if (!IsIntType(FDecl->getReturnType()))
1062 if (FDecl->getNumParams() < 2 || FDecl->getNumParams() > 3)
1064 if (!IsIntType(FDecl->parameters()[0]->getType()))
1066 const MainType Type = IsCharPtrPtr(FDecl->parameters()[1]->getType());
1069 if (FDecl->getNumParams() == 3 &&
1070 IsCharPtrPtr(FDecl->parameters()[2]->getType()) != Type)
1074 static const llvm::Regex Matcher(
1075 "(^[Mm]ain([_A-Z]|$))|([a-z0-9_]Main([_A-Z]|$))|(_main(_|$))");
1076 assert(Matcher.isValid() &&
"Invalid Matcher for main like functions.");
1077 return Matcher.match(FDecl->getName());
1079 static const llvm::Regex Matcher(
1080 "(^((W[Mm])|(wm))ain([_A-Z]|$))|([a-z0-9_]W[Mm]"
1081 "ain([_A-Z]|$))|(_wmain(_|$))");
1082 assert(Matcher.isValid() &&
"Invalid Matcher for wmain like functions.");
1083 return Matcher.match(FDecl->getName());
1087 StringRef Type, StringRef Name,
1090 const Decl *D)
const {
1091 Name.consume_front(Style.Prefix);
1092 Name.consume_back(Style.Suffix);
1094 Type, Name, D, Style, HNOption,
1097 std::string HungarianPrefix;
1101 if (!HungarianPrefix.empty()) {
1103 HungarianPrefix +=
'_';
1106 Fixed[0] = toupper(Fixed[0]);
1109 StringRef Mid = StringRef(Fixed).trim(
"_");
1113 return (Style.Prefix + HungarianPrefix + Mid + Style.Suffix).str();
1118 ArrayRef<std::optional<IdentifierNamingCheck::NamingStyle>> NamingStyles,
1119 bool IgnoreMainLikeFunctions,
bool CheckAnonFieldInParentScope)
const {
1120 assert(D && D->getIdentifier() && !D->getName().empty() && !D->isImplicit() &&
1121 "Decl must be an explicit identifier with a name.");
1123 if (isa<ObjCIvarDecl>(D) && NamingStyles[SK_ObjcIvar])
1126 if (isa<TypedefDecl>(D) && NamingStyles[SK_Typedef])
1129 if (isa<TypeAliasDecl>(D) && NamingStyles[SK_TypeAlias])
1130 return SK_TypeAlias;
1132 if (isa<NamespaceAliasDecl>(D) && NamingStyles[SK_Namespace])
1133 return SK_Namespace;
1135 if (
const auto *Decl = dyn_cast<NamespaceDecl>(D)) {
1136 if (Decl->isAnonymousNamespace())
1139 if (Decl->isInline() && NamingStyles[SK_InlineNamespace])
1140 return SK_InlineNamespace;
1142 if (NamingStyles[SK_Namespace])
1143 return SK_Namespace;
1146 if (isa<EnumDecl>(D) && NamingStyles[SK_Enum])
1149 if (
const auto *EnumConst = dyn_cast<EnumConstantDecl>(D)) {
1150 if (cast<EnumDecl>(EnumConst->getDeclContext())->isScoped() &&
1151 NamingStyles[SK_ScopedEnumConstant])
1152 return SK_ScopedEnumConstant;
1154 if (NamingStyles[SK_EnumConstant])
1155 return SK_EnumConstant;
1157 if (NamingStyles[SK_Constant])
1160 return undefinedStyle(NamingStyles);
1163 if (
const auto *Decl = dyn_cast<RecordDecl>(D)) {
1164 if (Decl->isAnonymousStructOrUnion())
1167 if (
const auto *Definition = Decl->getDefinition()) {
1168 if (
const auto *CxxRecordDecl = dyn_cast<CXXRecordDecl>(Definition)) {
1169 if (CxxRecordDecl->isAbstract() && NamingStyles[SK_AbstractClass])
1170 return SK_AbstractClass;
1173 if (Definition->isStruct() && NamingStyles[SK_Struct])
1176 if (Definition->isStruct() && NamingStyles[SK_Class])
1179 if (Definition->isClass() && NamingStyles[SK_Class])
1182 if (Definition->isClass() && NamingStyles[SK_Struct])
1185 if (Definition->isUnion() && NamingStyles[SK_Union])
1188 if (Definition->isEnum() && NamingStyles[SK_Enum])
1192 return undefinedStyle(NamingStyles);
1195 if (
const auto *Decl = dyn_cast<FieldDecl>(D)) {
1196 if (CheckAnonFieldInParentScope) {
1197 const RecordDecl *Record = Decl->getParent();
1198 if (Record->isAnonymousStructOrUnion())
1199 return findStyleKindForAnonField(Decl, NamingStyles);
1202 return findStyleKindForField(Decl, Decl->getType(), NamingStyles);
1205 if (
const auto *Decl = dyn_cast<ParmVarDecl>(D)) {
1208 const QualType Type = Decl->getType();
1210 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprVariable])
1211 return SK_ConstexprVariable;
1213 if (!Type.isNull() && Type.isConstQualified()) {
1214 if (Type.getTypePtr()->isAnyPointerType() &&
1215 NamingStyles[SK_ConstantPointerParameter])
1216 return SK_ConstantPointerParameter;
1218 if (NamingStyles[SK_ConstantParameter])
1219 return SK_ConstantParameter;
1221 if (NamingStyles[SK_Constant])
1225 if (Decl->isParameterPack() && NamingStyles[SK_ParameterPack])
1226 return SK_ParameterPack;
1228 if (!Type.isNull() && Type.getTypePtr()->isAnyPointerType() &&
1229 NamingStyles[SK_PointerParameter])
1230 return SK_PointerParameter;
1232 if (NamingStyles[SK_Parameter])
1233 return SK_Parameter;
1235 return undefinedStyle(NamingStyles);
1238 if (
const auto *Decl = dyn_cast<VarDecl>(D))
1239 return findStyleKindForVar(Decl, Decl->getType(), NamingStyles);
1241 if (
const auto *Decl = dyn_cast<CXXMethodDecl>(D)) {
1242 if (Decl->isMain() || !Decl->isUserProvided() ||
1243 Decl->size_overridden_methods() > 0 || Decl->hasAttr<OverrideAttr>())
1248 for (
const CXXBaseSpecifier &Base : Decl->getParent()->bases())
1249 if (
const auto *RD = Base.getType()->getAsCXXRecordDecl())
1250 if (RD->hasMemberName(Decl->getDeclName()))
1253 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprMethod])
1254 return SK_ConstexprMethod;
1256 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprFunction])
1257 return SK_ConstexprFunction;
1259 if (Decl->isStatic() && NamingStyles[SK_ClassMethod])
1260 return SK_ClassMethod;
1262 if (Decl->isVirtual() && NamingStyles[SK_VirtualMethod])
1263 return SK_VirtualMethod;
1265 if (Decl->getAccess() == AS_private && NamingStyles[SK_PrivateMethod])
1266 return SK_PrivateMethod;
1268 if (Decl->getAccess() == AS_protected && NamingStyles[SK_ProtectedMethod])
1269 return SK_ProtectedMethod;
1271 if (Decl->getAccess() == AS_public && NamingStyles[SK_PublicMethod])
1272 return SK_PublicMethod;
1274 if (NamingStyles[SK_Method])
1277 if (NamingStyles[SK_Function])
1280 return undefinedStyle(NamingStyles);
1283 if (
const auto *Decl = dyn_cast<FunctionDecl>(D)) {
1287 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprFunction])
1288 return SK_ConstexprFunction;
1290 if (Decl->isGlobal() && NamingStyles[SK_GlobalFunction])
1291 return SK_GlobalFunction;
1293 if (NamingStyles[SK_Function])
1297 if (isa<TemplateTypeParmDecl>(D)) {
1298 if (NamingStyles[SK_TypeTemplateParameter])
1299 return SK_TypeTemplateParameter;
1301 if (NamingStyles[SK_TemplateParameter])
1302 return SK_TemplateParameter;
1304 return undefinedStyle(NamingStyles);
1307 if (isa<NonTypeTemplateParmDecl>(D)) {
1308 if (NamingStyles[SK_ValueTemplateParameter])
1309 return SK_ValueTemplateParameter;
1311 if (NamingStyles[SK_TemplateParameter])
1312 return SK_TemplateParameter;
1314 return undefinedStyle(NamingStyles);
1317 if (isa<TemplateTemplateParmDecl>(D)) {
1318 if (NamingStyles[SK_TemplateTemplateParameter])
1319 return SK_TemplateTemplateParameter;
1321 if (NamingStyles[SK_TemplateParameter])
1322 return SK_TemplateParameter;
1324 return undefinedStyle(NamingStyles);
1327 if (isa<ConceptDecl>(D) && NamingStyles[SK_Concept])
1330 return undefinedStyle(NamingStyles);
1333std::optional<RenamerClangTidyCheck::FailureInfo>
1335 StringRef Type, StringRef Name,
const NamedDecl *ND,
1337 ArrayRef<std::optional<IdentifierNamingCheck::NamingStyle>> NamingStyles,
1339 StyleKind SK,
const SourceManager &SM,
bool IgnoreFailedSplit)
const {
1341 return std::nullopt;
1343 const auto &StyleOpt = NamingStyles[SK];
1345 return std::nullopt;
1348 if (Style.IgnoredRegexp.isValid() && Style.IgnoredRegexp.match(Name))
1349 return std::nullopt;
1352 return std::nullopt;
1354 std::string KindName =
1359 llvm::replace(KindName,
'_',
' ');
1361 std::string Fixup =
fixupWithStyle(Type, Name, Style, HNOption, ND);
1362 if (StringRef(Fixup) == Name) {
1363 if (!IgnoreFailedSplit) {
1364 LLVM_DEBUG(
Location.print(llvm::dbgs(), SM);
1365 llvm::dbgs() <<
": unable to split words for " << KindName
1366 <<
" '" << Name <<
"'\n");
1368 return std::nullopt;
1374std::optional<RenamerClangTidyCheck::FailureInfo>
1375IdentifierNamingCheck::getDeclFailureInfo(
const NamedDecl *Decl,
1376 const SourceManager &SM)
const {
1378 if (Decl->isImplicit())
1379 return std::nullopt;
1381 const SourceLocation Loc = Decl->getLocation();
1382 const FileStyle &FileStyle = getStyleForFile(SM.getFilename(Loc));
1383 if (!FileStyle.isActive())
1384 return std::nullopt;
1388 FileStyle.getStyles(), FileStyle.getHNOption(),
1390 FileStyle.isIgnoringMainLikeFunction(),
1391 FileStyle.isCheckingAnonFieldInParentScope()),
1392 SM, IgnoreFailedSplit);
1395std::optional<RenamerClangTidyCheck::FailureInfo>
1396IdentifierNamingCheck::getMacroFailureInfo(
const Token &MacroNameTok,
1397 const SourceManager &SM)
const {
1398 const SourceLocation Loc = MacroNameTok.getLocation();
1399 const FileStyle &Style = getStyleForFile(SM.getFilename(Loc));
1400 if (!Style.isActive())
1401 return std::nullopt;
1403 const auto &Styles = Style.getStyles();
1404 const StyleKind UsedKind = !Styles[SK_MacroDefinition] && Styles[SK_Default]
1406 : SK_MacroDefinition;
1408 return getFailureInfo(
"", MacroNameTok.getIdentifierInfo()->getName(),
1409 nullptr, Loc, Style.getStyles(), Style.getHNOption(),
1410 UsedKind, SM, IgnoreFailedSplit);
1413RenamerClangTidyCheck::DiagInfo
1415 const NamingCheckFailure &Failure)
const {
1416 return DiagInfo{
"invalid case style for %0 '%1'",
1417 [&](DiagnosticBuilder &Diag) {
1418 Diag << Failure.Info.KindName << ID.second;
1422StringRef IdentifierNamingCheck::getRealFileName(StringRef FileName)
const {
1423 auto Iter = RealFileNameCache.try_emplace(FileName);
1424 SmallString<256U> &RealFileName = Iter.first->getValue();
1426 return RealFileName;
1427 llvm::sys::fs::real_path(FileName, RealFileName);
1428 return RealFileName;
1431const IdentifierNamingCheck::FileStyle &
1432IdentifierNamingCheck::getStyleForFile(StringRef FileName)
const {
1433 if (!GetConfigPerFile)
1434 return *MainFileStyle;
1436 const StringRef RealFileName = getRealFileName(FileName);
1437 const StringRef Parent = llvm::sys::path::parent_path(RealFileName);
1438 auto Iter = NamingStylesCache.find(Parent);
1439 if (Iter != NamingStylesCache.end())
1440 return Iter->getValue();
1442 const StringRef CheckName = getID();
1443 ClangTidyOptions Options = Context->getOptionsForFile(RealFileName);
1444 if (Options.
Checks && GlobList(*Options.
Checks).contains(CheckName)) {
1445 auto It = NamingStylesCache.try_emplace(
1449 return It.first->getValue();
1452 auto It = NamingStylesCache.try_emplace(Parent);
1454 return It.first->getValue();
1457StyleKind IdentifierNamingCheck::findStyleKindForAnonField(
1458 const FieldDecl *AnonField,
1459 ArrayRef<std::optional<NamingStyle>> NamingStyles)
const {
1460 const IndirectFieldDecl *IFD =
1462 assert(IFD &&
"Found an anonymous record field without an IndirectFieldDecl");
1464 const QualType
Type = AnonField->getType();
1466 if (
const auto *F = dyn_cast<FieldDecl>(IFD->chain().front()))
1467 return findStyleKindForField(F, Type, NamingStyles);
1469 if (
const auto *V = IFD->getVarDecl())
1470 return findStyleKindForVar(V, Type, NamingStyles);
1472 return undefinedStyle(NamingStyles);
1475StyleKind IdentifierNamingCheck::findStyleKindForField(
1476 const FieldDecl *Field, QualType Type,
1477 ArrayRef<std::optional<NamingStyle>> NamingStyles)
const {
1478 if (!
Type.isNull() &&
Type.isConstQualified()) {
1479 if (NamingStyles[SK_ConstantMember])
1480 return SK_ConstantMember;
1482 if (NamingStyles[SK_Constant])
1486 if (
Field->getAccess() == AS_private && NamingStyles[SK_PrivateMember])
1487 return SK_PrivateMember;
1489 if (
Field->getAccess() == AS_protected && NamingStyles[SK_ProtectedMember])
1490 return SK_ProtectedMember;
1492 if (
Field->getAccess() == AS_public && NamingStyles[SK_PublicMember])
1493 return SK_PublicMember;
1495 if (NamingStyles[SK_Member])
1498 return undefinedStyle(NamingStyles);
1501StyleKind IdentifierNamingCheck::findStyleKindForVar(
1502 const VarDecl *Var, QualType Type,
1503 ArrayRef<std::optional<NamingStyle>> NamingStyles)
const {
1504 if (Var->isConstexpr()) {
1505 if (Var->isStaticDataMember() && NamingStyles[SK_ClassConstexpr])
1506 return SK_ClassConstexpr;
1508 if (Var->isFileVarDecl() && NamingStyles[SK_GlobalConstexprVariable])
1509 return SK_GlobalConstexprVariable;
1511 if (Var->isStaticLocal() && NamingStyles[SK_StaticConstexprVariable])
1512 return SK_StaticConstexprVariable;
1514 if (Var->isLocalVarDecl() && NamingStyles[SK_LocalConstexprVariable])
1515 return SK_LocalConstexprVariable;
1517 if (NamingStyles[SK_ConstexprVariable])
1518 return SK_ConstexprVariable;
1521 if (!
Type.isNull() &&
Type.isConstQualified()) {
1522 if (Var->isStaticDataMember() && NamingStyles[SK_ClassConstant])
1523 return SK_ClassConstant;
1525 if (Var->isFileVarDecl() &&
Type.getTypePtr()->isAnyPointerType() &&
1526 NamingStyles[SK_GlobalConstantPointer])
1527 return SK_GlobalConstantPointer;
1529 if (Var->isFileVarDecl() && NamingStyles[SK_GlobalConstant])
1530 return SK_GlobalConstant;
1532 if (Var->isStaticLocal() && NamingStyles[SK_StaticConstant])
1533 return SK_StaticConstant;
1535 if (Var->isLocalVarDecl() &&
Type.getTypePtr()->isAnyPointerType() &&
1536 NamingStyles[SK_LocalConstantPointer])
1537 return SK_LocalConstantPointer;
1539 if (Var->isLocalVarDecl() && NamingStyles[SK_LocalConstant])
1540 return SK_LocalConstant;
1542 if (Var->isFunctionOrMethodVarDecl() && NamingStyles[SK_LocalConstant])
1543 return SK_LocalConstant;
1545 if (NamingStyles[SK_Constant])
1549 if (Var->isStaticDataMember() && NamingStyles[SK_ClassMember])
1550 return SK_ClassMember;
1552 if (Var->isFileVarDecl() &&
Type.getTypePtr()->isAnyPointerType() &&
1553 NamingStyles[SK_GlobalPointer])
1554 return SK_GlobalPointer;
1556 if (Var->isFileVarDecl() && NamingStyles[SK_GlobalVariable])
1557 return SK_GlobalVariable;
1559 if (Var->isStaticLocal() && NamingStyles[SK_StaticVariable])
1560 return SK_StaticVariable;
1562 if (Var->isLocalVarDecl() &&
Type.getTypePtr()->isAnyPointerType() &&
1563 NamingStyles[SK_LocalPointer])
1564 return SK_LocalPointer;
1566 if (Var->isLocalVarDecl() && NamingStyles[SK_LocalVariable])
1567 return SK_LocalVariable;
1569 if (Var->isFunctionOrMethodVarDecl() && NamingStyles[SK_LocalVariable])
1570 return SK_LocalVariable;
1572 if (NamingStyles[SK_Variable])
1575 return undefinedStyle(NamingStyles);
1578StyleKind IdentifierNamingCheck::undefinedStyle(
1579 ArrayRef<std::optional<NamingStyle>> NamingStyles)
const {
1580 return NamingStyles[SK_Default] ? SK_Default :
SK_Invalid;
#define HUNGARIAN_NOTATION_PRIMITIVE_TYPES(m)
#define HUNGARIAN_NOTATION_USER_DEFINED_TYPES(m)
Every ClangTidyCheck reports errors through a DiagnosticsEngine provided by this context.
std::pair< SourceLocation, StringRef > NamingCheckId
RenamerClangTidyCheck(StringRef CheckName, ClangTidyContext *Context)
void storeOptions(ClangTidyOptions::OptionMap &Opts) override
Derived classes that override this function should call this method from the overridden method.
IdentifierNamingCheck(StringRef Name, ClangTidyContext *Context)
std::string fixupWithCase(StringRef Type, StringRef Name, const Decl *D, const IdentifierNamingCheck::NamingStyle &Style, const IdentifierNamingCheck::HungarianNotationOption &HNOption, IdentifierNamingCheck::CaseType Case) const
std::optional< RenamerClangTidyCheck::FailureInfo > getFailureInfo(StringRef Type, StringRef Name, const NamedDecl *ND, SourceLocation Location, ArrayRef< std::optional< IdentifierNamingCheck::NamingStyle > > NamingStyles, const IdentifierNamingCheck::HungarianNotationOption &HNOption, StyleKind SK, const SourceManager &SM, bool IgnoreFailedSplit) const
~IdentifierNamingCheck() override
std::string fixupWithStyle(StringRef Type, StringRef Name, const IdentifierNamingCheck::NamingStyle &Style, const IdentifierNamingCheck::HungarianNotationOption &HNOption, const Decl *D) const
IdentifierNamingCheck::FileStyle getFileStyleFromOptions(const ClangTidyCheck::OptionsView &Options) const
bool isParamInMainLikeFunction(const ParmVarDecl &ParmDecl, bool IncludeMainLike) const
bool matchesStyle(StringRef Type, StringRef Name, const IdentifierNamingCheck::NamingStyle &Style, const IdentifierNamingCheck::HungarianNotationOption &HNOption, const NamedDecl *Decl) const
StyleKind findStyleKind(const NamedDecl *D, ArrayRef< std::optional< IdentifierNamingCheck::NamingStyle > > NamingStyles, bool IgnoreMainLikeFunctions, bool CheckAnonFieldInParentScope) const
@ CT_LeadingUpperSnakeCase
void storeOptions(ClangTidyOptions::OptionMap &Opts) override
@ Type
An inlay hint that for a type annotation.
static StringRef const HungarianNotationPrimitiveTypes[]
static StringRef const HungarianNotationUserDefinedTypes[]
static StringRef const StyleNames[]
const IndirectFieldDecl * findOutermostIndirectFieldDeclForField(const FieldDecl *FD)
OptionMap CheckOptions
Key-value mapping used to store check-specific options.
std::optional< std::string > Checks
Checks filter.
llvm::StringMap< ClangTidyValue > OptionMap
static llvm::ArrayRef< std::pair< readability::IdentifierNamingCheck::CaseType, StringRef > > getEnumMapping()
static llvm::ArrayRef< std::pair< HungarianPrefixType, StringRef > > getEnumMapping()
readability::IdentifierNamingCheck::HungarianPrefixType HungarianPrefixType
This class should be specialized by any enum type that needs to be converted to and from an llvm::Str...
Information describing a failed check.
llvm::StringMap< std::string > UserDefinedType
llvm::StringMap< std::string > DerivedType
llvm::StringMap< std::string > CString
llvm::StringMap< std::string > General
llvm::StringMap< std::string > PrimitiveType
std::string getDeclTypeName(const NamedDecl *ND) const
bool isOptionEnabled(StringRef OptionKey, const llvm::StringMap< std::string > &StrMap) const
StringRef getClassPrefix(const CXXRecordDecl *CRD, const IdentifierNamingCheck::HungarianNotationOption &HNOption) const
bool removeDuplicatedPrefix(SmallVector< StringRef, 8 > &Words, const IdentifierNamingCheck::HungarianNotationOption &HNOption) const
void loadFileConfig(const ClangTidyCheck::OptionsView &Options, IdentifierNamingCheck::HungarianNotationOption &HNOption) const
void loadDefaultConfig(IdentifierNamingCheck::HungarianNotationOption &HNOption) const
std::string getEnumPrefix(const EnumConstantDecl *ECD) const
bool checkOptionValid(int StyleKindIndex) const
std::string getPrefix(const Decl *D, const IdentifierNamingCheck::HungarianNotationOption &HNOption) const
size_t getAsteriskCount(const std::string &TypeName) const
std::string getDataTypePrefix(StringRef TypeName, const NamedDecl *ND, const IdentifierNamingCheck::HungarianNotationOption &HNOption) const