74 const auto *ParentDecl = Result.Nodes.getNodeAs<Decl>(
ParentDeclName);
77 const auto *ParentDeclStmt = Result.Nodes.getNodeAs<DeclStmt>(
DeclStmtName);
79 if (ParentDeclStmt->isSingleDecl())
80 ParentDecl = ParentDeclStmt->getSingleDecl();
83 ParentDeclStmt->getDeclGroup().getDeclGroup()
84 [ParentDeclStmt->getDeclGroup().getDeclGroup().size() - 1];
91 const SourceManager &SM = *Result.SourceManager;
92 const LangOptions &LO = getLangOpts();
96 const auto *MatchedTagDecl = Result.Nodes.getNodeAs<TagDecl>(
TagDeclName);
103 if (MatchedTagDecl->isThisDeclarationADefinition())
104 LastTagDeclRanges[ParentDecl] = MatchedTagDecl->getSourceRange();
108 const auto *MatchedDecl = Result.Nodes.getNodeAs<TypedefDecl>(
TypedefName);
109 if (MatchedDecl->getLocation().isInvalid())
112 const auto *ExternCDecl =
114 if (ExternCDecl && IgnoreExternC)
117 const SourceLocation StartLoc = MatchedDecl->getBeginLoc();
119 if (StartLoc.isMacroID() && IgnoreMacros)
122 static constexpr StringRef UseUsingWarning =
123 "use 'using' instead of 'typedef'";
126 if (MatchedDecl->getUnderlyingType()->isArrayType() || StartLoc.isMacroID()) {
127 diag(StartLoc, UseUsingWarning);
131 const TypeLoc TL = MatchedDecl->getTypeSourceInfo()->getTypeLoc();
133 bool FunctionPointerCase =
false;
134 auto [Type, QualifierStr] = [MatchedDecl,
this, &TL, &FunctionPointerCase,
136 &LO]() -> std::pair<std::string, std::string> {
137 SourceRange TypeRange = TL.getSourceRange();
141 if (TypeRange.fullyContains(MatchedDecl->getLocation())) {
142 FunctionPointerCase =
true;
143 SourceLocation StartLoc = MatchedDecl->getLocation();
144 SourceLocation EndLoc = MatchedDecl->getLocation();
147 const std::optional<Token> Prev =
149 const std::optional<Token> Next =
151 if (!Prev || Prev->isNot(tok::l_paren) || !Next ||
152 Next->isNot(tok::r_paren))
155 StartLoc = Prev->getLocation();
156 EndLoc = Next->getLocation();
159 const auto RangeLeftOfIdentifier =
160 CharSourceRange::getCharRange(TypeRange.getBegin(), StartLoc);
161 const auto RangeRightOfIdentifier = CharSourceRange::getCharRange(
162 Lexer::getLocForEndOfToken(EndLoc, 0, SM, LO),
163 Lexer::getLocForEndOfToken(TypeRange.getEnd(), 0, SM, LO));
164 const std::string VerbatimType =
165 (Lexer::getSourceText(RangeLeftOfIdentifier, SM, LO) +
166 Lexer::getSourceText(RangeRightOfIdentifier, SM, LO))
168 return {VerbatimType,
""};
171 StringRef ExtraReference =
"";
172 if (MainTypeEndLoc.isValid() && TypeRange.fullyContains(MainTypeEndLoc)) {
177 MatchedDecl->getLocation(), SM, LO, tok::TokenKind::star,
178 tok::TokenKind::amp, tok::TokenKind::comma,
179 tok::TokenKind::kw_typedef);
181 ExtraReference = Lexer::getSourceText(
182 CharSourceRange::getCharRange(Tok, Tok.getLocWithOffset(1)), SM, LO);
184 if (ExtraReference !=
"*" && ExtraReference !=
"&")
187 TypeRange.setEnd(MainTypeEndLoc);
190 Lexer::getSourceText(CharSourceRange::getTokenRange(TypeRange), SM, LO)
192 ExtraReference.str()};
194 const StringRef Name = MatchedDecl->getName();
195 SourceRange ReplaceRange = MatchedDecl->getSourceRange();
203 std::string Using =
"using ";
204 if (ReplaceRange.getBegin().isMacroID() ||
205 (Result.SourceManager->getFileID(ReplaceRange.getBegin()) !=
206 Result.SourceManager->getFileID(LastReplacementEnd)) ||
207 (ReplaceRange.getBegin() >= LastReplacementEnd)) {
210 FirstTypedefType = Type;
211 FirstTypedefName = Name.str();
212 MainTypeEndLoc = TL.getEndLoc();
216 ReplaceRange.setBegin(LastReplacementEnd);
222 if (Type == FirstTypedefType && !QualifierStr.empty())
223 Type = FirstTypedefName;
226 if (!ReplaceRange.getEnd().isMacroID()) {
227 const SourceLocation::IntTy Offset = FunctionPointerCase ? 0 : Name.size();
228 LastReplacementEnd = ReplaceRange.getEnd().getLocWithOffset(Offset);
231 auto Diag = diag(ReplaceRange.getBegin(), UseUsingWarning);
234 auto LastTagDeclRange = LastTagDeclRanges.find(ParentDecl);
235 if (LastTagDeclRange != LastTagDeclRanges.end() &&
236 LastTagDeclRange->second.isValid() &&
237 ReplaceRange.fullyContains(LastTagDeclRange->second)) {
238 Type = std::string(Lexer::getSourceText(
239 CharSourceRange::getTokenRange(LastTagDeclRange->second), SM, LO));
244 const std::string Replacement =
245 (Using + Name +
" = " + Type + QualifierStr).str();
246 Diag << FixItHint::CreateReplacement(ReplaceRange, Replacement);