10 #include "clang/AST/ASTContext.h"
11 #include "clang/ASTMatchers/ASTMatchFinder.h"
22 HeaderFileExtensions) {
24 Node.getBeginLoc(), Finder->getASTContext().getSourceManager(),
25 HeaderFileExtensions);
30 DefinitionsInHeadersCheck::DefinitionsInHeadersCheck(StringRef
Name,
33 UseHeaderFileExtension(Options.get(
"UseHeaderFileExtension", true)),
34 RawStringHeaderFileExtensions(Options.getLocalOrGlobal(
40 << RawStringHeaderFileExtensions;
46 Options.
store(Opts,
"UseHeaderFileExtension", UseHeaderFileExtension);
47 Options.
store(Opts,
"HeaderFileExtensions", RawStringHeaderFileExtensions);
51 auto DefinitionMatcher =
52 anyOf(functionDecl(isDefinition(), unless(isDeleted())),
53 varDecl(isDefinition()));
54 if (UseHeaderFileExtension) {
55 Finder->addMatcher(namedDecl(DefinitionMatcher,
56 usesHeaderFileExtension(HeaderFileExtensions))
61 namedDecl(DefinitionMatcher,
62 anyOf(usesHeaderFileExtension(HeaderFileExtensions),
63 unless(isExpansionInMainFile())))
71 if (Result.Context->getDiagnostics().hasUncompilableErrorOccurred())
82 const auto *ND = Result.Nodes.getNodeAs<NamedDecl>(
"name-decl");
84 if (ND->isInvalidDecl())
96 if (!ND->hasExternalFormalLinkage() && !ND->isInAnonymousNamespace())
99 if (
const auto *FD = dyn_cast<FunctionDecl>(ND)) {
104 if (FD->getTemplatedKind() == FunctionDecl::TK_FunctionTemplate)
107 if (FD->isTemplateInstantiation())
111 if (
const auto *
MD = dyn_cast<CXXMethodDecl>(FD)) {
112 const auto *DC =
MD->getDeclContext();
113 while (DC->isRecord()) {
114 if (
const auto *RD = dyn_cast<CXXRecordDecl>(DC)) {
115 if (isa<ClassTemplatePartialSpecializationDecl>(RD))
117 if (RD->getDescribedClassTemplate())
120 DC = DC->getParent();
124 bool IsFullSpec = FD->getTemplateSpecializationKind() != TSK_Undeclared;
125 diag(FD->getLocation(),
126 "%select{function|full function template specialization}0 %1 defined "
127 "in a header file; function definitions in header files can lead to "
133 diag(FD->getLocation(),
"make as 'inline'",
135 << FixItHint::CreateInsertion(FD->getInnerLocStart(),
"inline ");
136 }
else if (
const auto *VD = dyn_cast<VarDecl>(ND)) {
138 if (VD->getDescribedVarTemplate())
141 if (VD->getDeclContext()->isDependentContext() && VD->isStaticDataMember())
144 if (isTemplateInstantiation(VD->getTemplateSpecializationKind()))
147 if (VD->hasLocalStorage() || VD->isStaticLocal())
153 if (isa<VarTemplatePartialSpecializationDecl>(VD))
156 diag(VD->getLocation(),
157 "variable %0 defined in a header file; "
158 "variable definitions in header files can lead to ODR violations")