10 #include "../utils/Matchers.h"
11 #include "../utils/OptionsUtils.h"
12 #include "clang/ASTMatchers/ASTMatchers.h"
19 namespace readability {
22 "::std::basic_string_view;::std::basic_string";
25 std::vector<StringRef> Result;
26 Result.reserve(Names.size());
27 for (StringRef
Name : Names) {
28 StringRef::size_type ColonPos =
Name.rfind(
':');
30 Name.drop_front(ColonPos == StringRef::npos ? 0 : ColonPos + 1));
35 static const CXXConstructExpr *
37 const Expr *InitExpr = CtorInit.getInit();
38 if (
const auto *CleanUpExpr = dyn_cast<ExprWithCleanups>(InitExpr))
39 InitExpr = CleanUpExpr->getSubExpr();
40 return dyn_cast<CXXConstructExpr>(InitExpr);
43 static llvm::Optional<SourceRange>
46 for (
const Expr *Arg : Construct.arguments()) {
48 B = Arg->getBeginLoc();
49 if (Arg->getEndLoc().isValid())
52 if (
B.isInvalid() ||
E.isInvalid())
54 return SourceRange(
B,
E);
57 RedundantStringInitCheck::RedundantStringInitCheck(StringRef
Name,
68 const auto HasStringTypeName = hasAnyName(StringNames);
72 const auto StringConstructorExpr = expr(
73 anyOf(cxxConstructExpr(argumentCountIs(1),
74 hasDeclaration(cxxMethodDecl(HasStringCtorName))),
77 cxxConstructExpr(argumentCountIs(2),
78 hasDeclaration(cxxMethodDecl(HasStringCtorName)),
79 hasArgument(1, cxxDefaultArgExpr()))));
82 const auto EmptyStringCtorExpr = cxxConstructExpr(
83 StringConstructorExpr,
84 hasArgument(0, ignoringParenImpCasts(stringLiteral(hasSize(0)))));
86 const auto EmptyStringCtorExprWithTemporaries =
87 cxxConstructExpr(StringConstructorExpr,
88 hasArgument(0, ignoringImplicit(EmptyStringCtorExpr)));
90 const auto StringType = hasType(hasUnqualifiedDesugaredType(
91 recordType(hasDeclaration(cxxRecordDecl(HasStringTypeName)))));
92 const auto EmptyStringInit = traverse(
93 TK_AsIs, expr(ignoringImplicit(anyOf(
94 EmptyStringCtorExpr, EmptyStringCtorExprWithTemporaries))));
102 namedDecl(varDecl(StringType, hasInitializer(EmptyStringInit))
104 unless(parmVarDecl()))),
108 namedDecl(fieldDecl(StringType, hasInClassInitializer(EmptyStringInit))
118 forField(allOf(StringType, optionally(hasInClassInitializer(
119 EmptyStringInit.bind(
"empty_init"))))),
120 withInitializer(EmptyStringInit))
126 if (
const auto *VDecl = Result.Nodes.getNodeAs<VarDecl>(
"vardecl")) {
129 SourceRange ReplaceRange(VDecl->getLocation(), VDecl->getEndLoc());
130 diag(VDecl->getLocation(),
"redundant string initialization")
131 << FixItHint::CreateReplacement(ReplaceRange, VDecl->getName());
133 if (
const auto *FDecl = Result.Nodes.getNodeAs<FieldDecl>(
"fieldDecl")) {
136 SourceRange ReplaceRange(FDecl->getLocation(), FDecl->getEndLoc());
137 diag(FDecl->getLocation(),
"redundant string initialization")
138 << FixItHint::CreateReplacement(ReplaceRange, FDecl->getName());
140 if (
const auto *CtorInit =
141 Result.Nodes.getNodeAs<CXXCtorInitializer>(
"ctorInit")) {
142 if (
const FieldDecl *Member = CtorInit->getMember()) {
143 if (!Member->hasInClassInitializer() ||
144 Result.Nodes.getNodeAs<Expr>(
"empty_init")) {
149 diag(CtorInit->getMemberLocation(),
"redundant string initialization")
150 << FixItHint::CreateRemoval(CtorInit->getSourceRange());
157 if (llvm::Optional<SourceRange> RemovalRange =
159 diag(CtorInit->getMemberLocation(),
"redundant string initialization")
160 << FixItHint::CreateRemoval(*RemovalRange);