32 auto RandomGeneratorEngineDecl = cxxRecordDecl(hasAnyName(
33 "::std::linear_congruential_engine",
"::std::mersenne_twister_engine",
34 "::std::subtract_with_carry_engine",
"::std::discard_block_engine",
35 "::std::independent_bits_engine",
"::std::shuffle_order_engine"));
36 auto RandomGeneratorEngineTypeMatcher = hasType(hasUnqualifiedDesugaredType(
37 recordType(hasDeclaration(RandomGeneratorEngineDecl))));
49 has(memberExpr(has(declRefExpr(RandomGeneratorEngineTypeMatcher)),
50 member(hasName(
"seed")),
51 unless(hasDescendant(cxxThisExpr())))))
64 cxxConstructExpr(RandomGeneratorEngineTypeMatcher).bind(
"ctor")),
73 callExpr(callee(functionDecl(hasAnyName(
"::srand",
"::std::srand"))))
79 const MatchFinder::MatchResult &Result) {
80 const auto *Ctor = Result.Nodes.getNodeAs<CXXConstructExpr>(
"ctor");
82 checkSeed(Result, Ctor);
84 const auto *Func = Result.Nodes.getNodeAs<CXXMemberCallExpr>(
"seed");
86 checkSeed(Result, Func);
88 const auto *Srand = Result.Nodes.getNodeAs<CallExpr>(
"srand");
90 checkSeed(Result, Srand);
94void ProperlySeededRandomGeneratorCheck::checkSeed(
95 const MatchFinder::MatchResult &Result,
const T *Func) {
96 if (Func->getNumArgs() == 0 || Func->getArg(0)->isDefaultArgument()) {
97 diag(Func->getExprLoc(),
98 "random number generator seeded with a default argument will generate "
99 "a predictable sequence of values");
103 Expr::EvalResult EVResult;
104 if (Func->getArg(0)->EvaluateAsInt(EVResult, *Result.Context)) {
105 diag(Func->getExprLoc(),
106 "random number generator seeded with a constant value will generate a "
107 "predictable sequence of values");
111 const std::string SeedType(
112 Func->getArg(0)->IgnoreCasts()->getType().getAsString());
113 if (llvm::is_contained(DisallowedSeedTypes, SeedType)) {
114 diag(Func->getExprLoc(),
115 "random number generator seeded with a disallowed source of seed "
116 "value will generate a predictable sequence of values");
Every ClangTidyCheck reports errors through a DiagnosticsEngine provided by this context.