10 #include "clang/AST/ASTContext.h"
11 #include "clang/ASTMatchers/ASTMatchFinder.h"
23 switch (Node.getOverloadedOperator()) {
37 if (Node.isVariadic())
44 return Node.getNumParams() > 1;
45 if (Node.getNumParams() == 1)
52 if (Node.getNumParams() <= 1 || Node.getNumParams() > 2)
55 const auto *FPT = Node.getType()->castAs<FunctionProtoType>();
56 ASTContext &
Ctx = Node.getASTContext();
57 if (
Ctx.getLangOpts().SizedDeallocation &&
58 Ctx.hasSameType(FPT->getParamType(1),
Ctx.getSizeType()))
64 OverloadedOperatorKind getCorrespondingOverload(
const FunctionDecl *FD) {
65 switch (FD->getOverloadedOperator()) {
73 return OO_Array_Delete;
77 llvm_unreachable(
"Not an overloaded allocation operator");
85 return "operator new";
87 return "operator delete";
89 return "operator new[]";
91 return "operator delete[]";
93 llvm_unreachable(
"Not an overloaded allocation operator");
96 bool areCorrespondingOverloads(
const FunctionDecl *LHS,
97 const FunctionDecl *RHS) {
98 return RHS->getOverloadedOperator() == getCorrespondingOverload(LHS);
101 bool hasCorrespondingOverloadInBaseClass(
const CXXMethodDecl *
MD,
102 const CXXRecordDecl *RD =
nullptr) {
105 for (
const auto *BMD : RD->methods())
106 if (BMD->isOverloadedOperator() && BMD->getAccess() != AS_private &&
107 areCorrespondingOverloads(
MD, BMD))
113 RD =
MD->getParent();
116 for (
const auto &BS : RD->bases()) {
119 if (BS.getType()->isDependentType())
121 if (
const auto *BaseRD = BS.getType()->getAsCXXRecordDecl())
122 if (hasCorrespondingOverloadInBaseClass(
MD, BaseRD))
131 void NewDeleteOverloadsCheck::registerMatchers(MatchFinder *Finder) {
141 functionDecl(unless(anyOf(isImplicit(), isPlacementOverload(),
142 isDeleted(), cxxMethodDecl(isPrivate()))),
143 anyOf(hasOverloadedOperatorName(
"new"),
144 hasOverloadedOperatorName(
"new[]"),
145 hasOverloadedOperatorName(
"delete"),
146 hasOverloadedOperatorName(
"delete[]")))
154 const auto *FD = Result.Nodes.getNodeAs<FunctionDecl>(
"func");
155 const CXXRecordDecl *RD =
nullptr;
156 if (
const auto *
MD = dyn_cast<CXXMethodDecl>(FD))
157 RD =
MD->getParent();
158 Overloads[RD].push_back(FD);
161 void NewDeleteOverloadsCheck::onEndOfTranslationUnit() {
166 SmallVector<const FunctionDecl *, 4> Diagnose;
167 for (
const auto &RP : Overloads) {
171 for (
const auto *Overload : RP.second) {
173 std::find_if(RP.second.begin(), RP.second.end(),
174 [&Overload](
const FunctionDecl *FD) {
179 if (FD->getDeclContext() != Overload->getDeclContext())
184 if (!areCorrespondingOverloads(Overload, FD))
190 if (Match == RP.second.end()) {
194 const auto *
MD = dyn_cast<CXXMethodDecl>(Overload);
195 if (!
MD || !hasCorrespondingOverloadInBaseClass(
MD))
196 Diagnose.push_back(Overload);
201 for (
const auto *FD : Diagnose)
202 diag(FD->getLocation(),
"declaration of %0 has no matching declaration "
203 "of '%1' at the same scope")