12#include "clang/AST/ASTContext.h"
13#include "clang/ASTMatchers/ASTMatchFinder.h"
20static ast_matchers::internal::BindableMatcher<Stmt>
21handleFrom(
const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle,
22 const ast_matchers::internal::Matcher<Expr> &Arg) {
24 anyOf(cxxConstructExpr(hasDeclaration(cxxMethodDecl(ofClass(IsAHandle))),
26 cxxMemberCallExpr(hasType(hasUnqualifiedDesugaredType(recordType(
27 hasDeclaration(cxxRecordDecl(IsAHandle))))),
28 callee(memberExpr(member(cxxConversionDecl()))),
33 const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle) {
35 const auto TemporaryExpr = anyOf(
36 cxxBindTemporaryExpr(),
37 cxxFunctionalCastExpr(
38 hasCastKind(CK_ConstructorConversion),
39 hasSourceExpression(ignoringParenImpCasts(cxxBindTemporaryExpr()))));
43 const auto TemporaryTernary = conditionalOperator(
44 hasTrueExpression(ignoringParenImpCasts(TemporaryExpr)),
45 hasFalseExpression(ignoringParenImpCasts(TemporaryExpr)));
47 return handleFrom(IsAHandle, anyOf(TemporaryExpr, TemporaryTernary));
50static ast_matchers::internal::Matcher<RecordDecl>
isASequence() {
51 return hasAnyName(
"::std::deque",
"::std::forward_list",
"::std::list",
55static ast_matchers::internal::Matcher<RecordDecl>
isASet() {
56 return hasAnyName(
"::std::set",
"::std::multiset",
"::std::unordered_set",
57 "::std::unordered_multiset");
60static ast_matchers::internal::Matcher<RecordDecl>
isAMap() {
61 return hasAnyName(
"::std::map",
"::std::multimap",
"::std::unordered_map",
62 "::std::unordered_multimap");
66 const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle) {
79 callee(functionDecl(hasAnyName(
"assign",
"push_back",
"resize"))),
80 on(expr(hasType(hasUnqualifiedDesugaredType(
81 recordType(hasDeclaration(recordDecl(
isASequence())))))))),
83 cxxMemberCallExpr(callee(functionDecl(hasName(
"insert"))),
84 on(expr(hasType(hasUnqualifiedDesugaredType(
85 recordType(hasDeclaration(recordDecl(
88 cxxOperatorCallExpr(callee(cxxMethodDecl(ofClass(
isAMap()))),
89 hasOverloadedOperatorName(
"[]"))));
95 HandleClasses(
utils::options::parseStringList(Options.get(
96 "HandleClasses",
"std::basic_string_view;std::experimental::basic_"
97 "string_view;std::span"))),
98 IsAHandle(cxxRecordDecl(hasAnyName(HandleClasses)).bind(
"handle")) {}
101 Options.store(Opts,
"HandleClasses",
105void DanglingHandleCheck::registerMatchersForVariables(MatchFinder *Finder) {
110 varDecl(hasType(hasUnqualifiedDesugaredType(
111 recordType(hasDeclaration(cxxRecordDecl(IsAHandle))))),
112 unless(parmVarDecl()),
114 exprWithCleanups(ignoringElidableConstructorCall(has(
115 ignoringParenImpCasts(ConvertedHandle))))
122 cxxOperatorCallExpr(callee(cxxMethodDecl(ofClass(IsAHandle))),
123 hasOverloadedOperatorName(
"="),
124 hasArgument(1, ConvertedHandle))
134void DanglingHandleCheck::registerMatchersForReturn(MatchFinder *Finder) {
143 has(ignoringImplicit(ignoringElidableConstructorCall(
146 declRefExpr(to(varDecl(
148 hasAutomaticStorageDuration(),
150 anyOf(hasType(arrayType()),
151 hasType(hasUnqualifiedDesugaredType(
152 recordType(hasDeclaration(recordDecl(
153 unless(IsAHandle))))))))))))))),
155 unless(hasAncestor(lambdaExpr())))
162 returnStmt(has(exprWithCleanups(ignoringElidableConstructorCall(
163 has(ignoringParenImpCasts(
170 registerMatchersForVariables(Finder);
171 registerMatchersForReturn(Finder);
175 auto *Handle = Result.Nodes.getNodeAs<CXXRecordDecl>(
"handle");
176 diag(Result.Nodes.getNodeAs<Stmt>(
"bad_stmt")->getBeginLoc(),
177 "%0 outlives its value")
178 << Handle->getQualifiedNameAsString();
Every ClangTidyCheck reports errors through a DiagnosticsEngine provided by this context.
void registerMatchers(ast_matchers::MatchFinder *Finder) override
DanglingHandleCheck(StringRef Name, ClangTidyContext *Context)
void storeOptions(ClangTidyOptions::OptionMap &Opts) override
void check(const ast_matchers::MatchFinder::MatchResult &Result) override
static ast_matchers::internal::Matcher< RecordDecl > isASet()
static ast_matchers::internal::BindableMatcher< Stmt > handleFrom(const ast_matchers::internal::Matcher< RecordDecl > &IsAHandle, const ast_matchers::internal::Matcher< Expr > &Arg)
static ast_matchers::internal::Matcher< RecordDecl > isASequence()
static ast_matchers::internal::Matcher< Stmt > handleFromTemporaryValue(const ast_matchers::internal::Matcher< RecordDecl > &IsAHandle)
static ast_matchers::internal::BindableMatcher< Stmt > makeContainerMatcher(const ast_matchers::internal::Matcher< RecordDecl > &IsAHandle)
static ast_matchers::internal::Matcher< RecordDecl > isAMap()
std::string serializeStringList(ArrayRef< StringRef > Strings)
Serialize a sequence of names that can be parsed by parseStringList.
llvm::StringMap< ClangTidyValue > OptionMap