clang-tools  6.0.0svn
Public Member Functions | List of all members
clang::tidy::google::runtime::StringReferenceMemberCheck Class Reference

Finds members of type const string&. More...

#include <StringReferenceMemberCheck.h>

Inheritance diagram for clang::tidy::google::runtime::StringReferenceMemberCheck:
Inheritance graph
[legend]
Collaboration diagram for clang::tidy::google::runtime::StringReferenceMemberCheck:
Collaboration graph
[legend]

Public Member Functions

 StringReferenceMemberCheck (StringRef Name, ClangTidyContext *Context)
 
void registerMatchers (ast_matchers::MatchFinder *Finder) override
 Override this to register AST matchers with Finder. More...
 
void check (const ast_matchers::MatchFinder::MatchResult &Result) override
 ClangTidyChecks that register ASTMatchers should do the actual work in here. More...
 
- Public Member Functions inherited from clang::tidy::ClangTidyCheck
 ClangTidyCheck (StringRef CheckName, ClangTidyContext *Context)
 Initializes the check with CheckName and Context. More...
 
virtual void registerPPCallbacks (CompilerInstance &Compiler)
 Override this to register PPCallbacks with Compiler. More...
 
DiagnosticBuilder diag (SourceLocation Loc, StringRef Description, DiagnosticIDs::Level Level=DiagnosticIDs::Warning)
 Add a diagnostic with the check's name. More...
 
virtual void storeOptions (ClangTidyOptions::OptionMap &Options)
 Should store all options supported by this check with their current values or default values for options that haven't been overridden. More...
 

Additional Inherited Members

- Protected Member Functions inherited from clang::tidy::ClangTidyCheck
StringRef getCurrentMainFile () const
 Returns the main file name of the current translation unit. More...
 
LangOptions getLangOpts () const
 Returns the language options from the context. More...
 
- Protected Attributes inherited from clang::tidy::ClangTidyCheck
OptionsView Options
 

Detailed Description

Finds members of type const string&.

const string reference members are generally considered unsafe as they can be created from a temporary quite easily.

struct S {
S(const string &Str) : Str(Str) {}
const string &Str;
};
S instance("string");

In the constructor call a string temporary is created from const char * and destroyed immediately after the call. This leaves around a dangling reference.

This check emit warnings for both std::string and ::string const reference members.

Corresponding cpplint.py check name: 'runtime/member_string_reference'.

Definition at line 41 of file StringReferenceMemberCheck.h.

Constructor & Destructor Documentation

◆ StringReferenceMemberCheck()

clang::tidy::google::runtime::StringReferenceMemberCheck::StringReferenceMemberCheck ( StringRef  Name,
ClangTidyContext Context 
)
inline

Definition at line 43 of file StringReferenceMemberCheck.h.

References registerMatchers().

Member Function Documentation

◆ check()

void clang::tidy::google::runtime::StringReferenceMemberCheck::check ( const ast_matchers::MatchFinder::MatchResult &  Result)
overridevirtual

ClangTidyChecks that register ASTMatchers should do the actual work in here.

Reimplemented from clang::tidy::ClangTidyCheck.

Definition at line 41 of file StringReferenceMemberCheck.cpp.

◆ registerMatchers()

void clang::tidy::google::runtime::StringReferenceMemberCheck::registerMatchers ( ast_matchers::MatchFinder *  Finder)
overridevirtual

Override this to register AST matchers with Finder.

This should be used by clang-tidy checks that analyze code properties that dependent on AST knowledge.

You can register as many matchers as necessary with Finder. Usually, "this" will be used as callback, but you can also specify other callback classes. Thereby, different matchers can trigger different callbacks.

If you need to merge information between the different matchers, you can store these as members of the derived class. However, note that all matches occur in the order of the AST traversal.

Reimplemented from clang::tidy::ClangTidyCheck.

Definition at line 22 of file StringReferenceMemberCheck.cpp.

Referenced by StringReferenceMemberCheck().


The documentation for this class was generated from the following files: