misc-string-constructor

Finds string constructors that are suspicious and probably errors.

A common mistake is to swap parameters to the ‘fill’ string-constructor.

Examples:

std::string str('x', 50); // should be str(50, 'x')

Calling the string-literal constructor with a length bigger than the literal is suspicious and adds extra random characters to the string.

Examples:

std::string("test", 200);   // Will include random characters after "test".

Creating an empty string from constructors with parameters is considered suspicious. The programmer should use the empty constructor instead.

Examples:

std::string("test", 0);   // Creation of an empty string.

Options

WarnOnLargeLength

When non-zero, the check will warn on a string with a length greater than LargeLengthThreshold. Default is 1.

LargeLengthThreshold

An integer specifying the large length threshold. Default is 0x800000.